199422 2019-07-02 14:37:08 -0700 [ews-build] Allow skipping uploading built product for few builders 2019-07-03 05:21:58 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199234 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain aperez ap clopez commit-queue ews-watchlist jbedard mcatanzaro webkit-bug-importer oldest_to_newest 1549718 0 aakash_jain 2019-07-02 14:37:08 -0700 We don't need to upload built-product for all the builder-only queues (which don't trigger any tester). For e.g.: WPE/GTK folks don't need the uploaded built-product (as per email conversation). This process also adds extra time in the build (as we need to run archive-built-product, upload-built-product and transfer-to-s3 step), and the upload might take long time depending on the physical location of the bot and network conditions. We should allow the option to skip the upload. 1549719 1 373362 aakash_jain 2019-07-02 14:39:08 -0700 Created attachment 373362 Patch 1549720 2 aakash_jain 2019-07-02 14:39:48 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/7/builds/444 1549721 3 ews-watchlist 2019-07-02 14:41:06 -0700 Attachment 373362 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:622: [CompileWebKit.__init__] Use of super on an old style class [pylint/E1002] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1549756 4 373362 commit-queue 2019-07-02 16:03:17 -0700 Comment on attachment 373362 Patch Clearing flags on attachment: 373362 Committed r247075: <https://trac.webkit.org/changeset/247075> 1549757 5 commit-queue 2019-07-02 16:03:18 -0700 All reviewed patches have been landed. Closing bug. 1549758 6 webkit-bug-importer 2019-07-02 16:04:18 -0700 <rdar://problem/52553282> 373362 2019-07-02 14:39:08 -0700 2019-07-02 16:03:17 -0700 Patch bug-199422-20190702173907.patch text/plain 2074 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NzA3MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA3LTAyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBbGxvdyBza2lwcGluZyB1cGxvYWRpbmcgYnVpbHQg cHJvZHVjdCBmb3IgZmV3IGJ1aWxkZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTk0MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToK KyAgICAgICAgKENvbXBpbGVXZWJLaXQuX19pbml0X18pOiBBZGRlZCBvcHRpb25hbCBza2lwVXBs b2FkIHBhcmFtZXRlci4KKyAgICAgICAgKENvbXBpbGVXZWJLaXQuZXZhbHVhdGVDb21tYW5kKTog QWxsb3cgdG8gc2tpcCB1cGxvYWQgaWYgdGhlcmUgYXJlIG5vIHRyaWdnZXJzIGFuZCBza2lwVXBs b2FkIGlzIFRydWUuCisKIDIwMTktMDctMDIgIEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2dfMjJA YXBwbGUuY29tPgogCiAgICAgICAgIEVuaGFuY2Ugc3VwcG9ydCBvZiBhcmlhLWhhc3BvcHVwIHBl ciBBUklBIDEuMSBzcGVjaWZpY2F0aW9uLgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjQ3MDcyKQorKysgVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC02MTksNyArNjE5 LDggQEAgY2xhc3MgQ29tcGlsZVdlYktpdChzaGVsbC5Db21waWxlKToKICAgICBoYWx0T25GYWls dXJlID0gRmFsc2UKICAgICBjb21tYW5kID0gWydwZXJsJywgJ1Rvb2xzL1NjcmlwdHMvYnVpbGQt d2Via2l0JywgV2l0aFByb3BlcnRpZXMoJy0tJShjb25maWd1cmF0aW9uKXMnKV0KIAotICAgIGRl ZiBfX2luaXRfXyhzZWxmLCAqKmt3YXJncyk6CisgICAgZGVmIF9faW5pdF9fKHNlbGYsIHNraXBV cGxvYWQ9RmFsc2UsICoqa3dhcmdzKToKKyAgICAgICAgc2VsZi5za2lwVXBsb2FkID0gc2tpcFVw bG9hZAogICAgICAgICBzdXBlcihDb21waWxlV2ViS2l0LCBzZWxmKS5fX2luaXRfXyhsb2dFbnZp cm9uPUZhbHNlLCAqKmt3YXJncykKIAogICAgIGRlZiBzdGFydChzZWxmKToKQEAgLTY1MCw3ICs2 NTEsOSBAQCBjbGFzcyBDb21waWxlV2ViS2l0KHNoZWxsLkNvbXBpbGUpOgogICAgICAgICAgICAg c2VsZi5zZXRQcm9wZXJ0eSgncGF0Y2hGYWlsZWRUb0J1aWxkJywgVHJ1ZSkKICAgICAgICAgICAg IHNlbGYuYnVpbGQuYWRkU3RlcHNBZnRlckN1cnJlbnRTdGVwKFtVbkFwcGx5UGF0Y2hJZlJlcXVp cmVkKCksIENvbXBpbGVXZWJLaXRUb1QoKSwgQW5hbHl6ZUNvbXBpbGVXZWJLaXRSZXN1bHRzKCld KQogICAgICAgICBlbHNlOgotICAgICAgICAgICAgc2VsZi5idWlsZC5hZGRTdGVwc0FmdGVyQ3Vy cmVudFN0ZXAoW0FyY2hpdmVCdWlsdFByb2R1Y3QoKSwgVXBsb2FkQnVpbHRQcm9kdWN0KCksIFRy YW5zZmVyVG9TMygpXSkKKyAgICAgICAgICAgIHRyaWdnZXJzID0gc2VsZi5nZXRQcm9wZXJ0eSgn dHJpZ2dlcnMnLCBOb25lKQorICAgICAgICAgICAgaWYgdHJpZ2dlcnMgb3Igbm90IHNlbGYuc2tp cFVwbG9hZDoKKyAgICAgICAgICAgICAgICBzZWxmLmJ1aWxkLmFkZFN0ZXBzQWZ0ZXJDdXJyZW50 U3RlcChbQXJjaGl2ZUJ1aWx0UHJvZHVjdCgpLCBVcGxvYWRCdWlsdFByb2R1Y3QoKSwgVHJhbnNm ZXJUb1MzKCldKQogCiAgICAgICAgIHJldHVybiBzdXBlcihDb21waWxlV2ViS2l0LCBzZWxmKS5l dmFsdWF0ZUNvbW1hbmQoY21kKQogCg==