199399 2019-07-02 03:06:33 -0700 [JSC][Win] Support unwind information for LLInt ASM by using MASM directives to get callstack in debugger 2019-07-02 23:52:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 fujii webkit-unassigned oldest_to_newest 1549512 0 fujii 2019-07-02 03:06:33 -0700 [JSC][Win] Support unwind information for LLInt ASM by using MASM directives to get callstack in debugger MASM has directives for debug information. .SETFRAME | Microsoft Docs https://docs.microsoft.com/ja-jp/cpp/assembler/masm/dot-setframe?view=vs-2019 VS debugger can't get callstack under JSC. It looks like the following: > WebKit.dll!WebCore::Node::appendChild(WebCore::Node & newChild) Line 493 C++ > WebKit.dll!WebCore::jsNodePrototypeFunctionAppendChildBody(JSC::ExecState * state, WebCore::JSNode * castedThis, JSC::ThrowScope & throwScope) Line 860 C++ > WebKit.dll!WebCore::IDLOperation<WebCore::JSNode>::call<&WebCore::jsNodePrototypeFunctionAppendChildBody,WebCore::CastedThisErrorBehavior::Throw>(JSC::ExecState & state, const char * operationName) Line 53 C++ > WebKit.dll!WebCore::jsNodePrototypeFunctionAppendChild(JSC::ExecState * state) Line 866 C++ > [External Code] 1549513 1 373312 fujii 2019-07-02 03:07:55 -0700 Created attachment 373312 WIP patch This WIP patch doens't work as expected, but sometimes debugger can show full callstack like the following: > WebKit.dll!WebCore::Node::appendChild(WebCore::Node & newChild) Line 493 C++ > WebKit.dll!WebCore::jsNodePrototypeFunctionAppendChildBody(JSC::ExecState * state, WebCore::JSNode * castedThis, JSC::ThrowScope & throwScope) Line 860 C++ > WebKit.dll!WebCore::IDLOperation<WebCore::JSNode>::call<&WebCore::jsNodePrototypeFunctionAppendChildBody,WebCore::CastedThisErrorBehavior::Throw>(JSC::ExecState & state, const char * operationName) Line 53 C++ > WebKit.dll!WebCore::jsNodePrototypeFunctionAppendChild(JSC::ExecState * state) Line 866 C++ > [External Code] > JavaScriptCore.dll!JSC::JITCode::execute(JSC::VM * vm, JSC::ProtoCallFrame * protoCallFrame) Line 38 C++ > JavaScriptCore.dll!JSC::Interpreter::executeProgram(const JSC::SourceCode & source, JSC::ExecState * callFrame, JSC::JSObject * thisObj) Line 845 C++ > JavaScriptCore.dll!JSC::evaluate(JSC::ExecState * exec, const JSC::SourceCode & source, JSC::JSValue thisValue, WTF::NakedPtr<JSC::Exception> & returnedException) Line 149 C++ > JavaScriptCore.dll!JSC::profiledEvaluate(JSC::ExecState * exec, JSC::ProfilingReason reason, const JSC::SourceCode & source, JSC::JSValue thisValue, WTF::NakedPtr<JSC::Exception> & returnedException) Line 164 C++ > WebKit.dll!WebCore::JSExecState::profiledEvaluate(JSC::ExecState * exec, JSC::ProfilingReason reason, const JSC::SourceCode & source, JSC::JSValue thisValue, WTF::NakedPtr<JSC::Exception> & returnedException) Line 81 C++ > WebKit.dll!WebCore::ScriptController::evaluateInWorld(const WebCore::ScriptSourceCode & sourceCode, WebCore::DOMWrapperWorld & world, WebCore::ExceptionDetails * exceptionDetails) Line 133 C++ > WebKit.dll!WebCore::ScriptController::evaluate(const WebCore::ScriptSourceCode & sourceCode, WebCore::ExceptionDetails * exceptionDetails) Line 149 C++ > WebKit.dll!WebCore::ScriptElement::executeClassicScript(const WebCore::ScriptSourceCode & sourceCode) Line 388 C++ > WebKit.dll!WebCore::LoadableClassicScript::execute(WebCore::ScriptElement & scriptElement) Line 123 C++ > WebKit.dll!WebCore::ScriptElement::executeScriptAndDispatchEvent(WebCore::LoadableScript & loadableScript) Line 426 C++ > WebKit.dll!WebCore::ScriptElement::executePendingScript(WebCore::PendingScript & pendingScript) Line 434 C++ > WebKit.dll!WebCore::ScriptRunner::timerFired() Line 131 C++ > [External Code] > WebKit.dll!WTF::Detail::CallableWrapper<std::_Binder<std::_Unforced,void (WebCore::ScriptRunner::*&)(),WebCore::ScriptRunner *>,void>::call() Line 52 C++ > WebKit.dll!WTF::Function<void ()>::operator()() Line 79 C++ > WebKit.dll!WebCore::Timer::fired() Line 127 C++ > WebKit.dll!WebCore::ThreadTimers::sharedTimerFiredInternal() Line 129 C++ > WebKit.dll!WebCore::ThreadTimers::setSharedTimer::<unnamed-tag>::operator()() Line 69 C++ > WebKit.dll!WTF::Detail::CallableWrapper<`lambda at ..\..\Source\WebCore\platform/ThreadTimers.cpp:69:41',void>::call() Line 52 C++ > WebKit.dll!WTF::Function<void ()>::operator()() Line 79 C++ > WebKit.dll!WebCore::MainThreadSharedTimer::fired() Line 84 C++ > WebKit.dll!WebCore::TimerWindowWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 89 C++ > [External Code] > WebKit.dll!WebKitMessageLoop::run(HACCEL__ * hAccelTable) Line 94 C++ > MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 97 C++ > MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 115 C++ > MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 232 C++ > [External Code] 1549515 2 fujii 2019-07-02 03:13:21 -0700 https://docs.microsoft.com/en-us/cpp/assembler/masm/dot-setframe 1549847 3 fujii 2019-07-02 23:52:04 -0700 Umm, this doesn't seem an easy task. It manipulates the stack pointer outside of epilogue and prologue. 373312 2019-07-02 03:07:55 -0700 2019-07-02 03:07:55 -0700 WIP patch unwind.diff text/plain 3492 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJl dGVyLmFzbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVy LmFzbQppbmRleCBjMGFkODNjNmM0My4uNmQwMjUzODQyZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KQEAgLTg3Myw2ICs4 NzMsMjYgQEAgbWFjcm8gcHJlc2VydmVSZXR1cm5BZGRyZXNzQWZ0ZXJDYWxsKGRlc3RpbmF0aW9u UmVnaXN0ZXIpCiBlbmQKIAogbWFjcm8gZnVuY3Rpb25Qcm9sb2d1ZSgpCisgICAgdGFnUmV0dXJu QWRkcmVzcyBzcAorICAgIGlmIFg4NiBvciBYODZfV0lOIG9yIFg4Nl82NCBvciBYODZfNjRfV0lO CisgICAgICAgIHB1c2ggY2ZyCisgICAgICAgIGlmIFg4Nl82NF9XSU4KKyAgICAgICAgICAgZW1p dCAiLnB1c2hyZWcgcmJwIgorICAgICAgICBlbmQKKyAgICBlbHNpZiBBUk02NCBvciBBUk02NEUK KyAgICAgICAgcHVzaCBjZnIsIGxyCisgICAgZWxzaWYgQ19MT09QIG9yIENfTE9PUF9XSU4gb3Ig QVJNdjcgb3IgTUlQUworICAgICAgICBwdXNoIGxyCisgICAgICAgIHB1c2ggY2ZyCisgICAgZW5k CisgICAgbW92ZSBzcCwgY2ZyCisgICAgaWYgWDg2XzY0X1dJTgorICAgICAgIGVtaXQgIi5zZXRm cmFtZSByYnAsIDAiCisgICAgICAgZW1pdCAiLmVuZHByb2xvZyIKKyAgICBlbmQKK2VuZAorCitt YWNybyBmdW5jdGlvblByb2xvZ3VlRm9yVHJhbXBvbGluZSgpCiAgICAgdGFnUmV0dXJuQWRkcmVz cyBzcAogICAgIGlmIFg4NiBvciBYODZfV0lOIG9yIFg4Nl82NCBvciBYODZfNjRfV0lOCiAgICAg ICAgIHB1c2ggY2ZyCkBAIC0xMjczLDYgKzEyOTMsOSBAQCBpZiBub3QgKENfTE9PUCBvciBDX0xP T1BfV0lOKQogICAgICMgdm9pZCBzYW5pdGl6ZVN0YWNrRm9yVk1JbXBsKFZNKiB2bSkKICAgICBn bG9iYWwgX3Nhbml0aXplU3RhY2tGb3JWTUltcGwKICAgICBfc2FuaXRpemVTdGFja0ZvclZNSW1w bDoKKyAgICAgICAgaWYgWDg2XzY0X1dJTgorICAgICAgICAgICAgZW1pdCAiLmVuZHByb2xvZyIK KyAgICAgICAgZW5kCiAgICAgICAgIHRhZ1JldHVybkFkZHJlc3Mgc3AKICAgICAgICAgIyBXZSBu ZWVkIHRocmVlIG5vbi1hbGlhc2VkIGNhbGxlci1zYXZlIHJlZ2lzdGVycy4gV2UgYXJlIGd1YXJh bnRlZWQKICAgICAgICAgIyB0aGlzIGZvciBhMCwgYTEgYW5kIGEyIG9uIGFsbCBhcmNoaXRlY3R1 cmVzLgpAQCAtMTMwMCw2ICsxMzIzLDkgQEAgaWYgbm90IChDX0xPT1Agb3IgQ19MT09QX1dJTikK ICAgICAjIFZNRW50cnlSZWNvcmQqIHZtRW50cnlSZWNvcmQoY29uc3QgRW50cnlGcmFtZSogZW50 cnlGcmFtZSkKICAgICBnbG9iYWwgX3ZtRW50cnlSZWNvcmQKICAgICBfdm1FbnRyeVJlY29yZDoK KyAgICAgICAgaWYgWDg2XzY0X1dJTgorICAgICAgICAgICAgZW1pdCAiLmVuZHByb2xvZyIKKyAg ICAgICAgZW5kCiAgICAgICAgIHRhZ1JldHVybkFkZHJlc3Mgc3AKICAgICAgICAgaWYgWDg2IG9y IFg4Nl9XSU4KICAgICAgICAgICAgIGxvYWRwIDRbc3BdLCBhMApkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc20gYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQppbmRleCA5MDM2 MzVhZjUyNS4uMGZjZThiZmEwZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9s bGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCkBAIC0yMDg4LDcgKzIwODgsNyBAQCBl bmQpCiAKIG1hY3JvIG5hdGl2ZUNhbGxUcmFtcG9saW5lKGV4ZWN1dGFibGVPZmZzZXRUb0Z1bmN0 aW9uKQogCi0gICAgZnVuY3Rpb25Qcm9sb2d1ZSgpCisgICAgZnVuY3Rpb25Qcm9sb2d1ZUZvclRy YW1wb2xpbmUoKQogICAgIHN0b3JlcCAwLCBDb2RlQmxvY2tbY2ZyXQogICAgIGxvYWRwIENhbGxl ZVtjZnJdLCB0MAogICAgIGFuZHAgTWFya2VkQmxvY2tNYXNrLCB0MCwgdDEKQEAgLTIxMjgsNyAr MjEyOCw3IEBAIG1hY3JvIG5hdGl2ZUNhbGxUcmFtcG9saW5lKGV4ZWN1dGFibGVPZmZzZXRUb0Z1 bmN0aW9uKQogZW5kCiAKIG1hY3JvIGludGVybmFsRnVuY3Rpb25DYWxsVHJhbXBvbGluZShvZmZz ZXRPZkZ1bmN0aW9uKQotICAgIGZ1bmN0aW9uUHJvbG9ndWUoKQorICAgIGZ1bmN0aW9uUHJvbG9n dWVGb3JUcmFtcG9saW5lKCkKICAgICBzdG9yZXAgMCwgQ29kZUJsb2NrW2Nmcl0KICAgICBsb2Fk cCBDYWxsZWVbY2ZyXSwgdDAKICAgICBhbmRwIE1hcmtlZEJsb2NrTWFzaywgdDAsIHQxCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hc20ucmIgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hc20ucmIKaW5kZXggZjk2ZGVmYzJkOTYuLjFiMzBj Y2Q1YTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hc20u cmIKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXNtLnJiCkBAIC02NSw2 ICs2NSw3IEBAIGNsYXNzIEFzc2VtYmxlcgogICAgICAgICAgICAgQG91dHAucHV0cyAiT0ZGTElO RV9BU01fR0xPQkFMX0xBQkVMKGxsaW50UENSYW5nZVN0YXJ0KSIKICAgICAgICAgZWxzZQogICAg ICAgICAgICAgcHV0c1Byb2MoImxsaW50UENSYW5nZVN0YXJ0IiwgIiIpCisgICAgICAgICAgICBA b3V0cC5wdXRzICIuZW5kcHJvbG9nIgogICAgICAgICAgICAgcHV0c1Byb2NFbmRJZk5lZWRlZAog ICAgICAgICBlbmQKICAgICAgICAgQHN0YXRlID0gOmFzbQpAQCAtNzcsNiArNzgsNyBAQCBjbGFz cyBBc3NlbWJsZXIKICAgICAgICAgICAgIEBvdXRwLnB1dHMgIk9GRkxJTkVfQVNNX0dMT0JBTF9M QUJFTChsbGludFBDUmFuZ2VFbmQpIgogICAgICAgICBlbHNlCiAgICAgICAgICAgICBwdXRzUHJv YygibGxpbnRQQ1JhbmdlRW5kIiwgIiIpCisgICAgICAgICAgICBAb3V0cC5wdXRzICIuZW5kcHJv bG9nIgogICAgICAgICAgICAgcHV0c1Byb2NFbmRJZk5lZWRlZAogICAgICAgICBlbmQKICAgICAg ICAgcHV0c0xhc3RDb21tZW50CkBAIC0yMDAsNyArMjAyLDcgQEAgY2xhc3MgQXNzZW1ibGVyCiAK ICAgICBkZWYgcHV0c1Byb2MobGFiZWwsIGNvbW1lbnQpCiAgICAgICAgIHJhaXNlIHVubGVzcyAk ZW1pdFdpbkFzbQotICAgICAgICBAb3V0cC5wdXRzKGZvcm1hdER1bXAoIiN7bGFiZWx9IFBST0Mg UFVCTElDIiwgY29tbWVudCkpCisgICAgICAgIEBvdXRwLnB1dHMoZm9ybWF0RHVtcCgiI3tsYWJl bH0gUFJPQyBQVUJMSUMgRlJBTUUiLCBjb21tZW50KSkKICAgICAgICAgQGxhc3RsYWJlbCA9IGxh YmVsCiAgICAgZW5kCiAK