<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>199383</bug_id>
          
          <creation_ts>2019-07-01 14:32:30 -0700</creation_ts>
          <short_desc>Remove virtual functions on WebProcessLifetimeObserver that are unused after r245540</short_desc>
          <delta_ts>2019-07-01 15:28:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=197636</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>commit-queue</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1549339</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-07-01 14:32:30 -0700</bug_when>
    <thetext>Remove virtual functions on WebProcessLifetimeObserver that are unused after r245540.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549341</commentid>
    <comment_count>1</comment_count>
      <attachid>373267</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-07-01 14:33:38 -0700</bug_when>
    <thetext>Created attachment 373267
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549364</commentid>
    <comment_count>2</comment_count>
      <attachid>373267</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-07-01 15:27:13 -0700</bug_when>
    <thetext>Comment on attachment 373267
Patch

Clearing flags on attachment: 373267

Committed r247029: &lt;https://trac.webkit.org/changeset/247029&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549365</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-07-01 15:27:14 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549366</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-07-01 15:28:37 -0700</bug_when>
    <thetext>&lt;rdar://problem/52487011&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>373267</attachid>
            <date>2019-07-01 14:33:38 -0700</date>
            <delta_ts>2019-07-01 15:27:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199383-20190701143337.patch</filename>
            <type>text/plain</type>
            <size>2983</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGViOTZhODkyYjVhNzNlN2Nm
NjY4Mjg0ZjNlZTgzZjgzMDZlNDJjOWUuLmY0YjQwMzAyY2U2MzU4MDVlOTM2ZjM3MWQ2ZDk4NWYw
ZWI5ZjhhZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDctMDEgIENocmlzIER1
bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdmlydHVhbCBmdW5jdGlv
bnMgb24gV2ViUHJvY2Vzc0xpZmV0aW1lT2JzZXJ2ZXIgdGhhdCBhcmUgdW51c2VkIGFmdGVyIHIy
NDU1NDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5
OTM4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog
VUlQcm9jZXNzL1dlYlByb2Nlc3NMaWZldGltZU9ic2VydmVyLmg6CisgICAgICAgIChXZWJLaXQ6
OldlYlByb2Nlc3NMaWZldGltZU9ic2VydmVyOjp3ZWJQcm9jZXNzRGlkQ2xvc2VDb25uZWN0aW9u
KToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc0xpZmV0aW1lVHJhY2tlci5jcHA6Cisg
ICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NMaWZldGltZVRyYWNrZXI6OmFkZE9ic2VydmVyKToK
KyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc0xpZmV0aW1lVHJhY2tlcjo6cGFnZVdhc0ludmFs
aWRhdGVkKToKKwogMjAxOS0wNy0wMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog
CiAgICAgICAgIFN0b3JhZ2VNYW5hZ2VyOjpTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZTo6YWxsb3dl
ZENvbm5lY3Rpb25zKCkgc2hvdWxkIG5vdCBjb3B5IHRoZSBIYXNoU2V0CmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzTGlmZXRpbWVPYnNlcnZlci5oIGIvU291
cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc0xpZmV0aW1lT2JzZXJ2ZXIuaAppbmRleCA2
NjkzOTczNDU2MWU0MjAxYTIwZjQyYTM2NmRkZDAyYTQ0NzA0ZTk1Li40OWNiZmZiODQ5NDAwOGEy
OWFkOTBmMmIyN2ZhZmY4YzFlNDBhNjE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv
Y2Vzcy9XZWJQcm9jZXNzTGlmZXRpbWVPYnNlcnZlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ
cm9jZXNzL1dlYlByb2Nlc3NMaWZldGltZU9ic2VydmVyLmgKQEAgLTUzLDEyICs1MywxMCBAQCBw
dWJsaWM6CiBwcml2YXRlOgogICAgIGZyaWVuZCBjbGFzcyBXZWJQcm9jZXNzTGlmZXRpbWVUcmFj
a2VyOwogCi0gICAgdmlydHVhbCB2b2lkIHdlYlBhZ2VXYXNBZGRlZChXZWJQYWdlUHJveHkmKSB7
IH0KICAgICB2aXJ0dWFsIHZvaWQgd2ViUHJvY2Vzc1dpbGxPcGVuQ29ubmVjdGlvbihXZWJQcm9j
ZXNzUHJveHkmLCBJUEM6OkNvbm5lY3Rpb24mKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgd2ViUGFn
ZVdpbGxPcGVuQ29ubmVjdGlvbihXZWJQYWdlUHJveHkmLCBJUEM6OkNvbm5lY3Rpb24mKSB7IH0K
ICAgICB2aXJ0dWFsIHZvaWQgd2ViUGFnZURpZENsb3NlQ29ubmVjdGlvbihXZWJQYWdlUHJveHkm
LCBJUEM6OkNvbm5lY3Rpb24mKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgd2ViUHJvY2Vzc0RpZENs
b3NlQ29ubmVjdGlvbihXZWJQcm9jZXNzUHJveHkmLCBJUEM6OkNvbm5lY3Rpb24mKSB7IH0KLSAg
ICB2aXJ0dWFsIHZvaWQgd2ViUGFnZVdhc0ludmFsaWRhdGVkKFdlYlBhZ2VQcm94eSYpIHsgfQog
CiAgICAgSGFzaENvdW50ZWRTZXQ8V2ViUHJvY2Vzc1Byb3h5Kj4gbV9wcm9jZXNzZXM7CiB9Owpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc0xpZmV0aW1lVHJh
Y2tlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzTGlmZXRpbWVUcmFj
a2VyLmNwcAppbmRleCA3MWEwYTViMjVhYmUwYmMxYmQzODhjZjA3OTUyYzcyYTg3MTAyMDczLi4z
YTUwOGUxMzIzMjFhNzBjYWFjMDc5YzEwOTc1MjkxNjU1ZDgzMWI2IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzTGlmZXRpbWVUcmFja2VyLmNwcAorKysgYi9T
b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzTGlmZXRpbWVUcmFja2VyLmNwcApAQCAt
NDcsOCArNDcsNiBAQCB2b2lkIFdlYlByb2Nlc3NMaWZldGltZVRyYWNrZXI6OmFkZE9ic2VydmVy
KFdlYlByb2Nlc3NMaWZldGltZU9ic2VydmVyJiBvYnNlcnZlcgogCiAgICAgbV9vYnNlcnZlcnMu
YWRkKCZvYnNlcnZlcik7CiAKLSAgICBvYnNlcnZlci53ZWJQYWdlV2FzQWRkZWQobV93ZWJQYWdl
UHJveHkpOwotCiAgICAgaWYgKHByb2Nlc3NJc1J1bm5pbmcobV93ZWJQYWdlUHJveHkucHJvY2Vz
cygpKSkKICAgICAgICAgb2JzZXJ2ZXIuYWRkV2ViUGFnZShtX3dlYlBhZ2VQcm94eSwgbV93ZWJQ
YWdlUHJveHkucHJvY2VzcygpKTsKIH0KQEAgLTc0LDExICs3Miw4IEBAIHZvaWQgV2ViUHJvY2Vz
c0xpZmV0aW1lVHJhY2tlcjo6cGFnZVdhc0ludmFsaWRhdGVkKCkKICAgICBpZiAoIXByb2Nlc3NJ
c1J1bm5pbmcobV93ZWJQYWdlUHJveHkucHJvY2VzcygpKSkKICAgICAgICAgcmV0dXJuOwogCi0g
ICAgZm9yIChhdXRvJiBvYnNlcnZlciA6IG1fb2JzZXJ2ZXJzKSB7CisgICAgZm9yIChhdXRvJiBv
YnNlcnZlciA6IG1fb2JzZXJ2ZXJzKQogICAgICAgICBvYnNlcnZlci0+cmVtb3ZlV2ViUGFnZSht
X3dlYlBhZ2VQcm94eSwgbV93ZWJQYWdlUHJveHkucHJvY2VzcygpKTsKLQotICAgICAgICBvYnNl
cnZlci0+d2ViUGFnZVdhc0ludmFsaWRhdGVkKG1fd2ViUGFnZVByb3h5KTsKLSAgICB9CiB9CiAK
IGJvb2wgV2ViUHJvY2Vzc0xpZmV0aW1lVHJhY2tlcjo6cHJvY2Vzc0lzUnVubmluZyhXZWJQcm9j
ZXNzUHJveHkmIHByb2Nlc3MpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>