199377 2019-07-01 13:59:13 -0700 [WPE] Draw other button types 2019-07-25 11:04:24 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 JPEW.hacker webkit-unassigned bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1549306 0 JPEW.hacker 2019-07-01 13:59:13 -0700 [WPE] Draw other button types 1549308 1 373259 JPEW.hacker 2019-07-01 13:59:28 -0700 Created attachment 373259 Patch 1553178 2 373259 mcatanzaro 2019-07-16 07:59:48 -0700 Comment on attachment 373259 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373259&action=review Could you please add a ChangeLog entry (Tools/Scripts/prepare-ChangeLog -b 199377)? Then the ChangeLog can explain more directly why you're changing what you're changing here. > Source/WebCore/platform/wpe/ThemeWPE.cpp:71 > + case DefaultButtonPart: > + case ButtonPart: Please use fallthrough annotations: case DefaultButtonPart: FALLTHROUGH; case ButtonPart: FALLTHROUGH; case SquareButtonPart: > Source/WebCore/platform/wpe/ThemeWPE.cpp:142 > + float roundness = 2; > + > + if (part == SquareButtonPart) > + roundness = 0; It'd be nicer to write this in one line IMO: float roundness = (part == SquareButtonPart) ? 0 : 2; 1553184 3 373259 cgarcia 2019-07-16 08:10:43 -0700 Comment on attachment 373259 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373259&action=review >> Source/WebCore/platform/wpe/ThemeWPE.cpp:71 >> + case ButtonPart: > > Please use fallthrough annotations: > > case DefaultButtonPart: > FALLTHROUGH; > case ButtonPart: > FALLTHROUGH; > case SquareButtonPart: I don't think we want FALLTHROUGH in those cases, because it's obvious. FALLTHROUGH is useful when you actually have code in the case and want to fallthrough to the next case, to make it explicit that you haven't forgotten the break. 1553192 4 mcatanzaro 2019-07-16 08:40:35 -0700 OK, as you prefer 1553310 5 374239 JPEW.hacker 2019-07-16 14:05:53 -0700 Created attachment 374239 Patch 1553311 6 JPEW.hacker 2019-07-16 14:07:03 -0700 Sorry I forgot the changelog. This is my first WebKit bug, the tooling scripts for uploading changes are still a little clunky to me. 1553372 7 mcatanzaro 2019-07-16 16:25:59 -0700 (In reply to Joshua Watt from comment #5) > Created attachment 374239 [details] > Patch This new patch is actually still missing the ChangeLog. :) 1555442 8 374790 JPEW.hacker 2019-07-24 11:37:59 -0700 Created attachment 374790 Patch 1555449 9 374790 mcatanzaro 2019-07-24 12:04:16 -0700 Comment on attachment 374790 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374790&action=review > Source/WebCore/ChangeLog:8 > + [WPE] Draw other button types Don't duplicate the title here. 1555785 10 374889 JPEW.hacker 2019-07-25 08:23:16 -0700 Created attachment 374889 Patch 1555813 11 374889 mcatanzaro 2019-07-25 09:37:44 -0700 Comment on attachment 374889 Patch Request cq? when you're ready for commit. 1555841 12 374889 commit-queue 2019-07-25 11:04:22 -0700 Comment on attachment 374889 Patch Clearing flags on attachment: 374889 Committed r247827: <https://trac.webkit.org/changeset/247827> 1555842 13 commit-queue 2019-07-25 11:04:24 -0700 All reviewed patches have been landed. Closing bug. 373259 2019-07-01 13:59:28 -0700 2019-07-16 14:05:51 -0700 Patch bug-199377-20190701155927.patch text/plain 2169 JPEW.hacker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2Njc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS93cGUvVGhlbWVXUEUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3BlL1Ro ZW1lV1BFLmNwcAppbmRleCBlMjJhMjk0N2VlNzI3YWFmODBkYjcwNmFiNzY3YTdlNmExODQ1Zjky Li4xOGRkOTg4MDMyMmIwMDA3OTU2MDVhZTE4NzAyMmJiYmVmZGQyMWM4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93cGUvVGhlbWVXUEUuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5jcHAKQEAgLTY3LDcgKzY3LDEwIEBAIHZvaWQgVGhl bWVXUEU6OnBhaW50KENvbnRyb2xQYXJ0IHBhcnQsIENvbnRyb2xTdGF0ZXMmIHN0YXRlcywgR3Jh cGhpY3NDb250ZXh0JiBjCiAgICAgICAgIHBhaW50UmFkaW8oc3RhdGVzLCBjb250ZXh0LCB6b29t ZWRSZWN0LCB6b29tRmFjdG9yKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQdXNoQnV0dG9u UGFydDoKLSAgICAgICAgcGFpbnRCdXR0b24oc3RhdGVzLCBjb250ZXh0LCB6b29tZWRSZWN0LCB6 b29tRmFjdG9yKTsKKyAgICBjYXNlIERlZmF1bHRCdXR0b25QYXJ0OgorICAgIGNhc2UgQnV0dG9u UGFydDoKKyAgICBjYXNlIFNxdWFyZUJ1dHRvblBhcnQ6CisgICAgICAgIHBhaW50QnV0dG9uKHBh cnQsIHN0YXRlcywgY29udGV4dCwgem9vbWVkUmVjdCwgem9vbUZhY3Rvcik7CiAgICAgICAgIGJy ZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIGJyZWFrOwpAQCAtMTI5LDExICsxMzIsMTYgQEAg dm9pZCBUaGVtZVdQRTo6cGFpbnRSYWRpbyhDb250cm9sU3RhdGVzJiBzdGF0ZXMsIEdyYXBoaWNz Q29udGV4dCYgY29udGV4dCwgY29uc3QKICAgICB9CiB9CiAKLXZvaWQgVGhlbWVXUEU6OnBhaW50 QnV0dG9uKENvbnRyb2xTdGF0ZXMmIHN0YXRlcywgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBj b25zdCBGbG9hdFJlY3QmIHpvb21lZFJlY3QsIGZsb2F0KQordm9pZCBUaGVtZVdQRTo6cGFpbnRC dXR0b24oQ29udHJvbFBhcnQgcGFydCwgQ29udHJvbFN0YXRlcyYgc3RhdGVzLCBHcmFwaGljc0Nv bnRleHQmIGNvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYgem9vbWVkUmVjdCwgZmxvYXQpCiB7CiAg ICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBzdGF0ZVNhdmVyKGNvbnRleHQpOwogCi0gICAg RmxvYXRTaXplIGNvcm5lcigyLCAyKTsKKyAgICBmbG9hdCByb3VuZG5lc3MgPSAyOworCisgICAg aWYgKHBhcnQgPT0gU3F1YXJlQnV0dG9uUGFydCkKKyAgICAgICAgcm91bmRuZXNzID0gMDsKKwor ICAgIEZsb2F0U2l6ZSBjb3JuZXIocm91bmRuZXNzLCByb3VuZG5lc3MpOwogICAgIEZsb2F0Um91 bmRlZFJlY3Qgcm91bmRlZFJlY3Qoem9vbWVkUmVjdCwgY29ybmVyLCBjb3JuZXIsIGNvcm5lciwg Y29ybmVyKTsKICAgICBQYXRoIHBhdGg7CiAgICAgcGF0aC5hZGRSb3VuZGVkUmVjdChyb3VuZGVk UmVjdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93cGUvVGhlbWVXUEUu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5oCmluZGV4IGIxNzZhODAy ZjJhOThmNGZhMGMwMWJhYTY3ZjU5OGRjMDhkZGM3MjMuLjdjMzVkYzVjMGY5MmY2ZDAzMzZlOGJh NzEzYWE2ZDI5ZWQ4YjBmYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dw ZS9UaGVtZVdQRS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5o CkBAIC0zNyw3ICszNyw3IEBAIHByaXZhdGU6CiAKICAgICB2b2lkIHBhaW50Q2hlY2tib3goQ29u dHJvbFN0YXRlcyYsIEdyYXBoaWNzQ29udGV4dCYsIGNvbnN0IEZsb2F0UmVjdCYsIGZsb2F0KTsK ICAgICB2b2lkIHBhaW50UmFkaW8oQ29udHJvbFN0YXRlcyYsIEdyYXBoaWNzQ29udGV4dCYsIGNv bnN0IEZsb2F0UmVjdCYsIGZsb2F0KTsKLSAgICB2b2lkIHBhaW50QnV0dG9uKENvbnRyb2xTdGF0 ZXMmLCBHcmFwaGljc0NvbnRleHQmLCBjb25zdCBGbG9hdFJlY3QmLCBmbG9hdCk7CisgICAgdm9p ZCBwYWludEJ1dHRvbihDb250cm9sUGFydCwgQ29udHJvbFN0YXRlcyYsIEdyYXBoaWNzQ29udGV4 dCYsIGNvbnN0IEZsb2F0UmVjdCYsIGZsb2F0KTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNv cmUK 374239 2019-07-16 14:05:53 -0700 2019-07-24 11:37:56 -0700 Patch bug-199377-20190716160552.patch text/plain 2141 JPEW.hacker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS93cGUvVGhlbWVXUEUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3BlL1Ro ZW1lV1BFLmNwcAppbmRleCBlMjJhMjk0N2VlNzI3YWFmODBkYjcwNmFiNzY3YTdlNmExODQ1Zjky Li44ZTAyODU5MzU1MTY2ZTUyMTg1ZTBlNmEwMzBkOTE4NWI1ODRlZTQyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93cGUvVGhlbWVXUEUuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5jcHAKQEAgLTY3LDcgKzY3LDEwIEBAIHZvaWQgVGhl bWVXUEU6OnBhaW50KENvbnRyb2xQYXJ0IHBhcnQsIENvbnRyb2xTdGF0ZXMmIHN0YXRlcywgR3Jh cGhpY3NDb250ZXh0JiBjCiAgICAgICAgIHBhaW50UmFkaW8oc3RhdGVzLCBjb250ZXh0LCB6b29t ZWRSZWN0LCB6b29tRmFjdG9yKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQdXNoQnV0dG9u UGFydDoKLSAgICAgICAgcGFpbnRCdXR0b24oc3RhdGVzLCBjb250ZXh0LCB6b29tZWRSZWN0LCB6 b29tRmFjdG9yKTsKKyAgICBjYXNlIERlZmF1bHRCdXR0b25QYXJ0OgorICAgIGNhc2UgQnV0dG9u UGFydDoKKyAgICBjYXNlIFNxdWFyZUJ1dHRvblBhcnQ6CisgICAgICAgIHBhaW50QnV0dG9uKHBh cnQsIHN0YXRlcywgY29udGV4dCwgem9vbWVkUmVjdCwgem9vbUZhY3Rvcik7CiAgICAgICAgIGJy ZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIGJyZWFrOwpAQCAtMTI5LDExICsxMzIsMTMgQEAg dm9pZCBUaGVtZVdQRTo6cGFpbnRSYWRpbyhDb250cm9sU3RhdGVzJiBzdGF0ZXMsIEdyYXBoaWNz Q29udGV4dCYgY29udGV4dCwgY29uc3QKICAgICB9CiB9CiAKLXZvaWQgVGhlbWVXUEU6OnBhaW50 QnV0dG9uKENvbnRyb2xTdGF0ZXMmIHN0YXRlcywgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBj b25zdCBGbG9hdFJlY3QmIHpvb21lZFJlY3QsIGZsb2F0KQordm9pZCBUaGVtZVdQRTo6cGFpbnRC dXR0b24oQ29udHJvbFBhcnQgcGFydCwgQ29udHJvbFN0YXRlcyYgc3RhdGVzLCBHcmFwaGljc0Nv bnRleHQmIGNvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYgem9vbWVkUmVjdCwgZmxvYXQpCiB7CiAg ICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBzdGF0ZVNhdmVyKGNvbnRleHQpOwogCi0gICAg RmxvYXRTaXplIGNvcm5lcigyLCAyKTsKKyAgICBmbG9hdCByb3VuZG5lc3MgPSAocGFydCA9PSBT cXVhcmVCdXR0b25QYXJ0KSA/IDAgOiAyOworCisgICAgRmxvYXRTaXplIGNvcm5lcihyb3VuZG5l c3MsIHJvdW5kbmVzcyk7CiAgICAgRmxvYXRSb3VuZGVkUmVjdCByb3VuZGVkUmVjdCh6b29tZWRS ZWN0LCBjb3JuZXIsIGNvcm5lciwgY29ybmVyLCBjb3JuZXIpOwogICAgIFBhdGggcGF0aDsKICAg ICBwYXRoLmFkZFJvdW5kZWRSZWN0KHJvdW5kZWRSZWN0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v d3BlL1RoZW1lV1BFLmgKaW5kZXggYjE3NmE4MDJmMmE5OGY0ZmEwYzAxYmFhNjdmNTk4ZGMwOGRk YzcyMy4uN2MzNWRjNWMwZjkyZjZkMDMzNmU4YmE3MTNhYTZkMjllZDhiMGZjMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3BlL1RoZW1lV1BFLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vd3BlL1RoZW1lV1BFLmgKQEAgLTM3LDcgKzM3LDcgQEAgcHJpdmF0ZToK IAogICAgIHZvaWQgcGFpbnRDaGVja2JveChDb250cm9sU3RhdGVzJiwgR3JhcGhpY3NDb250ZXh0 JiwgY29uc3QgRmxvYXRSZWN0JiwgZmxvYXQpOwogICAgIHZvaWQgcGFpbnRSYWRpbyhDb250cm9s U3RhdGVzJiwgR3JhcGhpY3NDb250ZXh0JiwgY29uc3QgRmxvYXRSZWN0JiwgZmxvYXQpOwotICAg IHZvaWQgcGFpbnRCdXR0b24oQ29udHJvbFN0YXRlcyYsIEdyYXBoaWNzQ29udGV4dCYsIGNvbnN0 IEZsb2F0UmVjdCYsIGZsb2F0KTsKKyAgICB2b2lkIHBhaW50QnV0dG9uKENvbnRyb2xQYXJ0LCBD b250cm9sU3RhdGVzJiwgR3JhcGhpY3NDb250ZXh0JiwgY29uc3QgRmxvYXRSZWN0JiwgZmxvYXQp OwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 374790 2019-07-24 11:37:59 -0700 2019-07-25 08:23:14 -0700 Patch bug-199377-20190724133758.patch text/plain 2979 JPEW.hacker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjFkYzVmZDY2ZTM3NjRm MDFlMWYyOGI5MGM3NmUxMDQxNzVhOWUzOS4uN2YxMWNjNDNlZTc2ZDc3YjhhMDI5ZGEyYWU3MWRl ZTIyNDRkNzM0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA3LTE2ICBKb3No dWEgV2F0dCAgPEpQRVcuaGFja2VyQGdtYWlsLmNvbT4KKworICAgICAgICBbV1BFXSBEcmF3IG90 aGVyIGJ1dHRvbiB0eXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk5Mzc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1dQRV0gRHJhdyBvdGhlciBidXR0b24gdHlwZXMKKworICAgICAgICBUaGVyZSBh cmUgb3RoZXIgYnV0dG9uIHR5cGVzIHRoYXQgc2hvdWxkIGJlIGRyYXduIHdpdGggdGhlIGRlZmF1 bHQgc3R5bGUKKyAgICAgICAgYmVzaWRlcyBqdXN0IHB1c2ggYnV0dG9ucy4KKworICAgICAgICAq IHBsYXRmb3JtL3dwZS9UaGVtZVdQRS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUaGVtZVdQRTo6 cGFpbnQpOgorICAgICAgICAoV2ViQ29yZTo6VGhlbWVXUEU6OnBhaW50QnV0dG9uKToKKyAgICAg ICAgKiBwbGF0Zm9ybS93cGUvVGhlbWVXUEUuaDoKKwogMjAxOS0wNy0xNSAgUnlhbiBIYWRkYWQg IDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMjQ3NDQ0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3BlL1RoZW1l V1BFLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5jcHAKaW5kZXgg ZTIyYTI5NDdlZTcyN2FhZjgwZGI3MDZhYjc2N2E3ZTZhMTg0NWY5Mi4uOGUwMjg1OTM1NTE2NmU1 MjE4NWUwZTZhMDMwZDkxODViNTg0ZWU0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vd3BlL1RoZW1lV1BFLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93cGUv VGhlbWVXUEUuY3BwCkBAIC02Nyw3ICs2NywxMCBAQCB2b2lkIFRoZW1lV1BFOjpwYWludChDb250 cm9sUGFydCBwYXJ0LCBDb250cm9sU3RhdGVzJiBzdGF0ZXMsIEdyYXBoaWNzQ29udGV4dCYgYwog ICAgICAgICBwYWludFJhZGlvKHN0YXRlcywgY29udGV4dCwgem9vbWVkUmVjdCwgem9vbUZhY3Rv cik7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgUHVzaEJ1dHRvblBhcnQ6Ci0gICAgICAgIHBh aW50QnV0dG9uKHN0YXRlcywgY29udGV4dCwgem9vbWVkUmVjdCwgem9vbUZhY3Rvcik7CisgICAg Y2FzZSBEZWZhdWx0QnV0dG9uUGFydDoKKyAgICBjYXNlIEJ1dHRvblBhcnQ6CisgICAgY2FzZSBT cXVhcmVCdXR0b25QYXJ0OgorICAgICAgICBwYWludEJ1dHRvbihwYXJ0LCBzdGF0ZXMsIGNvbnRl eHQsIHpvb21lZFJlY3QsIHpvb21GYWN0b3IpOwogICAgICAgICBicmVhazsKICAgICBkZWZhdWx0 OgogICAgICAgICBicmVhazsKQEAgLTEyOSwxMSArMTMyLDEzIEBAIHZvaWQgVGhlbWVXUEU6OnBh aW50UmFkaW8oQ29udHJvbFN0YXRlcyYgc3RhdGVzLCBHcmFwaGljc0NvbnRleHQmIGNvbnRleHQs IGNvbnN0CiAgICAgfQogfQogCi12b2lkIFRoZW1lV1BFOjpwYWludEJ1dHRvbihDb250cm9sU3Rh dGVzJiBzdGF0ZXMsIEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiB6 b29tZWRSZWN0LCBmbG9hdCkKK3ZvaWQgVGhlbWVXUEU6OnBhaW50QnV0dG9uKENvbnRyb2xQYXJ0 IHBhcnQsIENvbnRyb2xTdGF0ZXMmIHN0YXRlcywgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBj b25zdCBGbG9hdFJlY3QmIHpvb21lZFJlY3QsIGZsb2F0KQogewogICAgIEdyYXBoaWNzQ29udGV4 dFN0YXRlU2F2ZXIgc3RhdGVTYXZlcihjb250ZXh0KTsKIAotICAgIEZsb2F0U2l6ZSBjb3JuZXIo MiwgMik7CisgICAgZmxvYXQgcm91bmRuZXNzID0gKHBhcnQgPT0gU3F1YXJlQnV0dG9uUGFydCkg PyAwIDogMjsKKworICAgIEZsb2F0U2l6ZSBjb3JuZXIocm91bmRuZXNzLCByb3VuZG5lc3MpOwog ICAgIEZsb2F0Um91bmRlZFJlY3Qgcm91bmRlZFJlY3Qoem9vbWVkUmVjdCwgY29ybmVyLCBjb3Ju ZXIsIGNvcm5lciwgY29ybmVyKTsKICAgICBQYXRoIHBhdGg7CiAgICAgcGF0aC5hZGRSb3VuZGVk UmVjdChyb3VuZGVkUmVjdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93 cGUvVGhlbWVXUEUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5oCmlu ZGV4IGIxNzZhODAyZjJhOThmNGZhMGMwMWJhYTY3ZjU5OGRjMDhkZGM3MjMuLjdjMzVkYzVjMGY5 MmY2ZDAzMzZlOGJhNzEzYWE2ZDI5ZWQ4YjBmYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dw ZS9UaGVtZVdQRS5oCkBAIC0zNyw3ICszNyw3IEBAIHByaXZhdGU6CiAKICAgICB2b2lkIHBhaW50 Q2hlY2tib3goQ29udHJvbFN0YXRlcyYsIEdyYXBoaWNzQ29udGV4dCYsIGNvbnN0IEZsb2F0UmVj dCYsIGZsb2F0KTsKICAgICB2b2lkIHBhaW50UmFkaW8oQ29udHJvbFN0YXRlcyYsIEdyYXBoaWNz Q29udGV4dCYsIGNvbnN0IEZsb2F0UmVjdCYsIGZsb2F0KTsKLSAgICB2b2lkIHBhaW50QnV0dG9u KENvbnRyb2xTdGF0ZXMmLCBHcmFwaGljc0NvbnRleHQmLCBjb25zdCBGbG9hdFJlY3QmLCBmbG9h dCk7CisgICAgdm9pZCBwYWludEJ1dHRvbihDb250cm9sUGFydCwgQ29udHJvbFN0YXRlcyYsIEdy YXBoaWNzQ29udGV4dCYsIGNvbnN0IEZsb2F0UmVjdCYsIGZsb2F0KTsKIH07CiAKIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUK 374889 2019-07-25 08:23:16 -0700 2019-07-25 11:04:22 -0700 Patch bug-199377-20190725102315.patch text/plain 2938 JPEW.hacker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjFkYzVmZDY2ZTM3NjRm MDFlMWYyOGI5MGM3NmUxMDQxNzVhOWUzOS4uMTA4MjRlZWJmNDQ3NjYzZDJiNjAwNWQxZTdiNjgy ZDA4ZWY1MTYxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA3LTE2ICBKb3No dWEgV2F0dCAgPEpQRVcuaGFja2VyQGdtYWlsLmNvbT4KKworICAgICAgICBbV1BFXSBEcmF3IG90 aGVyIGJ1dHRvbiB0eXBlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk5Mzc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlcmUgYXJlIG90aGVyIGJ1dHRvbiB0eXBlcyB0aGF0IHNob3VsZCBiZSBkcmF3 biB3aXRoIHRoZSBkZWZhdWx0IHN0eWxlCisgICAgICAgIGJlc2lkZXMganVzdCBwdXNoIGJ1dHRv bnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93cGUvVGhlbWVXUEUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6VGhlbWVXUEU6OnBhaW50KToKKyAgICAgICAgKFdlYkNvcmU6OlRoZW1lV1BFOjpwYWlu dEJ1dHRvbik6CisgICAgICAgICogcGxhdGZvcm0vd3BlL1RoZW1lV1BFLmg6CisKIDIwMTktMDct MTUgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjI0NzQ0NC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3dwZS9UaGVtZVdQRS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93cGUvVGhl bWVXUEUuY3BwCmluZGV4IGUyMmEyOTQ3ZWU3MjdhYWY4MGRiNzA2YWI3NjdhN2U2YTE4NDVmOTIu LjhlMDI4NTkzNTUxNjZlNTIxODVlMGU2YTAzMGQ5MTg1YjU4NGVlNDIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dwZS9UaGVtZVdQRS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vd3BlL1RoZW1lV1BFLmNwcApAQCAtNjcsNyArNjcsMTAgQEAgdm9pZCBUaGVt ZVdQRTo6cGFpbnQoQ29udHJvbFBhcnQgcGFydCwgQ29udHJvbFN0YXRlcyYgc3RhdGVzLCBHcmFw aGljc0NvbnRleHQmIGMKICAgICAgICAgcGFpbnRSYWRpbyhzdGF0ZXMsIGNvbnRleHQsIHpvb21l ZFJlY3QsIHpvb21GYWN0b3IpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFB1c2hCdXR0b25Q YXJ0OgotICAgICAgICBwYWludEJ1dHRvbihzdGF0ZXMsIGNvbnRleHQsIHpvb21lZFJlY3QsIHpv b21GYWN0b3IpOworICAgIGNhc2UgRGVmYXVsdEJ1dHRvblBhcnQ6CisgICAgY2FzZSBCdXR0b25Q YXJ0OgorICAgIGNhc2UgU3F1YXJlQnV0dG9uUGFydDoKKyAgICAgICAgcGFpbnRCdXR0b24ocGFy dCwgc3RhdGVzLCBjb250ZXh0LCB6b29tZWRSZWN0LCB6b29tRmFjdG9yKTsKICAgICAgICAgYnJl YWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgYnJlYWs7CkBAIC0xMjksMTEgKzEzMiwxMyBAQCB2 b2lkIFRoZW1lV1BFOjpwYWludFJhZGlvKENvbnRyb2xTdGF0ZXMmIHN0YXRlcywgR3JhcGhpY3ND b250ZXh0JiBjb250ZXh0LCBjb25zdAogICAgIH0KIH0KIAotdm9pZCBUaGVtZVdQRTo6cGFpbnRC dXR0b24oQ29udHJvbFN0YXRlcyYgc3RhdGVzLCBHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIGNv bnN0IEZsb2F0UmVjdCYgem9vbWVkUmVjdCwgZmxvYXQpCit2b2lkIFRoZW1lV1BFOjpwYWludEJ1 dHRvbihDb250cm9sUGFydCBwYXJ0LCBDb250cm9sU3RhdGVzJiBzdGF0ZXMsIEdyYXBoaWNzQ29u dGV4dCYgY29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiB6b29tZWRSZWN0LCBmbG9hdCkKIHsKICAg ICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0YXRlU2F2ZXIoY29udGV4dCk7CiAKLSAgICBG bG9hdFNpemUgY29ybmVyKDIsIDIpOworICAgIGZsb2F0IHJvdW5kbmVzcyA9IChwYXJ0ID09IFNx dWFyZUJ1dHRvblBhcnQpID8gMCA6IDI7CisKKyAgICBGbG9hdFNpemUgY29ybmVyKHJvdW5kbmVz cywgcm91bmRuZXNzKTsKICAgICBGbG9hdFJvdW5kZWRSZWN0IHJvdW5kZWRSZWN0KHpvb21lZFJl Y3QsIGNvcm5lciwgY29ybmVyLCBjb3JuZXIsIGNvcm5lcik7CiAgICAgUGF0aCBwYXRoOwogICAg IHBhdGguYWRkUm91bmRlZFJlY3Qocm91bmRlZFJlY3QpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vd3BlL1RoZW1lV1BFLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93 cGUvVGhlbWVXUEUuaAppbmRleCBiMTc2YTgwMmYyYTk4ZjRmYTBjMDFiYWE2N2Y1OThkYzA4ZGRj NzIzLi43YzM1ZGM1YzBmOTJmNmQwMzM2ZThiYTcxM2FhNmQyOWVkOGIwZmMzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93cGUvVGhlbWVXUEUuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS93cGUvVGhlbWVXUEUuaApAQCAtMzcsNyArMzcsNyBAQCBwcml2YXRlOgog CiAgICAgdm9pZCBwYWludENoZWNrYm94KENvbnRyb2xTdGF0ZXMmLCBHcmFwaGljc0NvbnRleHQm LCBjb25zdCBGbG9hdFJlY3QmLCBmbG9hdCk7CiAgICAgdm9pZCBwYWludFJhZGlvKENvbnRyb2xT dGF0ZXMmLCBHcmFwaGljc0NvbnRleHQmLCBjb25zdCBGbG9hdFJlY3QmLCBmbG9hdCk7Ci0gICAg dm9pZCBwYWludEJ1dHRvbihDb250cm9sU3RhdGVzJiwgR3JhcGhpY3NDb250ZXh0JiwgY29uc3Qg RmxvYXRSZWN0JiwgZmxvYXQpOworICAgIHZvaWQgcGFpbnRCdXR0b24oQ29udHJvbFBhcnQsIENv bnRyb2xTdGF0ZXMmLCBHcmFwaGljc0NvbnRleHQmLCBjb25zdCBGbG9hdFJlY3QmLCBmbG9hdCk7 CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==