199366 2019-07-01 08:15:17 -0700 [iOS] REGRESSION (r246757): Unable to select non-editable text in subframes 2019-07-01 15:10:53 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1549219 0 wenson_hsieh 2019-07-01 08:15:17 -0700 To reproduce: 1. Go to https://whsieh.github.io/examples/subframes. 2. Try to select any of the text in the first section (lorem.html) by any of the usual means (long pressing, via tap-and-half, etc.) Observe that you can’t select any text. 1549222 1 webkit-bug-importer 2019-07-01 08:19:56 -0700 <rdar://problem/52460509> 1549223 2 wenson_hsieh 2019-07-01 08:20:03 -0700 Appears to be a recent regression in iOS 13. 1549227 3 wenson_hsieh 2019-07-01 08:39:56 -0700 Caused by: https://trac.webkit.org/changeset/246757/webkit That revision also caused several layout tests to consistently fail: • editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk.html • editing/selection/ios/selection-handles-in-iframe.html • editing/selection/ios/selection-handle-clamping-in-iframe.html 1549292 4 wenson_hsieh 2019-07-01 13:43:07 -0700 (In reply to Wenson Hsieh from comment #3) > Caused by: https://trac.webkit.org/changeset/246757/webkit > > That revision also caused several layout tests to consistently fail: > > • > editing/selection/ios/dispatch-mouse-events-when-modifying-selection-quirk. > html This one’s actually failing for a different reason. > • editing/selection/ios/selection-handles-in-iframe.html > • editing/selection/ios/selection-handle-clamping-in-iframe.html 1549295 5 373253 wenson_hsieh 2019-07-01 13:44:18 -0700 Created attachment 373253 Patch 1549358 6 373253 commit-queue 2019-07-01 15:10:51 -0700 Comment on attachment 373253 Patch Clearing flags on attachment: 373253 Committed r247027: <https://trac.webkit.org/changeset/247027> 1549359 7 commit-queue 2019-07-01 15:10:53 -0700 All reviewed patches have been landed. Closing bug. 373253 2019-07-01 13:44:18 -0700 2019-07-01 15:10:51 -0700 Patch bug-199366-20190701134418.patch text/plain 5066 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM0YTlhY2M3MTMxNmVhYzIw ZTExYmU3NGEyODM5OTc5MmQ5NDFlYjUuLjg0MDkyYTNiZGNkYjk5MDBmZmZiYmY2NTdmODljOTc4 YjMzNTYyMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMgQEAKKzIwMTktMDctMDEgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUkVHUkVTU0lP TiAocjI0Njc1Nyk6IFVuYWJsZSB0byBzZWxlY3Qgbm9uLWVkaXRhYmxlIHRleHQgaW4gc3ViZnJh bWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkz NjYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUyNDYwNTA5PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyNDY3NTcgcmVtb3ZlZCBsb2dpYyBpbiBz ZWxlY3Rpb25Qb3NpdGlvbkluZm9ybWF0aW9uIHJlc3BvbnNpYmxlIGZvciBzZXR0aW5nIHRoZSBm b2N1c2VkIGZyYW1lIHdoZW4gaGFuZGxpbmcgYQorICAgICAgICBwb3NpdGlvbiBpbmZvcm1hdGlv biByZXF1ZXN0LiBBcyB0aGUgRklYTUUgZm9ybWVybHkgaW4gSW50ZXJhY3Rpb25JbmZvcm1hdGlv blJlcXVlc3QuaCBhbGx1ZGVkIHRvLCB0ZXh0CisgICAgICAgIHNlbGVjdGlvbiBnZXN0dXJlcyBv biBpT1Mgd2VyZSBkZXBlbmRlbnQgb24gdGhpcyBiZWhhdmlvciB3aGVuIHNlbGVjdGluZyB0ZXh0 IGluIHN1YmZyYW1lcywgc2luY2UgdGV4dCBzZWxlY3Rpb24KKyAgICAgICAgaGVscGVycyBpbiBX ZWJQYWdlSU9TLm1tIGFzc3VtZSB0aGF0IHRoZSBmb2N1c2VkIGZyYW1lIGFscmVhZHkgY29udGFp bnMgdGhlIHNlbGVjdGlvbiBiZWluZyBzZXQuCisKKyAgICAgICAgUmF0aGVyIHRoYW4gY2FsbGlu ZyBzZXRGb2N1c2VkRnJhbWUgd2hlbiByZXF1ZXN0aW5nIHBvc2l0aW9uIGluZm9ybWF0aW9uLCB3 ZSBjYW4gZml4IHRoaXMgYnkgbWFraW5nCisgICAgICAgIFdlYlBhZ2U6OnNlbGVjdFdpdGhHZXN0 dXJlIGFuZCBXZWJQYWdlOjpzZWxlY3RUZXh0V2l0aEdyYW51bGFyaXR5QXRQb2ludCBib3RoIHNl dCB0aGUgZm9jdXNlZCBmcmFtZSBpZiBuZWVkZWQKKyAgICAgICAgYmVmb3JlIGV4dGVuZGluZyBv ciBtb3ZpbmcgdGV4dCBzZWxlY3Rpb25zLgorCisgICAgICAgIENvdmVyZWQgYnkgbGF5b3V0IHRl c3RzIHRoYXQgYmVnYW4gdG8gZmFpbCBhZnRlciByMjQ2NzU3OgorICAgICAgICAtIGVkaXRpbmcv c2VsZWN0aW9uL2lvcy9zZWxlY3Rpb24taGFuZGxlcy1pbi1pZnJhbWUuaHRtbAorICAgICAgICAt IGVkaXRpbmcvc2VsZWN0aW9uL2lvcy9zZWxlY3Rpb24taGFuZGxlLWNsYW1waW5nLWluLWlmcmFt ZS5odG1sCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oOgorICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZTo6c2VsZWN0V2l0aEdlc3R1cmUpOgorCisgICAgICAgIE9ubHkgY2FsbCB0aGUg bmV3IGhlbHBlciBtZXRob2QsIHNldEZvY3VzZWRGcmFtZUJlZm9yZVNlbGVjdGluZ1RleHRBdExv Y2F0aW9uLCBhdCB0aGUgc3RhcnQgb2YgdGhlIGdlc3R1cmUuCisKKyAgICAgICAgKFdlYktpdDo6 V2ViUGFnZTo6c2V0Rm9jdXNlZEZyYW1lQmVmb3JlU2VsZWN0aW5nVGV4dEF0TG9jYXRpb24pOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpzZWxlY3RUZXh0V2l0aEdyYW51bGFyaXR5QXRQb2lu dCk6CisKIDIwMTktMDctMDEgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+ CiAKICAgICAgICAgaU9TOiBSRUdSRVNTSU9OKGFzeW5jIHNjcm9sbCk6IENhcmV0IGRvZXNuJ3Qg c2Nyb2xsIHdoZW4gc2Nyb2xsaW5nIHRleHRhcmVhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmgKaW5kZXggMTViY2I5MGY1ZDkyOWI3NjRiMWNhNTA4ZjY4MmY1Y2I0 M2YyZmMwNC4uN2Q3OWE3OGFmYTM4Y2NmOGNjYTM5MmIxY2ZjMjliNzMwZWI2MTUxZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaApAQCAtMTI0NSw2ICsxMjQ1 LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIHJlc2V0SWRlbXBvdGVudFRleHRBdXRvc2l6aW5nSWZO ZWVkZWQoZG91YmxlIHByZXZpb3VzSW5pdGlhbFNjYWxlKTsKICAgICBXZWJDb3JlOjpWaXNpYmxl UG9zaXRpb24gdmlzaWJsZVBvc2l0aW9uSW5Gb2N1c2VkTm9kZUZvclBvaW50KGNvbnN0IFdlYkNv cmU6OkZyYW1lJiwgY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmLCBib29sIGlzSW50ZXJhY3RpbmdX aXRoRm9jdXNlZEVsZW1lbnQpOwogICAgIFJlZlB0cjxXZWJDb3JlOjpSYW5nZT4gcmFuZ2VGb3JH cmFudWxhcml0eUF0UG9pbnQoV2ViQ29yZTo6RnJhbWUmLCBjb25zdCBXZWJDb3JlOjpJbnRQb2lu dCYsIHVpbnQzMl90IGdyYW51bGFyaXR5LCBib29sIGlzSW50ZXJhY3RpbmdXaXRoRm9jdXNlZEVs ZW1lbnQpOworICAgIHZvaWQgc2V0Rm9jdXNlZEZyYW1lQmVmb3JlU2VsZWN0aW5nVGV4dEF0TG9j YXRpb24oY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmKTsKICAgICB2b2lkIGRpc3BhdGNoU3ludGhl dGljTW91c2VFdmVudHNGb3JTZWxlY3Rpb25HZXN0dXJlKFNlbGVjdGlvblRvdWNoLCBjb25zdCBX ZWJDb3JlOjpJbnRQb2ludCYpOwogCiAgICAgdm9pZCBzZW5kUG9zaXRpb25JbmZvcm1hdGlvbihJ bnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbiYmKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tIGIvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KaW5kZXggNzcxODM2OGE4NGI0 YjVjMGU2Mjg5OWJmMGFlYzJiOWQwMDc5NTVhNS4uYWYwNTBkMmRkOTZjMDNjYjNmNzBlNzA0MWJk NTBmZThlMjhjNTg4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBh Z2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBh Z2UvaW9zL1dlYlBhZ2VJT1MubW0KQEAgLTEzMDMsNiArMTMwMyw5IEBAIHN0YXRpYyBJbnRSZWN0 IHNlbGVjdGlvbkJveEZvclJhbmdlKFdlYkNvcmU6OlJhbmdlKiByYW5nZSkKIAogdm9pZCBXZWJQ YWdlOjpzZWxlY3RXaXRoR2VzdHVyZShjb25zdCBJbnRQb2ludCYgcG9pbnQsIHVpbnQzMl90IGdy YW51bGFyaXR5LCB1aW50MzJfdCBnZXN0dXJlVHlwZSwgdWludDMyX3QgZ2VzdHVyZVN0YXRlLCBi b29sIGlzSW50ZXJhY3RpbmdXaXRoRm9jdXNlZEVsZW1lbnQsIENhbGxiYWNrSUQgY2FsbGJhY2tJ RCkKIHsKKyAgICBpZiAoc3RhdGljX2Nhc3Q8R2VzdHVyZVJlY29nbml6ZXJTdGF0ZT4oZ2VzdHVy ZVN0YXRlKSA9PSBHZXN0dXJlUmVjb2duaXplclN0YXRlOjpCZWdhbikKKyAgICAgICAgc2V0Rm9j dXNlZEZyYW1lQmVmb3JlU2VsZWN0aW5nVGV4dEF0TG9jYXRpb24ocG9pbnQpOworCiAgICAgYXV0 byYgZnJhbWUgPSBtX3BhZ2UtPmZvY3VzQ29udHJvbGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgp OwogICAgIFZpc2libGVQb3NpdGlvbiBwb3NpdGlvbiA9IHZpc2libGVQb3NpdGlvbkluRm9jdXNl ZE5vZGVGb3JQb2ludChmcmFtZSwgcG9pbnQsIGlzSW50ZXJhY3RpbmdXaXRoRm9jdXNlZEVsZW1l bnQpOwogCkBAIC0yMDIyLDggKzIwMjUsMTggQEAgc3RhdGljIGlubGluZSBib29sIHJlY3RJc1Rv b0JpZ0ZvclNlbGVjdGlvbihjb25zdCBJbnRSZWN0JiBibG9ja1JlY3QsIGNvbnN0IEZyYW0KICAg ICByZXR1cm4gYmxvY2tSZWN0LmhlaWdodCgpID4gZnJhbWUudmlldygpLT51bm9ic2N1cmVkQ29u dGVudFJlY3QoKS5oZWlnaHQoKSAqIGZhY3RvcjsKIH0KIAordm9pZCBXZWJQYWdlOjpzZXRGb2N1 c2VkRnJhbWVCZWZvcmVTZWxlY3RpbmdUZXh0QXRMb2NhdGlvbihjb25zdCBJbnRQb2ludCYgcG9p bnQpCit7CisgICAgYXV0byByZXN1bHQgPSBtX3BhZ2UtPm1haW5GcmFtZSgpLmV2ZW50SGFuZGxl cigpLmhpdFRlc3RSZXN1bHRBdFBvaW50KHBvaW50LCBIaXRUZXN0UmVxdWVzdDo6UmVhZE9ubHkg fCBIaXRUZXN0UmVxdWVzdDo6QWN0aXZlIHwgSGl0VGVzdFJlcXVlc3Q6OkRpc2FsbG93VXNlckFn ZW50U2hhZG93Q29udGVudCB8IEhpdFRlc3RSZXF1ZXN0OjpBbGxvd0NoaWxkRnJhbWVDb250ZW50 KTsKKyAgICBhdXRvKiBoaXROb2RlID0gcmVzdWx0LmlubmVyTm9kZSgpOworICAgIGlmIChoaXRO b2RlICYmIGhpdE5vZGUtPnJlbmRlcmVyKCkpCisgICAgICAgIG1fcGFnZS0+Zm9jdXNDb250cm9s bGVyKCkuc2V0Rm9jdXNlZEZyYW1lKHJlc3VsdC5pbm5lck5vZGVGcmFtZSgpKTsKK30KKwogdm9p ZCBXZWJQYWdlOjpzZWxlY3RUZXh0V2l0aEdyYW51bGFyaXR5QXRQb2ludChjb25zdCBXZWJDb3Jl OjpJbnRQb2ludCYgcG9pbnQsIHVpbnQzMl90IGdyYW51bGFyaXR5LCBib29sIGlzSW50ZXJhY3Rp bmdXaXRoRm9jdXNlZEVsZW1lbnQsIENhbGxiYWNrSUQgY2FsbGJhY2tJRCkKIHsKKyAgICBzZXRG b2N1c2VkRnJhbWVCZWZvcmVTZWxlY3RpbmdUZXh0QXRMb2NhdGlvbihwb2ludCk7CisKICAgICBh dXRvJiBmcmFtZSA9IG1fcGFnZS0+Zm9jdXNDb250cm9sbGVyKCkuZm9jdXNlZE9yTWFpbkZyYW1l KCk7CiAgICAgUmVmUHRyPFJhbmdlPiByYW5nZSA9IHJhbmdlRm9yR3JhbnVsYXJpdHlBdFBvaW50 KGZyYW1lLCBwb2ludCwgZ3JhbnVsYXJpdHksIGlzSW50ZXJhY3RpbmdXaXRoRm9jdXNlZEVsZW1l bnQpOwogICAgIGlmICghaXNJbnRlcmFjdGluZ1dpdGhGb2N1c2VkRWxlbWVudCkgewo=