199365 2019-07-01 07:55:48 -0700 Frozen Arrays length assignment should throw in strict mode 2019-07-02 11:46:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore Safari Technology Preview All All RESOLVED FIXED InRadar P2 Normal --- 1 jason keith_miller commit-queue ews-watchlist fpizlo keith_miller mark.lam mathias msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1549214 0 jason 2019-07-01 07:55:48 -0700 In strict mode, assigning to `.length` on a Frozen Array silently fails, when it should raise a TypeError. I noticed this when I realized I could assign strings.length from within the tag function of a Tagged Template. Example: const a = Object.freeze(['a']); // this should throw, but it doesn't: a.length = 2; console.log(a.length); // 1 // this throws correctly: // a.x = 2; Reproduction: https://jsbin.com/fecosoh/edit?html,console 1549516 1 webkit-bug-importer 2019-07-02 03:45:47 -0700 <rdar://problem/52514370> 1549624 2 373339 keith_miller 2019-07-02 10:47:10 -0700 Created attachment 373339 Patch 1549628 3 373339 ysuzuki 2019-07-02 10:48:20 -0700 Comment on attachment 373339 Patch r=me 1549629 4 keith_miller 2019-07-02 10:49:17 -0700 Thanks for the report! This patch should fix this. 1549659 5 commit-queue 2019-07-02 11:46:02 -0700 The commit-queue encountered the following flaky tests while processing attachment 373339: imported/w3c/web-platform-tests/xhr/event-error-order.sub.html bug 192363 (authors: cdumez@apple.com and youennf@gmail.com) imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html bug 183294 (authors: cdumez@apple.com and youennf@gmail.com) imported/w3c/web-platform-tests/websockets/interfaces/WebSocket/events/020.html bug 199414 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1549661 6 373339 commit-queue 2019-07-02 11:46:49 -0700 Comment on attachment 373339 Patch Clearing flags on attachment: 373339 Committed r247065: <https://trac.webkit.org/changeset/247065> 1549662 7 commit-queue 2019-07-02 11:46:51 -0700 All reviewed patches have been landed. Closing bug. 373339 2019-07-02 10:47:10 -0700 2019-07-02 11:46:49 -0700 Patch bug-199365-20190702104709.patch text/plain 2870 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy Y2VmYjc4ZTg2MmI4NmY0YTYxMDU4NDE2OTNkZWViOGMzNWY0NjA4Li42MGNkYWY2NWRmNGFkODA0 YmRhY2IzYjlmYjkxZjQ4MTYzMTJkZmQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0wNy0wMiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGcm96ZW4gQXJyYXlzIGxlbmd0aCBhc3NpZ25tZW50IHNob3VsZCB0 aHJvdyBpbiBzdHJpY3QgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk5MzY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBydW50aW1lL0pTQXJyYXkuY3BwOgorICAgICAgICAoSlNDOjpKU0FycmF5 OjpwdXQpOgorCiAyMDE5LTA3LTAyICBQYXVsbyBNYXRvcyAgPHBtYXRvc0BsaW5raS50b29scz4K IAogICAgICAgICBGaXggdHlwbyBpbiBpZi9lbHNlIGJsb2NrIGFuZCByZW1vdmUgZGVhZCBhc3Np Z25tZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5 LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCmluZGV4IDU0 N2MxYjU5YTk1YWIwMTZhMTQwNTE0YjZiODU0N2QyYjIxY2Y3N2IuLjQyOTc0OWJlYzdlZTJkNWNm YWU5YTg4OWFhNDQwMmNiNDkyOGQ0MmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTQXJyYXkuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTQXJyYXkuY3BwCkBAIC0yODYsOCArMjg2LDEyIEBAIGJvb2wgSlNBcnJheTo6cHV0KEpTQ2Vs bCogY2VsbCwgRXhlY1N0YXRlKiBleGVjLCBQcm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1lLCBKU1Zh CiAgICAgdGhpc09iamVjdC0+ZW5zdXJlV3JpdGFibGUodm0pOwogCiAgICAgaWYgKHByb3BlcnR5 TmFtZSA9PSB2bS5wcm9wZXJ0eU5hbWVzLT5sZW5ndGgpIHsKLSAgICAgICAgaWYgKCF0aGlzT2Jq ZWN0LT5pc0xlbmd0aFdyaXRhYmxlKCkpCisgICAgICAgIGlmICghdGhpc09iamVjdC0+aXNMZW5n dGhXcml0YWJsZSgpKSB7CisgICAgICAgICAgICBpZiAoc2xvdC5pc1N0cmljdE1vZGUoKSkKKyAg ICAgICAgICAgICAgICB0aHJvd1R5cGVFcnJvcihleGVjLCBzY29wZSwgIkFycmF5IGxlbmd0aCBp cyBub3Qgd3JpdGFibGUiX3MpOwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9 CisKICAgICAgICAgdW5zaWduZWQgbmV3TGVuZ3RoID0gdmFsdWUudG9VSW50MzIoZXhlYyk7CiAg ICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGZhbHNlKTsKICAgICAgICAgZG91Ymxl IHZhbHVlQXNOdW1iZXIgPSB2YWx1ZS50b051bWJlcihleGVjKTsKZGlmZiAtLWdpdCBhL0pTVGVz dHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjBlODU0YTJhNGFiOTM2NTA0 ZmVhZDc2M2M4MDZiZmYxMTExODYwYy4uZWMyZjZhYTBjMzcwNjg1NDEyMTM3ZGViZTEwNmVlZmNk OGM4NmJjYyAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0wNy0wMiAgS2VpdGggTWlsbGVyICA8a2VpdGhf bWlsbGVyQGFwcGxlLmNvbT4KKworICAgICAgICBGcm96ZW4gQXJyYXlzIGxlbmd0aCBhc3NpZ25t ZW50IHNob3VsZCB0aHJvdyBpbiBzdHJpY3QgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MzY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvZnJvemVuLWFycmF5LWxlbmd0aC1zaG91 bGQtdGhyb3ctc3RyaWN0LmpzOiBBZGRlZC4KKyAgICAgICAgKHRlc3QpOgorCiAyMDE5LTA3LTAx ICBKdXN0aW4gTWljaGF1ZCAgPGp1c3Rpbl9taWNoYXVkQGFwcGxlLmNvbT4KIAogICAgICAgICBb V2FzbS1SZWZlcmVuY2VzXSBEaXNhYmxlIHJlZmVyZW5jZXMgYnkgZGVmYXVsdApkaWZmIC0tZ2l0 IGEvSlNUZXN0cy9zdHJlc3MvZnJvemVuLWFycmF5LWxlbmd0aC1zaG91bGQtdGhyb3ctc3RyaWN0 LmpzIGIvSlNUZXN0cy9zdHJlc3MvZnJvemVuLWFycmF5LWxlbmd0aC1zaG91bGQtdGhyb3ctc3Ry aWN0LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLmU2ZGZkMzI2YmI5OWMxNWY4ZDM5OGIzMDQwOTEzMGRlNzJmZjlk ZmUKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9mcm96ZW4tYXJyYXktbGVuZ3Ro LXNob3VsZC10aHJvdy1zdHJpY3QuanMKQEAgLTAsMCArMSwxNyBAQAorY29uc3QgYSA9IE9iamVj dC5mcmVlemUoWydhJ10pOworCitmdW5jdGlvbiB0ZXN0KGEpIHsKKyAgICAidXNlIHN0cmljdCI7 CisKKyAgICB0cnkgeworICAgICAgICBhLmxlbmd0aCA9IDI7CisgICAgfSBjYXRjaCAoZSkgewor ICAgICAgICBpZiAoZSBpbnN0YW5jZW9mIFR5cGVFcnJvcikKKyAgICAgICAgICAgIHJldHVybjsK KyAgICB9CisgICAgdGhyb3cgbmV3IEVycm9yKCJkaWRuJ3QgdGhyb3cgdGhlIHJpZ2h0IGV4Y2Vw dGlvbiIpOworfQorbm9JbmxpbmUodGVzdCk7CisKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDA7 IGkrKykKKyAgICB0ZXN0KGEpOwo=