199327 2019-06-28 11:09:10 -0700 Null check provisionalItem in FrameLoader::continueLoadAfterNavigationPolicy 2019-07-01 14:11:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez commit-queue darin ews-watchlist japhet mjs rniwa webkit-bug-importer oldest_to_newest 1548885 0 achristensen 2019-06-28 11:09:10 -0700 Null check provisionalItem in FrameLoader::continueLoadAfterNavigationPolicy 1548887 1 373135 achristensen 2019-06-28 11:10:06 -0700 Created attachment 373135 Patch 1548888 2 achristensen 2019-06-28 11:10:08 -0700 <rdar://problem/48262384> 1549020 3 373135 dbates 2019-06-28 23:16:49 -0700 Comment on attachment 373135 Patch So, I’ve been out of this code for a while. But I spent like ***20**** seconds just grepping this file for provisionalItem and I can say that this patch makes absolutely no sense to me. Hint: It contradicts a bunch of RELEASE_ASSERTS. And with 0 details about why this fix is necessary except an appeal to “Let’s not crash” I have no means of helping you further (I don’t have a radar client handy at the moment). 1549166 4 mjs 2019-07-01 02:23:21 -0700 This is an attempt to fix a top crash based on telemetry. It doesn't contradict a RELEASE_ASSERT in the control flow path that led to the crash, because otherwise these crashes would have crashed earlier. The crash is known to be a null Derek on this line. So this is probably sensible as a speculative fix, even though there's probably something deeper wrong here. 1549285 5 rniwa 2019-07-01 13:17:43 -0700 (In reply to Daniel Bates from comment #3) > Comment on attachment 373135 [details] > Patch > > So, I’ve been out of this code for a while. But I spent like ***20**** > seconds just grepping this file for provisionalItem and I can say that this > patch makes absolutely no sense to me. Hint: It contradicts a bunch of > RELEASE_ASSERTS. And with 0 details about why this fix is necessary except > an appeal to “Let’s not crash” I have no means of helping you further (I > don’t have a radar client handy at the moment). That is true but we've been trying to fix this particular crash for the last 2-3 releases and at some point, we need to fix the damn crash for the sake of our users instead of keep investigating what the root cause is. 1549320 6 373135 commit-queue 2019-07-01 14:11:47 -0700 Comment on attachment 373135 Patch Clearing flags on attachment: 373135 Committed r247021: <https://trac.webkit.org/changeset/247021> 1549321 7 commit-queue 2019-07-01 14:11:48 -0700 All reviewed patches have been landed. Closing bug. 373135 2019-06-28 11:10:06 -0700 2019-07-01 14:11:47 -0700 Patch bug-199327-20190628111005.patch text/plain 1895 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjkzYzNlYTZiMDMwYjMy ZGJiMTNhYWYxNDgyNjM1M2VjY2Y0M2UwYi4uM2Q2ODE3YzgzNjI1MDkwMDcwYzc1NzRiZTAzZDc5 YTk2Mzc2NjY3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA2LTI4ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTnVsbCBj aGVjayBwcm92aXNpb25hbEl0ZW0gaW4gRnJhbWVMb2FkZXI6OmNvbnRpbnVlTG9hZEFmdGVyTmF2 aWdhdGlvblBvbGljeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk5MzI3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODI2MjM4ND4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxvYWRlci9GcmFtZUxv YWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y29udGludWVMb2FkQWZ0 ZXJOYXZpZ2F0aW9uUG9saWN5KToKKyAgICAgICAgU29tZXRpbWVzIHByb3Zpc2lvbmFsSXRlbSBp cyBudWxsLiAgTGV0J3Mgbm90IGNyYXNoLgorCiAyMDE5LTA2LTI3ICBCZXRoIERha2luICA8YmRh a2luQGFwcGxlLmNvbT4KIAogICAgICAgICBVcHN0cmVhbSB1c2Ugb2YgTUFDQ0FUQUxZU1QKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IDdlNDEzNjAzOGE1M2ExYTBkNjQw MzVjZGI4OTVhNGJjMmFiMDU3MzkuLjI0NmRlOWE0ZGFjOGI2ZTI3ZDQ3YThjZGZlYWJlMjU1NmYx NmRhMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMzQ2OCw3ICsz NDY4LDcgQEAgdm9pZCBGcmFtZUxvYWRlcjo6Y29udGludWVMb2FkQWZ0ZXJOYXZpZ2F0aW9uUG9s aWN5KGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWUKIAogICAgIGlmIChpc0JhY2tGb3J3YXJk TG9hZFR5cGUodHlwZSkpIHsKICAgICAgICAgYXV0byYgZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQg PSBtX2ZyYW1lLnBhZ2UoKS0+ZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQoKTsKLSAgICAgICAgaWYg KGhpc3RvcnkoKS5wcm92aXNpb25hbEl0ZW0oKS0+aXNJblBhZ2VDYWNoZSgpKSB7CisgICAgICAg IGlmIChoaXN0b3J5KCkucHJvdmlzaW9uYWxJdGVtKCkgJiYgaGlzdG9yeSgpLnByb3Zpc2lvbmFs SXRlbSgpLT5pc0luUGFnZUNhY2hlKCkpIHsKICAgICAgICAgICAgIGRpYWdub3N0aWNMb2dnaW5n Q2xpZW50LmxvZ0RpYWdub3N0aWNNZXNzYWdlV2l0aFJlc3VsdChEaWFnbm9zdGljTG9nZ2luZ0tl eXM6OnBhZ2VDYWNoZUtleSgpLCBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnJldHJpZXZhbEtleSgp LCBEaWFnbm9zdGljTG9nZ2luZ1Jlc3VsdFBhc3MsIFNob3VsZFNhbXBsZTo6WWVzKTsKICAgICAg ICAgICAgIGxvYWRQcm92aXNpb25hbEl0ZW1Gcm9tQ2FjaGVkUGFnZSgpOwogICAgICAgICAgICAg UkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgiY29udGludWVMb2FkQWZ0ZXJOYXZpZ2F0aW9uUG9saWN5 OiBjYW4ndCBjb250aW51ZSBsb2FkaW5nIGZyYW1lIGJlY2F1c2UgaXQgd2lsbCBiZSBsb2FkZWQg ZnJvbSBjYWNoZSAoZnJhbWUgPSAlcCwgbWFpbiA9ICVkKSIsICZtX2ZyYW1lLCBtX2ZyYW1lLmlz TWFpbkZyYW1lKCkpOwo=