199324 2019-06-28 10:16:48 -0700 Add main thread assertions in sendWithAsyncReply code 2019-07-01 14:12:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen commit-queue sam webkit-bug-importer oldest_to_newest 1548854 0 achristensen 2019-06-28 10:16:48 -0700 Add main thread assertions in sendWithAsyncReply code 1548855 1 373124 achristensen 2019-06-28 10:17:21 -0700 Created attachment 373124 Patch 1549060 2 373124 sam 2019-06-29 21:28:17 -0700 Comment on attachment 373124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373124&action=review > Source/WebKit/ChangeLog:8 > + This is responding to good feedback from r237294 Please add a more complete explanation. 1549297 3 373255 achristensen 2019-07-01 13:48:40 -0700 Created attachment 373255 Patch 1549318 4 373255 commit-queue 2019-07-01 14:11:36 -0700 Comment on attachment 373255 Patch Clearing flags on attachment: 373255 Committed r247020: <https://trac.webkit.org/changeset/247020> 1549319 5 commit-queue 2019-07-01 14:11:37 -0700 All reviewed patches have been landed. Closing bug. 1549324 6 webkit-bug-importer 2019-07-01 14:12:19 -0700 <rdar://problem/52481920> 373124 2019-06-28 10:17:21 -0700 2019-07-01 13:48:39 -0700 Patch bug-199324-20190628101720.patch text/plain 2959 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRjYjNlMTA5MTAxYWU3Yzgy NDcxYTAzNTZkYjA4MzdiY2M4MjVmMTMuLmVhOGFkMDdhNDFhODkzZmU1ZTU3OTY4ZjA1ODI1OTQ2 NzdjYjdhZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDYtMjggIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgbWFpbiB0 aHJlYWQgYXNzZXJ0aW9ucyBpbiBzZW5kV2l0aEFzeW5jUmVwbHkgY29kZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MzI0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyByZXNwb25kaW5nIHRv IGdvb2QgZmVlZGJhY2sgZnJvbSByMjM3Mjk0CisKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvQ29u bmVjdGlvbi5jcHA6CisgICAgICAgIChJUEM6OmFzeW5jUmVwbHlIYW5kbGVyTWFwKToKKyAgICAg ICAgKElQQzo6bmV4dEFzeW5jUmVwbHlIYW5kbGVySUQpOgorICAgICAgICAoSVBDOjphZGRBc3lu Y1JlcGx5SGFuZGxlcik6CisgICAgICAgIChJUEM6OmNsZWFyQXN5bmNSZXBseUhhbmRsZXJzKToK KyAgICAgICAgKElQQzo6Q29tcGxldGlvbkhhbmRsZXI8dm9pZCk6CisKIDIwMTktMDYtMjcgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFdlYlNv Y2tldHM6IGF2b2lkIGRhdGEgY29waWVzIHdoZW4gcXVldWluZyB0YXNrcyBpbiBXZWJTb2NrZXRD aGFubmVsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9Db25uZWN0aW9u LmNwcCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwCmluZGV4IDM2 MWY4NjE5ZDIzYzg0ODA3NWJjMTA3NGZkNjdmNGFlMDhjYjk5YjUuLjkyMWE2MjIyOGJkODBkZGY1 N2YwZDc5NzY4NDIyNTlmMDEzYzdlYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vSVBDL0Nvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0Nv bm5lY3Rpb24uY3BwCkBAIC0yMzksNiArMjM5LDcgQEAgc3RhdGljIEhhc2hNYXA8SVBDOjpDb25u ZWN0aW9uOjpVbmlxdWVJRCwgQ29ubmVjdGlvbio+JiBhbGxDb25uZWN0aW9ucygpCiAKIHN0YXRp YyBIYXNoTWFwPHVpbnRwdHJfdCwgSGFzaE1hcDx1aW50NjRfdCwgQ29tcGxldGlvbkhhbmRsZXI8 dm9pZChEZWNvZGVyKik+Pj4mIGFzeW5jUmVwbHlIYW5kbGVyTWFwKCkKIHsKKyAgICBBU1NFUlQo UnVuTG9vcDo6aXNNYWluKCkpOwogICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxIYXNoTWFwPHVp bnRwdHJfdCwgSGFzaE1hcDx1aW50NjRfdCwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChEZWNvZGVy Kik+Pj4+IG1hcDsKICAgICByZXR1cm4gbWFwLmdldCgpOwogfQpAQCAtMTEyNywxMiArMTEyOCwx NCBAQCB2b2lkIENvbm5lY3Rpb246OmRpc3BhdGNoSW5jb21pbmdNZXNzYWdlcygpCiAKIHVpbnQ2 NF90IG5leHRBc3luY1JlcGx5SGFuZGxlcklEKCkKIHsKKyAgICBBU1NFUlQoUnVuTG9vcDo6aXNN YWluKCkpOwogICAgIHN0YXRpYyB1aW50NjRfdCBpZGVudGlmaWVyIHsgMCB9OwogICAgIHJldHVy biArK2lkZW50aWZpZXI7CiB9CiAKIHZvaWQgYWRkQXN5bmNSZXBseUhhbmRsZXIoQ29ubmVjdGlv biYgY29ubmVjdGlvbiwgdWludDY0X3QgaWRlbnRpZmllciwgQ29tcGxldGlvbkhhbmRsZXI8dm9p ZChEZWNvZGVyKik+JiYgY29tcGxldGlvbkhhbmRsZXIpCiB7CisgICAgQVNTRVJUKFJ1bkxvb3A6 OmlzTWFpbigpKTsKICAgICBhdXRvIHJlc3VsdCA9IGFzeW5jUmVwbHlIYW5kbGVyTWFwKCkuZW5z dXJlKHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90PigmY29ubmVjdGlvbiksIFtdIHsKICAgICAg ICAgcmV0dXJuIEhhc2hNYXA8dWludDY0X3QsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoRGVjb2Rl ciopPj4oKTsKICAgICB9KS5pdGVyYXRvci0+dmFsdWUuYWRkKGlkZW50aWZpZXIsIFdURk1vdmUo Y29tcGxldGlvbkhhbmRsZXIpKTsKQEAgLTExNDEsNiArMTE0NCw3IEBAIHZvaWQgYWRkQXN5bmNS ZXBseUhhbmRsZXIoQ29ubmVjdGlvbiYgY29ubmVjdGlvbiwgdWludDY0X3QgaWRlbnRpZmllciwg Q29tcGxldGlvCiAKIHZvaWQgY2xlYXJBc3luY1JlcGx5SGFuZGxlcnMoY29uc3QgQ29ubmVjdGlv biYgY29ubmVjdGlvbikKIHsKKyAgICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOwogICAgIGF1 dG8gbWFwID0gYXN5bmNSZXBseUhhbmRsZXJNYXAoKS50YWtlKHJlaW50ZXJwcmV0X2Nhc3Q8dWlu dHB0cl90PigmY29ubmVjdGlvbikpOwogICAgIGZvciAoYXV0byYgaGFuZGxlciA6IG1hcC52YWx1 ZXMoKSkgewogICAgICAgICBpZiAoaGFuZGxlcikKQEAgLTExNTAsNiArMTE1NCw3IEBAIHZvaWQg Y2xlYXJBc3luY1JlcGx5SGFuZGxlcnMoY29uc3QgQ29ubmVjdGlvbiYgY29ubmVjdGlvbikKIAog Q29tcGxldGlvbkhhbmRsZXI8dm9pZChEZWNvZGVyKik+IHRha2VBc3luY1JlcGx5SGFuZGxlcihD b25uZWN0aW9uJiBjb25uZWN0aW9uLCB1aW50NjRfdCBpZGVudGlmaWVyKQogeworICAgIEFTU0VS VChSdW5Mb29wOjppc01haW4oKSk7CiAgICAgYXV0byBpdGVyYXRvciA9IGFzeW5jUmVwbHlIYW5k bGVyTWFwKCkuZmluZChyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4oJmNvbm5lY3Rpb24pKTsK ICAgICBpZiAoaXRlcmF0b3IgIT0gYXN5bmNSZXBseUhhbmRsZXJNYXAoKS5lbmQoKSkgewogICAg ICAgICBpZiAoIWl0ZXJhdG9yLT52YWx1ZS5pc1ZhbGlkS2V5KGlkZW50aWZpZXIpKSB7Cg== 373255 2019-07-01 13:48:40 -0700 2019-07-01 14:11:36 -0700 Patch bug-199324-20190701134839.patch text/plain 3314 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRjYjNlMTA5MTAxYWU3Yzgy NDcxYTAzNTZkYjA4MzdiY2M4MjVmMTMuLjA5ZTdkNjY4OGUzNDhlODhiOTEwOGU2YjJlNTM3M2Vm YzBiOWYxOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMDctMDEgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgbWFpbiB0 aHJlYWQgYXNzZXJ0aW9ucyBpbiBzZW5kV2l0aEFzeW5jUmVwbHkgY29kZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MzI0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgU2FtIFdlaW5pZy4KKworICAgICAgICBzZW5kV2l0aEFzeW5jUmVwbHkgY2FuIG9u bHkgYmUgdXNlZCBvbiB0aGUgbWFpbiB0aHJlYWQgYmVjYXVzZQorICAgICAgICB0aGUgQ29tcGxl dGlvbkhhbmRsZXIgd2lsbCBiZSBjYWxsZWQgb24gdGhlIG1haW4gdGhyZWFkLCBhbmQgaWYgaXQn cworICAgICAgICBjYWxsZWQgZnJvbSBhIGJhY2tncm91bmQgdGhyZWFkLCB0aGVuIEhhc2hNYXAg Y29ycnVwdGlvbiB3aWxsIGxpa2VseSBoYXBwZW4uCisgICAgICAgIEFkZCBhc3NlcnRpb25zIHRv IGFsZXJ0IGRldmVsb3BlcnMgdGhhdCB0aGV5IHNob3VsZCBvbmx5IGNhbGwgc2VuZFdpdGhBc3lu Y1JlcGx5CisgICAgICAgIGZyb20gdGhlIG1haW4gdGhyZWFkLgorCisgICAgICAgIFRoaXMgaXMg cmVzcG9uZGluZyB0byBnb29kIGZlZWRiYWNrIGZyb20gcjIzNzI5NAorCisgICAgICAgICogUGxh dGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwOgorICAgICAgICAoSVBDOjphc3luY1JlcGx5SGFuZGxl ck1hcCk6CisgICAgICAgIChJUEM6Om5leHRBc3luY1JlcGx5SGFuZGxlcklEKToKKyAgICAgICAg KElQQzo6YWRkQXN5bmNSZXBseUhhbmRsZXIpOgorICAgICAgICAoSVBDOjpjbGVhckFzeW5jUmVw bHlIYW5kbGVycyk6CisgICAgICAgIChJUEM6OkNvbXBsZXRpb25IYW5kbGVyPHZvaWQpOgorCiAy MDE5LTA2LTI3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBXZWJTb2NrZXRzOiBhdm9pZCBkYXRhIGNvcGllcyB3aGVuIHF1ZXVpbmcgdGFza3Mg aW4gV2ViU29ja2V0Q2hhbm5lbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9J UEMvQ29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9Db25uZWN0aW9u LmNwcAppbmRleCAzNjFmODYxOWQyM2M4NDgwNzViYzEwNzRmZDY3ZjRhZTA4Y2I5OWI1Li45MjFh NjIyMjhiZDgwZGRmNTdmMGQ3OTc2ODQyMjU5ZjAxM2M3ZWE2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1BsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1Bs YXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcApAQCAtMjM5LDYgKzIzOSw3IEBAIHN0YXRpYyBIYXNo TWFwPElQQzo6Q29ubmVjdGlvbjo6VW5pcXVlSUQsIENvbm5lY3Rpb24qPiYgYWxsQ29ubmVjdGlv bnMoKQogCiBzdGF0aWMgSGFzaE1hcDx1aW50cHRyX3QsIEhhc2hNYXA8dWludDY0X3QsIENvbXBs ZXRpb25IYW5kbGVyPHZvaWQoRGVjb2RlciopPj4+JiBhc3luY1JlcGx5SGFuZGxlck1hcCgpCiB7 CisgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKICAgICBzdGF0aWMgTmV2ZXJEZXN0cm95 ZWQ8SGFzaE1hcDx1aW50cHRyX3QsIEhhc2hNYXA8dWludDY0X3QsIENvbXBsZXRpb25IYW5kbGVy PHZvaWQoRGVjb2RlciopPj4+PiBtYXA7CiAgICAgcmV0dXJuIG1hcC5nZXQoKTsKIH0KQEAgLTEx MjcsMTIgKzExMjgsMTQgQEAgdm9pZCBDb25uZWN0aW9uOjpkaXNwYXRjaEluY29taW5nTWVzc2Fn ZXMoKQogCiB1aW50NjRfdCBuZXh0QXN5bmNSZXBseUhhbmRsZXJJRCgpCiB7CisgICAgQVNTRVJU KFJ1bkxvb3A6OmlzTWFpbigpKTsKICAgICBzdGF0aWMgdWludDY0X3QgaWRlbnRpZmllciB7IDAg fTsKICAgICByZXR1cm4gKytpZGVudGlmaWVyOwogfQogCiB2b2lkIGFkZEFzeW5jUmVwbHlIYW5k bGVyKENvbm5lY3Rpb24mIGNvbm5lY3Rpb24sIHVpbnQ2NF90IGlkZW50aWZpZXIsIENvbXBsZXRp b25IYW5kbGVyPHZvaWQoRGVjb2RlciopPiYmIGNvbXBsZXRpb25IYW5kbGVyKQogeworICAgIEFT U0VSVChSdW5Mb29wOjppc01haW4oKSk7CiAgICAgYXV0byByZXN1bHQgPSBhc3luY1JlcGx5SGFu ZGxlck1hcCgpLmVuc3VyZShyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4oJmNvbm5lY3Rpb24p LCBbXSB7CiAgICAgICAgIHJldHVybiBIYXNoTWFwPHVpbnQ2NF90LCBDb21wbGV0aW9uSGFuZGxl cjx2b2lkKERlY29kZXIqKT4+KCk7CiAgICAgfSkuaXRlcmF0b3ItPnZhbHVlLmFkZChpZGVudGlm aWVyLCBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CkBAIC0xMTQxLDYgKzExNDQsNyBAQCB2 b2lkIGFkZEFzeW5jUmVwbHlIYW5kbGVyKENvbm5lY3Rpb24mIGNvbm5lY3Rpb24sIHVpbnQ2NF90 IGlkZW50aWZpZXIsIENvbXBsZXRpbwogCiB2b2lkIGNsZWFyQXN5bmNSZXBseUhhbmRsZXJzKGNv bnN0IENvbm5lY3Rpb24mIGNvbm5lY3Rpb24pCiB7CisgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFp bigpKTsKICAgICBhdXRvIG1hcCA9IGFzeW5jUmVwbHlIYW5kbGVyTWFwKCkudGFrZShyZWludGVy cHJldF9jYXN0PHVpbnRwdHJfdD4oJmNvbm5lY3Rpb24pKTsKICAgICBmb3IgKGF1dG8mIGhhbmRs ZXIgOiBtYXAudmFsdWVzKCkpIHsKICAgICAgICAgaWYgKGhhbmRsZXIpCkBAIC0xMTUwLDYgKzEx NTQsNyBAQCB2b2lkIGNsZWFyQXN5bmNSZXBseUhhbmRsZXJzKGNvbnN0IENvbm5lY3Rpb24mIGNv bm5lY3Rpb24pCiAKIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoRGVjb2RlciopPiB0YWtlQXN5bmNS ZXBseUhhbmRsZXIoQ29ubmVjdGlvbiYgY29ubmVjdGlvbiwgdWludDY0X3QgaWRlbnRpZmllcikK IHsKKyAgICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOwogICAgIGF1dG8gaXRlcmF0b3IgPSBh c3luY1JlcGx5SGFuZGxlck1hcCgpLmZpbmQocmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KCZj b25uZWN0aW9uKSk7CiAgICAgaWYgKGl0ZXJhdG9yICE9IGFzeW5jUmVwbHlIYW5kbGVyTWFwKCku ZW5kKCkpIHsKICAgICAgICAgaWYgKCFpdGVyYXRvci0+dmFsdWUuaXNWYWxpZEtleShpZGVudGlm aWVyKSkgewo=