199321 2019-06-28 09:46:09 -0700 REGRESSION (r239984): pages with custom scrollbars also show normal scrollbars 2019-06-28 13:23:19 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue koivisto simon.fraser thorton timothy webkit-bug-importer oldest_to_newest 1548842 0 simon.fraser 2019-06-28 09:46:09 -0700 and we paint the scrollbars on the main thread, causing flickering. 1548843 1 simon.fraser 2019-06-28 09:46:21 -0700 <rdar://problem/52308095> 1548847 2 simon.fraser 2019-06-28 10:05:53 -0700 theme().registerScrollbar(*this), called from Scrollbar's constructor, is trying to call virtual functions which RenderScrollbar overrides. 1548878 3 373131 simon.fraser 2019-06-28 10:48:50 -0700 Created attachment 373131 Patch 1548925 4 373131 commit-queue 2019-06-28 13:23:18 -0700 Comment on attachment 373131 Patch Clearing flags on attachment: 373131 Committed r246934: <https://trac.webkit.org/changeset/246934> 1548926 5 commit-queue 2019-06-28 13:23:19 -0700 All reviewed patches have been landed. Closing bug. 373131 2019-06-28 10:48:50 -0700 2019-06-28 13:23:18 -0700 Patch bug-199321-20190628104849.patch text/plain 4914 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2OTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWRhNzNhNzE0YTdjMjUy N2IzNTgwMmE0YzAyYzQ3YTViZGNjYjRkNS4uNzFlZTI4MzY5YmFmZDUxMGYxZjY2N2I5NmVjMDgx NTJlN2ViNTlkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTA2LTI4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyMzk5ODQpOiBwYWdlcyB3aXRoIGN1c3RvbSBzY3JvbGxiYXJzIGFsc28gc2hvdyBub3JtYWwg c2Nyb2xsYmFycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk5MzIxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MjMwODA5NT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXZlcnQgdGhlIHBhcnQgb2Yg cjIzOTk4NCB0aGF0IG1hZGUgaXNDdXN0b21TY3JvbGxiYXIoKSB2aXJ0dWFsLCBzaW5jZSB0aGVt ZSgpLnJlZ2lzdGVyU2Nyb2xsYmFyKCkKKyAgICAgICAgY2FsbHMgaXQgZnJvbSB0aGUgYmFzZSBj bGFzcyBjb25zdHJ1Y3Rvci4KKworICAgICAgICBJIHdhc24ndCBhYmxlIHRvIG1ha2UgYSB0ZXN0 IHRoYXQgdGVzdHMgcmVuZGVyaW5nIG9mIG92ZXJsYXkgc2Nyb2xsYmFycyAod2Via2l0Lm9yZy9i LzE5OTMyMykuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxiYXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U2Nyb2xsYmFyOjpTY3JvbGxiYXIpOgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9s bGJhci5oOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyOjppc0N1c3RvbVNjcm9sbGJhciBj b25zdCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclNjcm9sbGJhci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJTY3JvbGxiYXI6OlJlbmRlclNjcm9sbGJhcik6CisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlclNjcm9sbGJhci5oOgorCiAyMDE5LTA2LTI3ICBGdWppaSBIaXJvbm9y aSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb11bTWVkaWFG b3VuZGF0aW9uXSBTdG9wIHVzaW5nIHNvZnQgbGlua2luZyBmb3IgTWVkaWEgRm91bmRhdGlvbgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYmFyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGJhci5jcHAKaW5kZXggMzk2OTE1NTBkOWZhMmU3Mzk1 YzU1MzA5YjNlMjRlNzczMmVkZmI3Yi4uMTI5M2UyZDc5MzEzZjg2YjllODZjOGJjMGIyNTc3OTZk ZmQ1ZDYyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYmFyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxiYXIuY3BwCkBAIC01NCwxMSAr NTQsMTIgQEAgaW50IFNjcm9sbGJhcjo6bWF4T3ZlcmxhcEJldHdlZW5QYWdlcygpCiAgICAgcmV0 dXJuIG1heE92ZXJsYXBCZXR3ZWVuUGFnZXM7CiB9CiAKLVNjcm9sbGJhcjo6U2Nyb2xsYmFyKFNj cm9sbGFibGVBcmVhJiBzY3JvbGxhYmxlQXJlYSwgU2Nyb2xsYmFyT3JpZW50YXRpb24gb3JpZW50 YXRpb24sIFNjcm9sbGJhckNvbnRyb2xTaXplIGNvbnRyb2xTaXplLCBTY3JvbGxiYXJUaGVtZSog Y3VzdG9tVGhlbWUpCitTY3JvbGxiYXI6OlNjcm9sbGJhcihTY3JvbGxhYmxlQXJlYSYgc2Nyb2xs YWJsZUFyZWEsIFNjcm9sbGJhck9yaWVudGF0aW9uIG9yaWVudGF0aW9uLCBTY3JvbGxiYXJDb250 cm9sU2l6ZSBjb250cm9sU2l6ZSwgU2Nyb2xsYmFyVGhlbWUqIGN1c3RvbVRoZW1lLCBib29sIGlz Q3VzdG9tU2Nyb2xsYmFyKQogICAgIDogbV9zY3JvbGxhYmxlQXJlYShzY3JvbGxhYmxlQXJlYSkK ICAgICAsIG1fb3JpZW50YXRpb24ob3JpZW50YXRpb24pCiAgICAgLCBtX2NvbnRyb2xTaXplKGNv bnRyb2xTaXplKQogICAgICwgbV90aGVtZShjdXN0b21UaGVtZSA/ICpjdXN0b21UaGVtZSA6IFNj cm9sbGJhclRoZW1lOjp0aGVtZSgpKQorICAgICwgbV9pc0N1c3RvbVNjcm9sbGJhcihpc0N1c3Rv bVNjcm9sbGJhcikKICAgICAsIG1fc2Nyb2xsVGltZXIoKnRoaXMsICZTY3JvbGxiYXI6OmF1dG9z Y3JvbGxUaW1lckZpcmVkKQogewogICAgIHRoZW1lKCkucmVnaXN0ZXJTY3JvbGxiYXIoKnRoaXMp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYmFyLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxiYXIuaAppbmRleCBjMmJjNmMyMTg0MGEwMGI2YTA3 YjUxODEzMGQ3MzdiZjEwNmMwY2U2Li5lMmEyNWI3ZWRmYzFiZGZjOWE5OTg2ODFiMjhmY2ZlNzhi NDc1ZjhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxiYXIuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxiYXIuaApAQCAtNTYsNyArNTYsNyBA QCBwdWJsaWM6CiAKICAgICBTY3JvbGxhYmxlQXJlYSYgc2Nyb2xsYWJsZUFyZWEoKSBjb25zdCB7 IHJldHVybiBtX3Njcm9sbGFibGVBcmVhOyB9CiAKLSAgICB2aXJ0dWFsIGJvb2wgaXNDdXN0b21T Y3JvbGxiYXIoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorICAgIGJvb2wgaXNDdXN0b21TY3Jv bGxiYXIoKSBjb25zdCB7IHJldHVybiBtX2lzQ3VzdG9tU2Nyb2xsYmFyOyB9CiAgICAgU2Nyb2xs YmFyT3JpZW50YXRpb24gb3JpZW50YXRpb24oKSBjb25zdCB7IHJldHVybiBtX29yaWVudGF0aW9u OyB9CiAKICAgICBpbnQgdmFsdWUoKSBjb25zdCB7IHJldHVybiBscm91bmRmKG1fY3VycmVudFBv cyk7IH0KQEAgLTEzMiw3ICsxMzIsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBzdXBwb3J0c1VwZGF0 ZU9uU2Vjb25kYXJ5VGhyZWFkKCkgY29uc3Q7CiAKIHByb3RlY3RlZDoKLSAgICBTY3JvbGxiYXIo U2Nyb2xsYWJsZUFyZWEmLCBTY3JvbGxiYXJPcmllbnRhdGlvbiwgU2Nyb2xsYmFyQ29udHJvbFNp emUsIFNjcm9sbGJhclRoZW1lKiA9IG51bGxwdHIpOworICAgIFNjcm9sbGJhcihTY3JvbGxhYmxl QXJlYSYsIFNjcm9sbGJhck9yaWVudGF0aW9uLCBTY3JvbGxiYXJDb250cm9sU2l6ZSwgU2Nyb2xs YmFyVGhlbWUqID0gbnVsbHB0ciwgYm9vbCBpc0N1c3RvbVNjcm9sbGJhciA9IGZhbHNlKTsKIAog ICAgIHZvaWQgdXBkYXRlVGh1bWIoKTsKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlVGh1bWJQb3Np dGlvbigpOwpAQCAtMTY1LDYgKzE2NSw3IEBAIHByb3RlY3RlZDoKICAgICBpbnQgbV9kb2N1bWVu dERyYWdQb3MgeyAwIH07CiAKICAgICBib29sIG1fZW5hYmxlZCB7IHRydWUgfTsKKyAgICBib29s IG1faXNDdXN0b21TY3JvbGxiYXIgeyBmYWxzZSB9OwogCiAgICAgVGltZXIgbV9zY3JvbGxUaW1l cjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNjcm9sbGJh ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2Nyb2xsYmFyLmNwcAppbmRl eCAzMDhkMjM3NmNmN2VhOTJiYWYwNjg5MGI0YjgzZDQ2N2Y0OGQ2YTY4Li40MjJiYTkyMWEyMDcw OTYyMjUyMzQzZTJhZTE0MDNjNDY1NTVkZDBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyU2Nyb2xsYmFyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyU2Nyb2xsYmFyLmNwcApAQCAtNDIsNyArNDIsNyBAQCBSZWY8U2Nyb2xsYmFyPiBS ZW5kZXJTY3JvbGxiYXI6OmNyZWF0ZUN1c3RvbVNjcm9sbGJhcihTY3JvbGxhYmxlQXJlYSYgc2Ny b2xsYWJsZQogfQogCiBSZW5kZXJTY3JvbGxiYXI6OlJlbmRlclNjcm9sbGJhcihTY3JvbGxhYmxl QXJlYSYgc2Nyb2xsYWJsZUFyZWEsIFNjcm9sbGJhck9yaWVudGF0aW9uIG9yaWVudGF0aW9uLCBF bGVtZW50KiBvd25lckVsZW1lbnQsIEZyYW1lKiBvd25pbmdGcmFtZSkKLSAgICA6IFNjcm9sbGJh cihzY3JvbGxhYmxlQXJlYSwgb3JpZW50YXRpb24sIFJlZ3VsYXJTY3JvbGxiYXIsIFJlbmRlclNj cm9sbGJhclRoZW1lOjpyZW5kZXJTY3JvbGxiYXJUaGVtZSgpKQorICAgIDogU2Nyb2xsYmFyKHNj cm9sbGFibGVBcmVhLCBvcmllbnRhdGlvbiwgUmVndWxhclNjcm9sbGJhciwgUmVuZGVyU2Nyb2xs YmFyVGhlbWU6OnJlbmRlclNjcm9sbGJhclRoZW1lKCksIHRydWUpCiAgICAgLCBtX293bmVyRWxl bWVudChvd25lckVsZW1lbnQpCiAgICAgLCBtX293bmluZ0ZyYW1lKG93bmluZ0ZyYW1lKQogewpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNjcm9sbGJhci5oIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNjcm9sbGJhci5oCmluZGV4IGU1ODU2MDVl YmVmODRjODYxMTAzN2Y3MjZlYThkN2YwY2FhZGU4ZTQuLmY4Y2M5YmViY2I5N2RjM2M0YTNmZDE3 ZmZmN2IwMDYwNmZkZjFiMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJTY3JvbGxiYXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2Ny b2xsYmFyLmgKQEAgLTYxLDcgKzYxLDYgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBSZW5kZXJT Y3JvbGxiYXIoU2Nyb2xsYWJsZUFyZWEmLCBTY3JvbGxiYXJPcmllbnRhdGlvbiwgRWxlbWVudCos IEZyYW1lKik7CiAKLSAgICBib29sIGlzQ3VzdG9tU2Nyb2xsYmFyKCkgY29uc3Qgb3ZlcnJpZGUg eyByZXR1cm4gdHJ1ZTsgfQogICAgIGJvb2wgaXNPdmVybGF5U2Nyb2xsYmFyKCkgY29uc3Qgb3Zl cnJpZGUgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgIHZvaWQgc2V0UGFyZW50KFNjcm9sbFZpZXcq KSBvdmVycmlkZTsK