<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>199312</bug_id>
          
          <creation_ts>2019-06-27 23:05:43 -0700</creation_ts>
          <short_desc>[Win] unresolved external symbol &quot;JSC::JSObject::didBecomePrototype(void)&quot; referenced in function &quot;JSC::Structure::create(...)&quot;</short_desc>
          <delta_ts>2019-06-30 19:45:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=196315</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>1998zhangyi</cc>
    
    <cc>alecflett</cc>
    
    <cc>beidson</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>jsbell</cc>
    
    <cc>keith_miller</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1548730</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-06-27 23:05:43 -0700</bug_when>
    <thetext>[Win] unresolved external symbol &quot;JSC::JSObject::didBecomePrototype(void)&quot; referenced in function &quot;JSC::Structure::create(...)&quot;

trunk@246920, WinCairo port, clang-cl Release builds reports following linkage errors:

&gt; WebCore.lib(UnifiedSource-4babe430-10.cpp.obj) : error LNK2019: unresolved external symbol &quot;public: void __cdecl JSC::JSObject::didBecomePrototype(void)&quot; (?didBecomePrototype@JSObject@JSC@@QEAAXXZ) referenced in function &quot;public: static class JSC::Structure * __cdecl JSC::Structure::create(class JSC::VM &amp;,class JSC::JSGlobalObject *,class JSC::JSValue,class JSC::TypeInfo const &amp;,struct JSC::ClassInfo const *,unsigned char,unsigned int)&quot; (?create@Structure@JSC@@SAPEAV12@AEAVVM@2@PEAVJSGlobalObject@2@VJSValue@2@AEBVTypeInfo@2@PEBUClassInfo@2@EI@Z)
&gt; bin64\WebKit2.dll : fatal error LNK1120: 1 unresolved externals
&gt; [82/155] Linking CXX shared library bin64\TestWebCoreLib.dll
&gt; FAILED: bin64/TestWebCoreLib.dll lib64/TestWebCoreLib.lib 

&gt; WebCore.lib(UnifiedSource-4babe430-10.cpp.obj) : error LNK2019: unresolved external symbol &quot;public: void __cdecl JSC::JSObject::didBecomePrototype(void)&quot; (?didBecomePrototype@JSObject@JSC@@QEAAXXZ) referenced in function &quot;public: static class JSC::Structure * __cdecl JSC::Structure::create(class JSC::VM &amp;,class JSC::JSGlobalObject *,class JSC::JSValue,class JSC::TypeInfo const &amp;,struct JSC::ClassInfo const *,unsigned char,unsigned int)&quot; (?create@Structure@JSC@@SAPEAV12@AEAVVM@2@PEAVJSGlobalObject@2@VJSValue@2@AEBVTypeInfo@2@PEBUClassInfo@2@EI@Z)
&gt; bin64\WebKit.dll : fatal error LNK1120: 1 unresolved externals</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548732</commentid>
    <comment_count>1</comment_count>
      <attachid>373089</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-06-27 23:09:34 -0700</bug_when>
    <thetext>Created attachment 373089
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548745</commentid>
    <comment_count>2</comment_count>
      <attachid>373089</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-06-28 00:27:35 -0700</bug_when>
    <thetext>Comment on attachment 373089
Patch

r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548751</commentid>
    <comment_count>3</comment_count>
      <attachid>373089</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-06-28 00:38:36 -0700</bug_when>
    <thetext>Comment on attachment 373089
Patch

Clearing flags on attachment: 373089

Committed r246922: &lt;https://trac.webkit.org/changeset/246922&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548752</commentid>
    <comment_count>4</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-06-28 00:38:39 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548753</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-06-28 00:39:23 -0700</bug_when>
    <thetext>&lt;rdar://problem/52315398&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1549123</commentid>
    <comment_count>6</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-06-30 19:45:17 -0700</bug_when>
    <thetext>*** Bug 199315 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>373089</attachid>
            <date>2019-06-27 23:09:34 -0700</date>
            <delta_ts>2019-06-28 00:38:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199312-20190628150933.patch</filename>
            <type>text/plain</type>
            <size>2461</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2OTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGY2YTQ4ZjZlNWFkN2Yx
MjI5YzVjY2U5OTI4NzM5ZGE2NGJkYTRiZi4uODhkZGUxOTU5NmE3MDhhZGZiYzRkNmUxYmEzZDk1
MWI5YmVkMDFhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA2LTI3ICBGdWpp
aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIHVu
cmVzb2x2ZWQgZXh0ZXJuYWwgc3ltYm9sICJKU0M6OkpTT2JqZWN0OjpkaWRCZWNvbWVQcm90b3R5
cGUodm9pZCkiIHJlZmVyZW5jZWQgaW4gZnVuY3Rpb24gIkpTQzo6U3RydWN0dXJlOjpjcmVhdGUo
Li4uKSIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5
OTMxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdp
bkNhaXJvIHBvcnQsIGNsYW5nLWNsIFJlbGVhc2UgYnVpbGRzIHJlcG9ydGVkIGEgZm9sbG93aW5n
IGxpbmthZ2UgZXJyb3I6CisKKyAgICAgICAgPiBXZWJDb3JlLmxpYihVbmlmaWVkU291cmNlLTRi
YWJlNDMwLTEwLmNwcC5vYmopIDogZXJyb3IgTE5LMjAxOTogdW5yZXNvbHZlZCBleHRlcm5hbCBz
eW1ib2wgInB1YmxpYzogdm9pZCBfX2NkZWNsIEpTQzo6SlNPYmplY3Q6OmRpZEJlY29tZVByb3Rv
dHlwZSh2b2lkKSIgKD9kaWRCZWNvbWVQcm90b3R5cGVASlNPYmplY3RASlNDQEBRRUFBWFhaKSBy
ZWZlcmVuY2VkIGluIGZ1bmN0aW9uICJwdWJsaWM6IHN0YXRpYyBjbGFzcyBKU0M6OlN0cnVjdHVy
ZSAqIF9fY2RlY2wgSlNDOjpTdHJ1Y3R1cmU6OmNyZWF0ZShjbGFzcyBKU0M6OlZNICYsY2xhc3Mg
SlNDOjpKU0dsb2JhbE9iamVjdCAqLGNsYXNzIEpTQzo6SlNWYWx1ZSxjbGFzcyBKU0M6OlR5cGVJ
bmZvIGNvbnN0ICYsc3RydWN0IEpTQzo6Q2xhc3NJbmZvIGNvbnN0ICosdW5zaWduZWQgY2hhcix1
bnNpZ25lZCBpbnQpIiAoP2NyZWF0ZUBTdHJ1Y3R1cmVASlNDQEBTQVBFQVYxMkBBRUFWVk1AMkBQ
RUFWSlNHbG9iYWxPYmplY3RAMkBWSlNWYWx1ZUAyQEFFQlZUeXBlSW5mb0AyQFBFQlVDbGFzc0lu
Zm9AMkBFSUBaKQorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGJl
aGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxp
dGVJREJCYWNraW5nU3RvcmUuY3BwOiBJbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU0NJbmxpbmVz
Lmg+LAorICAgICAgICBhbmQgZG8gbm90IGluY2x1ZGUgaGVhZGVycyB3aGljaCBpcyBpbmNsdWRl
ZCBieSBpdC4KKwogMjAxOS0wNi0yNyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog
CiAgICAgICAgIFJFR1JFU1NJT04ocjI0NDYzMyk6IGUtbWFpbCB3aXRoICJoZWlnaHQ6IDEwMCUi
IGNhdXNlcyB1bnN0YWJsZSBsYXlvdXQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1
bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNraW5nU3RvcmUuY3Bw
CmluZGV4IGQxYjA0N2NlZjY1YWMzZDlmOTJkYmYzZmRiYzFjNjQ1MDgyMjIwY2EuLjA4OTlhOWFi
N2U5NmM4NTc5NTViMjZhN2IwYWIwYmM4MDJjMjk1OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNraW5nU3RvcmUuY3BwCisr
KyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNr
aW5nU3RvcmUuY3BwCkBAIC00OSwxMSArNDksOCBAQAogI2luY2x1ZGUgIlNRTGl0ZVRyYW5zYWN0
aW9uLmgiCiAjaW5jbHVkZSAiVGhyZWFkU2FmZURhdGFCdWZmZXIuaCIKICNpbmNsdWRlIDxKYXZh
U2NyaXB0Q29yZS9BdXhpbGlhcnlCYXJyaWVySW5saW5lcy5oPgotI2luY2x1ZGUgPEphdmFTY3Jp
cHRDb3JlL0hlYXBJbmxpbmVzLmg+Ci0jaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvSlNDSlNWYWx1
ZUlubGluZXMuaD4KLSNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU0dsb2JhbE9iamVjdC5oPgor
I2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTQ0lubGluZXMuaD4KICNpbmNsdWRlIDxKYXZhU2Ny
aXB0Q29yZS9TdHJvbmdJbmxpbmVzLmg+Ci0jaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvU3RydWN0
dXJlSW5saW5lcy5oPgogI2luY2x1ZGUgPHd0Zi9GaWxlU3lzdGVtLmg+CiAjaW5jbHVkZSA8d3Rm
L05ldmVyRGVzdHJveWVkLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nQ29uY2F0ZW5hdGVO
dW1iZXJzLmg+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>