199297 2019-06-27 16:02:36 -0700 Fix crash in ScrollingStateNode::insertChild() 2019-06-27 18:09:53 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cmarcelo commit-queue ews-watchlist fred.wang jamesr koivisto luiz simon.fraser thorton tonikitoo webkit-bug-importer zalan oldest_to_newest 1548649 0 simon.fraser 2019-06-27 16:02:36 -0700 Fix crash in ScrollingStateNode::insertChild() 1548659 1 373066 simon.fraser 2019-06-27 16:14:25 -0700 Created attachment 373066 Patch 1548660 2 simon.fraser 2019-06-27 16:14:28 -0700 <rdar://problem/49415136> 1548689 3 373066 commit-queue 2019-06-27 18:09:52 -0700 Comment on attachment 373066 Patch Clearing flags on attachment: 373066 Committed r246913: <https://trac.webkit.org/changeset/246913> 1548690 4 commit-queue 2019-06-27 18:09:53 -0700 All reviewed patches have been landed. Closing bug. 373066 2019-06-27 16:14:25 -0700 2019-06-27 18:09:52 -0700 Patch bug-199297-20190627161424.patch text/plain 6915 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk2ODI0ZjRhZGE4OGNm YzljOTVhZmY1YjRlZTczOTc5ZmIxNDgxZS4uMTBmOWNjNjYyMjczOTJmN2Y0NzdhYjlmYTY5YjQy MjFlMDNmMGY4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE5LTA2LTI3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBjcmFzaCBp biBTY3JvbGxpbmdTdGF0ZU5vZGU6Omluc2VydENoaWxkKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTI5NworICAgICAgICByZGFyOi8vcHJvYmxl bS80OTQxNTEzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENyYXNoIGRhdGEgc3VnZ2VzdCB0aGF0ICdwYXJlbnQnIGNhbiBiZSBkZWxldGVkIGluIFNj cm9sbGluZ1N0YXRlVHJlZTo6aW5zZXJ0Tm9kZSgpLiBUbyBhdm9pZCB0aGlzLAorICAgICAgICBo YXZlIFNjcm9sbGluZ1N0YXRlVHJlZTo6bV9zdGF0ZU5vZGVNYXAgc3RvcmUgUmVmUHRzLCBhbmQg ZG8gdGhlIHNhbWUgZm9yIFNjcm9sbGluZ1RyZWU6Om1fbm9kZU1hcC4KKworICAgICAgICAqIHBh Z2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT Y3JvbGxpbmdTdGF0ZU5vZGU6OlNjcm9sbGluZ1N0YXRlTm9kZSk6IFRoZSByZWxheEFkb3B0aW9u UmVxdWlyZW1lbnQoKSBpcyByZXF1aXJlZAorICAgICAgICB0byBhdm9pZCBBU1NFUlQoIW1fYWRv cHRpb25Jc1JlcXVpcmVkKSB3aGVuIHRoZSBub2RlIGlzIGFkZGVkIHRvIHRoZSB0cmVlIGluIGl0 cyBjb25zdHJ1Y3Rvci4KKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZVRy ZWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nU3RhdGVUcmVlOjp1bnBhcmVudE5v ZGUpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nU3RhdGVUcmVlOjp1bnBhcmVudENoaWxk cmVuQW5kRGVzdHJveU5vZGUpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nU3RhdGVUcmVl OjpkZXRhY2hBbmREZXN0cm95U3VidHJlZSk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdT dGF0ZVRyZWU6OnN0YXRlTm9kZUZvcklEIGNvbnN0KToKKyAgICAgICAgKiBwYWdlL3Njcm9sbGlu Zy9TY3JvbGxpbmdTdGF0ZVRyZWUuaDoKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9TY3JvbGxp bmdUcmVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ1RyZWU6OnVwZGF0ZVRyZWVG cm9tU3RhdGVOb2RlKToKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlLmg6 CisKIDIwMTktMDYtMjcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTiAocjI0Njg2OSk6IEFTU0VSVElPTiBGQUlMRUQ6ICFyZW5kZXJl cigpLmhhc1JlcGFpbnRMYXlvdXRSZWN0cygpIHx8IHJlbmRlcmVyKCkucmVwYWludExheW91dFJl Y3RzKCkubV9yZXBhaW50UmVjdCA9PSByZW5kZXJlcigpLmNsaXBwZWRPdmVyZmxvd1JlY3RGb3JS ZXBhaW50KHJlbmRlcmVyKCkuY29udGFpbmVyRm9yUmVwYWludCgpKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVOb2RlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlTm9kZS5jcHAKaW5kZXggODgy ZDczM2YwNmQ1MWNiZTkxNjU0ZDM3ZGE3NjhjNzc3ZmNlNWQ3MS4uMmU2ZDRkM2Y4MmI5ZjI0N2Uz NDUzMzg0NTAxYThhYmU2NWI5MWMwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9z Y3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuY3BwCkBAIC01Myw2ICs1Myw4IEBAIFNjcm9s bGluZ1N0YXRlTm9kZTo6U2Nyb2xsaW5nU3RhdGVOb2RlKGNvbnN0IFNjcm9sbGluZ1N0YXRlTm9k ZSYgc3RhdGVOb2RlLCBTY3JvCiB7CiAgICAgaWYgKGhhc0NoYW5nZWRQcm9wZXJ0eShMYXllcikp CiAgICAgICAgIHNldExheWVyKHN0YXRlTm9kZS5sYXllcigpLnRvUmVwcmVzZW50YXRpb24oYWRv cHRpdmVUcmVlLnByZWZlcnJlZExheWVyUmVwcmVzZW50YXRpb24oKSkpOworCisgICAgcmVsYXhB ZG9wdGlvblJlcXVpcmVtZW50KCk7CiAgICAgc2Nyb2xsaW5nU3RhdGVUcmVlKCkuYWRkTm9kZSgq dGhpcyk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Nj cm9sbGluZ1N0YXRlVHJlZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3Jv bGxpbmdTdGF0ZVRyZWUuY3BwCmluZGV4IDhhOTZiY2JhZjFlZjg2OGYxNjk3ZjI0YTY0ZmRmY2Yw OTkzMDljMjAuLmY2MWUyOGUwZWM1MDMwMTJiMzcyZmIyNTU2OWE4Y2I3ZGQ1M2FhNzAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlVHJlZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVUcmVl LmNwcApAQCAtMjA5LDcgKzIwOSw3IEBAIHZvaWQgU2Nyb2xsaW5nU3RhdGVUcmVlOjp1bnBhcmVu dE5vZGUoU2Nyb2xsaW5nTm9kZUlEIG5vZGVJRCkKICAgICBMT0dfV0lUSF9TVFJFQU0oU2Nyb2xs aW5nLCBzdHJlYW0gPDwgIlNjcm9sbGluZ1N0YXRlVHJlZSAiIDw8IHRoaXMgPDwgIiB1bnBhcmVu dE5vZGUgIiA8PCBub2RlSUQpOwogCiAgICAgLy8gVGhlIG5vZGUgbWF5IG5vdCBiZSBmb3VuZCBp ZiBjbGVhcigpIHdhcyByZWNlbnRseSBjYWxsZWQuCi0gICAgUmVmUHRyPFNjcm9sbGluZ1N0YXRl Tm9kZT4gcHJvdGVjdGVkTm9kZSA9IG1fc3RhdGVOb2RlTWFwLmdldChub2RlSUQpOworICAgIGF1 dG8gcHJvdGVjdGVkTm9kZSA9IG1fc3RhdGVOb2RlTWFwLmdldChub2RlSUQpOwogICAgIGlmICgh cHJvdGVjdGVkTm9kZSkKICAgICAgICAgcmV0dXJuOwogCkBAIC0yMjgsNyArMjI4LDcgQEAgdm9p ZCBTY3JvbGxpbmdTdGF0ZVRyZWU6OnVucGFyZW50Q2hpbGRyZW5BbmREZXN0cm95Tm9kZShTY3Jv bGxpbmdOb2RlSUQgbm9kZUlEKQogICAgIExPR19XSVRIX1NUUkVBTShTY3JvbGxpbmcsIHN0cmVh bSA8PCAiU2Nyb2xsaW5nU3RhdGVUcmVlICIgPDwgdGhpcyA8PCAiIHVucGFyZW50Q2hpbGRyZW5B bmREZXN0cm95Tm9kZSAiIDw8IG5vZGVJRCk7CiAKICAgICAvLyBUaGUgbm9kZSBtYXkgbm90IGJl IGZvdW5kIGlmIGNsZWFyKCkgd2FzIHJlY2VudGx5IGNhbGxlZC4KLSAgICBSZWZQdHI8U2Nyb2xs aW5nU3RhdGVOb2RlPiBwcm90ZWN0ZWROb2RlID0gbV9zdGF0ZU5vZGVNYXAudGFrZShub2RlSUQp OworICAgIGF1dG8gcHJvdGVjdGVkTm9kZSA9IG1fc3RhdGVOb2RlTWFwLnRha2Uobm9kZUlEKTsK ICAgICBpZiAoIXByb3RlY3RlZE5vZGUpCiAgICAgICAgIHJldHVybjsKIApAQCAtMjU2LDEzICsy NTYsMTMgQEAgdm9pZCBTY3JvbGxpbmdTdGF0ZVRyZWU6OmRldGFjaEFuZERlc3Ryb3lTdWJ0cmVl KFNjcm9sbGluZ05vZGVJRCBub2RlSUQpCiAgICAgTE9HX1dJVEhfU1RSRUFNKFNjcm9sbGluZywg c3RyZWFtIDw8ICJTY3JvbGxpbmdTdGF0ZVRyZWUgIiA8PCB0aGlzIDw8ICIgZGV0YWNoQW5kRGVz dHJveVN1YnRyZWUgIiA8PCBub2RlSUQpOwogCiAgICAgLy8gVGhlIG5vZGUgbWF5IG5vdCBiZSBm b3VuZCBpZiBjbGVhcigpIHdhcyByZWNlbnRseSBjYWxsZWQuCi0gICAgYXV0byogbm9kZSA9IG1f c3RhdGVOb2RlTWFwLnRha2Uobm9kZUlEKTsKKyAgICBhdXRvIG5vZGUgPSBtX3N0YXRlTm9kZU1h cC50YWtlKG5vZGVJRCk7CiAgICAgaWYgKCFub2RlKQogICAgICAgICByZXR1cm47CiAKICAgICAv LyBJZiB0aGUgbm9kZSB3YXMgdW5wYXJlbnRlZCwgcmVtb3ZlIGl0IGZyb20gbV91bnBhcmVudGVk Tm9kZXMgKGtlZXBpbmcgaXQgYWxpdmUgdW50aWwgdGhpcyBmdW5jdGlvbiByZXR1cm5zKS4KICAg ICBhdXRvIHVucGFyZW50ZWROb2RlID0gbV91bnBhcmVudGVkTm9kZXMudGFrZShub2RlSUQpOwot ICAgIHJlbW92ZU5vZGVBbmRBbGxEZXNjZW5kYW50cyhub2RlKTsKKyAgICByZW1vdmVOb2RlQW5k QWxsRGVzY2VuZGFudHMobm9kZS5nZXQoKSk7CiB9CiAKIHZvaWQgU2Nyb2xsaW5nU3RhdGVUcmVl OjpjbGVhcigpCkBAIC0zNjUsNyArMzY1LDcgQEAgU2Nyb2xsaW5nU3RhdGVOb2RlKiBTY3JvbGxp bmdTdGF0ZVRyZWU6OnN0YXRlTm9kZUZvcklEKFNjcm9sbGluZ05vZGVJRCBzY3JvbGxMYXkKICAg ICAgICAgcmV0dXJuIG51bGxwdHI7CiAKICAgICBBU1NFUlQoaXQtPnZhbHVlLT5zY3JvbGxpbmdO b2RlSUQoKSA9PSBzY3JvbGxMYXllcklEKTsKLSAgICByZXR1cm4gaXQtPnZhbHVlOworICAgIHJl dHVybiBpdC0+dmFsdWUuZ2V0KCk7CiB9CiAKIHZvaWQgU2Nyb2xsaW5nU3RhdGVUcmVlOjpyZWNv bmNpbGVMYXllclBvc2l0aW9uc1JlY3Vyc2l2ZShTY3JvbGxpbmdTdGF0ZU5vZGUmIGN1cnJOb2Rl LCBjb25zdCBMYXlvdXRSZWN0JiBsYXlvdXRWaWV3cG9ydCwgU2Nyb2xsaW5nTGF5ZXJQb3NpdGlv bkFjdGlvbiBhY3Rpb24pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9TY3JvbGxpbmdTdGF0ZVRyZWUuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Nj cm9sbGluZ1N0YXRlVHJlZS5oCmluZGV4IDI0ZDgxODBmMzEyNTA0NzEzNzFhYmVlMmVlMWExYzRl YzU4MjY0ZDEuLjYyNmM5MGZkZDY4Y2Y2MGI0NWQyZjZmNTdlN2FhODMyNWM1NzQ1YjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlVHJlZS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlVHJlZS5o CkBAIC02OSw3ICs2OSw3IEBAIHB1YmxpYzoKIAogICAgIHVuc2lnbmVkIG5vZGVDb3VudCgpIGNv bnN0IHsgcmV0dXJuIG1fc3RhdGVOb2RlTWFwLnNpemUoKTsgfQogCi0gICAgdHlwZWRlZiBIYXNo TWFwPFNjcm9sbGluZ05vZGVJRCwgU2Nyb2xsaW5nU3RhdGVOb2RlKj4gU3RhdGVOb2RlTWFwOwor ICAgIHR5cGVkZWYgSGFzaE1hcDxTY3JvbGxpbmdOb2RlSUQsIFJlZlB0cjxTY3JvbGxpbmdTdGF0 ZU5vZGU+PiBTdGF0ZU5vZGVNYXA7CiAgICAgY29uc3QgU3RhdGVOb2RlTWFwJiBub2RlTWFwKCkg Y29uc3QgeyByZXR1cm4gbV9zdGF0ZU5vZGVNYXA7IH0KIAogICAgIExheWVyUmVwcmVzZW50YXRp b246OlR5cGUgcHJlZmVycmVkTGF5ZXJSZXByZXNlbnRhdGlvbigpIGNvbnN0IHsgcmV0dXJuIG1f cHJlZmVycmVkTGF5ZXJSZXByZXNlbnRhdGlvbjsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlLmNwcAppbmRleCAxMGUzODBkMzA2Njg3NDVmNTZkNzQy YzZhZDRiNjI0NTZlODg3MDA5Li41MTM2NDYyYjkzMzRmNTllM2Q3OTYzYmQwZDEzZjg3ZDk5ZDgx NTM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdU cmVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVl LmNwcApAQCAtMjE4LDcgKzIxOCw3IEBAIHZvaWQgU2Nyb2xsaW5nVHJlZTo6dXBkYXRlVHJlZUZy b21TdGF0ZU5vZGUoY29uc3QgU2Nyb2xsaW5nU3RhdGVOb2RlKiBzdGF0ZU5vZGUsCiAgICAgICAg IGF1dG8gcGFyZW50SXQgPSBtX25vZGVNYXAuZmluZChwYXJlbnROb2RlSUQpOwogICAgICAgICBB U1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihwYXJlbnRJdCAhPSBtX25vZGVNYXAuZW5k KCkpOwogICAgICAgICBpZiAocGFyZW50SXQgIT0gbV9ub2RlTWFwLmVuZCgpKSB7Ci0gICAgICAg ICAgICBhdXRvKiBwYXJlbnQgPSBwYXJlbnRJdC0+dmFsdWU7CisgICAgICAgICAgICBhdXRvKiBw YXJlbnQgPSBwYXJlbnRJdC0+dmFsdWUuZ2V0KCk7CiAKICAgICAgICAgICAgIGF1dG8qIG9sZFBh cmVudCA9IG5vZGUtPnBhcmVudCgpOwogICAgICAgICAgICAgaWYgKG9sZFBhcmVudCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuaCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuaAppbmRleCBiNjViNjYw ZWI4ZDQxZTFkM2Y3MzYyY2Y4OTc5NjJjMmZjZjVkODIzLi4zMDExN2ZiMTRiZDk5M2U4NjU3M2U0 NDhhNDg3YmU1ZGMyYjcyZjlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9s bGluZy9TY3JvbGxpbmdUcmVlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcv U2Nyb2xsaW5nVHJlZS5oCkBAIC0xNzUsNyArMTc1LDcgQEAgcHJpdmF0ZToKIAogICAgIFJlZlB0 cjxTY3JvbGxpbmdUcmVlRnJhbWVTY3JvbGxpbmdOb2RlPiBtX3Jvb3ROb2RlOwogCi0gICAgdXNp bmcgU2Nyb2xsaW5nVHJlZU5vZGVNYXAgPSBIYXNoTWFwPFNjcm9sbGluZ05vZGVJRCwgU2Nyb2xs aW5nVHJlZU5vZGUqPjsKKyAgICB1c2luZyBTY3JvbGxpbmdUcmVlTm9kZU1hcCA9IEhhc2hNYXA8 U2Nyb2xsaW5nTm9kZUlELCBSZWZQdHI8U2Nyb2xsaW5nVHJlZU5vZGU+PjsKICAgICBTY3JvbGxp bmdUcmVlTm9kZU1hcCBtX25vZGVNYXA7CiAKICAgICBSZWxhdGVkTm9kZXNNYXAgbV9vdmVyZmxv d1JlbGF0ZWROb2Rlc01hcDsK