199286 2019-06-27 14:17:20 -0700 Fix build error on WebCore when disabling ENABLE_INDEXED_DATABASE. 2019-06-27 18:53:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke webkit-unassigned bfulgham commit-queue webkit-bug-importer oldest_to_newest 1548615 0 basuke 2019-06-27 14:17:20 -0700 ../Source/WebCore/testing/Internals.cpp:2405:12: error: use of undeclared identifier 'IDBTransaction' return IDBTransaction::numberOfIDBTransactions; 1548616 1 373053 basuke 2019-06-27 14:24:33 -0700 Created attachment 373053 PATCH 1548661 2 373067 basuke 2019-06-27 16:23:46 -0700 Created attachment 373067 ONE MORE TIME 1548664 3 373067 bfulgham 2019-06-27 16:33:35 -0700 Comment on attachment 373067 ONE MORE TIME View in context: https://bugs.webkit.org/attachment.cgi?id=373067&action=review > Source/WebCore/testing/Internals.cpp:2406 > +#if ENABLE(INDEXED_DATABASE) I think that if you have this disabled, you need to also disable it in the header, don't you? 1548672 4 373067 basuke 2019-06-27 17:08:22 -0700 Comment on attachment 373067 ONE MORE TIME View in context: https://bugs.webkit.org/attachment.cgi?id=373067&action=review >> Source/WebCore/testing/Internals.cpp:2406 >> +#if ENABLE(INDEXED_DATABASE) > > I think that if you have this disabled, you need to also disable it in the header, don't you? Ah, right. I should do that. Also in idl. 1548673 5 373070 basuke 2019-06-27 17:25:53 -0700 Created attachment 373070 Patch 1548691 6 basuke 2019-06-27 18:17:53 -0700 It passed! Thanks, Brent. 1548693 7 373070 commit-queue 2019-06-27 18:49:35 -0700 Comment on attachment 373070 Patch Clearing flags on attachment: 373070 Committed r246917: <https://trac.webkit.org/changeset/246917> 1548694 8 commit-queue 2019-06-27 18:49:36 -0700 All reviewed patches have been landed. Closing bug. 1548696 9 webkit-bug-importer 2019-06-27 18:53:48 -0700 <rdar://problem/52300694> 373053 2019-06-27 14:24:33 -0700 2019-06-27 16:23:46 -0700 PATCH bug199286.diff text/plain 1620 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyYWFiMmNlZGM3MS4uOWY4YWYxNDQzZGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxOS0wNi0yNyAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29u eS5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIGVycm9yIG9uIFdlYkNvcmUgd2hlbiBkaXNhYmxp bmcgRU5BQkxFX0lOREVYRURfREFUQUJBU0UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkyODYKKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZp eC4KKworICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmNwcDoKKwogMjAxOS0wNS0yOSAgWmFs YW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gTW92ZSBM aW5lIGNsYXNzIHRvIGEgZGVkaWNhdGVkIGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3Rlc3RpbmcvSW50ZXJuYWxzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxz LmNwcAppbmRleCA1MTBlZjBkMzFiNi4uY2ZiYjU1YWZlNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFscy5jcHAKQEAgLTk4LDcgKzk4LDYgQEAKICNpbmNsdWRlICJIaXN0b3J5SXRlbS5o IgogI2luY2x1ZGUgIkhpdFRlc3RSZXN1bHQuaCIKICNpbmNsdWRlICJJREJSZXF1ZXN0LmgiCi0j aW5jbHVkZSAiSURCVHJhbnNhY3Rpb24uaCIKICNpbmNsdWRlICJJbnNwZWN0b3JDbGllbnQuaCIK ICNpbmNsdWRlICJJbnNwZWN0b3JDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9yRnJv bnRlbmRDbGllbnRMb2NhbC5oIgpAQCAtMjczLDYgKzI3MiwxMCBAQAogI2luY2x1ZGUgIlBvaW50 ZXJMb2NrQ29udHJvbGxlci5oIgogI2VuZGlmCiAKKyNpZiBFTkFCTEUoSU5ERVhFRF9EQVRBQkFT RSkKKyNpbmNsdWRlICJJREJUcmFuc2FjdGlvbi5oIgorI2VuZGlmCisKICNpZiBVU0UoUVVJQ0tf TE9PSykKICNpbmNsdWRlICJNb2NrUHJldmlld0xvYWRlckNsaWVudC5oIgogI2luY2x1ZGUgIlBy ZXZpZXdMb2FkZXIuaCIKQEAgLTI0MDAsMTAgKzI0MDMsMTIgQEAgRXhjZXB0aW9uT3I8dW5zaWdu ZWQ+IEludGVybmFsczo6Y291bnRGaW5kTWF0Y2hlcyhjb25zdCBTdHJpbmcmIHRleHQsIGNvbnN0 IFZlY3QKICAgICByZXR1cm4gZG9jdW1lbnQtPnBhZ2UoKS0+Y291bnRGaW5kTWF0Y2hlcyh0ZXh0 LCBwYXJzZWRPcHRpb25zLnJlbGVhc2VSZXR1cm5WYWx1ZSgpLCAxMDAwKTsKIH0KIAorI2lmIEVO QUJMRShJTkRFWEVEX0RBVEFCQVNFKQogdW5zaWduZWQgSW50ZXJuYWxzOjpudW1iZXJPZklEQlRy YW5zYWN0aW9ucygpIGNvbnN0CiB7CiAgICAgcmV0dXJuIElEQlRyYW5zYWN0aW9uOjpudW1iZXJP ZklEQlRyYW5zYWN0aW9uczsKIH0KKyNlbmRpZgogCiB1bnNpZ25lZCBJbnRlcm5hbHM6Om51bWJl ck9mTGl2ZU5vZGVzKCkgY29uc3QKIHsK 373067 2019-06-27 16:23:46 -0700 2019-06-27 17:25:53 -0700 ONE MORE TIME bug199286.diff text/plain 1620 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyYWFiMmNlZGM3MS4uOWY4YWYxNDQzZGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxOS0wNi0yNyAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29u eS5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIGVycm9yIG9uIFdlYkNvcmUgd2hlbiBkaXNhYmxp bmcgRU5BQkxFX0lOREVYRURfREFUQUJBU0UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkyODYKKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZp eC4KKworICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmNwcDoKKwogMjAxOS0wNS0yOSAgWmFs YW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gTW92ZSBM aW5lIGNsYXNzIHRvIGEgZGVkaWNhdGVkIGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3Rlc3RpbmcvSW50ZXJuYWxzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxz LmNwcAppbmRleCA1MTBlZjBkMzFiNi4uY2ZiYjU1YWZlNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFscy5jcHAKQEAgLTk4LDcgKzk4LDYgQEAKICNpbmNsdWRlICJIaXN0b3J5SXRlbS5o IgogI2luY2x1ZGUgIkhpdFRlc3RSZXN1bHQuaCIKICNpbmNsdWRlICJJREJSZXF1ZXN0LmgiCi0j aW5jbHVkZSAiSURCVHJhbnNhY3Rpb24uaCIKICNpbmNsdWRlICJJbnNwZWN0b3JDbGllbnQuaCIK ICNpbmNsdWRlICJJbnNwZWN0b3JDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9yRnJv bnRlbmRDbGllbnRMb2NhbC5oIgpAQCAtMjczLDYgKzI3MiwxMCBAQAogI2luY2x1ZGUgIlBvaW50 ZXJMb2NrQ29udHJvbGxlci5oIgogI2VuZGlmCiAKKyNpZiBFTkFCTEUoSU5ERVhFRF9EQVRBQkFT RSkKKyNpbmNsdWRlICJJREJUcmFuc2FjdGlvbi5oIgorI2VuZGlmCisKICNpZiBVU0UoUVVJQ0tf TE9PSykKICNpbmNsdWRlICJNb2NrUHJldmlld0xvYWRlckNsaWVudC5oIgogI2luY2x1ZGUgIlBy ZXZpZXdMb2FkZXIuaCIKQEAgLTI0MDAsMTAgKzI0MDMsMTIgQEAgRXhjZXB0aW9uT3I8dW5zaWdu ZWQ+IEludGVybmFsczo6Y291bnRGaW5kTWF0Y2hlcyhjb25zdCBTdHJpbmcmIHRleHQsIGNvbnN0 IFZlY3QKICAgICByZXR1cm4gZG9jdW1lbnQtPnBhZ2UoKS0+Y291bnRGaW5kTWF0Y2hlcyh0ZXh0 LCBwYXJzZWRPcHRpb25zLnJlbGVhc2VSZXR1cm5WYWx1ZSgpLCAxMDAwKTsKIH0KIAorI2lmIEVO QUJMRShJTkRFWEVEX0RBVEFCQVNFKQogdW5zaWduZWQgSW50ZXJuYWxzOjpudW1iZXJPZklEQlRy YW5zYWN0aW9ucygpIGNvbnN0CiB7CiAgICAgcmV0dXJuIElEQlRyYW5zYWN0aW9uOjpudW1iZXJP ZklEQlRyYW5zYWN0aW9uczsKIH0KKyNlbmRpZgogCiB1bnNpZ25lZCBJbnRlcm5hbHM6Om51bWJl ck9mTGl2ZU5vZGVzKCkgY29uc3QKIHsK 373070 2019-06-27 17:25:53 -0700 2019-06-27 18:49:35 -0700 Patch bug199286.diff text/plain 3029 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1OTY4MjRmNGFkYS4uNWI5NjdlNWRjYjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOS0wNi0yNyAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29u eS5jb20+CisKKyAgICAgICAgIEZpeCBidWlsZCBlcnJvciBvbiBXZWJDb3JlIHdoZW4gZGlzYWJs aW5nIEVOQUJMRV9JTkRFWEVEX0RBVEFCQVNFLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5Mjg2CisKKyAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQg Zml4LgorCisgICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmNwcDogTWFrZSBtZXRob2QgY29u ZGl0aW9uYWwuCisgICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmg6IERpdHRvLgorICAgICAg ICAgKiB0ZXN0aW5nL0ludGVybmFscy5pZGw6IERpdHRvLgorCiAyMDE5LTA2LTI3ICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIy NDY4NjkpOiBBU1NFUlRJT04gRkFJTEVEOiAhcmVuZGVyZXIoKS5oYXNSZXBhaW50TGF5b3V0UmVj dHMoKSB8fCByZW5kZXJlcigpLnJlcGFpbnRMYXlvdXRSZWN0cygpLm1fcmVwYWludFJlY3QgPT0g cmVuZGVyZXIoKS5jbGlwcGVkT3ZlcmZsb3dSZWN0Rm9yUmVwYWludChyZW5kZXJlcigpLmNvbnRh aW5lckZvclJlcGFpbnQoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50 ZXJuYWxzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAppbmRleCBh Y2RlMTJmOGRlNC4uODgzNGZmYmE0NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3Rp bmcvSW50ZXJuYWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5j cHAKQEAgLTk3LDggKzk3LDYgQEAKICNpbmNsdWRlICJIaXN0b3J5Q29udHJvbGxlci5oIgogI2lu Y2x1ZGUgIkhpc3RvcnlJdGVtLmgiCiAjaW5jbHVkZSAiSGl0VGVzdFJlc3VsdC5oIgotI2luY2x1 ZGUgIklEQlJlcXVlc3QuaCIKLSNpbmNsdWRlICJJREJUcmFuc2FjdGlvbi5oIgogI2luY2x1ZGUg Ikluc3BlY3RvckNsaWVudC5oIgogI2luY2x1ZGUgIkluc3BlY3RvckNvbnRyb2xsZXIuaCIKICNp bmNsdWRlICJJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsLmgiCkBAIC0yNzMsNiArMjcxLDEx IEBACiAjaW5jbHVkZSAiUG9pbnRlckxvY2tDb250cm9sbGVyLmgiCiAjZW5kaWYKIAorI2lmIEVO QUJMRShJTkRFWEVEX0RBVEFCQVNFKQorI2luY2x1ZGUgIklEQlJlcXVlc3QuaCIKKyNpbmNsdWRl ICJJREJUcmFuc2FjdGlvbi5oIgorI2VuZGlmCisKICNpZiBVU0UoUVVJQ0tfTE9PSykKICNpbmNs dWRlICJNb2NrUHJldmlld0xvYWRlckNsaWVudC5oIgogI2luY2x1ZGUgIlByZXZpZXdMb2FkZXIu aCIKQEAgLTI0MDksMTAgKzI0MTIsMTIgQEAgRXhjZXB0aW9uT3I8dW5zaWduZWQ+IEludGVybmFs czo6Y291bnRGaW5kTWF0Y2hlcyhjb25zdCBTdHJpbmcmIHRleHQsIGNvbnN0IFZlY3QKICAgICBy ZXR1cm4gZG9jdW1lbnQtPnBhZ2UoKS0+Y291bnRGaW5kTWF0Y2hlcyh0ZXh0LCBwYXJzZWRPcHRp b25zLnJlbGVhc2VSZXR1cm5WYWx1ZSgpLCAxMDAwKTsKIH0KIAorI2lmIEVOQUJMRShJTkRFWEVE X0RBVEFCQVNFKQogdW5zaWduZWQgSW50ZXJuYWxzOjpudW1iZXJPZklEQlRyYW5zYWN0aW9ucygp IGNvbnN0CiB7CiAgICAgcmV0dXJuIElEQlRyYW5zYWN0aW9uOjpudW1iZXJPZklEQlRyYW5zYWN0 aW9uczsKIH0KKyNlbmRpZgogCiB1bnNpZ25lZCBJbnRlcm5hbHM6Om51bWJlck9mTGl2ZU5vZGVz KCkgY29uc3QKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxz LmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oCmluZGV4IGJiZjFlOTFmN2Ew Li45MWE3ZTAwNGM5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5h bHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oCkBAIC0zODgsNyAr Mzg4LDkgQEAgcHVibGljOgogICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IGluc2VydEF1dGhvckNTUyhj b25zdCBTdHJpbmcmKSBjb25zdDsKICAgICBFeGNlcHRpb25Pcjx2b2lkPiBpbnNlcnRVc2VyQ1NT KGNvbnN0IFN0cmluZyYpIGNvbnN0OwogCisjaWYgRU5BQkxFKElOREVYRURfREFUQUJBU0UpCiAg ICAgdW5zaWduZWQgbnVtYmVyT2ZJREJUcmFuc2FjdGlvbnMoKSBjb25zdDsKKyNlbmRpZgogCiAg ICAgdW5zaWduZWQgbnVtYmVyT2ZMaXZlTm9kZXMoKSBjb25zdDsKICAgICB1bnNpZ25lZCBudW1i ZXJPZkxpdmVEb2N1bWVudHMoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rl c3RpbmcvSW50ZXJuYWxzLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlk bAppbmRleCAxNTI1NjA5N2JjZC4uZGM5NzUyZWRkNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0lu dGVybmFscy5pZGwKQEAgLTQyMyw3ICs0MjMsNyBAQCBlbnVtIENvbXBvc2l0aW5nUG9saWN5IHsK ICAgICB2b2lkIGJlZ2luU2ltdWxhdGVkTWVtb3J5UHJlc3N1cmUoKTsKICAgICB2b2lkIGVuZFNp bXVsYXRlZE1lbW9yeVByZXNzdXJlKCk7CiAKLSAgICB1bnNpZ25lZCBsb25nIG51bWJlck9mSURC VHJhbnNhY3Rpb25zKCk7CisgICAgW0NvbmRpdGlvbmFsPUlOREVYRURfREFUQUJBU0VdIHVuc2ln bmVkIGxvbmcgbnVtYmVyT2ZJREJUcmFuc2FjdGlvbnMoKTsKIAogICAgIHVuc2lnbmVkIGxvbmcg bnVtYmVyT2ZMaXZlTm9kZXMoKTsKICAgICB1bnNpZ25lZCBsb25nIG51bWJlck9mTGl2ZURvY3Vt ZW50cygpOwo=