199280 2019-06-27 11:45:06 -0700 Layout Test fast/parser/parser-yield-timing.html is flaky 2019-06-27 13:58:43 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 repstein webkit-unassigned commit-queue ggaren mark.lam ryanhaddad thorton tsavell webkit-bug-importer oldest_to_newest 1548562 0 repstein 2019-06-27 11:45:06 -0700 The following layout test is flaky on Mojave Debug WK1 fast/parser/parser-yield-timing.html Steps to reproduce: run-webkit-tests --iter 1000 -f -1 fast/parser/parser-yield-timing.html Regression range appears to be between r244212 and r244236. Confirmed test passing in r244211, failing r244239. Lack of testable builds is preventing further reduction of the regression range. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fparser%2Fparser-yield-timing.html Diff: --- /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/fast/parser/parser-yield-timing-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/fast/parser/parser-yield-timing-actual.txt @@ -4,8 +4,8 @@ PASS new Date().getTime() - startTime is within 300 of 1000 -PASS new Date().getTime() - startTime is within 300 of 2000 -PASS new Date().getTime() - startTime is within 300 of 3000 +FAIL new Date().getTime() - startTime should be within 300 of 2000. Was 2307. +FAIL new Date().getTime() - startTime should be within 300 of 3000. Was 3331. PASS successfullyParsed is true TEST COMPLETE 1548563 1 373040 repstein 2019-06-27 11:48:56 -0700 Created attachment 373040 Update TestExpectations 1548587 2 373040 tsavell 2019-06-27 13:00:43 -0700 Comment on attachment 373040 Update TestExpectations Clearing flags on attachment: 373040 Committed r246898: <https://trac.webkit.org/changeset/246898> 1548588 3 webkit-bug-importer 2019-06-27 13:00:53 -0700 <rdar://problem/52278766> 1548595 4 373048 repstein 2019-06-27 13:23:19 -0700 Created attachment 373048 Patch 1548608 5 373048 commit-queue 2019-06-27 13:57:16 -0700 Comment on attachment 373048 Patch Clearing flags on attachment: 373048 Committed r246904: <https://trac.webkit.org/changeset/246904> 1548609 6 commit-queue 2019-06-27 13:57:18 -0700 All reviewed patches have been landed. Closing bug. 1548610 7 repstein 2019-06-27 13:58:43 -0700 Had an offline discussion with thorton. Discussed that it may be better to increase the test tolerance rather than marking the test as flaky. Increased test tolerance from ±300ms to ±400ms to reduce noise. Updated fast/parser/parser-yield-timing-expected.txt to reflect this change. Removed expected failure from TestExpectations. https://trac.webkit.org/changeset/246904/webkit (In reply to WebKit Commit Bot from comment #5) > Comment on attachment 373048 [details] > Patch > > Clearing flags on attachment: 373048 > > Committed r246904: <https://trac.webkit.org/changeset/246904> 373040 2019-06-27 11:48:56 -0700 2019-06-27 13:23:18 -0700 Update TestExpectations bug-199280-20190627114855.patch text/plain 1283 repstein U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODk2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjBhNzc1YmEyYjI1Njc1OWI5NjI1 NmIwZGYzNGIxMjUxZTk3Nzk3ZS4uMjE0YjQ0OTQ0ZWJkYzE4ODhkM2Y0MTAyZGU2YWQ2NjU4NGE3 ODAxMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA2LTI3ICBSdXNzZWxsIEVwc3RlaW4g IDxydXNzZWxsX2VAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dCBUZXN0IGZhc3QvcGFyc2Vy L3BhcnNlci15aWVsZC10aW1pbmcuaHRtbCBpcyBmbGFreS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTI4MAorCisgICAgICAgIFVucmV2aWV3ZWQg dGVzdCBnYXJkZW5pbmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3Rh dGlvbnM6CisKIDIwMTktMDYtMjcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCB0ZXN0IGZhaWx1cmVzIGFmdGVyIHIyNDY4NzYuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYWEx MWQ5YmMyOTY1Y2Q3ZDg0NjVlMTgwZmE2NzYyY2NiMDEzZTBlZi4uNzU4ZjkwNDRlNWU2ODBiNTM0 OWVlNjE5ZDQ1Y2E4YjQ2NGEwNDJlYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13 azEvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNzQ2LDMgKzc0Niw1IEBAIHdlYmtpdC5vcmcvYi8xOTg2 NzYgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jb250ZW50LXNlY3VyaXR5LXBvbGlj eS9yZXBvCiAKIHdlYmtpdC5vcmcvYi8xOTkyNDIgWyBEZWJ1ZyBdIGh0dHAvdGVzdHMvcGVyZm9y bWFuY2UvcGVyZm9ybWFuY2UtcmVzb3VyY2UtdGltaW5nLXJlc291cmNldGltaW5nYnVmZmVyZnVs bC1zaHJpbmtpbmctYnVmZmVyLWNyYXNoLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCit3ZWJraXQu b3JnL2IvMTk5MjgwIFsgRGVidWcgTW9qYXZlIF0gZmFzdC9wYXJzZXIvcGFyc2VyLXlpZWxkLXRp bWluZy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KKwo= 373048 2019-06-27 13:23:19 -0700 2019-06-27 13:57:16 -0700 Patch bug-199280-20190627132319.patch text/plain 3318 repstein U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODk4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTczNDRjM2ZjMmUzY2Y2Zjk0ZDUy ODI1Yzk5OWI3YTQzOGE2MGY1ZS4uNzYzMzY4MTVlMjM3NjVlMDBlMGMyZDdmNTRjZjg3ODAyODY2 Nzc5ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA2LTI3ICBSdXNzZWxsIEVwc3RlaW4g IDxydXNzZWxsX2VAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dCBUZXN0IGZhc3QvcGFyc2Vy L3BhcnNlci15aWVsZC10aW1pbmcuaHRtbCB3YXMgZmxha3kgZHVlIHRvIHN0cmljdCB0b2xlcmFu Y2UsIGluY3JlYXNlZCB0b2xlcmFuY2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTkyODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGZhc3QvcGFyc2VyL3BhcnNlci15aWVsZC10aW1pbmctZXhwZWN0 ZWQudHh0OgorICAgICAgICAqIGZhc3QvcGFyc2VyL3BhcnNlci15aWVsZC10aW1pbmcuaHRtbDoK KyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTktMDYt MjcgIFJ1c3NlbGwgRXBzdGVpbiAgPHJ1c3NlbGxfZUBhcHBsZS5jb20+CiAKICAgICAgICAgTGF5 b3V0IFRlc3QgZmFzdC9wYXJzZXIvcGFyc2VyLXlpZWxkLXRpbWluZy5odG1sIGlzIGZsYWt5Lgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvcGFyc2VyLXlpZWxkLXRpbWluZy1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9wYXJzZXIteWllbGQtdGltaW5n LWV4cGVjdGVkLnR4dAppbmRleCA5NDhkYTQyNDUyYmEzZDVlNWYwNGU0OWJlZTVlODIzM2QxMDYy M2Q3Li43NWRjY2JlMmIyNmQ4YmZlMGFhMjE2OGU4YTBkYmE2NThmOTdjMzk5IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9wYXJzZXIteWllbGQtdGltaW5nLWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9wYXJzZXIteWllbGQtdGltaW5nLWV4cGVj dGVkLnR4dApAQCAtMyw5ICszLDkgQEAgUnVucyAzIHNlcGFyYXRlIDEgc2Vjb25kIDxzY3JpcHQ+ IGJsb2NrcyB3aXRoIGEgc2V0VGltZW91dCBzY2hlZHVsZSBiZWZvcmUgZWFjaC4KIE9uIHN1Y2Nl c3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5 ICJURVNUIENPTVBMRVRFIi4KIAogCi1QQVNTIG5ldyBEYXRlKCkuZ2V0VGltZSgpIC0gc3RhcnRU aW1lIGlzIHdpdGhpbiAzMDAgb2YgMTAwMAotUEFTUyBuZXcgRGF0ZSgpLmdldFRpbWUoKSAtIHN0 YXJ0VGltZSBpcyB3aXRoaW4gMzAwIG9mIDIwMDAKLVBBU1MgbmV3IERhdGUoKS5nZXRUaW1lKCkg LSBzdGFydFRpbWUgaXMgd2l0aGluIDMwMCBvZiAzMDAwCitQQVNTIG5ldyBEYXRlKCkuZ2V0VGlt ZSgpIC0gc3RhcnRUaW1lIGlzIHdpdGhpbiA0MDAgb2YgMTAwMAorUEFTUyBuZXcgRGF0ZSgpLmdl dFRpbWUoKSAtIHN0YXJ0VGltZSBpcyB3aXRoaW4gNDAwIG9mIDIwMDAKK1BBU1MgbmV3IERhdGUo KS5nZXRUaW1lKCkgLSBzdGFydFRpbWUgaXMgd2l0aGluIDQwMCBvZiAzMDAwCiBQQVNTIHN1Y2Nl c3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvcGFyc2VyL3BhcnNlci15aWVsZC10aW1pbmcuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvcGFyc2VyL3BhcnNlci15aWVsZC10aW1pbmcuaHRtbAppbmRleCA1ZWIzMGFhODQ0Nzdj YzM0ZTEwZTNjZGZiNWYzY2EwYjE0NTI1ZTE0Li44ZTQwYWQyMWMyODBhMzgxNjc5ZTdkODRlMDc4 ZWU0MjFkYWVlMDNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9wYXJzZXIt eWllbGQtdGltaW5nLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvcGFyc2VyLXlp ZWxkLXRpbWluZy5odG1sCkBAIC04LDcgKzgsNyBAQAogICAgICAgZGVzY3JpcHRpb24oIlJ1bnMg MyBzZXBhcmF0ZSAxIHNlY29uZCAmbHQ7c2NyaXB0Jmd0OyBibG9ja3Mgd2l0aCBhIHNldFRpbWVv dXQgc2NoZWR1bGUgYmVmb3JlIGVhY2guIFRoZSBleGVjdXRpb24gdGltZSBvZiB0aGUgc2V0VGlt ZW91dCBpcyB3aGVuIHRoZSBIVE1MIHlpZWxkZWQgdG8gdGhlIGV2ZW50IGxvb3AuIFRoZSB5aWVs ZHMgYWxzbyByZXByZXNlbnQgcGFpbnRpbmcgb3Bwb3J0dW5pdGllcy4gV2Ugd2FudCB0aGUgcGFy c2VyIHRvIHlpZWxkIGV2ZXJ5IDAuNSBzZWNvbmRzIG9uY2UgaXQgaGFzIHNlZW4gYSBzY3JpcHQu Iik7CiAKICAgICAgIHZhciBzdGFydFRpbWUgPSBuZXcgRGF0ZSgpLmdldFRpbWUoKTsKLSAgICAg IHZhciB0b2xlcmFuY2UgPSAzMDA7IC8vIDMwMCBtcworICAgICAgdmFyIHRvbGVyYW5jZSA9IDQw MDsgLy8gNDAwIG1zCiAKICAgICAgIGZ1bmN0aW9uIGV4cGVjdEVsYXBzZWRUaW1lKGV4cGVjdGVk VGltZSkgewogICAgICAgICBzaG91bGRCZUNsb3NlVG8oIm5ldyBEYXRlKCkuZ2V0VGltZSgpIC0g c3RhcnRUaW1lIiwgZXhwZWN0ZWRUaW1lLCB0b2xlcmFuY2UpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDc1OGY5MDQ0ZTVlNjgwYjUzNDll ZTYxOWQ0NWNhOGI0NjRhMDQyZWMuLmFhMTFkOWJjMjk2NWNkN2Q4NDY1ZTE4MGZhNjc2MmNjYjAx M2UwZWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVj dGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlv bnMKQEAgLTc0Niw1ICs3NDYsMyBAQCB3ZWJraXQub3JnL2IvMTk4Njc2IGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvY29udGVudC1zZWN1cml0eS1wb2xpY3kvcmVwbwogCiB3ZWJraXQu b3JnL2IvMTk5MjQyIFsgRGVidWcgXSBodHRwL3Rlc3RzL3BlcmZvcm1hbmNlL3BlcmZvcm1hbmNl LXJlc291cmNlLXRpbWluZy1yZXNvdXJjZXRpbWluZ2J1ZmZlcmZ1bGwtc2hyaW5raW5nLWJ1ZmZl ci1jcmFzaC5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzE5OTI4MCBbIERl YnVnIE1vamF2ZSBdIGZhc3QvcGFyc2VyL3BhcnNlci15aWVsZC10aW1pbmcuaHRtbCBbIFBhc3Mg RmFpbHVyZSBdCi0K