19928 2008-07-07 09:59:31 -0700 querySelectorAll handling of namespaces poisons the functionality 2008-07-07 21:25:43 -0700 1 1 1 Unclassified WebKit DOM 525.x (Safari 3.1) Mac (Intel) OS X 10.5 RESOLVED FIXED P2 Major --- 0 bzbarsky webkit-unassigned gavin.sharp oldest_to_newest 85350 0 bzbarsky 2008-07-07 09:59:31 -0700 As far as I can tell, there is no exception thrown when CSS3 Namespaces syntax is used in the string passed to querySelectorAll, and at the same time the second argument (the NSResolver) is completely ignored. The latter means the selector has no way to work correctly. The former means that the page can't detect this. I would have expected either correct use of the NSResolver or a SYNTAX_ERR or NAMESPACE_ERR on the attempt to use namespace selectors if they're not supported, so that pages can fallback as needed. As currently implemented this makes it easy for pages to start relying on the incorrect behavior, causing problems for other UAs. 85351 1 22134 bzbarsky 2008-07-07 10:01:02 -0700 Created attachment 22134 Testcase showing the problem 85386 2 sam 2008-07-07 14:32:04 -0700 As of r35041, we now throw a NOT_SUPPORTED_ERR when passing in an NSResolver as the second argument as per spec. We still have to deal with the issue of CSS3 Namespaces syntax in the selector string. I will have to read the spec more closely to figure out what to do in that case. 85398 3 bzbarsky 2008-07-07 16:23:47 -0700 As a data point, IE8 beta 1 in standards mode (doesn't support this in quirks) completely ignores the second argument, and throws SYNTAX_ERR on uses of namespaces syntax. The SYNTAX_ERR is certainly what I'd expect if your CSS parser doesn't do namespaces. NAMESPACE_ERR is what I'd expect per current draft text if it does and there is no NSResolver (as in all cases now that you're throwing NOT_SUPPORTED_ERR). In any case, it's not as important what exception is thrown as that an exception is thrown if there is no NSResolver and the string includes namespaces syntax. 85415 4 sam 2008-07-07 17:50:19 -0700 Right now I am trying to determine what the behavior should be in the face of a selector such as "*|div" which uses namespace syntax but should not require a NSResolver. 85429 5 bzbarsky 2008-07-07 19:37:03 -0700 I think if your parser parses it, it should work without an NSResolver (since there is nothing to resolve in this case). 85434 6 sam 2008-07-07 21:25:43 -0700 Fixed in r35056. 22134 2008-07-07 10:01:02 -0700 2008-07-07 10:01:02 -0700 Testcase showing the problem test.html text/html 389 bzbarsky PGh0bWw+CjxoZWFkPgogIDxzY3JpcHQ+CiAgICBmdW5jdGlvbiB0ZXN0KCkgewogICAgICB0cnkg ewogICAgICAgIGFsZXJ0KGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwoImJiYnxpbnB1dCIsIGZ1 bmN0aW9uKHByZWZpeCkgeyByZXR1cm4gImFhYSI7IH0pWzBdKTsKICAgICAgfSBjYXRjaChleCkg ewogICAgICAgIGFsZXJ0KCJFeGNlcHRpb24gdGhyb3duOiAiICsgZXgpOwogICAgICB9CiAgICB9 CiAgPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+CjxpbnB1dCB0eXBlPSJidXR0b24iIG9uY2xpY2s9 InRlc3QoKSIgdmFsdWU9IlJ1biB0aGUgdGVzdC4gIFRoZSBhbGVydCBzaG91bGQgaW5kaWNhdGUg dGhhdCBhbiBleGNlcHRpb24gd2FzIHRocm93biI+CjwvYm9keT4KPC9odG1sPgo=