199279 2019-06-27 11:20:37 -0700 Move WebKitLegacy off of a couple AppKit ivars 2019-07-11 10:56:11 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 199209 1 timothy timothy benjamin cdumez cmarcelo commit-queue dbates ews-watchlist fred.wang jbedard thorton webkit-bug-importer oldest_to_newest 1548548 0 timothy 2019-06-27 11:20:37 -0700 We use _borderView on NSWindow and _subviews on NSView. There are alternatives now. <rdar://problem/34983438> 1548568 1 373042 timothy 2019-06-27 12:03:41 -0700 Created attachment 373042 Patch 1548611 2 373042 commit-queue 2019-06-27 14:11:19 -0700 Comment on attachment 373042 Patch Clearing flags on attachment: 373042 Committed r246905: <https://trac.webkit.org/changeset/246905> 1548612 3 commit-queue 2019-06-27 14:11:21 -0700 All reviewed patches have been landed. Closing bug. 1552015 4 373042 fred.wang 2019-07-11 03:41:29 -0700 Comment on attachment 373042 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373042&action=review > Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:237 > + ALLOW_DEPRECATED_DECLARATIONS_END @Timothy: These _subviews are causing macOS build failures with XCode 11.0 beta 3 and the public SDK (that seems to be the only build failure though). Any idea? I wonder why SUBVIEWS_IVAR_SPI is not set with Xcode beta (maybe because I'm using Mojave not Catalina?). 1552114 5 timothy 2019-07-11 10:56:11 -0700 (In reply to Frédéric Wang (:fredw) from comment #4) > Comment on attachment 373042 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373042&action=review > > > Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:237 > > + ALLOW_DEPRECATED_DECLARATIONS_END > > @Timothy: These _subviews are causing macOS build failures with XCode 11.0 > beta 3 and the public SDK (that seems to be the only build failure though). > Any idea? I wonder why SUBVIEWS_IVAR_SPI is not set with Xcode beta (maybe > because I'm using Mojave not Catalina?). The SPI is only on Catalina. But it sounds like the SDK removed the ivars still… 373042 2019-06-27 12:03:41 -0700 2019-06-27 14:11:19 -0700 Patch bug-199279-20190627120341.patch text/plain 5740 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZlZGNlYzg5YmJiNGY0NDgwNmJmY2Rh NDcxOGE4ZmFhM2NjOWEwNjEuLjFiNjMwNGRmYTg2MmU2MDc4M2MzZmMzY2NhNjcwNTlmNDBiYWZm ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDYtMjcgIFRpbW90aHkgSGF0Y2hlciAgPHRp bW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIE1vdmUgV2ViS2l0TGVnYWN5IG9mZiBvZiBhIGNv dXBsZSBBcHBLaXQgaXZhcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTkyNzkKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMzQ5ODM0MzgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9y bS5oOiBBZGRlZCBIQVZFX1NVQlZJRVdTX0lWQVJfU1BJLgorCiAyMDE5LTA2LTI3ICBEb24gT2xt c3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0ZUV10gQnVpbGQgSmF2 YVNjcmlwdENvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwppbmRleCAxYTViNmM5MjE5NjNm M2JmYmEyM2ExMGQxNTY5ZTgzMDI4YmZiYWIwLi43Y2Y3NWRhZjlkYmVjMTI5ODIzNmYyY2Y0YmEz ZDAxMmU3MmIwMDA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTktMDYtMjcgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisg ICAgICAgIE1vdmUgV2ViS2l0TGVnYWN5IG9mZiBvZiBhIGNvdXBsZSBBcHBLaXQgaXZhcnMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkyNzkKKyAg ICAgICAgcmRhcjovL3Byb2JsZW0vMzQ5ODM0MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlZpZXcvV2ViSFRNTFZpZXcubW06CisgICAgICAg ICgtW05TVmlldyBfc2V0U3Vidmlld3NJdmFyOl0pOiBBZGRlZC4gSW1wbGVtZW50IG9uIG9sZGVy IHN5c3RlbXMuCisgICAgICAgICgtW05TVmlldyBfc3Vidmlld3NJdmFyXSk6IEFkZGVkLiBEaXR0 by4KKyAgICAgICAgKG5lZWRzQ3Vyc29yUmVjdHNTdXBwb3J0QXRQb2ludCk6IFVzZSBfYm9yZGVy VmlldyBwcm9wZXJ0eS4KKyAgICAgICAgKC1bV2ViSFRNTFZpZXcgX3NldEFzaWRlU3Vidmlld3Nd KTogVXNlIF9zdWJ2aWV3c0l2YXIgcHJvcGVydHkuCisgICAgICAgICgtW05TV2luZG93IF93ZWJf Ym9yZGVyVmlld10pOiBEZWxldGVkLgorCiAyMDE5LTA2LTI3ICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgV0VCR1BVIGVuYWJsZWQgb25seSBvbiBNb2ph dmUgYW5kIGxhdGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCBiL1Nv dXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKaW5kZXggMzNhNGJiOGQ5ZTJiMjdiNjMyMDBhN2MxZDRl NDY0OGQ4ODgxN2VkYi4uZmJhZWM2Njc5YjllZGE2ODkzNGI2MTRmYTk0ZWY4MWFmZTRiMGRjMSAx MDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9QbGF0Zm9ybS5oCkBAIC0xNTk5LDMgKzE1OTksNyBAQAogI2lmIFBMQVRGT1JNKE1BQykgJiYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8PSAxMDEzMDAKICNkZWZpbmUgVVNFX0lO VEVMX01FVEFMX1dPUktBUk9VTkQgMQogI2VuZGlmCisKKyNpZiBQTEFURk9STShNQUMpICYmIF9f TUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNTAwCisjZGVmaW5lIEhBVkVfU1VC VklFV1NfSVZBUl9TUEkgMQorI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5 L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2Vi Vmlldy9XZWJIVE1MVmlldy5tbQppbmRleCBmMWJkY2RiODljZTMzY2Y2YzFlNGU4YWJkZjRhYzMx ZWU1ZTMyNTc0Li40OGVhMTg2NDdjZWI3OTg1NzQ2NGYxNjA4MTk3YzNhZGFkYmRjYTNjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCisr KyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KQEAgLTIx MywxMiArMjEzLDMyIEBAIC0gKHZvaWQpX3dpbmRvd0NoYW5nZWRLZXlTdGF0ZTsKIEBlbmQKIAog QGludGVyZmFjZSBOU1dpbmRvdyAoKQorQHByb3BlcnR5IChyZWFkb25seSkgX19raW5kb2YgTlNW aWV3ICpfYm9yZGVyVmlldzsKKwogLSAoaWQpX25ld0ZpcnN0UmVzcG9uZGVyQWZ0ZXJSZXNpZ25p bmc7CiBAZW5kCiAKLUBpbnRlcmZhY2UgTlNXaW5kb3cgKFdlYkJvcmRlclZpZXdBY2Nlc3MpCi0t IChOU1ZpZXcgKilfd2ViX2JvcmRlclZpZXc7CitAaW50ZXJmYWNlIE5TVmlldyAoU3Vidmlld3NJ dmFyKQorQHByb3BlcnR5IChudWxsYWJsZSwgYXNzaWduLCBzZXR0ZXI9X3NldFN1YnZpZXdzSXZh cjopIE5TTXV0YWJsZUFycmF5PF9fa2luZG9mIE5TVmlldyAqPiAqX3N1YnZpZXdzSXZhcjsKK0Bl bmQKKworI2lmICFIQVZFKFNVQlZJRVdTX0lWQVJfU1BJKQorQGltcGxlbWVudGF0aW9uIE5TVmll dyAoU3Vidmlld3NJdmFyKQorCistICh2b2lkKV9zZXRTdWJ2aWV3c0l2YXI6KE5TTXV0YWJsZUFy cmF5PF9fa2luZG9mIE5TVmlldyAqPiAqKXN1YnZpZXdzIHsKKyAgICBBTExPV19ERVBSRUNBVEVE X0RFQ0xBUkFUSU9OU19CRUdJTgorICAgIF9zdWJ2aWV3cyA9IHN1YnZpZXdzOworICAgIEFMTE9X X0RFUFJFQ0FURURfREVDTEFSQVRJT05TX0VORAorfQorCistIChOU011dGFibGVBcnJheTxfX2tp bmRvZiBOU1ZpZXcgKj4gKilfc3Vidmlld3NJdmFyIHsKKyAgICBBTExPV19ERVBSRUNBVEVEX0RF Q0xBUkFUSU9OU19CRUdJTgorICAgIHJldHVybiAoTlNNdXRhYmxlQXJyYXkgKilfc3Vidmlld3M7 CisgICAgQUxMT1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfRU5ECit9CisKIEBlbmQKKyNlbmRp ZgogCiB1c2luZyBXZWJFdmVudCA9IE5TRXZlbnQ7CiBjb25zdCBhdXRvIFdlYkV2ZW50TW91c2VE b3duID0gTlNFdmVudFR5cGVMZWZ0TW91c2VEb3duOwpAQCAtNjI2LDE3ICs2NDYsNiBAQCAtICh2 b2lkKWZvcndhcmRDb250ZXh0TWVudUFjdGlvbjooaWQpc2VuZGVyCiAKIEBlbmQKIAotQGltcGxl bWVudGF0aW9uIE5TV2luZG93IChXZWJCb3JkZXJWaWV3QWNjZXNzKQotCi0tIChOU1ZpZXcgKilf d2ViX2JvcmRlclZpZXcKLXsKLSAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19CRUdJ TgotICAgIHJldHVybiBfYm9yZGVyVmlldzsKLSAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFU SU9OU19FTkQKLX0KLQotQGVuZAotCiBAaW50ZXJmYWNlIFdlYlJlc3BvbmRlckNoYWluU2luayA6 IE5TUmVzcG9uZGVyIHsKICAgICBOU1Jlc3BvbmRlciogX2xhc3RSZXNwb25kZXJJbkNoYWluOwog ICAgIEJPT0wgX3JlY2VpdmVkVW5oYW5kbGVkQ29tbWFuZDsKQEAgLTY4NSw3ICs2OTQsNyBAQCBz dGF0aWMgV2ViSFRNTFZpZXcgKmxhc3RIaXRWaWV3Owogc3RhdGljIGJvb2wgbmVlZHNDdXJzb3JS ZWN0c1N1cHBvcnRBdFBvaW50KE5TV2luZG93KiB3aW5kb3csIE5TUG9pbnQgcG9pbnQpCiB7CiAg ICAgZm9yY2VOU1ZpZXdIaXRUZXN0ID0gWUVTOwotICAgIE5TVmlldyogdmlldyA9IFtbd2luZG93 IF93ZWJfYm9yZGVyVmlld10gaGl0VGVzdDpwb2ludF07CisgICAgTlNWaWV3KiB2aWV3ID0gW3dp bmRvdy5fYm9yZGVyVmlldyBoaXRUZXN0OnBvaW50XTsKICAgICBmb3JjZU5TVmlld0hpdFRlc3Qg PSBOTzsKIAogICAgIC8vIFdlYkhUTUxWaWV3IGRvZXNuJ3QgdXNlIGN1cnNvciByZWN0cy4KQEAg LTE1NDQsMTcgKzE1NTMsMTMgQEAgLSAodm9pZClfc2V0QXNpZGVTdWJ2aWV3cwogI2lmIFBMQVRG T1JNKE1BQykKICAgICBBU1NFUlQoIV9wcml2YXRlLT5zdWJ2aWV3c1NldEFzaWRlKTsKICAgICBB U1NFUlQoX3ByaXZhdGUtPnNhdmVkU3Vidmlld3MgPT0gbmlsKTsKLSAgICBBTExPV19ERVBSRUNB VEVEX0RFQ0xBUkFUSU9OU19CRUdJTgotICAgIF9wcml2YXRlLT5zYXZlZFN1YnZpZXdzID0gX3N1 YnZpZXdzOwotICAgIEFMTE9XX0RFUFJFQ0FURURfREVDTEFSQVRJT05TX0VORAorICAgIF9wcml2 YXRlLT5zYXZlZFN1YnZpZXdzID0gc2VsZi5fc3Vidmlld3NJdmFyOwogICAgIC8vIFdlIG5lZWQg dG8ga2VlcCB0aGUgbGF5ZXItaG9zdGluZyB2aWV3IGluIHRoZSBzdWJ2aWV3cywgb3RoZXJ3aXNl IHRoZSBsYXllcnMgZmxhc2guCiAgICAgaWYgKF9wcml2YXRlLT5sYXllckhvc3RpbmdWaWV3KSB7 Ci0gICAgICAgIE5TQXJyYXkqIG5ld1N1YnZpZXdzID0gW1tOU0FycmF5IGFsbG9jXSBpbml0V2l0 aE9iamVjdHM6X3ByaXZhdGUtPmxheWVySG9zdGluZ1ZpZXcsIG5pbF07Ci0gICAgICAgIEFMTE9X X0RFUFJFQ0FURURfREVDTEFSQVRJT05TX0JFR0lOCi0gICAgICAgIF9zdWJ2aWV3cyA9IG5ld1N1 YnZpZXdzOworICAgICAgICBOU011dGFibGVBcnJheSogbmV3U3Vidmlld3MgPSBbW05TTXV0YWJs ZUFycmF5IGFsbG9jXSBpbml0V2l0aE9iamVjdHM6X3ByaXZhdGUtPmxheWVySG9zdGluZ1ZpZXcs IG5pbF07CisgICAgICAgIHNlbGYuX3N1YnZpZXdzSXZhciA9IG5ld1N1YnZpZXdzOwogICAgIH0g ZWxzZQotICAgICAgICBfc3Vidmlld3MgPSBuaWw7Ci0gICAgQUxMT1dfREVQUkVDQVRFRF9ERUNM QVJBVElPTlNfRU5ECisgICAgICAgIHNlbGYuX3N1YnZpZXdzSXZhciA9IG5pbDsKICAgICBfcHJp dmF0ZS0+c3Vidmlld3NTZXRBc2lkZSA9IFlFUzsKICNlbmRpZgogIH0KQEAgLTE1NjQsMTMgKzE1 NjksMTEgQEAgLSAodm9pZClfc2V0QXNpZGVTdWJ2aWV3cwogI2lmIFBMQVRGT1JNKE1BQykKICAg ICBBU1NFUlQoX3ByaXZhdGUtPnN1YnZpZXdzU2V0QXNpZGUpOwogICAgIGlmIChfcHJpdmF0ZS0+ bGF5ZXJIb3N0aW5nVmlldykgewotICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9O U19CRUdJTgotICAgICAgICBbX3N1YnZpZXdzIHJlbGVhc2VdOwotICAgICAgICBfc3Vidmlld3Mg PSBfcHJpdmF0ZS0+c2F2ZWRTdWJ2aWV3czsKKyAgICAgICAgW3NlbGYuX3N1YnZpZXdzSXZhciBy ZWxlYXNlXTsKKyAgICAgICAgc2VsZi5fc3Vidmlld3NJdmFyID0gX3ByaXZhdGUtPnNhdmVkU3Vi dmlld3M7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgQVNTRVJUKF9zdWJ2aWV3cyA9PSBuaWwpOwot ICAgICAgICBfc3Vidmlld3MgPSBfcHJpdmF0ZS0+c2F2ZWRTdWJ2aWV3czsKLSAgICAgICAgQUxM T1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfRU5ECisgICAgICAgIEFTU0VSVChzZWxmLl9zdWJ2 aWV3c0l2YXIgPT0gbmlsKTsKKyAgICAgICAgc2VsZi5fc3Vidmlld3NJdmFyID0gX3ByaXZhdGUt PnNhdmVkU3Vidmlld3M7CiAgICAgfQogICAgIF9wcml2YXRlLT5zYXZlZFN1YnZpZXdzID0gbmls OwogICAgIF9wcml2YXRlLT5zdWJ2aWV3c1NldEFzaWRlID0gTk87Cg==