199274 2019-06-27 10:01:18 -0700 REGRESSION (r246869): ASSERTION FAILED: !renderer().hasRepaintLayoutRects() || renderer().repaintLayoutRects().m_repaintRect == renderer().clippedOverflowRectForRepaint(renderer().containerForRepaint()) 2019-06-27 13:23:11 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199253 InRadar P2 Normal --- 1 repstein simon.fraser ryanhaddad simon.fraser tsavell webkit-bug-importer zalan oldest_to_newest 1548504 0 repstein 2019-06-27 10:01:18 -0700 This patch appears to have caused the following test to crash: fast/repaint/fixed-and-absolute-position-scrolled.html Platform: Mac Debug WK2 Build : r246869 Steps to Reproduce: run-webkit-tests --iter 1000 -f fast/repaint/fixed-and-absolute-position-scrolled.html History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Frepaint%2Ffixed-and-absolute-position-scrolled.html Crash Log: No crash log found for com.apple.WebKit.WebContent.Development:99727. stdout: stderr: ASSERTION FAILED: !renderer().hasRepaintLayoutRects() || renderer().repaintLayoutRects().m_repaintRect == renderer().clippedOverflowRectForRepaint(renderer().containerForRepaint()) ./rendering/RenderLayer.cpp(1123) : void WebCore::RenderLayer::updateLayerPositionsAfterScroll(WebCore::RenderGeometryMap *, OptionSet<WebCore::RenderLayer::UpdateLayerPositionsAfterScrollFlag>) 1 0x3631759c9 WTFCrash 2 0x34a1803db WTFCrashWithInfo(int, char const*, char const*, int) 3 0x34dd07b94 WebCore::RenderLayer::updateLayerPositionsAfterScroll(WebCore::RenderGeometryMap*, WTF::OptionSet<WebCore::RenderLayer::UpdateLayerPositionsAfterScrollFlag>) 4 0x34dd07d25 WebCore::RenderLayer::updateLayerPositionsAfterScroll(WebCore::RenderGeometryMap*, WTF::OptionSet<WebCore::RenderLayer::UpdateLayerPositionsAfterScrollFlag>) 5 0x34dd07d25 WebCore::RenderLayer::updateLayerPositionsAfterScroll(WebCore::RenderGeometryMap*, WTF::OptionSet<WebCore::RenderLayer::UpdateLayerPositionsAfterScrollFlag>) 6 0x34dd07d25 WebCore::RenderLayer::updateLayerPositionsAfterScroll(WebCore::RenderGeometryMap*, WTF::OptionSet<WebCore::RenderLayer::UpdateLayerPositionsAfterScrollFlag>) 7 0x34dd0771e WebCore::RenderLayer::updateLayerPositionsAfterDocumentScroll() 8 0x34d456ddf WebCore::FrameView::updateLayerPositionsAfterScrolling() 9 0x34d68148c WebCore::ScrollView::completeUpdatesAfterScrollTo(WebCore::IntSize const&) 10 0x34d68181b WebCore::ScrollView::scrollTo(WebCore::IntPoint const&) 11 0x34d45b174 WebCore::FrameView::scrollTo(WebCore::IntPoint const&) 12 0x34d680fbd WebCore::ScrollView::setScrollOffset(WebCore::IntPoint const&) 13 0x34d68725e WebCore::ScrollableArea::scrollPositionChanged(WebCore::IntPoint const&) 14 0x34d6871bf WebCore::ScrollableArea::notifyScrollPositionChanged(WebCore::IntPoint const&) 15 0x34d5ffc6f WebCore::AsyncScrollingCoordinator::reconcileScrollingState(WebCore::FrameView&, WebCore::FloatPoint const&, WTF::Variant<WTF::Optional<WebCore::FloatPoint>, WTF::Optional<WebCore::FloatRect> > const&, WebCore::ScrollType, WebCore::ViewportRectStability, WebCore::ScrollingLayerPositionAction) 16 0x34d5ff130 WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll(unsigned long long, WebCore::FloatPoint const&, WTF::Optional<WebCore::FloatPoint>, WebCore::ScrollType, WebCore::ScrollingLayerPositionAction) 17 0x34d5fec31 WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate(WebCore::ScrollableArea&, WebCore::IntPoint const&) 18 0x34d457bd9 WebCore::FrameView::requestScrollPositionUpdate(WebCore::IntPoint const&) 19 0x34d681c9a WebCore::ScrollView::setScrollPosition(WebCore::IntPoint const&) 20 0x34d446c8f WebCore::FrameView::setScrollPosition(WebCore::IntPoint const&) 21 0x34d6801ac WebCore::ScrollView::setContentsScrollPosition(WebCore::IntPoint const&) 22 0x34d3df53a WebCore::DOMWindow::scrollTo(WebCore::ScrollToOptions const&, WebCore::ScrollClamping) const 23 0x34d3df5c9 WebCore::DOMWindow::scrollTo(double, double, WebCore::ScrollClamping) const 24 0x34aae574c WebCore::jsDOMWindowInstanceFunctionScrollTo2Body(JSC::ExecState*, WebCore::JSDOMWindow*, JSC::ThrowScope&) 25 0x34aae5480 WebCore::jsDOMWindowInstanceFunctionScrollToOverloadDispatcher(JSC::ExecState*, WebCore::JSDOMWindow*, JSC::ThrowScope&) 26 0x34aa87990 long long WebCore::IDLOperation<WebCore::JSDOMWindow>::call<&(WebCore::jsDOMWindowInstanceFunctionScrollToOverloadDispatcher(JSC::ExecState*, WebCore::JSDOMWindow*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::ExecState&, char const*) 27 0x34aa8767c WebCore::jsDOMWindowInstanceFunctionScrollTo(JSC::ExecState*) 28 0x36d431a0116b 29 0x3636a234c llint_entry 30 0x363685633 vmEntryToJavaScript 31 0x364366457 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) LEAK: 1 WebPageProxy 1548506 1 webkit-bug-importer 2019-06-27 10:04:06 -0700 <rdar://problem/52266798> 1548507 2 ryanhaddad 2019-06-27 10:05:51 -0700 'This patch' refers to https://trac.webkit.org/r246869 1548593 3 373047 simon.fraser 2019-06-27 13:17:55 -0700 Created attachment 373047 Patch 1548594 4 simon.fraser 2019-06-27 13:23:11 -0700 https://trac.webkit.org/changeset/246899/webkit 373047 2019-06-27 13:17:55 -0700 2019-06-27 13:18:45 -0700 Patch bug-199274-20190627131754.patch text/plain 1643 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjkzYzNlYTZiMDMwYjMy ZGJiMTNhYWYxNDgyNjM1M2VjY2Y0M2UwYi4uYmQ0MzAyYzAzMzQxN2M2ZDI3MjdlYmNlOThhZTc5 Y2IwNzBmYTFiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA2LTI3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyNDY4NjkpOiBBU1NFUlRJT04gRkFJTEVEOiAhcmVuZGVyZXIoKS5oYXNSZXBhaW50TGF5b3V0 UmVjdHMoKSB8fCByZW5kZXJlcigpLnJlcGFpbnRMYXlvdXRSZWN0cygpLm1fcmVwYWludFJlY3Qg PT0gcmVuZGVyZXIoKS5jbGlwcGVkT3ZlcmZsb3dSZWN0Rm9yUmVwYWludChyZW5kZXJlcigpLmNv bnRhaW5lckZvclJlcGFpbnQoKSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5OTI3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdoZW4gbGF5ZXIgYmFja2luZyBzaGFyaW5nIGNoYW5nZXMsIHdlIG5lZWQg dG8gY2xlYXIgY2FjaGVkIHJlcGFpbnQgcmVjdHMsIHNpbmNlIHRoZXkKKyAgICAgICAgcGFpbnRp bmcgcm9vdCBjaGFuZ2VzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpzZXRCYWNraW5nUHJvdmlkZXJMYXllcik6 CisKIDIwMTktMDYtMjcgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAg IFVwc3RyZWFtIHVzZSBvZiBNQUNDQVRBTFlTVApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllci5jcHAKaW5kZXggY2E3MjkwYTAyZDNiNzAzM2QwNmM2Mzk0ZmE5MDlmODBmM2VmZDAx Ni4uNzliMWM4NzJmMjRkYjVlYjY2YjBjYzU2Zjc5ZjhjNDMxMTY5YjRmNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0xNzg4LDggKzE3ODgsMTAgQEAgdm9p ZCBSZW5kZXJMYXllcjo6c2V0QmFja2luZ1Byb3ZpZGVyTGF5ZXIoUmVuZGVyTGF5ZXIqIGJhY2tp bmdQcm92aWRlcikKICAgICBpZiAoYmFja2luZ1Byb3ZpZGVyID09IG1fYmFja2luZ1Byb3ZpZGVy TGF5ZXIpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmICghcmVuZGVyZXIoKS5yZW5kZXJUcmVl QmVpbmdEZXN0cm95ZWQoKSkKKyAgICBpZiAoIXJlbmRlcmVyKCkucmVuZGVyVHJlZUJlaW5nRGVz dHJveWVkKCkpIHsKKyAgICAgICAgY2xlYXJSZXBhaW50UmVjdHMoKTsKICAgICAgICAgY2xlYXJD bGlwUmVjdHNJbmNsdWRpbmdEZXNjZW5kYW50cygpOworICAgIH0KIAogICAgIG1fYmFja2luZ1By b3ZpZGVyTGF5ZXIgPSBtYWtlV2Vha1B0cihiYWNraW5nUHJvdmlkZXIpOwogfQo=