199271 2019-06-27 06:29:03 -0700 Avoid using WTF::Function for passing local function pointers and closures in URLHelpers.cpp 2019-06-27 14:37:28 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 annulen annulen benjamin cdumez cmarcelo darin dbates ews-watchlist keith_miller mark.lam webkit-bug-importer ysuzuki oldest_to_newest 1548454 0 annulen 2019-06-27 06:29:03 -0700 WTF::Function allocates memory on heap, which is totally redundant in this case. I've also tried using ScopedLambda, however its constructor doesn't allow conversion from non-lambda functions. 1548455 1 373026 annulen 2019-06-27 06:30:07 -0700 Created attachment 373026 Patch 1548543 2 373026 keith_miller 2019-06-27 11:13:25 -0700 Comment on attachment 373026 Patch Why not change ScopedLambda to allow a function pointer? 1548554 3 annulen 2019-06-27 11:34:54 -0700 I thought about that, but it won't be Scoped*Lambda* anymore... 1548564 4 373041 annulen 2019-06-27 11:53:37 -0700 Created attachment 373041 Patch 1548565 5 annulen 2019-06-27 11:54:32 -0700 Yusuke adviced me to change it to template (to avoid indirect call in a loop) 1548575 6 373041 ysuzuki 2019-06-27 12:14:34 -0700 Comment on attachment 373041 Patch r=me 1548619 7 373041 annulen 2019-06-27 14:36:14 -0700 Comment on attachment 373041 Patch Clearing flags on attachment: 373041 Committed r246906: <https://trac.webkit.org/changeset/246906> 1548620 8 annulen 2019-06-27 14:36:19 -0700 All reviewed patches have been landed. Closing bug. 1548621 9 webkit-bug-importer 2019-06-27 14:37:28 -0700 <rdar://problem/52285454> 373026 2019-06-27 06:30:07 -0700 2019-06-27 11:53:32 -0700 Patch bug-199271-20190627163005.patch text/plain 1495 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDU1MTk0MTY0OWMzNjM3Y2QxNTkxMzg4 ZWIwMDAzZjhkZmJkY2QwYTIuLjBjNGUzMGJlNmExZGRkZDlhZWFmNzEzY2QxNzFiNDRjZGNjNzQz NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDYtMjcgIEtvbnN0YW50aW4gVG9rYXJldiAg PGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIEF2b2lkIHVzaW5nIFdURjo6RnVuY3Rpb24g Zm9yIHBhc3NpbmcgbG9jYWwgZnVuY3Rpb24gcG9pbnRlcnMgYW5kIGNsb3N1cmVzIGluIFVSTEhl bHBlcnMuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTkyNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXVEY6OkZ1bmN0aW9uIGFsbG9jYXRlcyBtZW1vcnkgb24gaGVhcCwgd2hpY2ggaXMgdG90YWxs eSByZWR1bmRhbnQgaW4gdGhpcworICAgICAgICBjYXNlLgorCisgICAgICAgICogd3RmL1VSTEhl bHBlcnMuY3BwOgorICAgICAgICAoV1RGOjpVUkxIZWxwZXJzOjppc1NlY29uZExldmVsRG9tYWlu TmFtZUFsbG93ZWRCeVRMRFJ1bGVzKToKKwogMjAxOS0wNi0yNyAgRnVqaWkgSGlyb25vcmkgIDxI aXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBbQ01ha2VdIEJ1bXAgY21ha2VfbWlu aW11bV9yZXF1aXJlZCB2ZXJzaW9uIHRvIDMuMTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3Rm L1VSTEhlbHBlcnMuY3BwIGIvU291cmNlL1dURi93dGYvVVJMSGVscGVycy5jcHAKaW5kZXggNjQw MDRhY2FhYjMwZGZmMzdjMmVlMGJhNjRhZjdiNDJhMzJhNmQ1OS4uZjIwNjI1ODFiMTg2OWQ0NmFi Yzk5YzFhY2RmOTFkYWJlMzVlZmEwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvVVJMSGVs cGVycy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvVVJMSGVscGVycy5jcHAKQEAgLTMyNyw3ICsz MjcsNyBAQCBzdGF0aWMgYm9vbCBhbGxDaGFyYWN0ZXJzSW5JRE5TY3JpcHRXaGl0ZUxpc3QoY29u c3QgVUNoYXIqIGJ1ZmZlciwgaW50MzJfdCBsZW5ndAogICAgIHJldHVybiB0cnVlOwogfQogCi1z dGF0aWMgYm9vbCBpc1NlY29uZExldmVsRG9tYWluTmFtZUFsbG93ZWRCeVRMRFJ1bGVzKGNvbnN0 IFVDaGFyKiBidWZmZXIsIGludDMyX3QgbGVuZ3RoLCBjb25zdCBXVEY6OkZ1bmN0aW9uPGJvb2wo VUNoYXIpPiYgY2hhcmFjdGVySXNBbGxvd2VkKQorc3RhdGljIGJvb2wgaXNTZWNvbmRMZXZlbERv bWFpbk5hbWVBbGxvd2VkQnlUTERSdWxlcyhjb25zdCBVQ2hhciogYnVmZmVyLCBpbnQzMl90IGxl bmd0aCwgYm9vbCgqY2hhcmFjdGVySXNBbGxvd2VkKShVQ2hhcikpCiB7CiAgICAgQVNTRVJUKGxl bmd0aCA+IDApOwogCg== 373041 2019-06-27 11:53:37 -0700 2019-06-27 14:36:14 -0700 Patch bug-199271-20190627215335.patch text/plain 1518 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDU1MTk0MTY0OWMzNjM3Y2QxNTkxMzg4 ZWIwMDAzZjhkZmJkY2QwYTIuLjBjNGUzMGJlNmExZGRkZDlhZWFmNzEzY2QxNzFiNDRjZGNjNzQz NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDYtMjcgIEtvbnN0YW50aW4gVG9rYXJldiAg PGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIEF2b2lkIHVzaW5nIFdURjo6RnVuY3Rpb24g Zm9yIHBhc3NpbmcgbG9jYWwgZnVuY3Rpb24gcG9pbnRlcnMgYW5kIGNsb3N1cmVzIGluIFVSTEhl bHBlcnMuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTkyNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXVEY6OkZ1bmN0aW9uIGFsbG9jYXRlcyBtZW1vcnkgb24gaGVhcCwgd2hpY2ggaXMgdG90YWxs eSByZWR1bmRhbnQgaW4gdGhpcworICAgICAgICBjYXNlLgorCisgICAgICAgICogd3RmL1VSTEhl bHBlcnMuY3BwOgorICAgICAgICAoV1RGOjpVUkxIZWxwZXJzOjppc1NlY29uZExldmVsRG9tYWlu TmFtZUFsbG93ZWRCeVRMRFJ1bGVzKToKKwogMjAxOS0wNi0yNyAgRnVqaWkgSGlyb25vcmkgIDxI aXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBbQ01ha2VdIEJ1bXAgY21ha2VfbWlu aW11bV9yZXF1aXJlZCB2ZXJzaW9uIHRvIDMuMTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3Rm L1VSTEhlbHBlcnMuY3BwIGIvU291cmNlL1dURi93dGYvVVJMSGVscGVycy5jcHAKaW5kZXggNjQw MDRhY2FhYjMwZGZmMzdjMmVlMGJhNjRhZjdiNDJhMzJhNmQ1OS4uODkyNzE1NmUyMzQ1MWMzZmQ1 ZjNmZjg1Y2M1NDU1NjBmYzQ0YTRkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvVVJMSGVs cGVycy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvVVJMSGVscGVycy5jcHAKQEAgLTMyNyw3ICsz MjcsOCBAQCBzdGF0aWMgYm9vbCBhbGxDaGFyYWN0ZXJzSW5JRE5TY3JpcHRXaGl0ZUxpc3QoY29u c3QgVUNoYXIqIGJ1ZmZlciwgaW50MzJfdCBsZW5ndAogICAgIHJldHVybiB0cnVlOwogfQogCi1z dGF0aWMgYm9vbCBpc1NlY29uZExldmVsRG9tYWluTmFtZUFsbG93ZWRCeVRMRFJ1bGVzKGNvbnN0 IFVDaGFyKiBidWZmZXIsIGludDMyX3QgbGVuZ3RoLCBjb25zdCBXVEY6OkZ1bmN0aW9uPGJvb2wo VUNoYXIpPiYgY2hhcmFjdGVySXNBbGxvd2VkKQordGVtcGxhdGU8dHlwZW5hbWUgRnVuYz4KK3N0 YXRpYyBpbmxpbmUgYm9vbCBpc1NlY29uZExldmVsRG9tYWluTmFtZUFsbG93ZWRCeVRMRFJ1bGVz KGNvbnN0IFVDaGFyKiBidWZmZXIsIGludDMyX3QgbGVuZ3RoLCBGdW5jIGNoYXJhY3RlcklzQWxs b3dlZCkKIHsKICAgICBBU1NFUlQobGVuZ3RoID4gMCk7CiAK