199262 2019-06-27 02:05:28 -0700 WebSockets: avoid data copies when queuing tasks in WebSocketChannel 2019-06-27 11:44:42 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned achristensen commit-queue webkit-bug-importer oldest_to_newest 1548404 0 cgarcia 2019-06-27 02:05:28 -0700 For IPC message handler arguments we can receive rvalue references instead of const references. 1548405 1 373011 cgarcia 2019-06-27 02:07:01 -0700 Created attachment 373011 Patch 1548559 2 373011 commit-queue 2019-06-27 11:43:17 -0700 Comment on attachment 373011 Patch Clearing flags on attachment: 373011 Committed r246896: <https://trac.webkit.org/changeset/246896> 1548560 3 commit-queue 2019-06-27 11:43:26 -0700 All reviewed patches have been landed. Closing bug. 1548561 4 webkit-bug-importer 2019-06-27 11:44:42 -0700 <rdar://problem/52274060> 373011 2019-06-27 02:07:01 -0700 2019-06-27 11:43:17 -0700 Patch wk2-websockets-data-copy.diff text/plain 5686 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggM2MzMTVkNGQwODEuLmRjZGRhMDdlNmIxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIwIEBACisyMDE5LTA2LTI3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBXZWJTb2NrZXRzOiBhdm9pZCBkYXRhIGNvcGllcyB3aGVuIHF1ZXVp bmcgdGFza3MgaW4gV2ViU29ja2V0Q2hhbm5lbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MjYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRm9yIElQQyBtZXNzYWdlIGhhbmRsZXIgYXJndW1lbnRzIHdl IGNhbiByZWNlaXZlIHJ2YWx1ZSByZWZlcmVuY2VzIGluc3RlYWQgb2YgY29uc3QgcmVmZXJlbmNl cy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvTmV0d29yay9XZWJTb2NrZXRDaGFubmVsLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViU29ja2V0Q2hhbm5lbDo6ZGlkQ29ubmVjdCk6CisgICAgICAg IChXZWJLaXQ6OldlYlNvY2tldENoYW5uZWw6OmRpZFJlY2VpdmVUZXh0KToKKyAgICAgICAgKFdl YktpdDo6V2ViU29ja2V0Q2hhbm5lbDo6ZGlkUmVjZWl2ZUJpbmFyeURhdGEpOgorICAgICAgICAo V2ViS2l0OjpXZWJTb2NrZXRDaGFubmVsOjpkaWRDbG9zZSk6CisgICAgICAgIChXZWJLaXQ6Oldl YlNvY2tldENoYW5uZWw6OmRpZFJlY2VpdmVNZXNzYWdlRXJyb3IpOgorICAgICAgICAqIFdlYlBy b2Nlc3MvTmV0d29yay9XZWJTb2NrZXRDaGFubmVsLmg6CisKIDIwMTktMDYtMjcgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTT1VQXSBXZWJT b2NrZXRzOiBoYW5kbGUgVExTIGNlcnRpZmljYXRlIGFuZCBlcnJvcnMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlNvY2tldENoYW5uZWwuY3BwIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvV2ViU29ja2V0Q2hhbm5lbC5jcHAKaW5kZXgg NzJmN2Q5YzYwZjIuLjU2Y2I3Yjg5NDFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvTmV0d29yay9XZWJTb2NrZXRDaGFubmVsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvTmV0d29yay9XZWJTb2NrZXRDaGFubmVsLmNwcApAQCAtMTYxLDcgKzE2MSw3IEBA IHZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlzY29ubmVjdCgpCiAgICAgTWVzc2FnZVNlbmRlcjo6 c2VuZChNZXNzYWdlczo6TmV0d29ya1NvY2tldENoYW5uZWw6OkNsb3NlIHsgMCwgeyB9IH0pOwog fQogCi12b2lkIFdlYlNvY2tldENoYW5uZWw6OmRpZENvbm5lY3QoY29uc3QgU3RyaW5nJiBzdWJw cm90b2NvbCkKK3ZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlkQ29ubmVjdChTdHJpbmcmJiBzdWJw cm90b2NvbCkKIHsKICAgICBpZiAobV9pc0Nsb3NpbmcpCiAgICAgICAgIHJldHVybjsKQEAgLTE3 MCwxNyArMTcwLDE3IEBAIHZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlkQ29ubmVjdChjb25zdCBT dHJpbmcmIHN1YnByb3RvY29sKQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAobV9pc1N1c3Bl bmRlZCkgewotICAgICAgICBlbnF1ZXVlVGFzayhbdGhpcywgc3VicHJvdG9jb2xdIHsKLSAgICAg ICAgICAgIGRpZENvbm5lY3Qoc3VicHJvdG9jb2wpOworICAgICAgICBlbnF1ZXVlVGFzayhbdGhp cywgc3VicHJvdG9jb2wgPSBXVEZNb3ZlKHN1YnByb3RvY29sKV0gKCkgbXV0YWJsZSB7CisgICAg ICAgICAgICBkaWRDb25uZWN0KFdURk1vdmUoc3VicHJvdG9jb2wpKTsKICAgICAgICAgfSk7CiAg ICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBtX3N1YnByb3RvY29sID0gc3VicHJvdG9jb2w7 CisgICAgbV9zdWJwcm90b2NvbCA9IFdURk1vdmUoc3VicHJvdG9jb2wpOwogICAgIG1fY2xpZW50 LT5kaWRDb25uZWN0KCk7CiB9CiAKLXZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlkUmVjZWl2ZVRl eHQoY29uc3QgU3RyaW5nJiBtZXNzYWdlKQordm9pZCBXZWJTb2NrZXRDaGFubmVsOjpkaWRSZWNl aXZlVGV4dChTdHJpbmcmJiBtZXNzYWdlKQogewogICAgIGlmIChtX2lzQ2xvc2luZykKICAgICAg ICAgcmV0dXJuOwpAQCAtMTg5LDggKzE4OSw4IEBAIHZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlk UmVjZWl2ZVRleHQoY29uc3QgU3RyaW5nJiBtZXNzYWdlKQogICAgICAgICByZXR1cm47CiAKICAg ICBpZiAobV9pc1N1c3BlbmRlZCkgewotICAgICAgICBlbnF1ZXVlVGFzayhbdGhpcywgbWVzc2Fn ZV0gewotICAgICAgICAgICAgZGlkUmVjZWl2ZVRleHQobWVzc2FnZSk7CisgICAgICAgIGVucXVl dWVUYXNrKFt0aGlzLCBtZXNzYWdlID0gV1RGTW92ZShtZXNzYWdlKV0gKCkgbXV0YWJsZSB7Cisg ICAgICAgICAgICBkaWRSZWNlaXZlVGV4dChXVEZNb3ZlKG1lc3NhZ2UpKTsKICAgICAgICAgfSk7 CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC0xOTgsNyArMTk4LDcgQEAgdm9pZCBXZWJTb2Nr ZXRDaGFubmVsOjpkaWRSZWNlaXZlVGV4dChjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCiAgICAgbV9j bGllbnQtPmRpZFJlY2VpdmVNZXNzYWdlKG1lc3NhZ2UpOwogfQogCi12b2lkIFdlYlNvY2tldENo YW5uZWw6OmRpZFJlY2VpdmVCaW5hcnlEYXRhKGNvbnN0IElQQzo6RGF0YVJlZmVyZW5jZSYgZGF0 YSkKK3ZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlkUmVjZWl2ZUJpbmFyeURhdGEoSVBDOjpEYXRh UmVmZXJlbmNlJiYgZGF0YSkKIHsKICAgICBpZiAobV9pc0Nsb3NpbmcpCiAgICAgICAgIHJldHVy bjsKQEAgLTIwNyw3ICsyMDcsNyBAQCB2b2lkIFdlYlNvY2tldENoYW5uZWw6OmRpZFJlY2VpdmVC aW5hcnlEYXRhKGNvbnN0IElQQzo6RGF0YVJlZmVyZW5jZSYgZGF0YSkKICAgICAgICAgcmV0dXJu OwogCiAgICAgaWYgKG1faXNTdXNwZW5kZWQpIHsKLSAgICAgICAgZW5xdWV1ZVRhc2soW3RoaXMs IGRhdGEgPSBkYXRhLnZlY3RvcigpXSgpIG11dGFibGUgeworICAgICAgICBlbnF1ZXVlVGFzayhb dGhpcywgZGF0YSA9IGRhdGEudmVjdG9yKCldICgpIG11dGFibGUgewogICAgICAgICAgICAgaWYg KCFtX2lzQ2xvc2luZyAmJiBtX2NsaWVudCkKICAgICAgICAgICAgICAgICBtX2NsaWVudC0+ZGlk UmVjZWl2ZUJpbmFyeURhdGEoV1RGTW92ZShkYXRhKSk7CiAgICAgICAgIH0pOwpAQCAtMjE2LDE0 ICsyMTYsMTQgQEAgdm9pZCBXZWJTb2NrZXRDaGFubmVsOjpkaWRSZWNlaXZlQmluYXJ5RGF0YShj b25zdCBJUEM6OkRhdGFSZWZlcmVuY2UmIGRhdGEpCiAgICAgbV9jbGllbnQtPmRpZFJlY2VpdmVC aW5hcnlEYXRhKGRhdGEudmVjdG9yKCkpOwogfQogCi12b2lkIFdlYlNvY2tldENoYW5uZWw6OmRp ZENsb3NlKHVuc2lnbmVkIHNob3J0IGNvZGUsIGNvbnN0IFN0cmluZyYgcmVhc29uKQordm9pZCBX ZWJTb2NrZXRDaGFubmVsOjpkaWRDbG9zZSh1bnNpZ25lZCBzaG9ydCBjb2RlLCBTdHJpbmcmJiBy ZWFzb24pCiB7CiAgICAgaWYgKCFtX2NsaWVudCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYg KG1faXNTdXNwZW5kZWQpIHsKLSAgICAgICAgZW5xdWV1ZVRhc2soW3RoaXMsIGNvZGUsIHJlYXNv bl0gewotICAgICAgICAgICAgZGlkQ2xvc2UoY29kZSwgcmVhc29uKTsKKyAgICAgICAgZW5xdWV1 ZVRhc2soW3RoaXMsIGNvZGUsIHJlYXNvbiA9IFdURk1vdmUocmVhc29uKV0gKCkgbXV0YWJsZSB7 CisgICAgICAgICAgICBkaWRDbG9zZShjb2RlLCBXVEZNb3ZlKHJlYXNvbikpOwogICAgICAgICB9 KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTIzNCwxNCArMjM0LDE0IEBAIHZvaWQgV2Vi U29ja2V0Q2hhbm5lbDo6ZGlkQ2xvc2UodW5zaWduZWQgc2hvcnQgY29kZSwgY29uc3QgU3RyaW5n JiByZWFzb24pCiAgICAgbV9jbGllbnQtPmRpZENsb3NlKG1fYnVmZmVyZWRBbW91bnQsIChtX2lz Q2xvc2luZyB8fCBjb2RlID09IFdlYkNvcmU6OldlYlNvY2tldENoYW5uZWw6OkNsb3NlRXZlbnRD b2RlTm9ybWFsQ2xvc3VyZSkgPyBXZWJDb3JlOjpXZWJTb2NrZXRDaGFubmVsQ2xpZW50OjpDbG9z aW5nSGFuZHNoYWtlQ29tcGxldGUgOiBXZWJDb3JlOjpXZWJTb2NrZXRDaGFubmVsQ2xpZW50OjpD bG9zaW5nSGFuZHNoYWtlSW5jb21wbGV0ZSwgY29kZSwgcmVhc29uKTsKIH0KIAotdm9pZCBXZWJT b2NrZXRDaGFubmVsOjpkaWRSZWNlaXZlTWVzc2FnZUVycm9yKGNvbnN0IFN0cmluZyYgZXJyb3JN ZXNzYWdlKQordm9pZCBXZWJTb2NrZXRDaGFubmVsOjpkaWRSZWNlaXZlTWVzc2FnZUVycm9yKFN0 cmluZyYmIGVycm9yTWVzc2FnZSkKIHsKICAgICBpZiAoIW1fY2xpZW50KQogICAgICAgICByZXR1 cm47CiAKICAgICBpZiAobV9pc1N1c3BlbmRlZCkgewotICAgICAgICBlbnF1ZXVlVGFzayhbdGhp cywgZXJyb3JNZXNzYWdlXSB7Ci0gICAgICAgICAgICBkaWRSZWNlaXZlTWVzc2FnZUVycm9yKGVy cm9yTWVzc2FnZSk7CisgICAgICAgIGVucXVldWVUYXNrKFt0aGlzLCBlcnJvck1lc3NhZ2UgPSBX VEZNb3ZlKGVycm9yTWVzc2FnZSldICgpIG11dGFibGUgeworICAgICAgICAgICAgZGlkUmVjZWl2 ZU1lc3NhZ2VFcnJvcihXVEZNb3ZlKGVycm9yTWVzc2FnZSkpOwogICAgICAgICB9KTsKICAgICAg ICAgcmV0dXJuOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9O ZXR3b3JrL1dlYlNvY2tldENoYW5uZWwuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3 b3JrL1dlYlNvY2tldENoYW5uZWwuaAppbmRleCAxYjRhNTUyODM1YS4uOTkzN2RmMTcyMjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlNvY2tldENoYW5u ZWwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9XZWJTb2NrZXRDaGFu bmVsLmgKQEAgLTczLDExICs3MywxMSBAQCBwcml2YXRlOgogICAgIHZvaWQgZGVyZWZUaHJlYWRh YmxlV2ViU29ja2V0Q2hhbm5lbCgpIGZpbmFsIHsgZGVyZWYoKTsgfQogCiAgICAgLy8gTWVzc2Fn ZSByZWNlaXZlcnMKLSAgICB2b2lkIGRpZENvbm5lY3QoY29uc3QgU3RyaW5nJik7Ci0gICAgdm9p ZCBkaWRSZWNlaXZlVGV4dChjb25zdCBTdHJpbmcmKTsKLSAgICB2b2lkIGRpZFJlY2VpdmVCaW5h cnlEYXRhKGNvbnN0IElQQzo6RGF0YVJlZmVyZW5jZSYpOwotICAgIHZvaWQgZGlkQ2xvc2UodW5z aWduZWQgc2hvcnQgY29kZSwgY29uc3QgU3RyaW5nJik7Ci0gICAgdm9pZCBkaWRSZWNlaXZlTWVz c2FnZUVycm9yKGNvbnN0IFN0cmluZyYpOworICAgIHZvaWQgZGlkQ29ubmVjdChTdHJpbmcmJik7 CisgICAgdm9pZCBkaWRSZWNlaXZlVGV4dChTdHJpbmcmJik7CisgICAgdm9pZCBkaWRSZWNlaXZl QmluYXJ5RGF0YShJUEM6OkRhdGFSZWZlcmVuY2UmJik7CisgICAgdm9pZCBkaWRDbG9zZSh1bnNp Z25lZCBzaG9ydCBjb2RlLCBTdHJpbmcmJik7CisgICAgdm9pZCBkaWRSZWNlaXZlTWVzc2FnZUVy cm9yKFN0cmluZyYmKTsKIAogICAgIC8vIE1lc3NhZ2VTZW5kZXIKICAgICBJUEM6OkNvbm5lY3Rp b24qIG1lc3NhZ2VTZW5kZXJDb25uZWN0aW9uKCkgY29uc3QgZmluYWw7Cg==