199243 2019-06-26 16:29:29 -0700 [iPadOS] Fix another crash in -[UIPreviewTarget initWithContainer:center:transform:] when generating a fallback targeted preview 2019-06-26 17:18:27 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue dino thorton webkit-bug-importer oldest_to_newest 1548197 0 wenson_hsieh 2019-06-26 16:29:29 -0700 <rdar://problem/51554509> 1548202 1 372965 wenson_hsieh 2019-06-26 16:31:59 -0700 Created attachment 372965 Patch 1548243 2 372965 commit-queue 2019-06-26 17:18:25 -0700 Comment on attachment 372965 Patch Clearing flags on attachment: 372965 Committed r246859: <https://trac.webkit.org/changeset/246859> 1548244 3 commit-queue 2019-06-26 17:18:27 -0700 All reviewed patches have been landed. Closing bug. 372965 2019-06-26 16:31:59 -0700 2019-06-26 17:18:25 -0700 Patch bug-199243-20190626163159.patch text/plain 3834 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM1ZGZkM2E1NDFlNDMwMjVm NDVkZGYwMjc4NDQxYjY3ZTIxYTcxZGYuLmExYjA1MGE1MmIyYzkyMDdjNDhmODNhOWZiMDk5M2Fk M2UzZDA5YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTktMDYtMjYgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lQYWRPU10gRml4IGFu b3RoZXIgY3Jhc2ggaW4gLVtVSVByZXZpZXdUYXJnZXQgaW5pdFdpdGhDb250YWluZXI6Y2VudGVy OnRyYW5zZm9ybTpdIHdoZW4gZ2VuZXJhdGluZyBhIGZhbGxiYWNrIHRhcmdldGVkIHByZXZpZXcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTI0Mwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE1NTQ1MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaXRpb25hbGx5IG1ha2UgY3JlYXRlRmFsbGJh Y2tUYXJnZXRlZFByZXZpZXcgcm9idXN0IGluIHRoZSBjYXNlIHdoZXJlIHRoZSBjb250ZW50IHZp ZXcgaXMgdW5wYXJlbnRlZCwgYW5kCisgICAgICAgIHJlbmFtZSBfZW5zdXJlVGFyZ2V0ZWRQcmV2 aWV3IHRvIF9jcmVhdGVUYXJnZXRlZFByZXZpZXdJZlBvc3NpYmxlLCB0byByZWZsZWN0IHRoZSBm YWN0IHRoYXQgaXQgbWF5IG5vdyByZXR1cm4KKyAgICAgICAgbmlsLgorCisgICAgICAgICogVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgIChjcmVhdGVU YXJnZXRlZFByZXZpZXcpOgorICAgICAgICAoY3JlYXRlRmFsbGJhY2tUYXJnZXRlZFByZXZpZXcp OgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9jcmVhdGVUYXJnZXRlZFByZXZpZXdJZlBvc3Np YmxlXSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgY29udGV4dE1lbnVJbnRlcmFjdGlvbjpw cmV2aWV3Rm9ySGlnaGxpZ2h0aW5nTWVudVdpdGhDb25maWd1cmF0aW9uOl0pOgorICAgICAgICAo LVtXS0NvbnRlbnRWaWV3IGNvbnRleHRNZW51SW50ZXJhY3Rpb246cHJldmlld0ZvckRpc21pc3Np bmdNZW51V2l0aENvbmZpZ3VyYXRpb246XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX2Vu c3VyZVRhcmdldGVkUHJldmlld10pOiBEZWxldGVkLgorCiAyMDE5LTA2LTI2ICBXZW5zb24gSHNp ZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtpUGFkT1NdIGVkZG0udXNw cy5jb20gc2Nyb2xscyBob3Jpem9udGFsbHkgZHVlIHRvIGV4cGxpY2l0IHdpZHRoIHNldCBpbiB2 aWV3cG9ydCBtZXRhIHRhZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9z L1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggMDZjY2U5Y2MzMzM5ODUzMjc1Mjcx YTM1MTkwMGM0M2U0ZjQ4ZGRiYy4uMTc3OWJiMWQyMDM1MjIyYjNhOWVkZGQwOTIwZTBiYzkzMDEx YmVjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC03OTIxLDYgKzc5MjEsOSBAQCBzdGF0aWMgUmV0YWlu UHRyPFVJVGFyZ2V0ZWRQcmV2aWV3PiBjcmVhdGVUYXJnZXRlZFByZXZpZXcoVUlJbWFnZSAqaW1h Z2UsIFVJVmlldwogCiBzdGF0aWMgUmV0YWluUHRyPFVJVGFyZ2V0ZWRQcmV2aWV3PiBjcmVhdGVG YWxsYmFja1RhcmdldGVkUHJldmlldyhVSVZpZXcgKnJvb3RWaWV3LCBVSVZpZXcgKmNvbnRhaW5l clZpZXcsIGNvbnN0IFdlYkNvcmU6OkZsb2F0UmVjdCYgZnJhbWVJblJvb3RWaWV3Q29vcmRpbmF0 ZXMpCiB7CisgICAgaWYgKCFjb250YWluZXJWaWV3LndpbmRvdykKKyAgICAgICAgcmV0dXJuIG5p bDsKKwogICAgIGF1dG8gcGFyYW1ldGVycyA9IGFkb3B0TlMoW1tVSVByZXZpZXdQYXJhbWV0ZXJz IGFsbG9jXSBpbml0XSk7CiAgICAgVUlWaWV3ICpzbmFwc2hvdFZpZXcgPSBbcm9vdFZpZXcgcmVz aXphYmxlU25hcHNob3RWaWV3RnJvbVJlY3Q6ZnJhbWVJblJvb3RWaWV3Q29vcmRpbmF0ZXMgYWZ0 ZXJTY3JlZW5VcGRhdGVzOk5PIHdpdGhDYXBJbnNldHM6VUlFZGdlSW5zZXRzWmVyb107CiAKQEAg LTc5MzMsNyArNzkzNiw3IEBAIHN0YXRpYyBSZXRhaW5QdHI8VUlUYXJnZXRlZFByZXZpZXc+IGNy ZWF0ZUZhbGxiYWNrVGFyZ2V0ZWRQcmV2aWV3KFVJVmlldyAqcm9vdFZpCiAgICAgcmV0dXJuIGFk b3B0TlMoW1tVSVRhcmdldGVkUHJldmlldyBhbGxvY10gaW5pdFdpdGhWaWV3OnNuYXBzaG90Vmll dyBwYXJhbWV0ZXJzOnBhcmFtZXRlcnMuZ2V0KCkgdGFyZ2V0OnRhcmdldC5nZXQoKV0pOwogfQog Ci0tIChVSVRhcmdldGVkUHJldmlldyAqKV9lbnN1cmVUYXJnZXRlZFByZXZpZXcKKy0gKFVJVGFy Z2V0ZWRQcmV2aWV3ICopX2NyZWF0ZVRhcmdldGVkUHJldmlld0lmUG9zc2libGUKIHsKICAgICBp ZiAoX2NvbnRleHRNZW51SW50ZXJhY3Rpb25UYXJnZXRlZFByZXZpZXcpCiAgICAgICAgIHJldHVy biBfY29udGV4dE1lbnVJbnRlcmFjdGlvblRhcmdldGVkUHJldmlldy5nZXQoKTsKQEAgLTc5NjAs NyArNzk2Myw3IEBAIC0gKFVJVGFyZ2V0ZWRQcmV2aWV3ICopX2Vuc3VyZVRhcmdldGVkUHJldmll dwogLSAoVUlUYXJnZXRlZFByZXZpZXcgKiljb250ZXh0TWVudUludGVyYWN0aW9uOihVSUNvbnRl eHRNZW51SW50ZXJhY3Rpb24gKilpbnRlcmFjdGlvbiBwcmV2aWV3Rm9ySGlnaGxpZ2h0aW5nTWVu dVdpdGhDb25maWd1cmF0aW9uOihVSUNvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3Vy YXRpb24KIHsKICAgICBbc2VsZiBfc3RhcnRTdXBwcmVzc2luZ1NlbGVjdGlvbkFzc2lzdGFudEZv clJlYXNvbjpXZWJLaXQ6OkludGVyYWN0aW9uSXNIYXBwZW5pbmddOwotICAgIHJldHVybiBbc2Vs ZiBfZW5zdXJlVGFyZ2V0ZWRQcmV2aWV3XTsKKyAgICByZXR1cm4gW3NlbGYgX2NyZWF0ZVRhcmdl dGVkUHJldmlld0lmUG9zc2libGVdOwogfQogCiAtICh2b2lkKWNvbnRleHRNZW51SW50ZXJhY3Rp b25XaWxsUHJlc2VudDooVUlDb250ZXh0TWVudUludGVyYWN0aW9uICopaW50ZXJhY3Rpb24KQEAg LTc5ODEsNyArNzk4NCw3IEBAIC0gKHZvaWQpY29udGV4dE1lbnVJbnRlcmFjdGlvbldpbGxQcmVz ZW50OihVSUNvbnRleHRNZW51SW50ZXJhY3Rpb24gKilpbnRlcmFjdGlvCiAKIC0gKFVJVGFyZ2V0 ZWRQcmV2aWV3ICopY29udGV4dE1lbnVJbnRlcmFjdGlvbjooVUlDb250ZXh0TWVudUludGVyYWN0 aW9uICopaW50ZXJhY3Rpb24gcHJldmlld0ZvckRpc21pc3NpbmdNZW51V2l0aENvbmZpZ3VyYXRp b246KFVJQ29udGV4dE1lbnVDb25maWd1cmF0aW9uICopY29uZmlndXJhdGlvbgogewotICAgIHJl dHVybiBbc2VsZiBfZW5zdXJlVGFyZ2V0ZWRQcmV2aWV3XTsKKyAgICByZXR1cm4gW3NlbGYgX2Ny ZWF0ZVRhcmdldGVkUHJldmlld0lmUG9zc2libGVdOwogfQogCiAtICh2b2lkKWNvbnRleHRNZW51 SW50ZXJhY3Rpb246KFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbiAqKWludGVyYWN0aW9uIHdpbGxD b21taXRXaXRoQW5pbWF0b3I6KGlkPFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbkNvbW1pdEFuaW1h dGluZz4pYW5pbWF0b3IK