<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>199240</bug_id>
          
          <creation_ts>2019-06-26 15:56:53 -0700</creation_ts>
          <short_desc>[ews-build] Add check for duplicate workers in config.json</short_desc>
          <delta_ts>2019-06-26 17:37:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1548156</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-06-26 15:56:53 -0700</bug_when>
    <thetext>Add check for duplicate workers in config.json. If someone accidentally adds a worker twice, loadConfig should be able to notice that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548160</commentid>
    <comment_count>1</comment_count>
      <attachid>372961</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-06-26 16:01:53 -0700</bug_when>
    <thetext>Created attachment 372961
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548263</commentid>
    <comment_count>2</comment_count>
      <attachid>372961</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-06-26 17:36:57 -0700</bug_when>
    <thetext>Comment on attachment 372961
Patch

Clearing flags on attachment: 372961

Committed r246862: &lt;https://trac.webkit.org/changeset/246862&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548264</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-06-26 17:36:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1548265</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-06-26 17:37:12 -0700</bug_when>
    <thetext>&lt;rdar://problem/52221465&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>372961</attachid>
            <date>2019-06-26 16:01:53 -0700</date>
            <delta_ts>2019-06-26 17:36:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199240-20190626190152.patch</filename>
            <type>text/plain</type>
            <size>2823</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI0Njg1MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE1IEBACisyMDE5LTA2LTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv
bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgY2hlY2sgZm9yIGR1cGxpY2F0ZSB3b3JrZXJz
IGluIGNvbmZpZy5qc29uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xOTkyNDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5OgorICAg
ICAgICAoY2hlY2tXb3JrZXJzQW5kQnVpbGRlcnNGb3JDb25zaXN0ZW5jeS5fZmluZF93b3JrZXJf
d2l0aF9uYW1lKTogQ2hlY2sgZm9yIGR1cGxpY2F0ZSB3b3JrZXIgZW50cnkuCisgICAgICAgICog
QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWdfdW5pdHRlc3QucHk6CisgICAg
ICAgIChUZXN0Y2hlY2tXb3JrZXJzQW5kQnVpbGRlcnNGb3JDb25zaXN0ZW5jeS50ZXN0X2R1cGxp
Y2F0ZV93b3JrZXIpOiBBZGRlZCB1bml0LXRlc3QuCisKIDIwMTktMDYtMjYgIFJvc3MgS2lyc2xp
bmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5dW01pbmlCcm93c2Vy
XSBSZW1vdmUgb2Jzb2xldGUgY29kZSBhZnRlciByMjQ2ODE0LgpJbmRleDogVG9vbHMvQnVpbGRT
bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHkKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv
QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHkJKHJldmlzaW9uIDI0Njg1
MCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5CSh3
b3JraW5nIGNvcHkpCkBAIC0xNTAsMTAgKzE1MCwxNCBAQCBkZWYgaXNUcmlnZ2VyVXNlZEJ5QW55
QnVpbGRlcihjb25maWcsIHRyCiAKIGRlZiBjaGVja1dvcmtlcnNBbmRCdWlsZGVyc0ZvckNvbnNp
c3RlbmN5KGNvbmZpZywgd29ya2VycywgYnVpbGRlcnMpOgogICAgIGRlZiBfZmluZF93b3JrZXJf
d2l0aF9uYW1lKHdvcmtlcnMsIHdvcmtlcl9uYW1lKToKKyAgICAgICAgcmVzdWx0ID0gTm9uZQog
ICAgICAgICBmb3Igd29ya2VyIGluIHdvcmtlcnM6CiAgICAgICAgICAgICBpZiB3b3JrZXJbJ25h
bWUnXSA9PSB3b3JrZXJfbmFtZToKLSAgICAgICAgICAgICAgICByZXR1cm4gd29ya2VyCi0gICAg
ICAgIHJldHVybiBOb25lCisgICAgICAgICAgICAgICAgaWYgbm90IHJlc3VsdDoKKyAgICAgICAg
ICAgICAgICAgICAgcmVzdWx0ID0gd29ya2VyCisgICAgICAgICAgICAgICAgZWxzZToKKyAgICAg
ICAgICAgICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCdEdXBsaWNhdGUgd29ya2VyIGVudHJ5IGZv
dW5kIGZvciB7fS4nLmZvcm1hdCh3b3JrZXJbJ25hbWUnXSkpCisgICAgICAgIHJldHVybiByZXN1
bHQKIAogICAgIGZvciB3b3JrZXIgaW4gd29ya2VyczoKICAgICAgICAgY2hlY2tWYWxpZFdvcmtl
cih3b3JrZXIpCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENv
bmZpZ191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l
d3MtYnVpbGQvbG9hZENvbmZpZ191bml0dGVzdC5weQkocmV2aXNpb24gMjQ2ODUwKQorKysgVG9v
bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWdfdW5pdHRlc3QucHkJKHdv
cmtpbmcgY29weSkKQEAgLTE2NCw2ICsxNjQsMTEgQEAgY2xhc3MgVGVzdGNoZWNrV29ya2Vyc0Fu
ZEJ1aWxkZXJzRm9yQ29ucwogICAgICAgICAgICAgbG9hZENvbmZpZy5jaGVja1dvcmtlcnNBbmRC
dWlsZGVyc0ZvckNvbnNpc3RlbmN5KHt9LCBbc2VsZi5ld3MxMDEsIHNlbGYuZXdzMTAyXSwgW3Nl
bGYuV0syQnVpbGRlcl0pCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoY29udGV4dC5leGNlcHRp
b24uYXJncywgKCdCdWlsZGVyIG1hY09TLUhpZ2gtU2llcnJhLVdLMi1FV1MgaXMgZm9yIHBsYXRm
b3JtIG1hYy1zaWVycmEsIGJ1dCBoYXMgd29ya2VyIGV3czEwMiBmb3IgcGxhdGZvcm0gaW9zLTEx
IScsKSkKIAorICAgIGRlZiB0ZXN0X2R1cGxpY2F0ZV93b3JrZXIoc2VsZik6CisgICAgICAgIHdp
dGggc2VsZi5hc3NlcnRSYWlzZXMoRXhjZXB0aW9uKSBhcyBjb250ZXh0OgorICAgICAgICAgICAg
bG9hZENvbmZpZy5jaGVja1dvcmtlcnNBbmRCdWlsZGVyc0ZvckNvbnNpc3RlbmN5KHt9LCBbc2Vs
Zi5ld3MxMDEsIHNlbGYuZXdzMTAxXSwgW3NlbGYuV0syQnVpbGRlcl0pCisgICAgICAgIHNlbGYu
YXNzZXJ0RXF1YWwoY29udGV4dC5leGNlcHRpb24uYXJncywgKCdEdXBsaWNhdGUgd29ya2VyIGVu
dHJ5IGZvdW5kIGZvciBld3MxMDEuJywpKQorCiAgICAgZGVmIHRlc3Rfc3VjY2VzcyhzZWxmKToK
ICAgICAgICAgbG9hZENvbmZpZy5jaGVja1dvcmtlcnNBbmRCdWlsZGVyc0ZvckNvbnNpc3RlbmN5
KHt9LCBbc2VsZi5ld3MxMDEsIHsnbmFtZSc6ICdld3MxMDInLCAncGxhdGZvcm0nOiAnbWFjLXNp
ZXJyYSd9XSwgW3NlbGYuV0syQnVpbGRlcl0pCiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>