199238 2019-06-26 15:49:00 -0700 [ews-build] Update bot configuration for WPE and GTK 2019-07-02 23:46:17 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199234 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain aperez ap clopez commit-queue ews-feeder jbedard mcatanzaro psaavedra webkit-bug-importer oldest_to_newest 1548151 0 aakash_jain 2019-06-26 15:49:00 -0700 Update bot configuration for WPE and GTK (to add new bots to the configuration). 1548153 1 372959 aakash_jain 2019-06-26 15:51:40 -0700 Created attachment 372959 Patch 1548154 2 aakash_jain 2019-06-26 15:52:37 -0700 These bots were recently active on old EWS. Please let me know if any other bots need to be added to GTK, WPE queues. 1549550 3 aakash_jain 2019-07-02 07:02:59 -0700 ping igalia reviewers. 1549551 4 372959 aperez 2019-07-02 07:19:54 -0700 Comment on attachment 372959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372959&action=review Reviewing informally: changes LGTM, with a nit about the bot identifiers which have the compiler version in them—it seems better to rename them. I'll try and ping our reviewers to get this rubber-stamped. > Tools/BuildSlaveSupport/ews-build/config.json:24 > + "name": "aperez-gtk-gcc7-ews", This could be just “aperez-gtk-ews”. > Tools/BuildSlaveSupport/ews-build/config.json:48 > + "name": "aperez-wpe-gcc7-ews", Same, this could be “aperez-wpe-ews”. > Tools/BuildSlaveSupport/ews-build/config.json:410 > + "workernames": ["igalia-wpe-ews", "aperez-wpe-gcc5-ews", "aperez-wpe-gcc6-ews", "aperez-wpe-gcc7-ews"] Here you could remove “aperez-wpe-gcc5-ews” and “aperez-wpe-gcc6-ews”. I used to change the bot identifier with each bump to the compiler version to make it clearer which version of GCC it was running. Probably it's better to replace “aperez-wpe-gcc7-ews” with a plain “aperez-wpe-ews”, because CMake prints anyway the version of the compiler during the configuration. 1549554 5 373320 aakash_jain 2019-07-02 07:37:23 -0700 Created attachment 373320 Patch 1549555 6 aakash_jain 2019-07-02 07:38:02 -0700 (In reply to Adrian Perez from comment #4) > Reviewing informally: changes LGTM, with a nit about the bot identifiers which have the compiler version in them—it seems better to rename them. Renamed. 1549556 7 373320 clopez 2019-07-02 07:42:36 -0700 Comment on attachment 373320 Patch Looks good. Thanks! 1549567 8 373320 ews-feeder 2019-07-02 08:02:07 -0700 Comment on attachment 373320 Patch Rejecting attachment 373320 from review queue. clopez@igalia.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 1549568 9 clopez 2019-07-02 08:13:46 -0700 (In reply to ews-feeder from comment #8) > Comment on attachment 373320 [details] > Patch > > Rejecting attachment 373320 [details] from review queue. > > clopez@igalia.com does not have reviewer permissions according to > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > contributors.json. > > - If you do not have reviewer rights please read > http://webkit.org/coding/contributing.html for instructions on how to use > bugzilla flags. > > - If you have reviewer rights please correct the error in > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to > the file (no review needed). The commit-queue restarts itself every 2 > hours. After restart the commit-queue will correctly respect your reviewer > rights. mmmm.. it looks somehow i lost my status at https://trac.webkit.org/changeset/24470 1549569 10 clopez 2019-07-02 08:14:24 -0700 (In reply to Carlos Alberto Lopez Perez from comment #9) > (In reply to ews-feeder from comment #8) > > Comment on attachment 373320 [details] > > Patch > > > > Rejecting attachment 373320 [details] from review queue. > > > > clopez@igalia.com does not have reviewer permissions according to > > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > > contributors.json. > > > > - If you do not have reviewer rights please read > > http://webkit.org/coding/contributing.html for instructions on how to use > > bugzilla flags. > > > > - If you have reviewer rights please correct the error in > > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to > > the file (no review needed). The commit-queue restarts itself every 2 > > hours. After restart the commit-queue will correctly respect your reviewer > > rights. > > mmmm.. it looks somehow i lost my status at > https://trac.webkit.org/changeset/24470 I mean https://trac.webkit.org/changeset/244705 1549584 11 373320 commit-queue 2019-07-02 09:00:11 -0700 Comment on attachment 373320 Patch Clearing flags on attachment: 373320 Committed r247051: <https://trac.webkit.org/changeset/247051> 1549585 12 commit-queue 2019-07-02 09:00:13 -0700 All reviewed patches have been landed. Closing bug. 1549588 13 webkit-bug-importer 2019-07-02 09:03:59 -0700 <rdar://problem/52526177> 1549846 14 ap 2019-07-02 23:46:17 -0700 > mmmm.. it looks somehow i lost my status at Following up via e-mail. 372959 2019-06-26 15:51:40 -0700 2019-07-02 07:37:20 -0700 Patch bug-199238-20190626185139.patch text/plain 2294 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Njg1MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTA2LTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBVcGRhdGUgYm90IGNvbmZpZ3VyYXRpb24gZm9yIFdQ RSBhbmQgR1RLCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTkyMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9jb25maWcuanNvbjoKKwogMjAxOS0wNi0y NiAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgW1dp bl1bTWluaUJyb3dzZXJdIFJlbW92ZSBvYnNvbGV0ZSBjb2RlIGFmdGVyIHIyNDY4MTQuCkluZGV4 OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvY29uZmlnLmpzb24KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2NvbmZpZy5qc29uCShyZXZp c2lvbiAyNDY4NTApCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvY29uZmln Lmpzb24JKHdvcmtpbmcgY29weSkKQEAgLTUsNiArNSwyNiBAQAogICAgICAgInBsYXRmb3JtIjog IioiCiAgICAgfSwKICAgICB7CisgICAgICAibmFtZSI6ICJpZ2FsaWExLWd0ay13azItZXdzIiwK KyAgICAgICJwbGF0Zm9ybSI6ICJndGsiCisgICAgfSwKKyAgICB7CisgICAgICAibmFtZSI6ICJp Z2FsaWEyLWd0ay13azItZXdzIiwKKyAgICAgICJwbGF0Zm9ybSI6ICJndGsiCisgICAgfSwKKyAg ICB7CisgICAgICAibmFtZSI6ICJpZ2FsaWEzLWd0ay13azItZXdzIiwKKyAgICAgICJwbGF0Zm9y bSI6ICJndGsiCisgICAgfSwKKyAgICB7CisgICAgICAibmFtZSI6ICJpZ2FsaWE0LWd0ay13azIt ZXdzIiwKKyAgICAgICJwbGF0Zm9ybSI6ICJndGsiCisgICAgfSwKKyAgICB7CisgICAgICAibmFt ZSI6ICJhcGVyZXotZ3RrLWdjYzctZXdzIiwKKyAgICAgICJwbGF0Zm9ybSI6ICJndGsiCisgICAg fSwKKyAgICB7CiAgICAgICAibmFtZSI6ICJ0YW50eS1ndGstd2syLWV3cyIsCiAgICAgICAicGxh dGZvcm0iOiAiZ3RrIgogICAgIH0sCkBAIC0yNSw2ICs0NSwxMCBAQAogICAgICAgInBsYXRmb3Jt IjogIndwZSIKICAgICB9LAogICAgIHsKKyAgICAgICJuYW1lIjogImFwZXJlei13cGUtZ2NjNy1l d3MiLAorICAgICAgInBsYXRmb3JtIjogIndwZSIKKyAgICB9LAorICAgIHsKICAgICAgICJuYW1l IjogIndpbmNhaXJvLWV3cy0wMDEiLAogICAgICAgInBsYXRmb3JtIjogIndpbmNhaXJvIgogICAg IH0sCkBAIC0yODMsNyArMzA3LDcgQEAKICAgICAgICJzaG9ydG5hbWUiOiAiZ3RrIiwKICAgICAg ICJmYWN0b3J5IjogIkdUS0ZhY3RvcnkiLAogICAgICAgInBsYXRmb3JtIjogImd0ayIsCi0gICAg ICAid29ya2VybmFtZXMiOiBbInRhbnR5LWd0ay13azItZXdzIiwgImx0aWx2ZS1ndGstd2syLWV3 cyJdCisgICAgICAid29ya2VybmFtZXMiOiBbImlnYWxpYTEtZ3RrLXdrMi1ld3MiLCAiaWdhbGlh Mi1ndGstd2syLWV3cyIsICJpZ2FsaWEzLWd0ay13azItZXdzIiwgImlnYWxpYTQtZ3RrLXdrMi1l d3MiLCAiYXBlcmV6LWd0ay1nY2M3LWV3cyIsICJ0YW50eS1ndGstd2syLWV3cyIsICJsdGlsdmUt Z3RrLXdrMi1ld3MiXQogICAgIH0sCiAgICAgewogICAgICAgIm5hbWUiOiAiaU9TLTEyLUJ1aWxk LUVXUyIsCkBAIC0zODMsNyArNDA3LDcgQEAKICAgICAgICJzaG9ydG5hbWUiOiAid3BlIiwKICAg ICAgICJmYWN0b3J5IjogIldQRUZhY3RvcnkiLAogICAgICAgInBsYXRmb3JtIjogIndwZSIsCi0g ICAgICAid29ya2VybmFtZXMiOiBbImlnYWxpYS13cGUtZXdzIiwgImFwZXJlei13cGUtZ2NjNS1l d3MiLCAiYXBlcmV6LXdwZS1nY2M2LWV3cyJdCisgICAgICAid29ya2VybmFtZXMiOiBbImlnYWxp YS13cGUtZXdzIiwgImFwZXJlei13cGUtZ2NjNS1ld3MiLCAiYXBlcmV6LXdwZS1nY2M2LWV3cyIs ICJhcGVyZXotd3BlLWdjYzctZXdzIl0KICAgICB9LAogICAgIHsKICAgICAgICJuYW1lIjogIkpT Qy1UZXN0cy1FV1MiLAo= 373320 2019-07-02 07:37:23 -0700 2019-07-02 09:00:11 -0700 Patch bug-199238-20190702103722.patch text/plain 2291 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NzA0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTA3LTAyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBVcGRhdGUgYm90IGNvbmZpZ3VyYXRpb24gZm9yIFdQ RSBhbmQgR1RLCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTkyMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9jb25maWcuanNvbjoKKwogMjAxOS0wNy0w MSAgSnVzdGluIE1pY2hhdWQgIDxqdXN0aW5fbWljaGF1ZEBhcHBsZS5jb20+CiAKICAgICAgICAg W1dhc20tUmVmZXJlbmNlc10gRGlzYWJsZSByZWZlcmVuY2VzIGJ5IGRlZmF1bHQKSW5kZXg6IFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9jb25maWcuanNvbgo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvY29uZmlnLmpzb24JKHJldmlzaW9u IDI0NzA0OCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9jb25maWcuanNv bgkod29ya2luZyBjb3B5KQpAQCAtNSw2ICs1LDI2IEBACiAgICAgICAicGxhdGZvcm0iOiAiKiIK ICAgICB9LAogICAgIHsKKyAgICAgICJuYW1lIjogImlnYWxpYTEtZ3RrLXdrMi1ld3MiLAorICAg ICAgInBsYXRmb3JtIjogImd0ayIKKyAgICB9LAorICAgIHsKKyAgICAgICJuYW1lIjogImlnYWxp YTItZ3RrLXdrMi1ld3MiLAorICAgICAgInBsYXRmb3JtIjogImd0ayIKKyAgICB9LAorICAgIHsK KyAgICAgICJuYW1lIjogImlnYWxpYTMtZ3RrLXdrMi1ld3MiLAorICAgICAgInBsYXRmb3JtIjog Imd0ayIKKyAgICB9LAorICAgIHsKKyAgICAgICJuYW1lIjogImlnYWxpYTQtZ3RrLXdrMi1ld3Mi LAorICAgICAgInBsYXRmb3JtIjogImd0ayIKKyAgICB9LAorICAgIHsKKyAgICAgICJuYW1lIjog ImFwZXJlei1ndGstZXdzIiwKKyAgICAgICJwbGF0Zm9ybSI6ICJndGsiCisgICAgfSwKKyAgICB7 CiAgICAgICAibmFtZSI6ICJ0YW50eS1ndGstd2syLWV3cyIsCiAgICAgICAicGxhdGZvcm0iOiAi Z3RrIgogICAgIH0sCkBAIC0xNywxMSArMzcsNyBAQAogICAgICAgInBsYXRmb3JtIjogIndwZSIK ICAgICB9LAogICAgIHsKLSAgICAgICJuYW1lIjogImFwZXJlei13cGUtZ2NjNS1ld3MiLAotICAg ICAgInBsYXRmb3JtIjogIndwZSIKLSAgICB9LAotICAgIHsKLSAgICAgICJuYW1lIjogImFwZXJl ei13cGUtZ2NjNi1ld3MiLAorICAgICAgIm5hbWUiOiAiYXBlcmV6LXdwZS1ld3MiLAogICAgICAg InBsYXRmb3JtIjogIndwZSIKICAgICB9LAogICAgIHsKQEAgLTI4NSw3ICszMDEsNyBAQAogICAg ICAgInBsYXRmb3JtIjogImd0ayIsCiAgICAgICAiY29uZmlndXJhdGlvbiI6ICJyZWxlYXNlIiwK ICAgICAgICJhcmNoaXRlY3R1cmVzIjogWyJ4ODZfNjQiXSwKLSAgICAgICJ3b3JrZXJuYW1lcyI6 IFsidGFudHktZ3RrLXdrMi1ld3MiLCAibHRpbHZlLWd0ay13azItZXdzIl0KKyAgICAgICJ3b3Jr ZXJuYW1lcyI6IFsiaWdhbGlhMS1ndGstd2syLWV3cyIsICJpZ2FsaWEyLWd0ay13azItZXdzIiwg ImlnYWxpYTMtZ3RrLXdrMi1ld3MiLCAiaWdhbGlhNC1ndGstd2syLWV3cyIsICJhcGVyZXotZ3Rr LWV3cyIsICJ0YW50eS1ndGstd2syLWV3cyIsICJsdGlsdmUtZ3RrLXdrMi1ld3MiXQogICAgIH0s CiAgICAgewogICAgICAgIm5hbWUiOiAiaU9TLTEyLUJ1aWxkLUVXUyIsCkBAIC0zODcsNyArNDAz LDcgQEAKICAgICAgICJwbGF0Zm9ybSI6ICJ3cGUiLAogICAgICAgImNvbmZpZ3VyYXRpb24iOiAi cmVsZWFzZSIsCiAgICAgICAiYXJjaGl0ZWN0dXJlcyI6IFsieDg2XzY0Il0sCi0gICAgICAid29y a2VybmFtZXMiOiBbImlnYWxpYS13cGUtZXdzIiwgImFwZXJlei13cGUtZ2NjNS1ld3MiLCAiYXBl cmV6LXdwZS1nY2M2LWV3cyJdCisgICAgICAid29ya2VybmFtZXMiOiBbImlnYWxpYS13cGUtZXdz IiwgImFwZXJlei13cGUtZXdzIl0KICAgICB9LAogICAgIHsKICAgICAgICJuYW1lIjogIkpTQy1U ZXN0cy1FV1MiLAo=