199233 2019-06-26 13:45:32 -0700 [Win][MiniBrowser] Remove obsolete code after r246814. 2019-06-26 16:48:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling commit-queue fujii webkit-bug-importer oldest_to_newest 1548107 0 ross.kirsling 2019-06-26 13:45:32 -0700 [Win][MiniBrowser] Remove obsolete code after r246814. 1548108 1 372946 ross.kirsling 2019-06-26 13:45:47 -0700 Created attachment 372946 Patch 1548110 2 ross.kirsling 2019-06-26 13:46:47 -0700 Addresses bug 199201 comment 9. I was going to just land this but I wanted to confirm with you that this is everything. 1548129 3 372946 fujii 2019-06-26 14:39:03 -0700 Comment on attachment 372946 Patch Thank you for working on this. 1548139 4 372946 commit-queue 2019-06-26 15:11:13 -0700 Comment on attachment 372946 Patch Clearing flags on attachment: 372946 Committed r246848: <https://trac.webkit.org/changeset/246848> 1548140 5 commit-queue 2019-06-26 15:11:14 -0700 All reviewed patches have been landed. Closing bug. 1548221 6 webkit-bug-importer 2019-06-26 16:48:16 -0700 <rdar://problem/52218908> 1548222 7 webkit-bug-importer 2019-06-26 16:48:20 -0700 <rdar://problem/52218915> 372946 2019-06-26 13:45:47 -0700 2019-06-26 15:11:13 -0700 Patch bug-199233-20190626134544.patch text/plain 3668 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDllZTM3MDM5YTYyMDA5ODczZTEwNjQxZmQ2YmM1NjY3 ZmIyNjM3NC4uZTM1Y2UyNjM5NTU2NDMwNmEzMzYzZTgzNDI2NzQzYWFhMzFmNGJlMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTA2LTI2ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBbV2luXVtNaW5pQnJvd3Nlcl0gUmVtb3ZlIG9ic29sZXRlIGNvZGUgYWZ0ZXIg cjI0NjgxNC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5OTIzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogTWluaUJyb3dzZXIvd2luL01pbmlCcm93c2VyV2ViSG9zdC5jcHA6CisgICAgICAgIChNaW5p QnJvd3NlcldlYkhvc3Q6OmRpZEZpbmlzaExvYWRGb3JGcmFtZSk6CisgICAgICAgIChTaW1wbGVF dmVudExpc3RlbmVyOjpTaW1wbGVFdmVudExpc3RlbmVyKTogRGVsZXRlZC4KKyAgICAgICAgKFNp bXBsZUV2ZW50TGlzdGVuZXI6OmhhbmRsZUV2ZW50KTogRGVsZXRlZC4KKwogMjAxOS0wNi0yNSAg Smlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBh IG5ldyBTUEkgdG8gaW5mb3JtIGNsaWVudHMgYWJvdXQgQXBwU1NPCmRpZmYgLS1naXQgYS9Ub29s cy9NaW5pQnJvd3Nlci93aW4vTWluaUJyb3dzZXJXZWJIb3N0LmNwcCBiL1Rvb2xzL01pbmlCcm93 c2VyL3dpbi9NaW5pQnJvd3NlcldlYkhvc3QuY3BwCmluZGV4IGE2MDRiOGNlMTJmOWE3OTFkOGVm YTYwOWVlN2E0OGM2YmEzZDJlMjYuLmNmYzU0ZDUzNmM3MDU3ZTAyOWU5NzU0ZWU1NzI1ZjRiMDAz NGZiNTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9NaW5pQnJvd3NlcldlYkhv c3QuY3BwCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9NaW5pQnJvd3NlcldlYkhvc3QuY3Bw CkBAIC0yOSwzMiArMjksMTAgQEAKICNpbmNsdWRlICJzdGRhZnguaCIKICNpbmNsdWRlICJNaW5p QnJvd3NlcldlYkhvc3QuaCIKIAotI2luY2x1ZGUgIkRPTURlZmF1bHRJbXBsLmgiCiAjaW5jbHVk ZSAiUGFnZUxvYWRUZXN0Q2xpZW50LmgiCiAjaW5jbHVkZSAiV2ViS2l0TGVnYWN5QnJvd3Nlcldp bmRvdy5oIgogI2luY2x1ZGUgPFdlYktpdExlZ2FjeS9XZWJLaXQuaD4KIAotY2xhc3MgU2ltcGxl RXZlbnRMaXN0ZW5lciA6IHB1YmxpYyBET01FdmVudExpc3RlbmVyIHsKLXB1YmxpYzoKLSAgICBT aW1wbGVFdmVudExpc3RlbmVyKExQV1NUUiB0eXBlKQotICAgIHsKLSAgICAgICAgd2NzbmNweV9z KG1fZXZlbnRUeXBlLCAxMDAsIHR5cGUsIDEwMCk7Ci0gICAgICAgIG1fZXZlbnRUeXBlWzk5XSA9 IDA7Ci0gICAgfQotCi0gICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIGhhbmRs ZUV2ZW50KElET01FdmVudCogZXZ0KQotICAgIHsKLSAgICAgICAgd2NoYXJfdCBtZXNzYWdlWzI1 NV07Ci0gICAgICAgIHdjc2NweV9zKG1lc3NhZ2UsIDI1NSwgbV9ldmVudFR5cGUpOwotICAgICAg ICB3Y3NjYXRfcyhtZXNzYWdlLCAyNTUsIEwiIGV2ZW50IGZpcmVkISIpOwotICAgICAgICA6Ok1l c3NhZ2VCb3goMCwgbWVzc2FnZSwgTCJFdmVudCBIYW5kbGVyIiwgTUJfT0spOwotICAgICAgICBy ZXR1cm4gU19PSzsKLSAgICB9Ci0KLXByaXZhdGU6Ci0gICAgd2NoYXJfdCBtX2V2ZW50VHlwZVsx MDBdOwotfTsKLQogdHlwZWRlZiBfY29tX3B0cl90PF9jb21fSUlJRDxJV2ViRGF0YVNvdXJjZSwg Jl9fdXVpZG9mKElXZWJEYXRhU291cmNlKT4+IElXZWJEYXRhU291cmNlUHRyOwogdHlwZWRlZiBf Y29tX3B0cl90PF9jb21fSUlJRDxJV2ViTXV0YWJsZVVSTFJlcXVlc3QsICZfX3V1aWRvZihJV2Vi TXV0YWJsZVVSTFJlcXVlc3QpPj4gSVdlYk11dGFibGVVUkxSZXF1ZXN0UHRyOwogCkBAIC0xMzgs OSArMTE2LDYgQEAgVUxPTkcgTWluaUJyb3dzZXJXZWJIb3N0OjpSZWxlYXNlKCkKICAgICByZXR1 cm4gbV9jbGllbnQtPlJlbGVhc2UoKTsKIH0KIAotdHlwZWRlZiBfY29tX3B0cl90PF9jb21fSUlJ RDxJRE9NRG9jdW1lbnQsICZfX3V1aWRvZihJRE9NRG9jdW1lbnQpPj4gSURPTURvY3VtZW50UHRy OwotdHlwZWRlZiBfY29tX3B0cl90PF9jb21fSUlJRDxJRE9NRWxlbWVudCwgJl9fdXVpZG9mKElE T01FbGVtZW50KT4+IElET01FbGVtZW50UHRyOwotdHlwZWRlZiBfY29tX3B0cl90PF9jb21fSUlJ RDxJRE9NRXZlbnRUYXJnZXQsICZfX3V1aWRvZihJRE9NRXZlbnRUYXJnZXQpPj4gSURPTUV2ZW50 VGFyZ2V0UHRyOwogdHlwZWRlZiBfY29tX3B0cl90PF9jb21fSUlJRDxJV2ViRnJhbWUyLCAmX191 dWlkb2YoSVdlYkZyYW1lMik+PiBJV2ViRnJhbWUyUHRyOwogCiBIUkVTVUxUIE1pbmlCcm93c2Vy V2ViSG9zdDo6ZGlkRmluaXNoTG9hZEZvckZyYW1lKF9Jbl9vcHRfIElXZWJWaWV3KiB3ZWJWaWV3 LCBfSW5fb3B0XyBJV2ViRnJhbWUqIGZyYW1lKQpAQCAtMTU3LDMyICsxMzIsMTAgQEAgSFJFU1VM VCBNaW5pQnJvd3NlcldlYkhvc3Q6OmRpZEZpbmlzaExvYWRGb3JGcmFtZShfSW5fb3B0XyBJV2Vi Vmlldyogd2ViVmlldywgX0kKICAgICAgICAgfQogICAgIH0KIAotICAgIElET01Eb2N1bWVudFB0 ciBkb2M7Ci0gICAgZnJhbWUtPkRPTURvY3VtZW50KCZkb2MuR2V0SW50ZXJmYWNlUHRyKCkpOwot Ci0gICAgSURPTUVsZW1lbnRQdHIgZWxlbWVudDsKLSAgICBJRE9NRXZlbnRUYXJnZXRQdHIgdGFy Z2V0OwotCiAgICAgaWYgKG1fY2xpZW50KQogICAgICAgICBtX2NsaWVudC0+c2hvd0xhc3RWaXNp dGVkU2l0ZXMoKndlYlZpZXcpOwogCi0gICAgLy8gVGhlIGZvbGxvd2luZyBpcyBmb3IgdGhlIHRl c3QgcGFnZToKLSAgICBzdGF0aWMgX2JzdHJfdCBpZCA9IEwid2Via2l0IGxvZ28iOwotICAgIEhS RVNVTFQgaHIgPSBkb2MtPmdldEVsZW1lbnRCeUlkKGlkLCAmZWxlbWVudC5HZXRJbnRlcmZhY2VQ dHIoKSk7Ci0gICAgaWYgKCFTVUNDRUVERUQoaHIpKQotICAgICAgICByZXR1cm4gaHI7Ci0KLSAg ICBociA9IGVsZW1lbnQtPlF1ZXJ5SW50ZXJmYWNlKElJRF9JRE9NRXZlbnRUYXJnZXQsIHJlaW50 ZXJwcmV0X2Nhc3Q8dm9pZCoqPigmdGFyZ2V0LkdldEludGVyZmFjZVB0cigpKSk7Ci0gICAgaWYg KCFTVUNDRUVERUQoaHIpKQotICAgICAgICByZXR1cm4gaHI7Ci0KLSAgICBzdGF0aWMgX2JzdHJf dCBldmVudE5hbWUgPSBMImNsaWNrIjsKLSAgICBzdGF0aWMgX2JzdHJfdCBldmVudFR5cGUgPSBM IndlYmtpdCBsb2dvIGNsaWNrIjsKLSAgICBociA9IHRhcmdldC0+YWRkRXZlbnRMaXN0ZW5lcihl dmVudE5hbWUsIG5ldyBTaW1wbGVFdmVudExpc3RlbmVyKGV2ZW50VHlwZSksIEZBTFNFKTsKLSAg ICBpZiAoIVNVQ0NFRURFRChocikpCi0gICAgICAgIHJldHVybiBocjsKLQotICAgIHJldHVybiBo cjsKKyAgICByZXR1cm4gU19PSzsKIH0KIAogSFJFU1VMVCBNaW5pQnJvd3NlcldlYkhvc3Q6OmRp ZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUoX0luX29wdF8gSVdlYlZpZXcqLCBfSW5fb3B0 XyBJV2ViRnJhbWUqIGZyYW1lKQo=