199231 2019-06-26 13:27:28 -0700 speciesConstruct needs to throw if the result is a DataView 2019-06-26 16:07:35 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1548099 0 keith_miller 2019-06-26 13:27:28 -0700 speciesConstruct needs to throw if the result is a DataView 1548102 1 372944 keith_miller 2019-06-26 13:31:26 -0700 Created attachment 372944 Patch 1548103 2 keith_miller 2019-06-26 13:32:06 -0700 <rdar://problem/52152122> 1548104 3 372944 mark.lam 2019-06-26 13:36:18 -0700 Comment on attachment 372944 Patch r=me 1548162 4 372944 commit-queue 2019-06-26 16:07:33 -0700 Comment on attachment 372944 Patch Clearing flags on attachment: 372944 Committed r246851: <https://trac.webkit.org/changeset/246851> 1548163 5 commit-queue 2019-06-26 16:07:35 -0700 All reviewed patches have been landed. Closing bug. 372944 2019-06-26 13:31:26 -0700 2019-06-26 16:07:33 -0700 Patch bug-199231-20190626133125.patch text/plain 6898 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj OTc0ZWVkYzE2MDEzMWRiOTRmNDI3YzE4ZGFjNzI5MWZmM2MyOGUyLi4xNmI5ZGEzNDBiZjZlYTIy ODNlNjRlMzRkZDU2YWIzNzc0ZTFmMjU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wNi0yNiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBzcGVjaWVzQ29uc3RydWN0IG5lZWRzIHRvIHRocm93IGlmIHRoZSBy ZXN1bHQgaXMgYSBEYXRhVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk5MjMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUHJldmlvdXNseSwgd2Ugb25seSBjaGVja2VkIHRoYXQgdGhlIHJlc3VsdCB3 YXMgYQorICAgICAgICBKU0FycmF5QnVmZmVyVmlldywgd2hpY2ggY2FuIGluY2x1ZGUgRGF0YVZp ZXdzLiBUaGlzIGlzIGluY29ycmVjdAorICAgICAgICBhcyB0aGUgcmVzdWx0IHNob3VsZCBiZSBv bmx5IGJlIGEgVHlwZWRBcnJheS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNHZW5lcmljVHlwZWRB cnJheVZpZXdQcm90b3R5cGVGdW5jdGlvbnMuaDoKKyAgICAgICAgKEpTQzo6c3BlY2llc0NvbnN0 cnVjdCk6CisKIDIwMTktMDYtMjYgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5j b20+CiAKICAgICAgICAgcmVtb3ZlIHVubmVlZGVkIGRpZEJlY29tZVByb3RvdHlwZSgpIGNhbGxz CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dlbmVyaWNUeXBl ZEFycmF5Vmlld1Byb3RvdHlwZUZ1bmN0aW9ucy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNHZW5lcmljVHlwZWRBcnJheVZpZXdQcm90b3R5cGVGdW5jdGlvbnMuaAppbmRleCA4 OWE5NzE3MjMyZWMyMWE0ZDg5YmQ2MzI4MDNjYTRkODhmOGY3Njk4Li5hZGIzMjc5M2I5MmM3ZDc3 NzlmNzllMDE4Mjk1OTBlMDhhOWVhMTZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0dlbmVyaWNUeXBlZEFycmF5Vmlld1Byb3RvdHlwZUZ1bmN0aW9ucy5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2VuZXJpY1R5cGVkQXJyYXlWaWV3 UHJvdG90eXBlRnVuY3Rpb25zLmgKQEAgLTcwLDYgKzcwLDExIEBAIGlubGluZSBKU0FycmF5QnVm ZmVyVmlldyogc3BlY2llc0NvbnN0cnVjdChFeGVjU3RhdGUqIGV4ZWMsIEpTT2JqZWN0KiBleGVt cGxhciwKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBudWxscHRyKTsKIAogICAgIGlm IChKU0FycmF5QnVmZmVyVmlldyogdmlldyA9IGpzRHluYW1pY0Nhc3Q8SlNBcnJheUJ1ZmZlclZp ZXcqPih2bSwgcmVzdWx0KSkgeworICAgICAgICBpZiAodmlldy0+dHlwZSgpID09IERhdGFWaWV3 VHlwZSkgeworICAgICAgICAgICAgdGhyb3dUeXBlRXJyb3IoZXhlYywgc2NvcGUsICJzcGVjaWVz IGNvbnN0cnVjdG9yIGRpZCBub3QgcmV0dXJuIGEgVHlwZWRBcnJheSBWaWV3Il9zKTsKKyAgICAg ICAgICAgIHJldHVybiBudWxscHRyOworICAgICAgICB9CisKICAgICAgICAgaWYgKCF2aWV3LT5p c05ldXRlcmVkKCkpCiAgICAgICAgICAgICByZXR1cm4gdmlldzsKIApkaWZmIC0tZ2l0IGEvSlNU ZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBhYWYxM2VjM2QwODU1Nzcy MzBmZTI3Njc5ZDQzNGI3N2VjNTAyNjcxLi4xODZmNWRiODBmMWY3NTI1Yjc0NDU3OWVlOGNiMTA3 OGMyNWU3Y2Q5IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA2LTI2ICBLZWl0aCBNaWxsZXIgIDxrZWl0 aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAgICAgIHNwZWNpZXNDb25zdHJ1Y3QgbmVlZHMgdG8g dGhyb3cgaWYgdGhlIHJlc3VsdCBpcyBhIERhdGFWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkyMzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy90eXBlZGFycmF5LWZpbHRlci5qczoK KyAgICAgICAgKHN1YmNsYXNzZXMuZm9yRWFjaCk6CisgICAgICAgICogc3RyZXNzL3R5cGVkYXJy YXktbWFwLmpzOgorICAgICAgICAoc3ViY2xhc3Nlcy5mb3JFYWNoKToKKyAgICAgICAgKiBzdHJl c3MvdHlwZWRhcnJheS1zbGljZS5qczoKKyAgICAgICAgKHR5cGVkQXJyYXlzLmZvckVhY2gpOgor ICAgICAgICAqIHN0cmVzcy90eXBlZGFycmF5LXN1YmFycmF5LmpzOgorICAgICAgICAoc3ViY2xh c3Nlcy5mb3JFYWNoKToKKwogMjAxOS0wNi0yNCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVl QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI0NjcxNC4K ZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3R5cGVkYXJyYXktZmlsdGVyLmpzIGIvSlNUZXN0 cy9zdHJlc3MvdHlwZWRhcnJheS1maWx0ZXIuanMKaW5kZXggNWU4NTkyMzgxNzA4YzM2ODc5MmE3 YzZlMjUzZTZiNmJkNDEwYmIzNC4uN2NlN2JiZjYzNjc5N2JmZGUxMzUzNWFjNGY0ODE4N2M1YjBh NDUwNiAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3MvdHlwZWRhcnJheS1maWx0ZXIuanMKKysr IGIvSlNUZXN0cy9zdHJlc3MvdHlwZWRhcnJheS1maWx0ZXIuanMKQEAgLTkxLDYgKzkxLDE3IEBA IHNob3VsZEJlVHJ1ZSgiZm9yRWFjaFR5cGVkQXJyYXkoc3ViY2xhc3NlcywgdGVzdFNwZWNpZXNJ c0RlZmF1bHQpIik7CiBzdWJjbGFzc2VzLmZvckVhY2goZnVuY3Rpb24oY29uc3RydWN0b3IpIHsg Y29uc3RydWN0b3JbU3ltYm9sLnNwZWNpZXNdID0gdW5kZWZpbmVkOyB9KTsKIHNob3VsZEJlVHJ1 ZSgiZm9yRWFjaFR5cGVkQXJyYXkoc3ViY2xhc3NlcywgdGVzdFNwZWNpZXNJc0RlZmF1bHQpIik7 CiAKK3N1YmNsYXNzZXMuZm9yRWFjaChmdW5jdGlvbihjb25zdHJ1Y3RvcikgeyBjb25zdHJ1Y3Rv cltTeW1ib2wuc3BlY2llc10gPSAoKSA9PiBuZXcgRGF0YVZpZXcobmV3IEFycmF5QnVmZmVyKCkp OyB9KTsKK2Z1bmN0aW9uIHRlc3RTcGVjaWVzUmV0dXJuc0RhdGFWaWV3KGFycmF5LCBjb25zdHJ1 Y3RvcikgeworICAgIHRyeSB7CisgICAgICAgIGFycmF5LmZpbHRlcihhY2NlcHQpOworICAgIH0g Y2F0Y2ggKGUpIHsKKyAgICAgICAgcmV0dXJuIGUgaW5zdGFuY2VvZiBUeXBlRXJyb3I7CisgICAg fQorICAgIHJldHVybiBmYWxzZTsKK30KK3Nob3VsZEJlVHJ1ZSgiZm9yRWFjaFR5cGVkQXJyYXko c3ViY2xhc3NlcywgdGVzdFNwZWNpZXNSZXR1cm5zRGF0YVZpZXcpIik7CisKIHN1YmNsYXNzZXMg PSB0eXBlZEFycmF5cy5tYXAoZnVuY3Rpb24oY29uc3RydWN0b3IpIHsgcmV0dXJuIGNsYXNzIGV4 dGVuZHMgY29uc3RydWN0b3IgeyB9IH0gKTsKIGZ1bmN0aW9uIHRlc3RTcGVjaWVzUmVtb3ZlQ29u c3RydWN0b3IoYXJyYXksIGNvbnN0cnVjdG9yKSB7CiAgICAgYXJyYXkuY29uc3RydWN0b3IgPSB1 bmRlZmluZWQ7CkBAIC0xMDAsNCArMTExLDUgQEAgZnVuY3Rpb24gdGVzdFNwZWNpZXNSZW1vdmVD b25zdHJ1Y3RvcihhcnJheSwgY29uc3RydWN0b3IpIHsKIH0KIAogc2hvdWxkQmVUcnVlKCJmb3JF YWNoVHlwZWRBcnJheShzdWJjbGFzc2VzLCB0ZXN0U3BlY2llc1JlbW92ZUNvbnN0cnVjdG9yKSIp OworCiBmaW5pc2hKU1Rlc3QoKTsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3R5cGVkYXJy YXktbWFwLmpzIGIvSlNUZXN0cy9zdHJlc3MvdHlwZWRhcnJheS1tYXAuanMKaW5kZXggMWQ5YTg5 MGQyMmMzMmZhOTVmZmRlNTI4MWFlMTViNjI4M2ZhYWZhNi4uOGRhZDIyMmNjZjUwMTlhM2FmMDkz ODY2YWY5M2FkZDY3YzA2NWMxMiAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3MvdHlwZWRhcnJh eS1tYXAuanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvdHlwZWRhcnJheS1tYXAuanMKQEAgLTkwLDYg KzkwLDE3IEBAIHNob3VsZEJlVHJ1ZSgiZm9yRWFjaFR5cGVkQXJyYXkoc3ViY2xhc3NlcywgdGVz dFNwZWNpZXNJc0RlZmF1bHQpIik7CiBzdWJjbGFzc2VzLmZvckVhY2goZnVuY3Rpb24oY29uc3Ry dWN0b3IpIHsgY29uc3RydWN0b3JbU3ltYm9sLnNwZWNpZXNdID0gdW5kZWZpbmVkOyB9KTsKIHNo b3VsZEJlVHJ1ZSgiZm9yRWFjaFR5cGVkQXJyYXkoc3ViY2xhc3NlcywgdGVzdFNwZWNpZXNJc0Rl ZmF1bHQpIik7CiAKK3N1YmNsYXNzZXMuZm9yRWFjaChmdW5jdGlvbihjb25zdHJ1Y3RvcikgeyBj b25zdHJ1Y3RvcltTeW1ib2wuc3BlY2llc10gPSAoKSA9PiBuZXcgRGF0YVZpZXcobmV3IEFycmF5 QnVmZmVyKCkpOyB9KTsKK2Z1bmN0aW9uIHRlc3RTcGVjaWVzUmV0dXJuc0RhdGFWaWV3KGFycmF5 LCBjb25zdHJ1Y3RvcikgeworICAgIHRyeSB7CisgICAgICAgIGFycmF5Lm1hcChpZCk7CisgICAg fSBjYXRjaCAoZSkgeworICAgICAgICByZXR1cm4gZSBpbnN0YW5jZW9mIFR5cGVFcnJvcjsKKyAg ICB9CisgICAgcmV0dXJuIGZhbHNlOworfQorc2hvdWxkQmVUcnVlKCJmb3JFYWNoVHlwZWRBcnJh eShzdWJjbGFzc2VzLCB0ZXN0U3BlY2llc1JldHVybnNEYXRhVmlldykiKTsKKwogc3ViY2xhc3Nl cyA9IHR5cGVkQXJyYXlzLm1hcChmdW5jdGlvbihjb25zdHJ1Y3RvcikgeyByZXR1cm4gY2xhc3Mg ZXh0ZW5kcyBjb25zdHJ1Y3RvciB7IH0gfSApOwogZnVuY3Rpb24gdGVzdFNwZWNpZXNSZW1vdmVD b25zdHJ1Y3RvcihhcnJheSwgY29uc3RydWN0b3IpIHsKICAgICBhcnJheS5jb25zdHJ1Y3RvciA9 IHVuZGVmaW5lZDsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3R5cGVkYXJyYXktc2xpY2Uu anMgYi9KU1Rlc3RzL3N0cmVzcy90eXBlZGFycmF5LXNsaWNlLmpzCmluZGV4IDk5Y2JiYTZmNmFi MjA1YzI4YzAwZjBmYzE2MDcxNjE5MzA0NGZlMWYuLmZiY2IxZjhiMTVkNGQ4MDg0ZmRlNjQ1MDFl YTdmNTBjNGU1YTQ4OWUgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL3R5cGVkYXJyYXktc2xp Y2UuanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvdHlwZWRhcnJheS1zbGljZS5qcwpAQCAtMTY5LDQg KzE2OSwxNSBAQCBmdW5jdGlvbiB0ZXN0U3BlY2llc1dpdGhUcmFuc2ZlcnJpbmcodW51c2VkLCBj b25zdHJ1Y3RvcikgewogCiBzaG91bGRCZVRydWUoImZvckVhY2hUeXBlZEFycmF5KHR5cGVkQXJy YXlzLCB0ZXN0U3BlY2llc1dpdGhUcmFuc2ZlcnJpbmcpIik7CiAKK3R5cGVkQXJyYXlzLmZvckVh Y2goZnVuY3Rpb24oY29uc3RydWN0b3IpIHsgY29uc3RydWN0b3JbU3ltYm9sLnNwZWNpZXNdID0g KCkgPT4gbmV3IERhdGFWaWV3KG5ldyBBcnJheUJ1ZmZlcigpKTsgfSk7CitmdW5jdGlvbiB0ZXN0 U3BlY2llc1JldHVybnNEYXRhVmlldyhhcnJheSwgY29uc3RydWN0b3IpIHsKKyAgICB0cnkgewor ICAgICAgICBhcnJheS5zbGljZSgwLCAxKTsKKyAgICB9IGNhdGNoIChlKSB7CisgICAgICAgIHJl dHVybiBlIGluc3RhbmNlb2YgVHlwZUVycm9yOworICAgIH0KKyAgICByZXR1cm4gZmFsc2U7Cit9 CitzaG91bGRCZVRydWUoImZvckVhY2hUeXBlZEFycmF5KHR5cGVkQXJyYXlzLCB0ZXN0U3BlY2ll c1JldHVybnNEYXRhVmlldykiKTsKKwogZmluaXNoSlNUZXN0KCk7CmRpZmYgLS1naXQgYS9KU1Rl c3RzL3N0cmVzcy90eXBlZGFycmF5LXN1YmFycmF5LmpzIGIvSlNUZXN0cy9zdHJlc3MvdHlwZWRh cnJheS1zdWJhcnJheS5qcwppbmRleCBlYjczMGU0YmE0NTdkOTI0YzU2MGVlMmQ4YmU3MTIyMzJm OWI0OTBkLi44ZjMyOTVmMDFmNTIxMjliMmI4MzUxMmQyN2E0MGU4NmM3ZGU5OGY2IDEwMDY0NAot LS0gYS9KU1Rlc3RzL3N0cmVzcy90eXBlZGFycmF5LXN1YmFycmF5LmpzCisrKyBiL0pTVGVzdHMv c3RyZXNzL3R5cGVkYXJyYXktc3ViYXJyYXkuanMKQEAgLTQ4LDYgKzQ4LDE3IEBAIHNob3VsZEJl VHJ1ZSgiZm9yRWFjaFR5cGVkQXJyYXkoc3ViY2xhc3NlcywgdGVzdFNwZWNpZXNJc0RlZmF1bHQp Iik7CiBzdWJjbGFzc2VzLmZvckVhY2goZnVuY3Rpb24oY29uc3RydWN0b3IpIHsgY29uc3RydWN0 b3JbU3ltYm9sLnNwZWNpZXNdID0gdW5kZWZpbmVkOyB9KTsKIHNob3VsZEJlVHJ1ZSgiZm9yRWFj aFR5cGVkQXJyYXkoc3ViY2xhc3NlcywgdGVzdFNwZWNpZXNJc0RlZmF1bHQpIik7CiAKK3N1YmNs YXNzZXMuZm9yRWFjaChmdW5jdGlvbihjb25zdHJ1Y3RvcikgeyBjb25zdHJ1Y3RvcltTeW1ib2wu c3BlY2llc10gPSAoKSA9PiBuZXcgRGF0YVZpZXcobmV3IEFycmF5QnVmZmVyKCkpOyB9KTsKK2Z1 bmN0aW9uIHRlc3RTcGVjaWVzUmV0dXJuc0RhdGFWaWV3KGFycmF5LCBjb25zdHJ1Y3Rvcikgewor ICAgIHRyeSB7CisgICAgICAgIGFycmF5LnN1YmFycmF5KDAsIDApOworICAgIH0gY2F0Y2ggKGUp IHsKKyAgICAgICAgcmV0dXJuIGUgaW5zdGFuY2VvZiBUeXBlRXJyb3I7CisgICAgfQorICAgIHJl dHVybiBmYWxzZTsKK30KK3Nob3VsZEJlVHJ1ZSgiZm9yRWFjaFR5cGVkQXJyYXkoc3ViY2xhc3Nl cywgdGVzdFNwZWNpZXNSZXR1cm5zRGF0YVZpZXcpIik7CisKIHN1YmNsYXNzZXMgPSB0eXBlZEFy cmF5cy5tYXAoZnVuY3Rpb24oY29uc3RydWN0b3IpIHsgcmV0dXJuIGNsYXNzIGV4dGVuZHMgY29u c3RydWN0b3IgeyB9IH0gKTsKIGZ1bmN0aW9uIHRlc3RTcGVjaWVzUmVtb3ZlQ29uc3RydWN0b3Io YXJyYXksIGNvbnN0cnVjdG9yKSB7CiAgICAgYXJyYXkuY29uc3RydWN0b3IgPSB1bmRlZmluZWQ7 Cg==