199202 2019-06-25 13:56:58 -0700 Add didBecomePrototype() calls to global context prototypes 2019-08-02 10:44:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller mark.lam mcatanzaro saam webkit-bug-importer ysuzuki oldest_to_newest 1547790 0 keith_miller 2019-06-25 13:56:58 -0700 Add didBecomePrototype() calls to global context prototypes 1547791 1 372860 keith_miller 2019-06-25 13:57:54 -0700 Created attachment 372860 Patch 1547798 2 372860 saam 2019-06-25 14:02:16 -0700 Comment on attachment 372860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372860&action=review > Source/WebCore/ChangeLog:9 > + This fixes some crashes related to checking that all prototypes have been > + marked as such to JSC. What crashes? I thought the assert got rolled out? And we were doing things in another way? 1547799 3 372860 saam 2019-06-25 14:03:56 -0700 Comment on attachment 372860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372860&action=review >> Source/WebCore/ChangeLog:9 >> + marked as such to JSC. > > What crashes? I thought the assert got rolled out? And we were doing things in another way? Do you mean this will crash a future change? Can you be more specific here 1547800 4 372860 ysuzuki 2019-06-25 14:04:57 -0700 Comment on attachment 372860 Patch r=me too, and can we add this `didBecomePrototype()` call before calling setPrototypeWithoutTransition() in JSGlobalObject's m_functionPrototype thing too? 1547801 5 372860 keith_miller 2019-06-25 14:05:36 -0700 Comment on attachment 372860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372860&action=review >>> Source/WebCore/ChangeLog:9 >>> + marked as such to JSC. >> >> What crashes? I thought the assert got rolled out? And we were doing things in another way? > > Do you mean this will crash a future change? Can you be more specific here The patch in https://trac.webkit.org/changeset/246801 breaks debug builds right now because setPrototypeWithoutTransition looks for isValidPrototype. I'll update the ChangeLog to make this clearer. 1547802 6 372860 mark.lam 2019-06-25 14:07:05 -0700 Comment on attachment 372860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372860&action=review > Source/WebCore/bindings/js/JSWindowProxy.cpp:115 > + properties.didBecomePrototype(); > prototype->structure(vm)->setPrototypeWithoutTransition(vm, &properties); I thought we were going too make setPrototypeWithoutTransition() call didBecomePrototype() on the passed in prototype object. Was there a change of plans? 1547807 7 372860 mark.lam 2019-06-25 14:12:24 -0700 Comment on attachment 372860 Patch restoring Saam's r+. 1547808 8 372860 keith_miller 2019-06-25 14:14:47 -0700 Comment on attachment 372860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372860&action=review >> Source/WebCore/bindings/js/JSWindowProxy.cpp:115 >> prototype->structure(vm)->setPrototypeWithoutTransition(vm, &properties); > > I thought we were going too make setPrototypeWithoutTransition() call didBecomePrototype() on the passed in prototype object. Was there a change of plans? No, we were going to do it on Structure::create because we know no objects already have that structure thus we don't need to check for haveABadTime. setPrototypeWithoutTransition() can modify existing objects thus haveABadTime should be enforced. 1547811 9 keith_miller 2019-06-25 14:19:35 -0700 Committed r246808: <https://trac.webkit.org/changeset/246808> 1547812 10 webkit-bug-importer 2019-06-25 14:22:05 -0700 <rdar://problem/52133576> 1547818 11 keith_miller 2019-06-25 14:36:25 -0700 Reopening to attach new patch. 1547819 12 372862 keith_miller 2019-06-25 14:36:26 -0700 Created attachment 372862 Patch 1557982 13 mcatanzaro 2019-08-02 10:42:20 -0700 Should this be closed? 372860 2019-06-25 13:57:54 -0700 2019-06-25 14:36:23 -0700 Patch bug-199202-20190625135754.patch text/plain 5278 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmM1ZmYwODRkNGM0N2Y2 NzVmMWZjMDUyZTI2MDVmZWE1NWIyNWUxNC4uOGNjNGNhMzJjZWRlNjM3ZWEzMzBhZmUyZmYxZGQ2 MjVlODc2YjJjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA2LTI1ICBLZWl0 aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBkaWRCZWNv bWVQcm90b3R5cGUoKSBjYWxscyB0byBnbG9iYWwgY29udGV4dCBwcm90b3R5cGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkyMDIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGZpeGVzIHNvbWUg Y3Jhc2hlcyByZWxhdGVkIHRvIGNoZWNraW5nIHRoYXQgYWxsIHByb3RvdHlwZXMgaGF2ZSBiZWVu CisgICAgICAgIG1hcmtlZCBhcyBzdWNoIHRvIEpTQy4KKworICAgICAgICAqIGJpbmRpbmdzL2pz L0pTV2luZG93UHJveHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNXaW5kb3dQcm94eTo6c2V0 V2luZG93KToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OldvcmtlclNjcmlwdENvbnRyb2xsZXI6OmluaXRTY3JpcHQp OgorICAgICAgICAqIHdvcmtsZXRzL1dvcmtsZXRTY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OldvcmtsZXRTY3JpcHRDb250cm9sbGVyOjppbml0U2NyaXB0V2l0aFN1YmNs YXNzKToKKwogMjAxOS0wNi0yNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEltcGxlbWVudCBjb25zb2xlLnRpbWVMb2cKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTV2luZG93UHJveHkuY3BwIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXaW5kb3dQcm94eS5jcHAKaW5kZXggYmYwZTIy NTkxZTU0NmQwZDgxZjYzZTQ4ZDY2NzA3ZmJhY2Q2MWQ2My4uYzIyOTc0OTg2MGI1YTUyNDBhYzU1 Yzg4NGEwMjRkYmE5ZDY2MjllMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNXaW5kb3dQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNX aW5kb3dQcm94eS5jcHAKQEAgLTExMSw2ICsxMTEsNyBAQCB2b2lkIEpTV2luZG93UHJveHk6OnNl dFdpbmRvdyhBYnN0cmFjdERPTVdpbmRvdyYgZG9tV2luZG93KQogCiAgICAgYXV0byYgcHJvcGVy dGllc1N0cnVjdHVyZSA9ICpKU0RPTVdpbmRvd1Byb3BlcnRpZXM6OmNyZWF0ZVN0cnVjdHVyZSh2 bSwgd2luZG93LCBKU0V2ZW50VGFyZ2V0Ojpwcm90b3R5cGUodm0sICp3aW5kb3cpKTsKICAgICBh dXRvJiBwcm9wZXJ0aWVzID0gKkpTRE9NV2luZG93UHJvcGVydGllczo6Y3JlYXRlKCZwcm9wZXJ0 aWVzU3RydWN0dXJlLCAqd2luZG93KTsKKyAgICBwcm9wZXJ0aWVzLmRpZEJlY29tZVByb3RvdHlw ZSgpOwogICAgIHByb3RvdHlwZS0+c3RydWN0dXJlKHZtKS0+c2V0UHJvdG90eXBlV2l0aG91dFRy YW5zaXRpb24odm0sICZwcm9wZXJ0aWVzKTsKIAogICAgIHNldFdpbmRvdyh2bSwgKndpbmRvdyk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250 cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dvcmtlclNjcmlwdENvbnRy b2xsZXIuY3BwCmluZGV4IGE2MjM1MjNkMGQ3YTk2YTg5MjgxZDhjNzdkYTY2ODZkYzE0ZWY0NGQu LjZmNzVkMTYxNTliNzBlNjUyODE4MjIzMWJhNTVkNDIyNTZjYmJhYjEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCkBA IC05MCw3ICs5MCw5IEBAIHZvaWQgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6aW5pdFNjcmlwdCgp CiAgICAgICAgIEFTU0VSVChzdHJ1Y3R1cmUtPmdsb2JhbE9iamVjdCgpID09IG1fd29ya2VyR2xv YmFsU2NvcGVXcmFwcGVyKTsKICAgICAgICAgQVNTRVJUKG1fd29ya2VyR2xvYmFsU2NvcGVXcmFw cGVyLT5zdHJ1Y3R1cmUoKm1fdm0pLT5nbG9iYWxPYmplY3QoKSA9PSBtX3dvcmtlckdsb2JhbFNj b3BlV3JhcHBlcik7CiAgICAgICAgIGRlZGljYXRlZENvbnRleHRQcm90b3R5cGUtPnN0cnVjdHVy ZSgqbV92bSktPnNldEdsb2JhbE9iamVjdCgqbV92bSwgbV93b3JrZXJHbG9iYWxTY29wZVdyYXBw ZXIuZ2V0KCkpOwotICAgICAgICBkZWRpY2F0ZWRDb250ZXh0UHJvdG90eXBlLT5zdHJ1Y3R1cmUo Km1fdm0pLT5zZXRQcm90b3R5cGVXaXRob3V0VHJhbnNpdGlvbigqbV92bSwgSlNXb3JrZXJHbG9i YWxTY29wZTo6cHJvdG90eXBlKCptX3ZtLCAqbV93b3JrZXJHbG9iYWxTY29wZVdyYXBwZXIuZ2V0 KCkpKTsKKyAgICAgICAgYXV0byogd29ya2VyR2xvYmFsU2NvcGVQcm90b3R5cGUgPSBKU1dvcmtl ckdsb2JhbFNjb3BlOjpwcm90b3R5cGUoKm1fdm0sICptX3dvcmtlckdsb2JhbFNjb3BlV3JhcHBl ci5nZXQoKSk7CisgICAgICAgIHdvcmtlckdsb2JhbFNjb3BlUHJvdG90eXBlLT5kaWRCZWNvbWVQ cm90b3R5cGUoKTsKKyAgICAgICAgZGVkaWNhdGVkQ29udGV4dFByb3RvdHlwZS0+c3RydWN0dXJl KCptX3ZtKS0+c2V0UHJvdG90eXBlV2l0aG91dFRyYW5zaXRpb24oKm1fdm0sIHdvcmtlckdsb2Jh bFNjb3BlUHJvdG90eXBlKTsKIAogICAgICAgICBwcm94eS0+c2V0VGFyZ2V0KCptX3ZtLCBtX3dv cmtlckdsb2JhbFNjb3BlV3JhcHBlci5nZXQoKSk7CiAgICAgICAgIHByb3h5LT5zdHJ1Y3R1cmUo Km1fdm0pLT5zZXRHbG9iYWxPYmplY3QoKm1fdm0sIG1fd29ya2VyR2xvYmFsU2NvcGVXcmFwcGVy LmdldCgpKTsKQEAgLTEwNyw3ICsxMDksOSBAQCB2b2lkIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6 OmluaXRTY3JpcHQoKQogICAgICAgICBBU1NFUlQoc3RydWN0dXJlLT5nbG9iYWxPYmplY3QoKSA9 PSBtX3dvcmtlckdsb2JhbFNjb3BlV3JhcHBlcik7CiAgICAgICAgIEFTU0VSVChtX3dvcmtlckds b2JhbFNjb3BlV3JhcHBlci0+c3RydWN0dXJlKCktPmdsb2JhbE9iamVjdCgpID09IG1fd29ya2Vy R2xvYmFsU2NvcGVXcmFwcGVyKTsKICAgICAgICAgY29udGV4dFByb3RvdHlwZS0+c3RydWN0dXJl KCptX3ZtKS0+c2V0R2xvYmFsT2JqZWN0KCptX3ZtLCBtX3dvcmtlckdsb2JhbFNjb3BlV3JhcHBl ci5nZXQoKSk7Ci0gICAgICAgIGNvbnRleHRQcm90b3R5cGUtPnN0cnVjdHVyZSgqbV92bSktPnNl dFByb3RvdHlwZVdpdGhvdXRUcmFuc2l0aW9uKCptX3ZtLCBKU1dvcmtlckdsb2JhbFNjb3BlOjpw cm90b3R5cGUoKm1fdm0sICptX3dvcmtlckdsb2JhbFNjb3BlV3JhcHBlci5nZXQoKSkpOworICAg ICAgICBhdXRvKiB3b3JrZXJHbG9iYWxTY29wZVByb3RvdHlwZSA9IEpTV29ya2VyR2xvYmFsU2Nv cGU6OnByb3RvdHlwZSgqbV92bSwgKm1fd29ya2VyR2xvYmFsU2NvcGVXcmFwcGVyLmdldCgpKTsK KyAgICAgICAgd29ya2VyR2xvYmFsU2NvcGVQcm90b3R5cGUtPmRpZEJlY29tZVByb3RvdHlwZSgp OworICAgICAgICBjb250ZXh0UHJvdG90eXBlLT5zdHJ1Y3R1cmUoKm1fdm0pLT5zZXRQcm90b3R5 cGVXaXRob3V0VHJhbnNpdGlvbigqbV92bSwgd29ya2VyR2xvYmFsU2NvcGVQcm90b3R5cGUpOwog CiAgICAgICAgIHByb3h5LT5zZXRUYXJnZXQoKm1fdm0sIG1fd29ya2VyR2xvYmFsU2NvcGVXcmFw cGVyLmdldCgpKTsKICAgICAgICAgcHJveHktPnN0cnVjdHVyZSgqbV92bSktPnNldEdsb2JhbE9i amVjdCgqbV92bSwgbV93b3JrZXJHbG9iYWxTY29wZVdyYXBwZXIuZ2V0KCkpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvd29ya2xldHMvV29ya2xldFNjcmlwdENvbnRyb2xsZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvd29ya2xldHMvV29ya2xldFNjcmlwdENvbnRyb2xsZXIuY3BwCmluZGV4 IDExNjg5NzhlNDI0ZGYxYzQ4ZTQ2MWM1ODg5Yzc4ZmNkYmEwNjdiNmYuLjFjZWU5ZWIzNDIxY2Q5 OWE1NmM4ODYwYjhlY2RkNDU5NmY4MGQyZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dv cmtsZXRzL1dvcmtsZXRTY3JpcHRDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93 b3JrbGV0cy9Xb3JrbGV0U2NyaXB0Q29udHJvbGxlci5jcHAKQEAgLTEyNiw3ICsxMjYsOSBAQCB2 b2lkIFdvcmtsZXRTY3JpcHRDb250cm9sbGVyOjppbml0U2NyaXB0V2l0aFN1YmNsYXNzKCkKICAg ICBBU1NFUlQoc3RydWN0dXJlLT5nbG9iYWxPYmplY3QoKSA9PSBtX3dvcmtsZXRHbG9iYWxTY29w ZVdyYXBwZXIpOwogICAgIEFTU0VSVChtX3dvcmtsZXRHbG9iYWxTY29wZVdyYXBwZXItPnN0cnVj dHVyZSgqbV92bSktPmdsb2JhbE9iamVjdCgpID09IG1fd29ya2xldEdsb2JhbFNjb3BlV3JhcHBl cik7CiAgICAgY29udGV4dFByb3RvdHlwZS0+c3RydWN0dXJlKCptX3ZtKS0+c2V0R2xvYmFsT2Jq ZWN0KCptX3ZtLCBtX3dvcmtsZXRHbG9iYWxTY29wZVdyYXBwZXIuZ2V0KCkpOwotICAgIGNvbnRl eHRQcm90b3R5cGUtPnN0cnVjdHVyZSgqbV92bSktPnNldFByb3RvdHlwZVdpdGhvdXRUcmFuc2l0 aW9uKCptX3ZtLCBKU0dsb2JhbFNjb3BlOjpwcm90b3R5cGUoKm1fdm0sICptX3dvcmtsZXRHbG9i YWxTY29wZVdyYXBwZXIuZ2V0KCkpKTsKKyAgICBhdXRvKiBnbG9iYWxTY29wZVByb3RvdHlwZSA9 IEpTR2xvYmFsU2NvcGU6OnByb3RvdHlwZSgqbV92bSwgKm1fd29ya2xldEdsb2JhbFNjb3BlV3Jh cHBlci5nZXQoKSk7CisgICAgZ2xvYmFsU2NvcGVQcm90b3R5cGUtPmRpZEJlY29tZVByb3RvdHlw ZSgpOworICAgIGNvbnRleHRQcm90b3R5cGUtPnN0cnVjdHVyZSgqbV92bSktPnNldFByb3RvdHlw ZVdpdGhvdXRUcmFuc2l0aW9uKCptX3ZtLCBnbG9iYWxTY29wZVByb3RvdHlwZSk7CiAKICAgICBw cm94eS0+c2V0VGFyZ2V0KCptX3ZtLCBtX3dvcmtsZXRHbG9iYWxTY29wZVdyYXBwZXIuZ2V0KCkp OwogICAgIHByb3h5LT5zdHJ1Y3R1cmUoKm1fdm0pLT5zZXRHbG9iYWxPYmplY3QoKm1fdm0sIG1f d29ya2xldEdsb2JhbFNjb3BlV3JhcHBlci5nZXQoKSk7Cg== 372862 2019-06-25 14:36:26 -0700 2019-06-25 14:36:26 -0700 Patch bug-199202-20190625143625.patch text/plain 1101 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2ODA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ4ODY1NjExZmVmZTgy ODhiMmQ1ZWQ2YmUzMjY0OTllYzY5YjVlMi4uMzE4YmM5NDhjM2Y0MWMzMWIzYzMzOTlkZTMzOWU5 YTBhZDljNWE3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDkgQEAKKzIwMTktMDYtMjUgIEtlaXRo IE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwg d2luZG93cyBidWlsZCBmaXguCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUdsb2JhbE9i amVjdC5oOgorCiAyMDE5LTA2LTI1ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIEFkZCBkaWRCZWNvbWVQcm90b3R5cGUoKSBjYWxscyB0byBnbG9iYWwg Y29udGV4dCBwcm90b3R5cGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RPTUdsb2JhbE9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01H bG9iYWxPYmplY3QuaAppbmRleCBlZDUyNTUxMDEwMDI2YTFhOGU0N2U3MDM2NzY1MTI3NGExYTM1 NzcwLi5iM2U3NThlZjU0MjUzZTFkMjcxY2Y5ZGFhOWYyOTY1NDkzM2IxNDM2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUdsb2JhbE9iamVjdC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NR2xvYmFsT2JqZWN0LmgKQEAgLTI5LDYgKzI5 LDcgQEAKICNpbmNsdWRlICJXZWJDb3JlSlNCdWlsdGluSW50ZXJuYWxzLmgiCiAjaW5jbHVkZSA8 SmF2YVNjcmlwdENvcmUvSGVhcElubGluZXMuaD4KICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9K U0dsb2JhbE9iamVjdC5oPgorI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTT2JqZWN0SW5saW5l cy5oPgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0xvY2tEdXJpbmdNYXJraW5nLmg+CiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsK