199194 2019-06-25 10:58:10 -0700 [ews-build] Retry Layout test in case of failures 2019-06-26 16:23:29 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196004 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1547730 0 aakash_jain 2019-06-25 10:58:10 -0700 When failures are found in layout-tests, we should retry the tests to ensure that the failures are not because of flaky test. Further, we should run the layout-tests without the patch as well, to identify whether the failures are pre-existing or new failures introduced by the patch. 1547735 1 372846 aakash_jain 2019-06-25 11:07:06 -0700 Created attachment 372846 Patch 1547736 2 aakash_jain 2019-06-25 11:08:13 -0700 Build step to analyze results from all the retries of layout-test will be added later-on in a separate patch. 1547740 3 aakash_jain 2019-06-25 11:10:01 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/35/builds/11 1547917 4 372846 commit-queue 2019-06-25 18:01:07 -0700 Comment on attachment 372846 Patch Clearing flags on attachment: 372846 Committed r246823: <https://trac.webkit.org/changeset/246823> 1547918 5 commit-queue 2019-06-25 18:01:08 -0700 All reviewed patches have been landed. Closing bug. 1548181 6 webkit-bug-importer 2019-06-26 16:23:26 -0700 <rdar://problem/52217478> 1548182 7 webkit-bug-importer 2019-06-26 16:23:29 -0700 <rdar://problem/52217483> 372846 2019-06-25 11:07:06 -0700 2019-06-25 18:01:07 -0700 Patch bug-199194-20190625140705.patch text/plain 2901 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Njc5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTA2LTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBSZXRyeSBMYXlvdXQgdGVzdCBpbiBjYXNlIG9mIGZh aWx1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTkxOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKFJ1bldlYktp dFRlc3RzLmV2YWx1YXRlQ29tbWFuZCk6IENoZWNrIGlmIHRlc3RzIGZhaWxlZCBhbmQgcmV0cnkg dGhlbSBpZiByZXF1aXJlZC4KKyAgICAgICAgKFJlUnVuV2ViS2l0VGVzdHMpOiBCdWlsZCBzdGVw IHRvIHJlLXJ1biBsYXlvdXQgdGVzdHMuCisgICAgICAgIChSZVJ1bldlYktpdFRlc3RzLmV2YWx1 YXRlQ29tbWFuZCk6IENoZWNrIGlmIHRlc3RzIGZhaWxlZCBhbmQgcmV0cnkgb24gY2xlYW4gYnVp bGQgaWYgcmVxdWlyZWQuCisgICAgICAgIChSdW5XZWJLaXRUZXN0c1dpdGhvdXRQYXRjaCk6IEJ1 aWxkIHN0ZXAgdG8gcnVuIHRlc3RzIHdpdGhvdXQgcGF0Y2guCisgICAgICAgIChSdW5XZWJLaXRU ZXN0c1dpdGhvdXRQYXRjaC5ldmFsdWF0ZUNvbW1hbmQpOgorCiAyMDE5LTA2LTI1ICBBYWthc2gg SmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzLWJ1aWxkXSBVcGxv YWRUZXN0UmVzdWx0cyBhbmQgRXh0cmFjdFRlc3RSZXN1bHRzIGNsb2JiZXIgcmVzdWx0cyBpbiBj YXNlIG9mIG11bHRpcGxlIGxheW91dCB0ZXN0IHJ1bnMgaW4gYSBidWlsZApJbmRleDogVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjQ2Nzk1KQor KysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNv cHkpCkBAIC03OTcsOSArNzk3LDM1IEBAIGNsYXNzIFJ1bldlYktpdFRlc3RzKHNoZWxsLlRlc3Qp OgogICAgICAgICAgICAgc2VsZi5idWlsZC5yZXN1bHRzID0gU1VDQ0VTUwogICAgICAgICAgICAg c2VsZi5idWlsZC5idWlsZEZpbmlzaGVkKFttZXNzYWdlXSwgU1VDQ0VTUykKICAgICAgICAgZWxz ZToKLSAgICAgICAgICAgIHNlbGYuYnVpbGQuYWRkU3RlcHNBZnRlckN1cnJlbnRTdGVwKFtBcmNo aXZlVGVzdFJlc3VsdHMoKSwgVXBsb2FkVGVzdFJlc3VsdHMoKSwgRXh0cmFjdFRlc3RSZXN1bHRz KCldKQorICAgICAgICAgICAgc2VsZi5idWlsZC5hZGRTdGVwc0FmdGVyQ3VycmVudFN0ZXAoW0Fy Y2hpdmVUZXN0UmVzdWx0cygpLCBVcGxvYWRUZXN0UmVzdWx0cygpLCBFeHRyYWN0VGVzdFJlc3Vs dHMoKSwgUmVSdW5XZWJLaXRUZXN0cygpXSkKICAgICAgICAgcmV0dXJuIHJjCiAKKworY2xhc3Mg UmVSdW5XZWJLaXRUZXN0cyhSdW5XZWJLaXRUZXN0cyk6CisgICAgbmFtZSA9ICdyZS1ydW4tbGF5 b3V0LXRlc3RzJworCisgICAgZGVmIGV2YWx1YXRlQ29tbWFuZChzZWxmLCBjbWQpOgorICAgICAg ICByYyA9IHNoZWxsLlRlc3QuZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNtZCkKKyAgICAgICAgaWYg cmMgPT0gU1VDQ0VTUzoKKyAgICAgICAgICAgIG1lc3NhZ2UgPSAnUGFzc2VkIGxheW91dCB0ZXN0 cycKKyAgICAgICAgICAgIHNlbGYuZGVzY3JpcHRpb25Eb25lID0gbWVzc2FnZQorICAgICAgICAg ICAgc2VsZi5idWlsZC5yZXN1bHRzID0gU1VDQ0VTUworICAgICAgICAgICAgc2VsZi5idWlsZC5i dWlsZEZpbmlzaGVkKFttZXNzYWdlXSwgU1VDQ0VTUykKKyAgICAgICAgZWxzZToKKyAgICAgICAg ICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BhdGNoRmFpbGVkVGVzdHMnLCBUcnVlKQorICAgICAgICAg ICAgc2VsZi5idWlsZC5hZGRTdGVwc0FmdGVyQ3VycmVudFN0ZXAoW0FyY2hpdmVUZXN0UmVzdWx0 cygpLCBVcGxvYWRUZXN0UmVzdWx0cyhpZGVudGlmaWVyPSdyZXJ1bicpLCBFeHRyYWN0VGVzdFJl c3VsdHMoaWRlbnRpZmllcj0ncmVydW4nKSwgVW5BcHBseVBhdGNoSWZSZXF1aXJlZCgpLCBDb21w aWxlV2ViS2l0VG9UKCksIFJ1bldlYktpdFRlc3RzV2l0aG91dFBhdGNoKCldKQorICAgICAgICBy ZXR1cm4gcmMKKworCitjbGFzcyBSdW5XZWJLaXRUZXN0c1dpdGhvdXRQYXRjaChSdW5XZWJLaXRU ZXN0cyk6CisgICAgbmFtZSA9ICdydW4tbGF5b3V0LXRlc3RzLXdpdGhvdXQtcGF0Y2gnCisKKyAg ICBkZWYgZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNtZCk6CisgICAgICAgIHJjID0gc2hlbGwuVGVz dC5ldmFsdWF0ZUNvbW1hbmQoc2VsZiwgY21kKQorICAgICAgICBzZWxmLmJ1aWxkLmFkZFN0ZXBz QWZ0ZXJDdXJyZW50U3RlcChbQXJjaGl2ZVRlc3RSZXN1bHRzKCksIFVwbG9hZFRlc3RSZXN1bHRz KGlkZW50aWZpZXI9J2NsZWFuLXRyZWUnKSwgRXh0cmFjdFRlc3RSZXN1bHRzKGlkZW50aWZpZXI9 J2NsZWFuLXRyZWUnKV0pCisgICAgICAgIHJldHVybiByYworCisKIGNsYXNzIFJ1bldlYktpdDFU ZXN0cyhSdW5XZWJLaXRUZXN0cyk6CiAgICAgZGVmIHN0YXJ0KHNlbGYpOgogICAgICAgICBzZWxm LnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWyctLWR1bXAtcmVuZGVyLXRyZWUnXSkK