199167 2019-06-24 11:34:18 -0700 [StyleResolver] Pass RenderStyle& instead of RenderStyle* to updateFont() related functions. 2019-06-24 12:38:06 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan commit-queue koivisto webkit-bug-importer oldest_to_newest 1547430 0 zalan 2019-06-24 11:34:18 -0700 it is expected to have a valid style object here. 1547431 1 webkit-bug-importer 2019-06-24 11:35:01 -0700 <rdar://problem/52062669> 1547434 2 372777 zalan 2019-06-24 11:36:56 -0700 Created attachment 372777 Patch 1547488 3 372777 commit-queue 2019-06-24 12:38:05 -0700 Comment on attachment 372777 Patch Clearing flags on attachment: 372777 Committed r246755: <https://trac.webkit.org/changeset/246755> 1547489 4 commit-queue 2019-06-24 12:38:06 -0700 All reviewed patches have been landed. Closing bug. 372777 2019-06-24 11:36:56 -0700 2019-06-24 12:38:05 -0700 Patch bug-199167-20190624113655.patch text/plain 6956 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODNhNmE5NTQyYzQwY2I3 MmFiYTk5ODMyMzk4OWNkYzMyODVkN2UwNC4uMTU2MjQzZDIzODEwMTI3NWE5MGM5ZGQ4ZDE5YzQx YWMwYTRmYmM3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA2LTI0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1N0eWxlUmVzb2x2ZXJdIFBh c3MgUmVuZGVyU3R5bGUmIGluc3RlYWQgb2YgUmVuZGVyU3R5bGUqIHRvIHVwZGF0ZUZvbnQoKSBy ZWxhdGVkIGZ1bmN0aW9ucy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5OTE2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTIwNjI2Njk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgaXMgZXhwZWN0 ZWQgdG8gaGF2ZSBhIHZhbGlkIFJlbmRlclN0eWxlIG9iamVjdCBoZXJlIChhbmQgZXhpc3Rpbmcg Y29kZSByZWxpZXMgb24gaXQpLgorCisgICAgICAgICogY3NzL1N0eWxlUmVzb2x2ZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Y2hlY2tGb3JPcmllbnRhdGlvbkNoYW5nZSk6CisgICAgICAgIChX ZWJDb3JlOjpTdHlsZVJlc29sdmVyOjp1cGRhdGVGb250KToKKyAgICAgICAgKFdlYkNvcmU6OlN0 eWxlUmVzb2x2ZXI6OmNoZWNrRm9yVGV4dFNpemVBZGp1c3QpOgorICAgICAgICAoV2ViQ29yZTo6 U3R5bGVSZXNvbHZlcjo6Y2hlY2tGb3Jab29tQ2hhbmdlKToKKyAgICAgICAgKFdlYkNvcmU6OlN0 eWxlUmVzb2x2ZXI6OmNoZWNrRm9yR2VuZXJpY0ZhbWlseUNoYW5nZSk6CisgICAgICAgICogY3Nz L1N0eWxlUmVzb2x2ZXIuaDoKKwogMjAxOS0wNi0yMSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBw bGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gQWRqdXN0IGJhc2VsaW5lIHRvcCB3aGVuIHRo ZSBiYXNlbGluZSBtb3Zlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJl c29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAppbmRleCA2 NDQxMDA0Njk4YmUzNWNmYzhkN2VhNjFjMTQwN2E4YjAwZjc5MGM2Li4wMjQ4NzkwZWViMGE4ODIz ZWFhYTZhOTI2MDQ2YmJjNDg4YjAxNTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv U3R5bGVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIu Y3BwCkBAIC0xMTc0LDIwICsxMTc0LDIwIEBAIHZvaWQgU3R5bGVSZXNvbHZlcjo6YWRqdXN0UmVu ZGVyU3R5bGVGb3JTaXRlU3BlY2lmaWNRdWlya3MoUmVuZGVyU3R5bGUmIHN0eWxlLCBjCiAgICAg fQogfQogCi1zdGF0aWMgdm9pZCBjaGVja0Zvck9yaWVudGF0aW9uQ2hhbmdlKFJlbmRlclN0eWxl KiBzdHlsZSkKK3N0YXRpYyB2b2lkIGNoZWNrRm9yT3JpZW50YXRpb25DaGFuZ2UoUmVuZGVyU3R5 bGUmIHN0eWxlKQogewogICAgIEZvbnRPcmllbnRhdGlvbiBmb250T3JpZW50YXRpb247CiAgICAg Tm9uQ0pLR2x5cGhPcmllbnRhdGlvbiBnbHlwaE9yaWVudGF0aW9uOwotICAgIHN0ZDo6dGllKGZv bnRPcmllbnRhdGlvbiwgZ2x5cGhPcmllbnRhdGlvbikgPSBzdHlsZS0+Zm9udEFuZEdseXBoT3Jp ZW50YXRpb24oKTsKKyAgICBzdGQ6OnRpZShmb250T3JpZW50YXRpb24sIGdseXBoT3JpZW50YXRp b24pID0gc3R5bGUuZm9udEFuZEdseXBoT3JpZW50YXRpb24oKTsKIAotICAgIGNvbnN0IGF1dG8m IGZvbnREZXNjcmlwdGlvbiA9IHN0eWxlLT5mb250RGVzY3JpcHRpb24oKTsKKyAgICBjb25zdCBh dXRvJiBmb250RGVzY3JpcHRpb24gPSBzdHlsZS5mb250RGVzY3JpcHRpb24oKTsKICAgICBpZiAo Zm9udERlc2NyaXB0aW9uLm9yaWVudGF0aW9uKCkgPT0gZm9udE9yaWVudGF0aW9uICYmIGZvbnRE ZXNjcmlwdGlvbi5ub25DSktHbHlwaE9yaWVudGF0aW9uKCkgPT0gZ2x5cGhPcmllbnRhdGlvbikK ICAgICAgICAgcmV0dXJuOwogCiAgICAgYXV0byBuZXdGb250RGVzY3JpcHRpb24gPSBmb250RGVz Y3JpcHRpb247CiAgICAgbmV3Rm9udERlc2NyaXB0aW9uLnNldE5vbkNKS0dseXBoT3JpZW50YXRp b24oZ2x5cGhPcmllbnRhdGlvbik7CiAgICAgbmV3Rm9udERlc2NyaXB0aW9uLnNldE9yaWVudGF0 aW9uKGZvbnRPcmllbnRhdGlvbik7Ci0gICAgc3R5bGUtPnNldEZvbnREZXNjcmlwdGlvbihXVEZN b3ZlKG5ld0ZvbnREZXNjcmlwdGlvbikpOworICAgIHN0eWxlLnNldEZvbnREZXNjcmlwdGlvbihX VEZNb3ZlKG5ld0ZvbnREZXNjcmlwdGlvbikpOwogfQogCiB2b2lkIFN0eWxlUmVzb2x2ZXI6OnVw ZGF0ZUZvbnQoKQpAQCAtMTE5NSwxNiArMTE5NSwxNiBAQCB2b2lkIFN0eWxlUmVzb2x2ZXI6OnVw ZGF0ZUZvbnQoKQogICAgIGlmICghbV9zdGF0ZS5mb250RGlydHkoKSkKICAgICAgICAgcmV0dXJu OwogCi0gICAgUmVuZGVyU3R5bGUqIHN0eWxlID0gbV9zdGF0ZS5zdHlsZSgpOworICAgIGF1dG8m IHN0eWxlID0gKm1fc3RhdGUuc3R5bGUoKTsKICNpZiBFTkFCTEUoVEVYVF9BVVRPU0laSU5HKQog ICAgIGNoZWNrRm9yVGV4dFNpemVBZGp1c3Qoc3R5bGUpOwogI2VuZGlmCiAgICAgY2hlY2tGb3JH ZW5lcmljRmFtaWx5Q2hhbmdlKHN0eWxlLCBtX3N0YXRlLnBhcmVudFN0eWxlKCkpOwogICAgIGNo ZWNrRm9yWm9vbUNoYW5nZShzdHlsZSwgbV9zdGF0ZS5wYXJlbnRTdHlsZSgpKTsKICAgICBjaGVj a0Zvck9yaWVudGF0aW9uQ2hhbmdlKHN0eWxlKTsKLSAgICBzdHlsZS0+Zm9udENhc2NhZGUoKS51 cGRhdGUoJmRvY3VtZW50KCkuZm9udFNlbGVjdG9yKCkpOworICAgIHN0eWxlLmZvbnRDYXNjYWRl KCkudXBkYXRlKCZkb2N1bWVudCgpLmZvbnRTZWxlY3RvcigpKTsKICAgICBpZiAobV9zdGF0ZS5m b250U2l6ZUhhc1ZpZXdwb3J0VW5pdHMoKSkKLSAgICAgICAgc3R5bGUtPnNldEhhc1ZpZXdwb3J0 VW5pdHModHJ1ZSk7CisgICAgICAgIHN0eWxlLnNldEhhc1ZpZXdwb3J0VW5pdHModHJ1ZSk7CiAg ICAgbV9zdGF0ZS5zZXRGb250RGlydHkoZmFsc2UpOwogfQogCkBAIC0xODQ4LDM4ICsxODQ4LDM3 IEBAIFJlZlB0cjxTdHlsZUltYWdlPiBTdHlsZVJlc29sdmVyOjpzdHlsZUltYWdlKENTU1ZhbHVl JiB2YWx1ZSkKIH0KIAogI2lmIEVOQUJMRShURVhUX0FVVE9TSVpJTkcpCi12b2lkIFN0eWxlUmVz b2x2ZXI6OmNoZWNrRm9yVGV4dFNpemVBZGp1c3QoUmVuZGVyU3R5bGUqIHN0eWxlKQordm9pZCBT dHlsZVJlc29sdmVyOjpjaGVja0ZvclRleHRTaXplQWRqdXN0KFJlbmRlclN0eWxlJiBzdHlsZSkK IHsKLSAgICBBU1NFUlQoc3R5bGUpOwotICAgIGlmIChzdHlsZS0+dGV4dFNpemVBZGp1c3QoKS5p c0F1dG8oKSB8fCAoc2V0dGluZ3MoKS50ZXh0QXV0b3NpemluZ1VzZXNJZGVtcG90ZW50TW9kZSgp ICYmICFzdHlsZS0+dGV4dFNpemVBZGp1c3QoKS5pc05vbmUoKSkpCisgICAgaWYgKHN0eWxlLnRl eHRTaXplQWRqdXN0KCkuaXNBdXRvKCkgfHwgKHNldHRpbmdzKCkudGV4dEF1dG9zaXppbmdVc2Vz SWRlbXBvdGVudE1vZGUoKSAmJiAhc3R5bGUudGV4dFNpemVBZGp1c3QoKS5pc05vbmUoKSkpCiAg ICAgICAgIHJldHVybjsKIAotICAgIGF1dG8gbmV3Rm9udERlc2NyaXB0aW9uID0gc3R5bGUtPmZv bnREZXNjcmlwdGlvbigpOwotICAgIGlmICghc3R5bGUtPnRleHRTaXplQWRqdXN0KCkuaXNOb25l KCkpCi0gICAgICAgIG5ld0ZvbnREZXNjcmlwdGlvbi5zZXRDb21wdXRlZFNpemUobmV3Rm9udERl c2NyaXB0aW9uLnNwZWNpZmllZFNpemUoKSAqIHN0eWxlLT50ZXh0U2l6ZUFkanVzdCgpLm11bHRp cGxpZXIoKSk7CisgICAgYXV0byBuZXdGb250RGVzY3JpcHRpb24gPSBzdHlsZS5mb250RGVzY3Jp cHRpb24oKTsKKyAgICBpZiAoIXN0eWxlLnRleHRTaXplQWRqdXN0KCkuaXNOb25lKCkpCisgICAg ICAgIG5ld0ZvbnREZXNjcmlwdGlvbi5zZXRDb21wdXRlZFNpemUobmV3Rm9udERlc2NyaXB0aW9u LnNwZWNpZmllZFNpemUoKSAqIHN0eWxlLnRleHRTaXplQWRqdXN0KCkubXVsdGlwbGllcigpKTsK ICAgICBlbHNlCiAgICAgICAgIG5ld0ZvbnREZXNjcmlwdGlvbi5zZXRDb21wdXRlZFNpemUobmV3 Rm9udERlc2NyaXB0aW9uLnNwZWNpZmllZFNpemUoKSk7Ci0gICAgc3R5bGUtPnNldEZvbnREZXNj cmlwdGlvbihXVEZNb3ZlKG5ld0ZvbnREZXNjcmlwdGlvbikpOworICAgIHN0eWxlLnNldEZvbnRE ZXNjcmlwdGlvbihXVEZNb3ZlKG5ld0ZvbnREZXNjcmlwdGlvbikpOwogfQogI2VuZGlmCiAKLXZv aWQgU3R5bGVSZXNvbHZlcjo6Y2hlY2tGb3Jab29tQ2hhbmdlKFJlbmRlclN0eWxlKiBzdHlsZSwg Y29uc3QgUmVuZGVyU3R5bGUqIHBhcmVudFN0eWxlKQordm9pZCBTdHlsZVJlc29sdmVyOjpjaGVj a0Zvclpvb21DaGFuZ2UoUmVuZGVyU3R5bGUmIHN0eWxlLCBjb25zdCBSZW5kZXJTdHlsZSogcGFy ZW50U3R5bGUpCiB7CiAgICAgaWYgKCFwYXJlbnRTdHlsZSkKICAgICAgICAgcmV0dXJuOwogCi0g ICAgaWYgKHN0eWxlLT5lZmZlY3RpdmVab29tKCkgPT0gcGFyZW50U3R5bGUtPmVmZmVjdGl2ZVpv b20oKSAmJiBzdHlsZS0+dGV4dFpvb20oKSA9PSBwYXJlbnRTdHlsZS0+dGV4dFpvb20oKSkKKyAg ICBpZiAoc3R5bGUuZWZmZWN0aXZlWm9vbSgpID09IHBhcmVudFN0eWxlLT5lZmZlY3RpdmVab29t KCkgJiYgc3R5bGUudGV4dFpvb20oKSA9PSBwYXJlbnRTdHlsZS0+dGV4dFpvb20oKSkKICAgICAg ICAgcmV0dXJuOwogCi0gICAgY29uc3QgYXV0byYgY2hpbGRGb250ID0gc3R5bGUtPmZvbnREZXNj cmlwdGlvbigpOworICAgIGNvbnN0IGF1dG8mIGNoaWxkRm9udCA9IHN0eWxlLmZvbnREZXNjcmlw dGlvbigpOwogICAgIGF1dG8gbmV3Rm9udERlc2NyaXB0aW9uID0gY2hpbGRGb250OwogICAgIHNl dEZvbnRTaXplKG5ld0ZvbnREZXNjcmlwdGlvbiwgY2hpbGRGb250LnNwZWNpZmllZFNpemUoKSk7 Ci0gICAgc3R5bGUtPnNldEZvbnREZXNjcmlwdGlvbihXVEZNb3ZlKG5ld0ZvbnREZXNjcmlwdGlv bikpOworICAgIHN0eWxlLnNldEZvbnREZXNjcmlwdGlvbihXVEZNb3ZlKG5ld0ZvbnREZXNjcmlw dGlvbikpOwogfQogCi12b2lkIFN0eWxlUmVzb2x2ZXI6OmNoZWNrRm9yR2VuZXJpY0ZhbWlseUNo YW5nZShSZW5kZXJTdHlsZSogc3R5bGUsIGNvbnN0IFJlbmRlclN0eWxlKiBwYXJlbnRTdHlsZSkK K3ZvaWQgU3R5bGVSZXNvbHZlcjo6Y2hlY2tGb3JHZW5lcmljRmFtaWx5Q2hhbmdlKFJlbmRlclN0 eWxlJiBzdHlsZSwgY29uc3QgUmVuZGVyU3R5bGUqIHBhcmVudFN0eWxlKQogewotICAgIGNvbnN0 IGF1dG8mIGNoaWxkRm9udCA9IHN0eWxlLT5mb250RGVzY3JpcHRpb24oKTsKKyAgICBjb25zdCBh dXRvJiBjaGlsZEZvbnQgPSBzdHlsZS5mb250RGVzY3JpcHRpb24oKTsKIAogICAgIGlmIChjaGls ZEZvbnQuaXNBYnNvbHV0ZVNpemUoKSB8fCAhcGFyZW50U3R5bGUpCiAgICAgICAgIHJldHVybjsK QEAgLTE5MDUsNyArMTkwNCw3IEBAIHZvaWQgU3R5bGVSZXNvbHZlcjo6Y2hlY2tGb3JHZW5lcmlj RmFtaWx5Q2hhbmdlKFJlbmRlclN0eWxlKiBzdHlsZSwgY29uc3QgUmVuZGVyCiAKICAgICBhdXRv IG5ld0ZvbnREZXNjcmlwdGlvbiA9IGNoaWxkRm9udDsKICAgICBzZXRGb250U2l6ZShuZXdGb250 RGVzY3JpcHRpb24sIHNpemUpOwotICAgIHN0eWxlLT5zZXRGb250RGVzY3JpcHRpb24oV1RGTW92 ZShuZXdGb250RGVzY3JpcHRpb24pKTsKKyAgICBzdHlsZS5zZXRGb250RGVzY3JpcHRpb24oV1RG TW92ZShuZXdGb250RGVzY3JpcHRpb24pKTsKIH0KIAogdm9pZCBTdHlsZVJlc29sdmVyOjppbml0 aWFsaXplRm9udFN0eWxlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJl c29sdmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5oCmluZGV4IDAxYmI4 ZmJiM2RjMTIzMGMwZjM5MTg0ZTE5YTFmZWE2NDQxMGEyOTUuLjhjODhkYThkNWM3ZmE0MmVkOWQ4 MTJhMDhmMTRlYTBkNDBhMTFjZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHls ZVJlc29sdmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuaApAQCAt MzEyLDEwICszMTIsMTAgQEAgcHVibGljOgogCiBwcml2YXRlOgogICAgIC8vIFRoaXMgZnVuY3Rp b24gZml4ZXMgdXAgdGhlIGRlZmF1bHQgZm9udCBzaXplIGlmIGl0IGRldGVjdHMgdGhhdCB0aGUg Y3VycmVudCBnZW5lcmljIGZvbnQgZmFtaWx5IGhhcyBjaGFuZ2VkLiAtZHdoCi0gICAgdm9pZCBj aGVja0ZvckdlbmVyaWNGYW1pbHlDaGFuZ2UoUmVuZGVyU3R5bGUqLCBjb25zdCBSZW5kZXJTdHls ZSogcGFyZW50U3R5bGUpOwotICAgIHZvaWQgY2hlY2tGb3Jab29tQ2hhbmdlKFJlbmRlclN0eWxl KiwgY29uc3QgUmVuZGVyU3R5bGUqIHBhcmVudFN0eWxlKTsKKyAgICB2b2lkIGNoZWNrRm9yR2Vu ZXJpY0ZhbWlseUNoYW5nZShSZW5kZXJTdHlsZSYsIGNvbnN0IFJlbmRlclN0eWxlKiBwYXJlbnRT dHlsZSk7CisgICAgdm9pZCBjaGVja0Zvclpvb21DaGFuZ2UoUmVuZGVyU3R5bGUmLCBjb25zdCBS ZW5kZXJTdHlsZSogcGFyZW50U3R5bGUpOwogI2lmIEVOQUJMRShURVhUX0FVVE9TSVpJTkcpCi0g ICAgdm9pZCBjaGVja0ZvclRleHRTaXplQWRqdXN0KFJlbmRlclN0eWxlKik7CisgICAgdm9pZCBj aGVja0ZvclRleHRTaXplQWRqdXN0KFJlbmRlclN0eWxlJik7CiAjZW5kaWYKIAogICAgIHZvaWQg YWRqdXN0UmVuZGVyU3R5bGUoUmVuZGVyU3R5bGUmLCBjb25zdCBSZW5kZXJTdHlsZSYgcGFyZW50 U3R5bGUsIGNvbnN0IFJlbmRlclN0eWxlKiBwYXJlbnRCb3hTdHlsZSwgY29uc3QgRWxlbWVudCop Owo=