199160 2019-06-24 08:06:15 -0700 [Cocoa] Avoid creating a PlatformMediaSessionManager when the WebProcess is suspended or resumed 2019-06-24 12:32:10 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue dean_johnson jer.noble webkit-bug-importer oldest_to_newest 1547359 0 pvollan 2019-06-24 08:06:15 -0700 When the WebProcess suspends or resumes, the PlatformMediaSessionManager is notified about this. Avoid creating a new PlatformMediaSessionManager if it does not already exist. 1547361 1 372763 pvollan 2019-06-24 08:08:15 -0700 Created attachment 372763 Patch 1547385 2 372763 bfulgham 2019-06-24 09:23:59 -0700 Comment on attachment 372763 Patch Oh, whoops! Good catch. r=me 1547455 3 pvollan 2019-06-24 11:59:57 -0700 rdar://problem/50666051 1547456 4 372763 pvollan 2019-06-24 12:00:22 -0700 Comment on attachment 372763 Patch Thanks for reviewing! 1547483 5 372763 commit-queue 2019-06-24 12:32:09 -0700 Comment on attachment 372763 Patch Clearing flags on attachment: 372763 Committed r246754: <https://trac.webkit.org/changeset/246754> 1547484 6 commit-queue 2019-06-24 12:32:10 -0700 All reviewed patches have been landed. Closing bug. 372763 2019-06-24 08:08:15 -0700 2019-06-24 12:32:09 -0700 Patch bug-199160-20190624080813.patch text/plain 2340 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDY3MzYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA2LTI0ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIEF2b2lkIGNyZWF0 aW5nIGEgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyIHdoZW4gdGhlIFdlYlByb2Nlc3MgaXMg c3VzcGVuZGVkIG9yIHJlc3VtZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5OTE2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdoZW4gdGhlIFdlYlByb2Nlc3Mgc3VzcGVuZHMgb3IgcmVzdW1lcywgdGhl IFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciBpcyBub3RpZmllZCBhYm91dCB0aGlzLgorICAg ICAgICBBdm9pZCBjcmVhdGluZyBhIG5ldyBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIgaWYg aXQgZG9lcyBub3QgYWxyZWFkeSBleGlzdC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUHJv Y2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OmFjdHVhbFByZXBhcmVUb1N1 c3BlbmQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjpjYW5jZWxQcmVwYXJlVG9TdXNw ZW5kKToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cHJvY2Vzc0RpZFJlc3VtZSk6CisK IDIwMTktMDYtMjQgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4K IAogICAgICAgICBbV1BFXVtHVEtdIEZpeGVzIGZvciBjb21waWxhdGlvbiB3aXRoIHVuaWZpZWQg YnVpbGRzIGRpc2FibGVkCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vz cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3Mu Y3BwCShyZXZpc2lvbiAyNDY2NTYpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJv Y2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NzMsNyArMTQ3Myw4IEBAIHZvaWQgV2ViUHJv Y2Vzczo6YWN0dWFsUHJlcGFyZVRvU3VzcGVuZCgKIAogI2lmIEVOQUJMRShWSURFTykKICAgICBz dXNwZW5kQWxsTWVkaWFCdWZmZXJpbmcoKTsKLSAgICBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFn ZXI6OnNoYXJlZE1hbmFnZXIoKS5wcm9jZXNzV2lsbFN1c3BlbmQoKTsKKyAgICBpZiAoYXV0byog cGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyID0gUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2Vy OjpzaGFyZWRNYW5hZ2VySWZFeGlzdHMoKSkKKyAgICAgICAgcGxhdGZvcm1NZWRpYVNlc3Npb25N YW5hZ2VyLT5wcm9jZXNzV2lsbFN1c3BlbmQoKTsKICNlbmRpZgogCiAgICAgaWYgKCFtX3N1cHBy ZXNzTWVtb3J5UHJlc3N1cmVIYW5kbGVyKQpAQCAtMTUzNSw3ICsxNTM2LDggQEAgdm9pZCBXZWJQ cm9jZXNzOjpjYW5jZWxQcmVwYXJlVG9TdXNwZW5kKAogI2VuZGlmCiAKICNpZiBFTkFCTEUoVklE RU8pCi0gICAgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpzaGFyZWRNYW5hZ2VyKCkucHJv Y2Vzc0RpZFJlc3VtZSgpOworICAgIGlmIChhdXRvKiBwbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFn ZXIgPSBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFnZXJJZkV4aXN0cygp KQorICAgICAgICBwbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXItPnByb2Nlc3NEaWRSZXN1bWUo KTsKICAgICByZXN1bWVBbGxNZWRpYUJ1ZmZlcmluZygpOwogI2VuZGlmCiAKQEAgLTE2MTEsNyAr MTYxMyw4IEBAIHZvaWQgV2ViUHJvY2Vzczo6cHJvY2Vzc0RpZFJlc3VtZSgpCiAjZW5kaWYKIAog I2lmIEVOQUJMRShWSURFTykKLSAgICBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJl ZE1hbmFnZXIoKS5wcm9jZXNzRGlkUmVzdW1lKCk7CisgICAgaWYgKGF1dG8qIHBsYXRmb3JtTWVk aWFTZXNzaW9uTWFuYWdlciA9IFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2hhcmVkTWFu YWdlcklmRXhpc3RzKCkpCisgICAgICAgIHBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlci0+cHJv Y2Vzc0RpZFJlc3VtZSgpOwogICAgIHJlc3VtZUFsbE1lZGlhQnVmZmVyaW5nKCk7CiAjZW5kaWYK IH0K