<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>199153</bug_id>
          
          <creation_ts>2019-06-24 06:54:24 -0700</creation_ts>
          <short_desc>Add user agent quirk for Google Drive</short_desc>
          <delta_ts>2021-02-17 07:08:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=208647</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=142074</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1547316</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-24 06:54:24 -0700</bug_when>
    <thetext>Add user agent quirk for Google Drive to suppress its unsupported browser warning</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1547317</commentid>
    <comment_count>1</comment_count>
      <attachid>372752</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-24 06:55:57 -0700</bug_when>
    <thetext>Created attachment 372752
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1547319</commentid>
    <comment_count>2</comment_count>
      <attachid>372752</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-06-24 07:01:21 -0700</bug_when>
    <thetext>Comment on attachment 372752
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372752&amp;action=review

&gt; Source/WebCore/platform/UserAgentQuirks.cpp:108
&gt;      // Google Docs shows a scary unsupported browser warning with WebKitGTK+&apos;s
&gt;      // standard user agent.

You could take the opportunity to remove that + too :-) And update the comment to say it also happens with drive.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1547336</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-24 07:34:52 -0700</bug_when>
    <thetext>I&apos;ll remove the pluses in a follow-up since there are a lot in this file.

(In reply to Carlos Garcia Campos from comment #2)
&gt; And update the comment to say it also happens with drive.

OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1547339</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-24 07:35:46 -0700</bug_when>
    <thetext>Committed r246733: &lt;https://trac.webkit.org/changeset/246733&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>372752</attachid>
            <date>2019-06-24 06:55:57 -0700</date>
            <delta_ts>2019-06-24 07:35:09 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-199153-20190624085556.patch</filename>
            <type>text/plain</type>
            <size>3482</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmRhOTZlMGJjZGM4ZDc5
ZDBkNTUyYjQ3YmEwNWU5Y2U1MDdjMjZmMS4uMTBjZTQxZjcwYmM0ZWFkZmMwODdhZmFmNDg5MGRi
OTZmN2JlNWNkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA2LTI0ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBBZGQgdXNl
ciBhZ2VudCBxdWlyayBmb3IgR29vZ2xlIERyaXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkxNTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHN1cHByZXNzZXMgYW4gdW5zdXBwb3J0ZWQgYnJv
d3NlciB3YXJuaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcDoK
KyAgICAgICAgKFdlYkNvcmU6OnVybFJlcXVpcmVzTWFjaW50b3NoUGxhdGZvcm0pOgorICAgICAg
ICAoV2ViQ29yZTo6dXJsUmVxdWlyZXNMaW51eERlc2t0b3BQbGF0Zm9ybSk6CisKIDIwMTktMDYt
MjQgIENoYXJsaWUgVHVybmVyICA8Y3R1cm5lckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3Ry
ZWFtZXJdW01TRV0gUGF1c2luZyB2aWRlbyBzb21ldGltZXMgY2F1c2VzIHNraXAgdG8gZmluaXNo
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Vc2VyQWdlbnRRdWlya3MuY3Bw
IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcAppbmRleCBmMTc2
MDBmMzgxZmRlYmEyYmJlNzc5NmZmZjJmYjk3MzhmYTIxMDZkLi5kNjY3NmJiYWU0ODI4N2FkNDM3
ZjZlZDdhMmM0MGRkMDkwOTk5Mzk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9Vc2VyQWdlbnRRdWlya3MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VzZXJB
Z2VudFF1aXJrcy5jcHAKQEAgLTEwNiw3ICsxMDYsOCBAQCBzdGF0aWMgYm9vbCB1cmxSZXF1aXJl
c01hY2ludG9zaFBsYXRmb3JtKGNvbnN0IFVSTCYgdXJsKQogCiAgICAgLy8gR29vZ2xlIERvY3Mg
c2hvd3MgYSBzY2FyeSB1bnN1cHBvcnRlZCBicm93c2VyIHdhcm5pbmcgd2l0aCBXZWJLaXRHVEsr
J3MKICAgICAvLyBzdGFuZGFyZCB1c2VyIGFnZW50LgotICAgIGlmIChkb21haW4gPT0gImRvY3Mu
Z29vZ2xlLmNvbSIpCisgICAgaWYgKGRvbWFpbiA9PSAiZG9jcy5nb29nbGUuY29tIgorICAgICAg
ICB8fCBkb21haW4gPT0gImRyaXZlLmdvb2dsZS5jb20iKQogICAgICAgICByZXR1cm4gdHJ1ZTsK
IAogICAgIHJldHVybiBmYWxzZTsKQEAgLTExNCw4ICsxMTUsMTAgQEAgc3RhdGljIGJvb2wgdXJs
UmVxdWlyZXNNYWNpbnRvc2hQbGF0Zm9ybShjb25zdCBVUkwmIHVybCkKIAogc3RhdGljIGJvb2wg
dXJsUmVxdWlyZXNMaW51eERlc2t0b3BQbGF0Zm9ybShjb25zdCBVUkwmIHVybCkKIHsKLSAgICAv
LyBkb2NzLmdvb2dsZS5jb20gcmVxdWlyZXMgdGhlIG1hY09TIHBsYXRmb3JtIHF1aXJrLgotICAg
IHJldHVybiBpc0dvb2dsZSh1cmwpICYmIHVybC5ob3N0KCkgIT0gImRvY3MuZ29vZ2xlLmNvbSI7
CisgICAgLy8gZG9jcy5nb29nbGUuY29tIGFuZCBkcml2ZS5nb29nbGUuY29tIHJlcXVpcmUgdGhl
IG1hY09TIHBsYXRmb3JtIHF1aXJrLgorICAgIHJldHVybiBpc0dvb2dsZSh1cmwpCisgICAgICAg
ICYmIHVybC5ob3N0KCkgIT0gImRvY3MuZ29vZ2xlLmNvbSIKKyAgICAgICAgJiYgdXJsLmhvc3Qo
KSAhPSAiZHJpdmUuZ29vZ2xlLmNvbSI7CiB9CiAKIFVzZXJBZ2VudFF1aXJrcyBVc2VyQWdlbnRR
dWlya3M6OnF1aXJrc0ZvclVSTChjb25zdCBVUkwmIHVybCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0No
YW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5YjFmNjBiNmFiMmVlY2ViNzkxMDU4YThh
M2Q3NTI2YmIwNTdkOGEzLi5iYjE4ZjY1OTkxNTEzYjdlMTJlMTUzZTRjNjBkYjZjYmNiYjFkNzg1
IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMTMgQEAKKzIwMTktMDYtMjQgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bp
Z2FsaWEuY29tPgorCisgICAgICAgIEFkZCB1c2VyIGFnZW50IHF1aXJrIGZvciBHb29nbGUgRHJp
dmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTE1
MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVz
dFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHA6CisgICAgICAgIChU
ZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxOS0wNi0yMiAgWmFsYW4gQnVqdGFzICA8emFsYW5A
YXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdIEV4cGFuZCB0ZXN0cyBjb3ZlcmFnZSAoMzI4IG5l
dyB0ZXN0cyAtPiAyNjUyKS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv
V2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X
ZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHAKaW5kZXggNWRiYTI0NjM5M2FmOTA2ZDFjYmZmNjhm
YjJjYjUyNGUwNjNiMDIzYi4uYmFjOGVkMTFkMGE4NzJmZjVkODI3NTBkZTZhNWEwYjAyZjBkZDdm
NyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VzZXJBZ2Vu
dFF1aXJrcy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VzZXJB
Z2VudFF1aXJrcy5jcHAKQEAgLTkzLDYgKzkzLDcgQEAgVEVTVChVc2VyQWdlbnRUZXN0LCBRdWly
a3MpCiAgICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzTWFjUGxhdGZvcm1RdWlyaygiaHR0cDov
L3dlYi53aGF0c2FwcC5jb20vIik7CiAgICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzTWFjUGxh
dGZvcm1RdWlyaygiaHR0cDovL3d3dy5jaGFzZS5jb20vIik7CiAgICAgYXNzZXJ0VXNlckFnZW50
Rm9yVVJMSGFzTWFjUGxhdGZvcm1RdWlyaygiaHR0cDovL2RvY3MuZ29vZ2xlLmNvbS8iKTsKKyAg
ICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNNYWNQbGF0Zm9ybVF1aXJrKCJodHRwOi8vZHJpdmUu
Z29vZ2xlLmNvbS8iKTsKICAgICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNNYWNQbGF0Zm9ybVF1
aXJrKCJodHRwOi8vcGF5cGFsLmNvbS8iKTsKICAgICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNN
YWNQbGF0Zm9ybVF1aXJrKCJodHRwOi8vb3V0bG9vay5saXZlLmNvbS8iKTsKICAgICBhc3NlcnRV
c2VyQWdlbnRGb3JVUkxIYXNNYWNQbGF0Zm9ybVF1aXJrKCJodHRwOi8vbWFpbC5udHUuZWR1LnR3
LyIpOwo=
</data>
<flag name="review"
          id="388533"
          type_id="1"
          status="+"
          setter="cgarcia"
    />
          </attachment>
      

    </bug>

</bugzilla>