199149 2019-06-24 04:59:02 -0700 [ews-build] Enable iOS-12-Build queue on new EWS 2019-06-24 12:25:27 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197396 https://bugs.webkit.org/show_bug.cgi?id=199150 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard ryanhaddad webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1547291 0 aakash_jain 2019-06-24 04:59:02 -0700 Enable iOS-12-Build queue on new EWS in production. 1547295 1 372746 aakash_jain 2019-06-24 05:12:53 -0700 Created attachment 372746 Patch 1547296 2 aakash_jain 2019-06-24 05:16:09 -0700 Note that this queue doesn't run layout-tests (we run layout-tests only on iOS simulator, not on iOS devices). Sample runs: Success: https://ews-build.webkit-uat.org/#/builders/38/builds/2 ToT Failure: https://ews-build.webkit-uat.org/#/builders/38/builds/13 Patch Failure: https://ews-build.webkit-uat.org/#/builders/38/builds/16 1547328 3 372746 jbedard 2019-06-24 07:18:09 -0700 Comment on attachment 372746 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372746&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:42 > + ALL_QUEUES = ['ios', 'api-ios', 'api-mac', 'bindings', 'gtk', 'ios-sim', 'ios-wk2', 'jsc', 'mac', 'mac-32bit', 'mac-32bit-wk2', Why did we change this order? > Tools/BuildSlaveSupport/ews-build/config.json:295 > + "workernames": ["ews152", "ews154", "ews108", "ews109"] You mention in your changelog that we're sharing temporarily...why temporarily? This seems like a good idea more generally. 1547342 4 372746 aakash_jain 2019-06-24 07:39:36 -0700 Comment on attachment 372746 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372746&action=review >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:42 >> + ALL_QUEUES = ['ios', 'api-ios', 'api-mac', 'bindings', 'gtk', 'ios-sim', 'ios-wk2', 'jsc', 'mac', 'mac-32bit', 'mac-32bit-wk2', > > Why did we change this order? So as to display the iOS bubble on the left. e.g.: https://ews.webkit-uat.org/status-bubble/372719/ I mentioned in ChangeLog: "Also display the ios bubble first (left). Going forward will keep the builders to the left and testers to the right." >> Tools/BuildSlaveSupport/ews-build/config.json:295 >> + "workernames": ["ews152", "ews154", "ews108", "ews109"] > > You mention in your changelog that we're sharing temporarily...why temporarily? This seems like a good idea more generally. We can leave them shared as well if we feel that this sharing is helping on this queue. This is required currently until move ews108 and ews109 from old to new EWS <rdar://problem/52051091>. 1547373 5 372746 commit-queue 2019-06-24 08:26:55 -0700 Comment on attachment 372746 Patch Clearing flags on attachment: 372746 Committed r246738: <https://trac.webkit.org/changeset/246738> 1547374 6 commit-queue 2019-06-24 08:26:56 -0700 All reviewed patches have been landed. Closing bug. 1547375 7 webkit-bug-importer 2019-06-24 08:27:15 -0700 <rdar://problem/52054574> 1547478 8 aakash_jain 2019-06-24 12:25:27 -0700 Deployed the change to the production. 'ios' bubble is now visible in new EWS bubbles. 372746 2019-06-24 05:12:53 -0700 2019-06-24 08:26:55 -0700 Patch bug-199149-20190624081252.patch text/plain 3695 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NjczMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTA2LTI0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBFbmFibGUgaU9TLTEyLUJ1aWxkIHF1ZXVlIG9uIG5l dyBFV1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 OTE0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2NvbmZpZy5qc29uOiBFbmFibGUgaU9TLTEyLUJ1 aWxkLUVXUyB0cmlnZ2VyLiBBbHNvIHRlbXBvcmFyaWx5IHNoYXJlIGV3czE1MiBhbmQgZXdzMTU0 IHdpdGgKKyAgICAgICAgdGhpcyBxdWV1ZS4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9l d3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHk6CisgICAgICAgIChTdGF0dXNCdWJibGUp OiBFbmFibGUgaW9zIHN0YXR1cy1idWJibGUuIEFsc28gZGlzcGxheSB0aGUgaW9zIGJ1YmJsZSBm aXJzdCAobGVmdCkuIEdvaW5nIGZvcndhcmQKKyAgICAgICAgd2lsbCBrZWVwIHRoZSBidWlsZGVy cyB0byB0aGUgbGVmdCBhbmQgdGVzdGVycyB0byB0aGUgcmlnaHQuCisKIDIwMTktMDYtMjIgIFph bGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXSBFeHBhbmQgdGVz dHMgY292ZXJhZ2UgKDMyOCBuZXcgdGVzdHMgLT4gMjY1MikuCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxl LnB5CShyZXZpc2lvbiAyNDY3MzEpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBw L2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkJKHdvcmtpbmcgY29weSkKQEAgLTM5LDkgKzM5LDkg QEAgaW1wb3J0IGV3cy5jb25maWcgYXMgY29uZmlnCiBjbGFzcyBTdGF0dXNCdWJibGUoVmlldyk6 CiAgICAgIyBUaGVzZSBxdWV1ZSBuYW1lcyBhcmUgZnJvbSBzaG9ydG5hbWUgaW4gaHR0cHM6Ly90 cmFjLndlYmtpdC5vcmcvYnJvd3Nlci93ZWJraXQvdHJ1bmsvVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWJ1aWxkL2NvbmZpZy5qc29uCiAgICAgIyBGSVhNRTogQXV0by1nZW5lcmF0ZSB0aGlz IGxpc3QgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTY0MAotICAg IEFMTF9RVUVVRVMgPSBbJ2FwaS1pb3MnLCAnYXBpLW1hYycsICdiaW5kaW5ncycsICdndGsnLCAn aW9zJywgJ2lvcy1zaW0nLCAnaW9zLXdrMicsICdqc2MnLCAnbWFjJywgJ21hYy0zMmJpdCcsICdt YWMtMzJiaXQtd2syJywKKyAgICBBTExfUVVFVUVTID0gWydpb3MnLCAnYXBpLWlvcycsICdhcGkt bWFjJywgJ2JpbmRpbmdzJywgJ2d0aycsICdpb3Mtc2ltJywgJ2lvcy13azInLCAnanNjJywgJ21h YycsICdtYWMtMzJiaXQnLCAnbWFjLTMyYml0LXdrMicsCiAgICAgICAgICAgICAgICAgICAgICdt YWMtZGVidWcnLCAnbWFjLWRlYnVnLXdrMScsICdtYWMtd2sxJywgJ21hYy13azInLCAnc3R5bGUn LCAnd2Via2l0cGVybCcsICd3ZWJraXRweScsICd3aW4nLCAnd2luY2Fpcm8nLCAnd3BlJ10KLSAg ICBFTkFCTEVEX1FVRVVFUyA9IFsnYXBpLWlvcycsICdhcGktbWFjJywgJ2JpbmRpbmdzJywgJ3dl YmtpdHBlcmwnLCAnd2Via2l0cHknXQorICAgIEVOQUJMRURfUVVFVUVTID0gWydpb3MnLCAnYXBp LWlvcycsICdhcGktbWFjJywgJ2JpbmRpbmdzJywgJ3dlYmtpdHBlcmwnLCAnd2Via2l0cHknXQog ICAgICMgRklYTUU6IEF1dG8tZ2VuZXJhdGUgdGhlIHF1ZXVlJ3MgdHJpZ2dlciByZWxhdGlvbnNo aXAKICAgICBRVUVVRV9UUklHR0VSUyA9IHsKICAgICAgICAgJ2FwaS1pb3MnOiAnaW9zLXNpbScs CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvY29uZmlnLmpzb24KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2NvbmZpZy5qc29u CShyZXZpc2lvbiAyNDY3MzEpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv Y29uZmlnLmpzb24JKHdvcmtpbmcgY29weSkKQEAgLTI5Miw3ICsyOTIsNyBAQAogICAgICAgInBs YXRmb3JtIjogImlvcy0xMiIsCiAgICAgICAiY29uZmlndXJhdGlvbiI6ICJyZWxlYXNlIiwKICAg ICAgICJhcmNoaXRlY3R1cmVzIjogWyJhcm02NCJdLAotICAgICAgIndvcmtlcm5hbWVzIjogWyJl d3MxMDgiLCAiZXdzMTA5Il0KKyAgICAgICJ3b3JrZXJuYW1lcyI6IFsiZXdzMTUyIiwgImV3czE1 NCIsICJld3MxMDgiLCAiZXdzMTA5Il0KICAgICB9LAogICAgIHsKICAgICAgICJuYW1lIjogImlP Uy0xMi1TaW11bGF0b3ItQnVpbGQtRVdTIiwKQEAgLTQzNCwxNCArNDM0LDE0IEBACiAgICAgICAi dHlwZSI6ICJUcnlfVXNlcnBhc3MiLAogICAgICAgIm5hbWUiOiAidHJ5IiwKICAgICAgICJwb3J0 IjogNTU1NSwKLSAgICAgICJidWlsZGVyTmFtZXMiOiBbIkJpbmRpbmdzLVRlc3RzLUVXUyIsICJt YWNPUy1IaWdoLVNpZXJyYS1SZWxlYXNlLUJ1aWxkLUVXUyIsCi0gICAgICAgICAgICAgICAgICAg ICAgICJpT1MtMTItU2ltdWxhdG9yLUJ1aWxkLUVXUyIsICJXZWJLaXRQZXJsLVRlc3RzLUVXUyIs ICJXZWJLaXRQeS1UZXN0cy1FV1MiXQorICAgICAgImJ1aWxkZXJOYW1lcyI6IFsiQmluZGluZ3Mt VGVzdHMtRVdTIiwgImlPUy0xMi1CdWlsZC1FV1MiLCAiaU9TLTEyLVNpbXVsYXRvci1CdWlsZC1F V1MiLAorICAgICAgICAgICAgICAgICAgICAgICAibWFjT1MtSGlnaC1TaWVycmEtUmVsZWFzZS1C dWlsZC1FV1MiLCAiV2ViS2l0UGVybC1UZXN0cy1FV1MiLCAiV2ViS2l0UHktVGVzdHMtRVdTIl0K ICAgICB9LAogICAgIHsKICAgICAgICJ0eXBlIjogIlRyeV9Vc2VycGFzcyIsCiAgICAgICAibmFt ZSI6ICJkaXNhYmxlZCIsCiAgICAgICAicG9ydCI6IDU1NTYsCi0gICAgICAiYnVpbGRlck5hbWVz IjogWyJHVEstV2Via2l0Mi1FV1MiLCAiaU9TLTEyLUJ1aWxkLUVXUyIsICJKU0MtVGVzdHMtRVdT IiwKKyAgICAgICJidWlsZGVyTmFtZXMiOiBbIkdUSy1XZWJraXQyLUVXUyIsICJKU0MtVGVzdHMt RVdTIiwKICAgICAgICAgICAgICAgICAgICAgICAgImlPUy0xMi1TaW11bGF0b3ItV0syLVRlc3Rz LUVXUyIsICJtYWNPUy1IaWdoLVNpZXJyYS1SZWxlYXNlLVdLMi1UZXN0cy1FV1MiLCAgIm1hY09T LUhpZ2gtU2llcnJhLVJlbGVhc2UtV0sxLVRlc3RzLUVXUyIsCiAgICAgICAgICAgICAgICAgICAg ICAgICJtYWNPUy1IaWdoLVNpZXJyYS1EZWJ1Zy1CdWlsZC1FV1MiLCAiU3R5bGUtRVdTIiwgIldp bkNhaXJvLUVXUyIsICJXaW5kb3dzLUVXUyIsICJXUEUtRVdTIl0KICAgICB9LAo=