199140 2019-06-23 17:27:59 -0700 Platform font class gets needlessly initialized in the Networking process 2019-06-24 09:25:07 -0700 1 1 1 Unclassified WebKit WebKit2 Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199119 InRadar P2 Normal --- 1 mitz webkit-unassigned bfulgham commit-queue thorton webkit-bug-importer oldest_to_newest 1547229 0 mitz 2019-06-23 17:27:59 -0700 typeFromObject() in ArgumentCodersCocoa.mm calls [PlatformFont class] which invokes the class’s initializer. This is wasteful to do in the Networking process, which doesn’t use the class otherwise. 1547230 1 372721 mitz 2019-06-23 17:33:06 -0700 Created attachment 372721 Use NSClassFromString to avoid unnecessary initialization 1547250 2 372721 commit-queue 2019-06-23 20:44:57 -0700 Comment on attachment 372721 Use NSClassFromString to avoid unnecessary initialization Clearing flags on attachment: 372721 Committed r246726: <https://trac.webkit.org/changeset/246726> 1547251 3 commit-queue 2019-06-23 20:44:59 -0700 All reviewed patches have been landed. Closing bug. 1547252 4 webkit-bug-importer 2019-06-23 20:48:00 -0700 <rdar://problem/52040306> 1547386 5 372721 bfulgham 2019-06-24 09:25:07 -0700 Comment on attachment 372721 Use NSClassFromString to avoid unnecessary initialization View in context: https://bugs.webkit.org/attachment.cgi?id=372721&action=review > Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:115 > + if ([object isKindOfClass:platformColorClass()]) Oh, really nice. Thank you guys for improving that! 372721 2019-06-23 17:33:06 -0700 2019-06-23 20:44:57 -0700 Use NSClassFromString to avoid unnecessary initialization file_199140.txt text/plain 4261 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gU291cmNlL1dl YktpdC9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NjcyNCkNCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwyMCBAQA0KKzIwMTktMDYtMjMgIERhbiBC ZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4NCisNCisgICAgICAgIFBsYXRmb3JtIGZvbnQgY2xh c3MgZ2V0cyBuZWVkbGVzc2x5IGluaXRpYWxpemVkIGluIHRoZSBOZXR3b3JraW5nIHByb2Nlc3MN CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkxNDAN CisNCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAgKiBO ZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5pbjog UmV2ZXJ0IGEgY2hhbmdlIHRoYXQgd2FzIG1hZGUgaW4NCisgICAgICAgICAgcjI0NjcwMiwgd2hp Y2ggaXMgbm90IG5lZWRlZCBhbnltb3JlLg0KKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFBy b2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtpbmcuc2I6IERpdHRvLg0KKw0KKyAg ICAgICAgKiBTaGFyZWQvQ29jb2EvQXJndW1lbnRDb2RlcnNDb2NvYS5tbToNCisgICAgICAgIChJ UEM6OnBsYXRmb3JtQ29sb3JDbGFzcyk6IEFkZGVkIGdldHRlciB0aGF0IHVzZXMgTlNDbGFzc0Zy b21TdHJpbmcsIHRoZXJlYnkgYXZvaWRpbmcNCisgICAgICAgICAgaW5pdGlhbGl6aW5nIHRoZSBj bGFzcy4NCisgICAgICAgIChJUEM6OnBsYXRmb3JtRm9udENsYXNzKTogRGl0dG8uDQorICAgICAg ICAoSVBDOjp0eXBlRnJvbU9iamVjdCk6IENoYW5nZWQgdG8gdXNlIHRoZSBhYm92ZSBnZXR0ZXJz IGluc3RlYWQgb2YgK2NsYXNzLg0KKw0KIDIwMTktMDYtMjMgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+DQogDQogICAgICAgICBBZGQgT3ZlcmZsb3dTY3JvbGxQcm94eU5v ZGVzIHRvIHRoZSBzY3JvbGxpbmcgdHJlZQ0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2IuaW4NCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0NCi0tLSBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0 Lk5ldHdvcmtQcm9jZXNzLnNiLmluCShyZXZpc2lvbiAyNDY3MjQpDQorKysgU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5p bgkod29ya2luZyBjb3B5KQ0KQEAgLTk1LDcgKzk1LDYgQEANCiANCiAoYWxsb3cgZmlsZS1yZWFk Kg0KICAgICA7OyBCYXNpYyBzeXN0ZW0gcGF0aHMNCi0gICAgKHN1YnBhdGggIi9MaWJyYXJ5L0Zv bnRzIikgOzsgTmVlZGVkIHRvIHNlcmlhbGl6ZSBmb250IGRhdGEgdHlwZXMgPHJkYXI6Ly9wcm9i bGVtLzUwMTY0ODc5Pg0KICAgICAoc3VicGF0aCAiL0xpYnJhcnkvRnJhbWV3b3JrcyIpDQogICAg IChzdWJwYXRoICIvTGlicmFyeS9NYW5hZ2VkIFByZWZlcmVuY2VzIikNCiANCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQu TmV0d29ya2luZy5zYg0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1Nh bmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5nLnNiCShyZXZpc2lv biAyNDY3MjQpDQorKysgU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lv cy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtpbmcuc2IJKHdvcmtpbmcgY29weSkNCkBAIC03Miwx MiArNzIsNiBAQA0KICAgICAobGl0ZXJhbCAiL3Vzci9sb2NhbC9saWIvbG9nIikgOyA8cmRhcjov L3Byb2JsZW0vMzY2Mjk0OTU+DQogKQ0KIA0KLTs7IFJlYWQtb25seSBwcmVmZXJlbmNlcyBhbmQg ZGF0YQ0KLShhbGxvdyBmaWxlLXJlYWQqDQotICAgIDs7IEJhc2ljIHN5c3RlbSBwYXRocw0KLSAg ICAoc3VicGF0aCAiL0xpYnJhcnkvRm9udHMiKSA7OyBOZWVkZWQgdG8gc2VyaWFsaXplIGZvbnQg ZGF0YSB0eXBlcyA8cmRhcjovL3Byb2JsZW0vNTAxNjQ4Nzk+DQotKQ0KLQ0KIDs7IFNlY3VyaXR5 IGZyYW1ld29yaw0KIChhbGxvdyBtYWNoLWxvb2t1cA0KICAgICAoZ2xvYmFsLW5hbWUgImNvbS5h cHBsZS5vY3NwZCIpDQpJbmRleDogU291cmNlL1dlYktpdC9TaGFyZWQvQ29jb2EvQXJndW1lbnRD b2RlcnNDb2NvYS5tbQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29h L0FyZ3VtZW50Q29kZXJzQ29jb2EubW0JKHJldmlzaW9uIDI0NjcyNCkNCisrKyBTb3VyY2UvV2Vi S2l0L1NoYXJlZC9Db2NvYS9Bcmd1bWVudENvZGVyc0NvY29hLm1tCSh3b3JraW5nIGNvcHkpDQpA QCAtNzcsNiArNzcsMzQgQEAgZW51bSBjbGFzcyBOU1R5cGUgew0KIA0KICNwcmFnbWEgbWFyayAt IEhlbHBlcnMNCiANCitzdGF0aWMgQ2xhc3MgcGxhdGZvcm1Db2xvckNsYXNzKCkNCit7DQorICAg IHN0YXRpYyBDbGFzcyBjb2xvckNsYXNzOw0KKyAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgZmxh ZzsNCisgICAgc3RkOjpjYWxsX29uY2UoZmxhZywgW10gew0KKyNpZiBVU0UoQVBQS0lUKQ0KKyAg ICAgICAgY29sb3JDbGFzcyA9IE5TQ2xhc3NGcm9tU3RyaW5nKEAiTlNDb2xvciIpOw0KKyNlbHNl DQorICAgICAgICBjb2xvckNsYXNzID0gTlNDbGFzc0Zyb21TdHJpbmcoQCJVSUNvbG9yIik7DQor I2VuZGlmDQorICAgIH0pOw0KKyAgICByZXR1cm4gY29sb3JDbGFzczsNCit9DQorDQorc3RhdGlj IENsYXNzIHBsYXRmb3JtRm9udENsYXNzKCkNCit7DQorICAgIHN0YXRpYyBDbGFzcyBmb250Q2xh c3M7DQorICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxhZyBmbGFnOw0KKyAgICBzdGQ6OmNhbGxfb25j ZShmbGFnLCBbXSB7DQorI2lmIFVTRShBUFBLSVQpDQorICAgICAgICBmb250Q2xhc3MgPSBOU0Ns YXNzRnJvbVN0cmluZyhAIk5TRm9udCIpOw0KKyNlbHNlDQorICAgICAgICBmb250Q2xhc3MgPSBO U0NsYXNzRnJvbVN0cmluZyhAIlVJRm9udCIpOw0KKyNlbmRpZg0KKyAgICB9KTsNCisgICAgcmV0 dXJuIGZvbnRDbGFzczsNCit9DQorDQogc3RhdGljIE5TVHlwZSB0eXBlRnJvbU9iamVjdChpZCBv YmplY3QpDQogew0KICAgICBBU1NFUlQob2JqZWN0KTsNCkBAIC04NCw3ICsxMTIsNyBAQCBzdGF0 aWMgTlNUeXBlIHR5cGVGcm9tT2JqZWN0KGlkIG9iamVjdCkNCiAgICAgLy8gU3BlY2lmaWMgY2xh c3NlcyBoYW5kbGVkLg0KICAgICBpZiAoW29iamVjdCBpc0tpbmRPZkNsYXNzOltOU0FycmF5IGNs YXNzXV0pDQogICAgICAgICByZXR1cm4gTlNUeXBlOjpBcnJheTsNCi0gICAgaWYgKFtvYmplY3Qg aXNLaW5kT2ZDbGFzczpbUGxhdGZvcm1Db2xvciBjbGFzc11dKQ0KKyAgICBpZiAoW29iamVjdCBp c0tpbmRPZkNsYXNzOnBsYXRmb3JtQ29sb3JDbGFzcygpXSkNCiAgICAgICAgIHJldHVybiBOU1R5 cGU6OkNvbG9yOw0KICAgICBpZiAoW29iamVjdCBpc0tpbmRPZkNsYXNzOltOU0RhdGEgY2xhc3Nd XSkNCiAgICAgICAgIHJldHVybiBOU1R5cGU6OkRhdGE7DQpAQCAtOTIsNyArMTIwLDcgQEAgc3Rh dGljIE5TVHlwZSB0eXBlRnJvbU9iamVjdChpZCBvYmplY3QpDQogICAgICAgICByZXR1cm4gTlNU eXBlOjpEYXRlOw0KICAgICBpZiAoW29iamVjdCBpc0tpbmRPZkNsYXNzOltOU0RpY3Rpb25hcnkg Y2xhc3NdXSkNCiAgICAgICAgIHJldHVybiBOU1R5cGU6OkRpY3Rpb25hcnk7DQotICAgIGlmIChb b2JqZWN0IGlzS2luZE9mQ2xhc3M6W1BsYXRmb3JtRm9udCBjbGFzc11dKQ0KKyAgICBpZiAoW29i amVjdCBpc0tpbmRPZkNsYXNzOnBsYXRmb3JtRm9udENsYXNzKCldKQ0KICAgICAgICAgcmV0dXJu IE5TVHlwZTo6Rm9udDsNCiAgICAgaWYgKFtvYmplY3QgaXNLaW5kT2ZDbGFzczpbTlNOdW1iZXIg Y2xhc3NdXSkNCiAgICAgICAgIHJldHVybiBOU1R5cGU6Ok51bWJlcjsNCg==