199131 2019-06-22 16:00:01 -0700 Web Inspector: Styles: show green highlight for newly added properties only when name and value are present 2019-06-23 11:32:59 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1547139 0 nvasilyev 2019-06-22 16:00:01 -0700 Steps: 1. Add a new CSS property (say, by clicking on the white space after "Style Attribute {"). Expected: No green highlight (until the property name and value are added). Actual: The green highlight is shown right away. 1547140 1 372691 nvasilyev 2019-06-22 16:00:48 -0700 Created attachment 372691 Patch 1547190 2 372691 mattbaker 2019-06-23 11:02:36 -0700 Comment on attachment 372691 Patch r=me 1547191 3 webkit-bug-importer 2019-06-23 11:03:02 -0700 <rdar://problem/52033894> 1547192 4 372691 commit-queue 2019-06-23 11:32:57 -0700 Comment on attachment 372691 Patch Clearing flags on attachment: 372691 Committed r246722: <https://trac.webkit.org/changeset/246722> 1547193 5 commit-queue 2019-06-23 11:32:59 -0700 All reviewed patches have been landed. Closing bug. 372691 2019-06-22 16:00:48 -0700 2019-06-23 11:32:57 -0700 Patch patch.txt text/plain 1514 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE3MTU1NWQyMjBjLi5iOTYyNmI3NjQ1MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDYtMjIgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogU3R5bGVzOiBzaG93IGdyZWVuIGhpZ2hsaWdodCBmb3IgbmV3bHkgYWRkZWQgcHJvcGVydGll cyBvbmx5IHdoZW4gbmFtZSBhbmQgdmFsdWUgYXJlIHByZXNlbnQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTEzMQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TcHJl YWRzaGVldFN0eWxlUHJvcGVydHkuanM6CisgICAgICAgIChXSS5TcHJlYWRzaGVldFN0eWxlUHJv cGVydHkucHJvdG90eXBlLnVwZGF0ZVN0YXR1cyk6CisKIDIwMTktMDYtMjIgIE5pa2l0YSBWYXNp bHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjQxOTgw KTogV2ViIEluc3BlY3RvcjogU3R5bGVzOiBQcmVzc2luZyBUYWIvRW50ZXIgb24gbGFzdCBwcm9w ZXJ0eSBubyBsb25nZXIgZm9jdXNlcyBvbiBzZWxlY3RvciBvbiBuZXh0IHJ1bGUKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNoZWV0 U3R5bGVQcm9wZXJ0eS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1NwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5qcwppbmRleCA3ZjU5MzIzMWEyOC4uN2YxNjll OWM0ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1NwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkuanMKQEAgLTMx Myw3ICszMTMsNyBAQCBXSS5TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkgPSBjbGFzcyBTcHJlYWRz aGVldFN0eWxlUHJvcGVydHkgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgaWYgKCF0aGlzLl9w cm9wZXJ0eS5lbmFibGVkKQogICAgICAgICAgICAgY2xhc3NOYW1lcy5wdXNoKCJkaXNhYmxlZCIp OwogCi0gICAgICAgIGlmICh0aGlzLl9wcm9wZXJ0eS5tb2RpZmllZCkKKyAgICAgICAgaWYgKHRo aXMuX3Byb3BlcnR5Lm1vZGlmaWVkICYmIHRoaXMuX3Byb3BlcnR5Lm5hbWUgJiYgdGhpcy5fcHJv cGVydHkucmF3VmFsdWUpCiAgICAgICAgICAgICBjbGFzc05hbWVzLnB1c2goIm1vZGlmaWVkIik7 CiAKICAgICAgICAgaWYgKHRoaXMuX3NlbGVjdGVkKQo=