199126 2019-06-21 19:28:15 -0700 Nullptr crash in DeleteSelectionCommand::handleGeneralDelete 2019-06-21 21:05:39 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa megan_gardner webkit-bug-importer wenson_hsieh oldest_to_newest 1547056 0 rniwa 2019-06-21 19:28:15 -0700 e.g. 0 WebCore 0x00000001bdd37420 WebCore::DeleteSelectionCommand::handleGeneralDelete() + 2348 (Node.h:595) 1 WebCore 0x00000001bdd36fbc WebCore::DeleteSelectionCommand::handleGeneralDelete() + 1224 (DeleteSelectionCommand.cpp:593) 2 WebCore 0x00000001bdd3993c WebCore::DeleteSelectionCommand::doApply() + 1228 (DeleteSelectionCommand.cpp:926) 3 WebCore 0x00000001bdd26ca0 WebCore::CompositeEditCommand::applyCommandToComposite(WTF::Ref<WebCore::EditCommand, WTF::DumbPtrTraits<WebCore::EditCommand> >&&) + 68 (CompositeEditCommand.cpp:463) 4 WebCore 0x00000001bdd28754 WebCore::CompositeEditCommand::deleteSelection(WebCore::VisibleSelection const&, bool, bool, bool, bool, bool) + 128 (CompositeEditCommand.cpp:855) 5 WebCore 0x00000001bdda5d78 WebCore::TypingCommand::deleteKeyPressed(WebCore::TextGranularity, bool) + 3284 (TypingCommand.cpp:763) 6 WebCore 0x00000001bdd26914 WebCore::CompositeEditCommand::apply() + 304 (CompositeEditCommand.cpp:372) 7 WebCore 0x00000001bdda4da8 WebCore::TypingCommand::deleteKeyPressed(WebCore::Document&, unsigned int, WebCore::TextGranularity) + 104 (TypingCommand.cpp:196) 8 WebCore 0x00000001bdd4e808 WebCore::Editor::deleteWithDirection(WebCore::SelectionDirection, WebCore::TextGranularity, bool, bool) + 480 (Editor.cpp:0) 9 WebCore 0x00000001bdd73a7c WebCore::executeDeleteBackward(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) + 36 (EditorCommand.cpp:309) 10 WebCore 0x00000001bdd56b78 WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const + 332 (EditorCommand.cpp:1852) 11 WebKit 0x00000001b0ecc4cc WebKit::WebPage::executeEditingCommand(WTF::String const&, WTF::String const&) + 120 (WebPage.cpp:1240) 12 WebKit 0x00000001b0eebf4c void IPC::handleMessage<Messages::WebPage::ExecuteEditCommand, WebKit::WebPage, void (WebKit::WebPage::*)(WTF::String const&, WTF::String const&)>(IPC::Decoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::String const&, WTF::String const&)) + 116 (HandleMessage.h:41) <rdar://problem/51161612> 1547057 1 372669 rniwa 2019-06-21 19:31:36 -0700 Created attachment 372669 Fixes the crash 1547058 2 372669 megan_gardner 2019-06-21 19:36:48 -0700 Comment on attachment 372669 Fixes the crash R+ as well. 1547059 3 rniwa 2019-06-21 19:44:28 -0700 Waiting for EWS... 1547063 4 rniwa 2019-06-21 21:04:25 -0700 Committed r246706: <https://trac.webkit.org/changeset/246706> 1547066 5 webkit-bug-importer 2019-06-21 21:05:39 -0700 <rdar://problem/52012691> 372669 2019-06-21 19:31:36 -0700 2019-06-21 19:36:01 -0700 Fixes the crash bug-199126-20190621193136.patch text/plain 2801 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NjcwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA2LTIxICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2ggaW4gRGVs ZXRlU2VsZWN0aW9uQ29tbWFuZDo6aGFuZGxlR2VuZXJhbERlbGV0ZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MTI2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgbnVsbCBjaGVja3MgdG8gaGFu ZGxlR2VuZXJhbERlbGV0ZSBhcyB3ZWxsIGFzIG1lcmdlUGFyYWdyYXBocyB3aGljaCBydW5zIGFm dGVyIGhhbmRsZUdlbmVyYWxEZWxldGUgdG8gYmUgZGVmZW5zaXZlLgorCisgICAgICAgIFVuZm9y dHVuYXRlbHkgbm8gbmV3IHRlc3RzIHNpbmNlIHRoZXJlIGlzIG5vIHJlcHJvZHVjaWJsZSB0ZXN0 IGNhc2UuCisKKyAgICAgICAgKiBlZGl0aW5nL0RlbGV0ZVNlbGVjdGlvbkNvbW1hbmQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RGVsZXRlU2VsZWN0aW9uQ29tbWFuZDo6aGFuZGxlR2VuZXJhbERl bGV0ZSk6CisgICAgICAgIChXZWJDb3JlOjpEZWxldGVTZWxlY3Rpb25Db21tYW5kOjptZXJnZVBh cmFncmFwaHMpOgorCiAyMDE5LTA2LTIxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXNvdXJjZUxvYWROb3RpZmllciBzaG91bGQgY2hlY2sgd2hldGhlciBp dHMgZnJhbWUgZG9jdW1lbnQgbG9hZGVyIGlzIG51bGwKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFuZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5kLmNwcAkocmV2aXNpb24gMjQ2NzA1 KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5kLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNjEwLDcgKzYxMCw5IEBAIHZvaWQgRGVsZXRlU2VsZWN0aW9uQ29t bWFuZDo6aGFuZGxlR2VuZXIKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICAKLSAg ICAgICAgaWYgKG1fZG93bnN0cmVhbUVuZC5kZXByZWNhdGVkTm9kZSgpICE9IHN0YXJ0Tm9kZSAm JiAhbV91cHN0cmVhbVN0YXJ0LmRlcHJlY2F0ZWROb2RlKCktPmlzRGVzY2VuZGFudE9mKG1fZG93 bnN0cmVhbUVuZC5kZXByZWNhdGVkTm9kZSgpKSAmJiBtX2Rvd25zdHJlYW1FbmQuYW5jaG9yTm9k ZSgpLT5pc0Nvbm5lY3RlZCgpICYmIG1fZG93bnN0cmVhbUVuZC5kZXByZWNhdGVkRWRpdGluZ09m ZnNldCgpID49IGNhcmV0TWluT2Zmc2V0KCptX2Rvd25zdHJlYW1FbmQuZGVwcmVjYXRlZE5vZGUo KSkpIHsKKyAgICAgICAgaWYgKCFtX2Rvd25zdHJlYW1FbmQuaXNOdWxsKCkgJiYgIW1fZG93bnN0 cmVhbUVuZC5pc09ycGhhbigpICYmIG1fZG93bnN0cmVhbUVuZC5kZXByZWNhdGVkTm9kZSgpICE9 IHN0YXJ0Tm9kZQorICAgICAgICAgICAgJiYgIW1fdXBzdHJlYW1TdGFydC5kZXByZWNhdGVkTm9k ZSgpLT5pc0Rlc2NlbmRhbnRPZihtX2Rvd25zdHJlYW1FbmQuZGVwcmVjYXRlZE5vZGUoKSkKKyAg ICAgICAgICAgICYmIG1fZG93bnN0cmVhbUVuZC5kZXByZWNhdGVkRWRpdGluZ09mZnNldCgpID49 IGNhcmV0TWluT2Zmc2V0KCptX2Rvd25zdHJlYW1FbmQuZGVwcmVjYXRlZE5vZGUoKSkpIHsKICAg ICAgICAgICAgIGlmIChtX2Rvd25zdHJlYW1FbmQuYXRMYXN0RWRpdGluZ1Bvc2l0aW9uRm9yTm9k ZSgpICYmICFjYW5IYXZlQ2hpbGRyZW5Gb3JFZGl0aW5nKCptX2Rvd25zdHJlYW1FbmQuZGVwcmVj YXRlZE5vZGUoKSkpIHsKICAgICAgICAgICAgICAgICAvLyBUaGUgbm9kZSBpdHNlbGYgaXMgZnVs bHkgc2VsZWN0ZWQsIG5vdCBqdXN0IGl0cyBjb250ZW50cy4gIERlbGV0ZSBpdC4KICAgICAgICAg ICAgICAgICByZW1vdmVOb2RlKCptX2Rvd25zdHJlYW1FbmQuZGVwcmVjYXRlZE5vZGUoKSk7CkBA IC02NzksNyArNjgxLDcgQEAgdm9pZCBEZWxldGVTZWxlY3Rpb25Db21tYW5kOjptZXJnZVBhcmFn cgogICAgIEFTU0VSVCghbV9wcnVuZVN0YXJ0QmxvY2tJZk5lY2Vzc2FyeSk7CiAKICAgICAvLyBG SVhNRTogRGVsZXRpb24gc2hvdWxkIGFkanVzdCBzZWxlY3Rpb24gZW5kcG9pbnRzIGFzIGl0IHJl bW92ZXMgbm9kZXMgc28gdGhhdCB3ZSBuZXZlciBnZXQgaW50byB0aGlzIHN0YXRlICg0MDk5ODM5 KS4KLSAgICBpZiAoIW1fZG93bnN0cmVhbUVuZC5hbmNob3JOb2RlKCktPmlzQ29ubmVjdGVkKCkg fHwgIW1fdXBzdHJlYW1TdGFydC5hbmNob3JOb2RlKCktPmlzQ29ubmVjdGVkKCkpCisgICAgaWYg KG1fZG93bnN0cmVhbUVuZC5pc051bGwoKSB8fCBtX3Vwc3RyZWFtU3RhcnQuaXNOdWxsKCkgfHwg IW1fZG93bnN0cmVhbUVuZC5hbmNob3JOb2RlKCktPmlzQ29ubmVjdGVkKCkgfHwgIW1fdXBzdHJl YW1TdGFydC5hbmNob3JOb2RlKCktPmlzQ29ubmVjdGVkKCkpCiAgICAgICAgICByZXR1cm47CiAK ICAgICAvLyBGSVhNRTogVGhlIGRlbGV0aW9uIGFsZ29yaXRobSBzaG91bGRuJ3QgbGV0IHRoaXMg aGFwcGVuLgo=