199120 2019-06-21 15:20:58 -0700 [ews-build] Upload test results after running layout-tests 2019-06-24 08:12:23 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist jbedard webkit-bug-importer oldest_to_newest 1547019 0 aakash_jain 2019-06-21 15:20:58 -0700 EWS should upload test results after running layout-tests. This will allow users to see the test results. 1547020 1 372658 aakash_jain 2019-06-21 15:23:16 -0700 Created attachment 372658 Patch 1547021 2 aakash_jain 2019-06-21 15:23:37 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/35/builds/8 1547022 3 ews-watchlist 2019-06-21 15:25:39 -0700 Attachment 372658 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:792: [RunWebKitTests.evaluateCommand] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:819: [TestRunWebKitTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:819: [TestRunWebKitTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:855: [TestRunWebKit1Tests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:855: [TestRunWebKit1Tests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1547343 4 372658 jbedard 2019-06-24 07:46:16 -0700 Comment on attachment 372658 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372658&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:800 > + self.build.addStepsAfterCurrentStep([ArchiveTestResults(), UploadTestResults(), ExtractTestResults()]) To make sure I'm understanding this correctly, these steps upload the results to the build-master, right? Sort of the same way it works for normal trunk testing? 1547345 5 aakash_jain 2019-06-24 07:51:11 -0700 > To make sure I'm understanding this correctly, these steps upload the results to the build-master, right? Sort of the same way it works for normal trunk testing? Yeah 1547363 6 372658 commit-queue 2019-06-24 08:11:09 -0700 Comment on attachment 372658 Patch Clearing flags on attachment: 372658 Committed r246737: <https://trac.webkit.org/changeset/246737> 1547364 7 commit-queue 2019-06-24 08:11:10 -0700 All reviewed patches have been landed. Closing bug. 1547367 8 webkit-bug-importer 2019-06-24 08:12:23 -0700 <rdar://problem/52054249> 372658 2019-06-21 15:23:16 -0700 2019-06-24 08:11:09 -0700 Patch bug-199120-20190621182315.patch text/plain 2559 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NjcwMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA2LTIxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBVcGxvYWQgdGVzdCByZXN1bHRzIGFmdGVyIHJ1bm5p bmcgbGF5b3V0LXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTkxMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAg KFJ1bldlYktpdFRlc3RzLmV2YWx1YXRlQ29tbWFuZCk6CisgICAgICAgICogQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBBZGRlZCB1bml0LXRlc3RzLgorCiAy MDE5LTA2LTIxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWJQYWdlUHJveHkgc2hvdWxkIHVzZSB0aGUgcmlnaHQgcGF0aCBmb3Igc2FuZGJveCBleHRlbnNp b24KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJl dmlzaW9uIDI0NjcwMCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVw cy5weQkod29ya2luZyBjb3B5KQpAQCAtNzg5LDYgKzc4OSwxNiBAQCBjbGFzcyBSdW5XZWJLaXRU ZXN0cyhzaGVsbC5UZXN0KToKICAgICAgICAgICAgIHNlbGYuc2V0Q29tbWFuZChzZWxmLmNvbW1h bmQgKyBhZGRpdGlvbmFsQXJndW1lbnRzKQogICAgICAgICByZXR1cm4gc2hlbGwuVGVzdC5zdGFy dChzZWxmKQogCisgICAgZGVmIGV2YWx1YXRlQ29tbWFuZChzZWxmLCBjbWQpOgorICAgICAgICBy YyA9IHN1cGVyKFJ1bldlYktpdFRlc3RzLCBzZWxmKS5ldmFsdWF0ZUNvbW1hbmQoY21kKQorICAg ICAgICBpZiByYyA9PSBTVUNDRVNTOgorICAgICAgICAgICAgbWVzc2FnZSA9ICdQYXNzZWQgbGF5 b3V0IHRlc3RzJworICAgICAgICAgICAgc2VsZi5kZXNjcmlwdGlvbkRvbmUgPSBtZXNzYWdlCisg ICAgICAgICAgICBzZWxmLmJ1aWxkLnJlc3VsdHMgPSBTVUNDRVNTCisgICAgICAgICAgICBzZWxm LmJ1aWxkLmJ1aWxkRmluaXNoZWQoW21lc3NhZ2VdLCBTVUNDRVNTKQorICAgICAgICBlbHNlOgor ICAgICAgICAgICAgc2VsZi5idWlsZC5hZGRTdGVwc0FmdGVyQ3VycmVudFN0ZXAoW0FyY2hpdmVU ZXN0UmVzdWx0cygpLCBVcGxvYWRUZXN0UmVzdWx0cygpLCBFeHRyYWN0VGVzdFJlc3VsdHMoKV0p CisgICAgICAgIHJldHVybiByYwogCiBjbGFzcyBSdW5XZWJLaXQxVGVzdHMoUnVuV2ViS2l0VGVz dHMpOgogICAgIGRlZiBzdGFydChzZWxmKToKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI0NjcwMCkK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQko d29ya2luZyBjb3B5KQpAQCAtODE2LDcgKzgxNiw3IEBAIGNsYXNzIFRlc3RSdW5XZWJLaXRUZXN0 cyhCdWlsZFN0ZXBNaXhpbkEKICAgICAgICAgICAgICAgICAgICAgICAgICkKICAgICAgICAgICAg ICsgMCwKICAgICAgICAgKQotICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NF U1MsIHN0YXRlX3N0cmluZz0nbGF5b3V0LXRlc3RzJykKKyAgICAgICAgc2VsZi5leHBlY3RPdXRj b21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1Bhc3NlZCBsYXlvdXQgdGVzdHMnKQog ICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAogICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2Vs Zik6CkBAIC04NTIsNyArODUyLDcgQEAgY2xhc3MgVGVzdFJ1bldlYktpdDFUZXN0cyhCdWlsZFN0 ZXBNaXhpbgogICAgICAgICAgICAgICAgICAgICAgICAgKQogICAgICAgICAgICAgKyAwLAogICAg ICAgICApCi0gICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVf c3RyaW5nPSdsYXlvdXQtdGVzdHMnKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0 PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nUGFzc2VkIGxheW91dCB0ZXN0cycpCiAgICAgICAgIHJl dHVybiBzZWxmLnJ1blN0ZXAoKQogCiAgICAgZGVmIHRlc3RfZmFpbHVyZShzZWxmKToK