199111 2019-06-21 10:24:03 -0700 Address reference to UIColor.groupTableViewBackgroundColor in WKPasswordView.mm 2019-06-21 12:12:51 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin commit-queue thorton timothy webkit-bug-importer oldest_to_newest 1546909 0 krollin 2019-06-21 10:24:03 -0700 WKPasswordView.mm is used on iOS-family devices. However, it doesn't build on tvOS or watchOS when "treat deprecation warnings as errors" is enabled. This build failure is due to a reference to UIColor.groupTableViewBackgroundColor in a branch of non-dark-mode code. Address this by surrounding the reference with ALLOW_DEPRECATED_DECLARATIONS_* macros. Attempting to address the build failure by unconditionally enabling the dark-mode code works for tvOS, but fails for watchOS due to lack of dark-mode support on that platform. 1546910 1 webkit-bug-importer 2019-06-21 10:24:18 -0700 <rdar://problem/51992107> 1546911 2 372633 krollin 2019-06-21 10:25:29 -0700 Created attachment 372633 Patch 1546939 3 372633 commit-queue 2019-06-21 12:12:50 -0700 Comment on attachment 372633 Patch Clearing flags on attachment: 372633 Committed r246687: <https://trac.webkit.org/changeset/246687> 1546940 4 commit-queue 2019-06-21 12:12:51 -0700 All reviewed patches have been landed. Closing bug. 372633 2019-06-21 10:25:29 -0700 2019-06-21 12:12:50 -0700 Patch bug-199111-20190621102529.patch text/plain 2051 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRkODUzYTE0NmI3ZGExYWZm ZmUyM2M0ZjQ5ZmQ4MjM1MjE1YWY3YjEuLjVkNWVlYzc1NTM1NDQ1ODEzYTEzYTkwMWFiM2MwNTU4 OWI0MjIzMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMDYtMjEgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZHJlc3MgcmVmZXJlbmNlIHRv IFVJQ29sb3IuZ3JvdXBUYWJsZVZpZXdCYWNrZ3JvdW5kQ29sb3IgaW4gV0tQYXNzd29yZFZpZXcu bW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTEx MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE5OTIxMDc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0tQYXNzd29yZFZpZXcubW0gaXMgdXNlZCBv biBpT1MtZmFtaWx5IGRldmljZXMuIEhvd2V2ZXIsIGl0IGRvZXNuJ3QKKyAgICAgICAgYnVpbGQg b24gdHZPUyBvciB3YXRjaE9TIHdoZW4gInRyZWF0IGRlcHJlY2F0aW9uIHdhcm5pbmdzIGFzIGVy cm9ycyIKKyAgICAgICAgaXMgZW5hYmxlZC4gVGhpcyBidWlsZCBmYWlsdXJlIGlzIGR1ZSB0byBh IHJlZmVyZW5jZSB0bworICAgICAgICBVSUNvbG9yLmdyb3VwVGFibGVWaWV3QmFja2dyb3VuZENv bG9yIGluIGEgYnJhbmNoIG9mIG5vbi1kYXJrLW1vZGUKKyAgICAgICAgY29kZS4gQWRkcmVzcyB0 aGlzIGJ5IHN1cnJvdW5kaW5nIHRoZSByZWZlcmVuY2Ugd2l0aAorICAgICAgICBBTExPV19ERVBS RUNBVEVEX0RFQ0xBUkFUSU9OU18qIG1hY3Jvcy4KKworICAgICAgICBBdHRlbXB0aW5nIHRvIGFk ZHJlc3MgdGhlIGJ1aWxkIGZhaWx1cmUgYnkgdW5jb25kaXRpb25hbGx5IGVuYWJsaW5nCisgICAg ICAgIHRoZSBkYXJrLW1vZGUgY29kZSB3b3JrcyBmb3IgdHZPUywgYnV0IGZhaWxzIGZvciB3YXRj aE9TIGR1ZSB0byBsYWNrCisgICAgICAgIG9mIGRhcmstbW9kZSBzdXBwb3J0IG9uIHRoYXQgcGxh dGZvcm0uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLUGFzc3dvcmRWaWV3Lm1tOgorICAg ICAgICAoLVtXS1Bhc3N3b3JkVmlldyBzaG93SW5TY3JvbGxWaWV3Ol0pOgorCiAyMDE5LTA2LTIw ICBBbGV4YW5kZXIgTWlraGF5bGVua28gIDxleGFsbTc2NTlAZ21haWwuY29tPgogCiAgICAgICAg IFtHVEtdIEVuYWJsZSBuYXZpZ2F0aW9uIHN3aXBlIGxheW91dCB0ZXN0cwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLUGFzc3dvcmRWaWV3Lm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLUGFzc3dvcmRWaWV3Lm1tCmluZGV4IGIxYTQ5YTE0YjJkZjAw NDJiNjliZjQ5MjBiODJlOTZjNWFiYzQ2M2UuLmU3NWJlMmQ2NjE5M2QzYzJmM2IyMWM2MzJhOTY1 NWFhYTdmYmM2ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1Bh c3N3b3JkVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tQYXNzd29y ZFZpZXcubW0KQEAgLTEwNCw3ICsxMDQsOSBAQCAtICh2b2lkKXNob3dJblNjcm9sbFZpZXc6KFVJ U2Nyb2xsVmlldyAqKXNjcm9sbFZpZXcKICNpZiBIQVZFKE9TX0RBUktfTU9ERV9TVVBQT1JUKQog ICAgIFtfc2Nyb2xsVmlldyBzZXRCYWNrZ3JvdW5kQ29sb3I6VUlDb2xvci5zeXN0ZW1Hcm91cGVk QmFja2dyb3VuZENvbG9yXTsKICNlbHNlCisgICAgQUxMT1dfREVQUkVDQVRFRF9ERUNMQVJBVElP TlNfQkVHSU4KICAgICBbX3Njcm9sbFZpZXcgc2V0QmFja2dyb3VuZENvbG9yOlVJQ29sb3IuZ3Jv dXBUYWJsZVZpZXdCYWNrZ3JvdW5kQ29sb3JdOworICAgIEFMTE9XX0RFUFJFQ0FURURfREVDTEFS QVRJT05TX0VORAogI2VuZGlmCiAKICAgICBbc2Nyb2xsVmlldyBhZGRTdWJ2aWV3OnNlbGZdOwo=