199099 2019-06-20 21:06:46 -0700 Try to use C++14 std::enable_if_t in CheckedArithmetic.h again 2019-06-21 00:19:21 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195187 InRadar P2 Normal --- 1 fujii fujii benjamin cdumez cmarcelo dbates ews-watchlist ross.kirsling webkit-bug-importer ysuzuki oldest_to_newest 1546797 0 fujii 2019-06-20 21:06:46 -0700 Try to use C++14 std::enable_if_t in CheckedArithmetic.h again Bug 195187 changed CheckedArithmetic to not use std::enable_if_t. Let's try C++14 again. [webkit-dev] Which WTF headers still should be in C++11? https://lists.webkit.org/pipermail/webkit-dev/2019-June/030692.html 1546799 1 372614 fujii 2019-06-20 21:10:06 -0700 Created attachment 372614 Patch 1546806 2 fujii 2019-06-20 22:19:52 -0700 Committed r246670: <https://trac.webkit.org/changeset/246670> 1546808 3 webkit-bug-importer 2019-06-20 22:24:08 -0700 <rdar://problem/51974955> 1546826 4 ysuzuki 2019-06-21 00:19:21 -0700 I think it is time to use C++17 constexpr-if :) 372614 2019-06-20 21:10:06 -0700 2019-06-20 21:13:28 -0700 Patch bug-199099-20190621131004.patch text/plain 3661 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY4NzM1N2RiZjhkMTBmOTI4ODBjNjMw MWZjMDI2ZGZiMmE2NTMzNTEuLjFiYWYyN2RjODg2YzFiNmMyNzQ0YzgzYTIyOTA4OGFiMTA3MzZi M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDYtMjAgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgVHJ5IHRvIHVzZSBDKysxNCBzdGQ6OmVu YWJsZV9pZl90IGluIENoZWNrZWRBcml0aG1ldGljLmggYWdhaW4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTA5OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyNDIyMzUgY2hhbmdlZCBDaGVja2VkQXJp dGhtZXRpYyB0byBub3QgdXNlIEMrKzE0LiBMZXQncyB0cnkKKyAgICAgICAgQysrMTQgYWdhaW4u CisKKyAgICAgICAgKiB3dGYvQ2hlY2tlZEFyaXRobWV0aWMuaDogVXNlIEMrKzE0IHN0ZDo6bWFr ZV91bnNpZ25lZF90IGFuZCBzdGQ6OmVuYWJsZV9pZl90LgorCiAyMDE5LTA2LTE4ICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBUaWR5IHVwIHRoZSByZW1haW5pbmcg Yml0cyBvZiB0aGUgQXRvbWljU3RyaW5nIHRvIEF0b21TdHJpbmcgcmVuYW1lCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9DaGVja2VkQXJpdGhtZXRpYy5oIGIvU291cmNlL1dURi93dGYvQ2hl Y2tlZEFyaXRobWV0aWMuaAppbmRleCBmMDlmZWE4NzhkNDY0NjRjY2I1Nzg0OTBhNTBlZDBkNjc2 YWViNjA3Li5jOTU1NDBjZDJkOWMwMmE2MDE4YjExMjEzZGU3ZGNlZjM5MGQ4NDRmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9DaGVja2VkQXJpdGhtZXRpYy5oCisrKyBiL1NvdXJjZS9XVEYv d3RmL0NoZWNrZWRBcml0aG1ldGljLmgKQEAgLTE4MSw3ICsxODEsNyBAQCB0ZW1wbGF0ZSA8dHlw ZW5hbWUgVGFyZ2V0LCB0eXBlbmFtZSBTb3VyY2U+IHN0cnVjdCBCb3VuZHNDaGVja2VyPFRhcmdl dCwgU291cmNlLAogICAgIHsKICAgICAgICAgLy8gV2hlbiBjb252ZXJ0aW5nIHZhbHVlIHRvIHVu c2lnbmVkIFNvdXJjZSwgdmFsdWUgd2lsbCBiZWNvbWUgYSBiaWcgdmFsdWUgaWYgdmFsdWUgaXMg bmVnYXRpdmUuCiAgICAgICAgIC8vIENhc3RlZCB2YWx1ZSB3aWxsIGJlY29tZSBiaWdnZXIgdGhh biBUYXJnZXQ6Om1heCBhcyBTb3VyY2UgaXMgYmlnZ2VyIHRoYW4gVGFyZ2V0LgotICAgICAgICBy ZXR1cm4gc3RhdGljX2Nhc3Q8dHlwZW5hbWUgc3RkOjptYWtlX3Vuc2lnbmVkPFNvdXJjZT46OnR5 cGU+KHZhbHVlKSA8PSBzdGQ6Om51bWVyaWNfbGltaXRzPFRhcmdldD46Om1heCgpOworICAgICAg ICByZXR1cm4gc3RhdGljX2Nhc3Q8c3RkOjptYWtlX3Vuc2lnbmVkX3Q8U291cmNlPj4odmFsdWUp IDw9IHN0ZDo6bnVtZXJpY19saW1pdHM8VGFyZ2V0Pjo6bWF4KCk7CiAgICAgfQogfTsKIApAQCAt NTQxLDcgKzU0MSw3IEBAIHRlbXBsYXRlIDx0eXBlbmFtZSBSZXN1bHRUeXBlPiBzdHJ1Y3QgQXJp dGhtZXRpY09wZXJhdGlvbnM8dW5zaWduZWQsIGludCwgUmVzdWx0CiAgICAgfQogfTsKIAotdGVt cGxhdGUgPGNsYXNzIE92ZXJmbG93SGFuZGxlciwgdHlwZW5hbWUgPSB0eXBlbmFtZSBzdGQ6OmVu YWJsZV9pZjwhc3RkOjppc19zY2FsYXI8T3ZlcmZsb3dIYW5kbGVyPjo6dmFsdWU+Ojp0eXBlPgor dGVtcGxhdGUgPGNsYXNzIE92ZXJmbG93SGFuZGxlciwgdHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9p Zl90PCFzdGQ6OmlzX3NjYWxhcjxPdmVyZmxvd0hhbmRsZXI+Ojp2YWx1ZT4+CiBpbmxpbmUgY29u c3RleHByIGJvb2wgb2JzZXJ2ZXNPdmVyZmxvdygpIHsgcmV0dXJuIHRydWU7IH0KIAogdGVtcGxh dGUgPD4KQEAgLTU1Myw3ICs1NTMsNyBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgVSwgdHlwZW5hbWUg ViwgdHlwZW5hbWUgUj4gc3RhdGljIGlubGluZSBib29sIHNhZmVBZGQoVSBsaHMsCiAgICAgcmV0 dXJuIHRydWU7CiB9CiAKLXRlbXBsYXRlIDxjbGFzcyBPdmVyZmxvd0hhbmRsZXIsIHR5cGVuYW1l IFUsIHR5cGVuYW1lIFYsIHR5cGVuYW1lIFIsIHR5cGVuYW1lID0gdHlwZW5hbWUgc3RkOjplbmFi bGVfaWY8IXN0ZDo6aXNfc2NhbGFyPE92ZXJmbG93SGFuZGxlcj46OnZhbHVlPjo6dHlwZT4KK3Rl bXBsYXRlIDxjbGFzcyBPdmVyZmxvd0hhbmRsZXIsIHR5cGVuYW1lIFUsIHR5cGVuYW1lIFYsIHR5 cGVuYW1lIFIsIHR5cGVuYW1lID0gc3RkOjplbmFibGVfaWZfdDwhc3RkOjppc19zY2FsYXI8T3Zl cmZsb3dIYW5kbGVyPjo6dmFsdWU+Pgogc3RhdGljIGlubGluZSBib29sIHNhZmVBZGQoVSBsaHMs IFYgcmhzLCBSJiByZXN1bHQpCiB7CiAgICAgaWYgKG9ic2VydmVzT3ZlcmZsb3c8T3ZlcmZsb3dI YW5kbGVyPigpKQpAQCAtNTY3LDcgKzU2Nyw3IEBAIHRlbXBsYXRlIDx0eXBlbmFtZSBVLCB0eXBl bmFtZSBWLCB0eXBlbmFtZSBSPiBzdGF0aWMgaW5saW5lIGJvb2wgc2FmZVN1YihVIGxocywKICAg ICByZXR1cm4gQXJpdGhtZXRpY09wZXJhdGlvbnM8VSwgViwgUj46OnN1YihsaHMsIHJocywgcmVz dWx0KTsKIH0KIAotdGVtcGxhdGUgPGNsYXNzIE92ZXJmbG93SGFuZGxlciwgdHlwZW5hbWUgVSwg dHlwZW5hbWUgViwgdHlwZW5hbWUgUiwgdHlwZW5hbWUgPSB0eXBlbmFtZSBzdGQ6OmVuYWJsZV9p Zjwhc3RkOjppc19zY2FsYXI8T3ZlcmZsb3dIYW5kbGVyPjo6dmFsdWU+Ojp0eXBlPgordGVtcGxh dGUgPGNsYXNzIE92ZXJmbG93SGFuZGxlciwgdHlwZW5hbWUgVSwgdHlwZW5hbWUgViwgdHlwZW5h bWUgUiwgdHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9pZl90PCFzdGQ6OmlzX3NjYWxhcjxPdmVyZmxv d0hhbmRsZXI+Ojp2YWx1ZT4+CiBzdGF0aWMgaW5saW5lIGJvb2wgc2FmZVN1YihVIGxocywgViBy aHMsIFImIHJlc3VsdCkKIHsKICAgICBpZiAob2JzZXJ2ZXNPdmVyZmxvdzxPdmVyZmxvd0hhbmRs ZXI+KCkpCkBAIC01ODEsNyArNTgxLDcgQEAgdGVtcGxhdGUgPHR5cGVuYW1lIFUsIHR5cGVuYW1l IFYsIHR5cGVuYW1lIFI+IHN0YXRpYyBpbmxpbmUgYm9vbCBzYWZlTXVsdGlwbHkoVQogICAgIHJl dHVybiBBcml0aG1ldGljT3BlcmF0aW9uczxVLCBWLCBSPjo6bXVsdGlwbHkobGhzLCByaHMsIHJl c3VsdCk7CiB9CiAKLXRlbXBsYXRlIDxjbGFzcyBPdmVyZmxvd0hhbmRsZXIsIHR5cGVuYW1lIFUs IHR5cGVuYW1lIFYsIHR5cGVuYW1lIFIsIHR5cGVuYW1lID0gdHlwZW5hbWUgc3RkOjplbmFibGVf aWY8IXN0ZDo6aXNfc2NhbGFyPE92ZXJmbG93SGFuZGxlcj46OnZhbHVlPjo6dHlwZT4KK3RlbXBs YXRlIDxjbGFzcyBPdmVyZmxvd0hhbmRsZXIsIHR5cGVuYW1lIFUsIHR5cGVuYW1lIFYsIHR5cGVu YW1lIFIsIHR5cGVuYW1lID0gc3RkOjplbmFibGVfaWZfdDwhc3RkOjppc19zY2FsYXI8T3ZlcmZs b3dIYW5kbGVyPjo6dmFsdWU+Pgogc3RhdGljIGlubGluZSBib29sIHNhZmVNdWx0aXBseShVIGxo cywgViByaHMsIFImIHJlc3VsdCkKIHsKICAgICBpZiAob2JzZXJ2ZXNPdmVyZmxvdzxPdmVyZmxv d0hhbmRsZXI+KCkpCg==