199098 2019-06-20 19:08:10 -0700 Web Inspector: rename some DOMObserver method parameters to match the protocol 2019-06-20 22:48:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1546785 0 mattbaker 2019-06-20 19:08:10 -0700 . 1546786 1 372608 mattbaker 2019-06-20 19:10:30 -0700 Created attachment 372608 Patch 1546790 2 372608 hi 2019-06-20 19:15:55 -0700 Comment on attachment 372608 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372608&action=review > Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js:80 > + shadowRootPushed(parentNodeId, payload) This doesn't match the name in the protocol either. It should be `hostId` and `root`. 1546794 3 mattbaker 2019-06-20 19:20:03 -0700 (In reply to Devin Rousso from comment #2) > Comment on attachment 372608 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372608&action=review > > > Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js:80 > > + shadowRootPushed(parentNodeId, payload) > > This doesn't match the name in the protocol either. It should be `hostId` > and `root`. I chose a poor name for this bug. I wanted to use payload to be consistent with other DOMObserver methods, setChildNodes and childNodeInserted. I can rename payload and payloads in those to match the respective names in the protocol. 1546795 4 372612 mattbaker 2019-06-20 19:37:03 -0700 Created attachment 372612 Patch 1546804 5 372612 hi 2019-06-20 22:11:58 -0700 Comment on attachment 372612 Patch rs=me 1546812 6 372612 commit-queue 2019-06-20 22:44:08 -0700 Comment on attachment 372612 Patch Clearing flags on attachment: 372612 Committed r246672: <https://trac.webkit.org/changeset/246672> 1546813 7 commit-queue 2019-06-20 22:44:10 -0700 All reviewed patches have been landed. Closing bug. 1546814 8 webkit-bug-importer 2019-06-20 22:48:15 -0700 <rdar://problem/51975578> 372608 2019-06-20 19:10:30 -0700 2019-06-20 19:37:01 -0700 Patch bug-199098-20190620191028.patch text/plain 1549 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4 ZjVjNzM5ODkxZDgxYTE0NTljODBmMzM1ZGRkYTllNDIyMTg0MGMwLi5lY2JmYjIzYjBjNTdhYWNl ZjUzMzBiNzgzN2UwMDViMTgwNmU5MWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0wNi0yMCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogcmVuYW1lIHNoYWRvd1Jvb3RQdXNoZWQgcGFyYW1l dGVyIHRvIG1hdGNoIHByb3RvY29sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTkwOTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvUHJvdG9jb2wvRE9NT2JzZXJ2ZXIuanM6Cisg ICAgICAgIChXSS5ET01PYnNlcnZlci5wcm90b3R5cGUuc2hhZG93Um9vdFB1c2hlZCk6CisKIDIw MTktMDYtMTkgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFJFR1JFU1NJT046IERlYnVnZ2VyOiBjdXJyZW50IGNhbGwgZnJhbWUgaW5k aWNhdG9yIGlzbid0IHZlcnRpY2FsbHkgY2VudGVyZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0RPTU9ic2VydmVyLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvRE9NT2JzZXJ2ZXIuanMKaW5k ZXggNzNjYmVmMzI2MGQwOGE3YjZhNWU4YzZjM2RlNDJlMzU0NDRjYTYxYi4uYTZkOWViYjM4MDIy YmZkMDhmOTIzNjhlYjcwNTVmNzEyYjJlMzhmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvRE9NT2JzZXJ2ZXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvRE9NT2JzZXJ2ZXIuanMKQEAg LTc3LDkgKzc3LDkgQEAgV0kuRE9NT2JzZXJ2ZXIgPSBjbGFzcyBET01PYnNlcnZlcgogICAgICAg ICBXSS5kb21NYW5hZ2VyLl9jaGlsZE5vZGVSZW1vdmVkKHBhcmVudE5vZGVJZCwgbm9kZUlkKTsK ICAgICB9CiAKLSAgICBzaGFkb3dSb290UHVzaGVkKHBhcmVudE5vZGVJZCwgbm9kZUlkKQorICAg IHNoYWRvd1Jvb3RQdXNoZWQocGFyZW50Tm9kZUlkLCBwYXlsb2FkKQogICAgIHsKLSAgICAgICAg V0kuZG9tTWFuYWdlci5fY2hpbGROb2RlSW5zZXJ0ZWQocGFyZW50Tm9kZUlkLCAwLCBub2RlSWQp OworICAgICAgICBXSS5kb21NYW5hZ2VyLl9jaGlsZE5vZGVJbnNlcnRlZChwYXJlbnROb2RlSWQs IDAsIHBheWxvYWQpOwogICAgIH0KIAogICAgIHNoYWRvd1Jvb3RQb3BwZWQocGFyZW50Tm9kZUlk LCBub2RlSWQpCg== 372612 2019-06-20 19:37:03 -0700 2019-06-20 22:44:08 -0700 Patch bug-199098-20190620193701.patch text/plain 2602 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4 ZjVjNzM5ODkxZDgxYTE0NTljODBmMzM1ZGRkYTllNDIyMTg0MGMwLi5lY2JmYjIzYjBjNTdhYWNl ZjUzMzBiNzgzN2UwMDViMTgwNmU5MWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0wNi0yMCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogcmVuYW1lIHNoYWRvd1Jvb3RQdXNoZWQgcGFyYW1l dGVyIHRvIG1hdGNoIHByb3RvY29sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTkwOTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvUHJvdG9jb2wvRE9NT2JzZXJ2ZXIuanM6Cisg ICAgICAgIChXSS5ET01PYnNlcnZlci5wcm90b3R5cGUuc2hhZG93Um9vdFB1c2hlZCk6CisKIDIw MTktMDYtMTkgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFJFR1JFU1NJT046IERlYnVnZ2VyOiBjdXJyZW50IGNhbGwgZnJhbWUgaW5k aWNhdG9yIGlzbid0IHZlcnRpY2FsbHkgY2VudGVyZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0RPTU9ic2VydmVyLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvRE9NT2JzZXJ2ZXIuanMKaW5k ZXggNzNjYmVmMzI2MGQwOGE3YjZhNWU4YzZjM2RlNDJlMzU0NDRjYTYxYi4uN2VhYWQyMTYxYWE0 YzViOGE1MjBmMjQzOGJiZjFlNDY3MDUxZjExZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvRE9NT2JzZXJ2ZXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvRE9NT2JzZXJ2ZXIuanMKQEAg LTM3LDkgKzM3LDkgQEAgV0kuRE9NT2JzZXJ2ZXIgPSBjbGFzcyBET01PYnNlcnZlcgogICAgICAg ICBXSS5kb21NYW5hZ2VyLmluc3BlY3RFbGVtZW50KG5vZGVJZCk7CiAgICAgfQogCi0gICAgc2V0 Q2hpbGROb2RlcyhwYXJlbnRJZCwgcGF5bG9hZHMpCisgICAgc2V0Q2hpbGROb2RlcyhwYXJlbnRJ ZCwgbm9kZXMpCiAgICAgewotICAgICAgICBXSS5kb21NYW5hZ2VyLl9zZXRDaGlsZE5vZGVzKHBh cmVudElkLCBwYXlsb2Fkcyk7CisgICAgICAgIFdJLmRvbU1hbmFnZXIuX3NldENoaWxkTm9kZXMo cGFyZW50SWQsIG5vZGVzKTsKICAgICB9CiAKICAgICBhdHRyaWJ1dGVNb2RpZmllZChub2RlSWQs IG5hbWUsIHZhbHVlKQpAQCAtNjcsOSArNjcsOSBAQCBXSS5ET01PYnNlcnZlciA9IGNsYXNzIERP TU9ic2VydmVyCiAgICAgICAgIFdJLmRvbU1hbmFnZXIuX2NoaWxkTm9kZUNvdW50VXBkYXRlZChu b2RlSWQsIGNoaWxkTm9kZUNvdW50KTsKICAgICB9CiAKLSAgICBjaGlsZE5vZGVJbnNlcnRlZChw YXJlbnROb2RlSWQsIHByZXZpb3VzTm9kZUlkLCBwYXlsb2FkKQorICAgIGNoaWxkTm9kZUluc2Vy dGVkKHBhcmVudE5vZGVJZCwgcHJldmlvdXNOb2RlSWQsIG5vZGUpCiAgICAgewotICAgICAgICBX SS5kb21NYW5hZ2VyLl9jaGlsZE5vZGVJbnNlcnRlZChwYXJlbnROb2RlSWQsIHByZXZpb3VzTm9k ZUlkLCBwYXlsb2FkKTsKKyAgICAgICAgV0kuZG9tTWFuYWdlci5fY2hpbGROb2RlSW5zZXJ0ZWQo cGFyZW50Tm9kZUlkLCBwcmV2aW91c05vZGVJZCwgbm9kZSk7CiAgICAgfQogCiAgICAgY2hpbGRO b2RlUmVtb3ZlZChwYXJlbnROb2RlSWQsIG5vZGVJZCkKQEAgLTc3LDE0ICs3NywxNCBAQCBXSS5E T01PYnNlcnZlciA9IGNsYXNzIERPTU9ic2VydmVyCiAgICAgICAgIFdJLmRvbU1hbmFnZXIuX2No aWxkTm9kZVJlbW92ZWQocGFyZW50Tm9kZUlkLCBub2RlSWQpOwogICAgIH0KIAotICAgIHNoYWRv d1Jvb3RQdXNoZWQocGFyZW50Tm9kZUlkLCBub2RlSWQpCisgICAgc2hhZG93Um9vdFB1c2hlZCho b3N0SWQsIHJvb3QpCiAgICAgewotICAgICAgICBXSS5kb21NYW5hZ2VyLl9jaGlsZE5vZGVJbnNl cnRlZChwYXJlbnROb2RlSWQsIDAsIG5vZGVJZCk7CisgICAgICAgIFdJLmRvbU1hbmFnZXIuX2No aWxkTm9kZUluc2VydGVkKGhvc3RJZCwgMCwgcm9vdCk7CiAgICAgfQogCi0gICAgc2hhZG93Um9v dFBvcHBlZChwYXJlbnROb2RlSWQsIG5vZGVJZCkKKyAgICBzaGFkb3dSb290UG9wcGVkKGhvc3RJ ZCwgcm9vdElkKQogICAgIHsKLSAgICAgICAgV0kuZG9tTWFuYWdlci5fY2hpbGROb2RlUmVtb3Zl ZChwYXJlbnROb2RlSWQsIG5vZGVJZCk7CisgICAgICAgIFdJLmRvbU1hbmFnZXIuX2NoaWxkTm9k ZVJlbW92ZWQoaG9zdElkLCByb290SWQpOwogICAgIH0KIAogICAgIGN1c3RvbUVsZW1lbnRTdGF0 ZUNoYW5nZWQobm9kZUlkLCBjdXN0b21FbGVtZW50U3RhdGUpCg==