199078 2019-06-20 13:48:34 -0700 test-webkitpy is broken on macOS Catalina 2019-07-02 19:17:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199428 InRadar P2 Normal --- 1 dean_johnson dean_johnson ap commit-queue dean_johnson ews-feeder ews-watchlist fujii glenn jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1546647 0 dean_johnson 2019-06-20 13:48:34 -0700 Building for lldb webkitpy tests fails. 1546652 1 372581 dean_johnson 2019-06-20 14:04:01 -0700 Created attachment 372581 Patch 1546686 2 372581 ews-feeder 2019-06-20 15:25:12 -0700 Comment on attachment 372581 Patch Rejecting attachment 372581 from commit-queue. dean_johnson@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1546692 3 dean_johnson 2019-06-20 15:27:15 -0700 <rdar://problem/51853557> 1546724 4 372581 commit-queue 2019-06-20 16:13:06 -0700 Comment on attachment 372581 Patch Clearing flags on attachment: 372581 Committed r246662: <https://trac.webkit.org/changeset/246662> 1546725 5 commit-queue 2019-06-20 16:13:07 -0700 All reviewed patches have been landed. Closing bug. 1546726 6 webkit-bug-importer 2019-06-20 16:14:17 -0700 <rdar://problem/51964923> 1549808 7 fujii 2019-07-02 19:17:16 -0700 Windows port are failing. Filed: Bug 199428 – [Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith' 372581 2019-06-20 14:04:01 -0700 2019-06-20 16:13:06 -0700 Patch bug-199078-20190620140400.patch text/plain 2770 dean_johnson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NjEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjg3NjA2MTU1MWRjZmRjN2Q4NmQyZTU1MjQ2MWU4MDA0 YmEwZDRmZi4uNWI1ZGY2YWU0ZjdmNmJlZGEwNGRiMzhkZWU1YzM5Nzk2M2Q4M2YwMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTA2LTIwICBEZWFuIEpvaG5zb24gIDxkZWFuX2pvaG5zb25AYXBwbGUuY29tPgor CisgICAgICAgIHRlc3Qtd2Via2l0cHkgaXMgYnJva2VuIG9uIG1hY09TIENhdGFsaW5hCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkwNzgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvdGVzdC9tYWluLnB5OiBDaGVjayBpZiBsbGRiIHRlc3RzIGFyZSBzdXBwb3J0ZWQgYmVm b3JlIGFkZGluZyB0aGVtCisgICAgICAgIHRvIHRoZSBydW5uZXIuCisgICAgICAgIChtYWluKTog CisgICAgICAgIChfc3VwcG9ydHNfYnVpbGRpbmdfYW5kX3J1bm5pbmdfbGxkYl90ZXN0cyk6IENo ZWNrIGlmIHlvdSBhcmUgcnVubmluZyBtYWNPUyBDYXRhbGluYS4KKwogMjAxOS0wNi0xOSAgQWFr YXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2V3cy1idWlsZF0g QWRkIHN0ZXAgdG8gYW5hbHl6ZSBDb21waWxlIFdlYktpdCBmYWlsdXJlcwpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3Rlc3QvbWFpbi5weQppbmRleCAxZmUwMzRhYmE4ZWM3YWI0MzFlN2EzNTdhNzE0MWI0NTg3 ZjY3MzUwLi5hOGUzYWUwNzE5NjVlNjJmMjRiMGIzMzAxNWFmMDQwOGEyNzFjMjkyIDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weQpAQCAtNjksMTQgKzY5LDE3IEBAIGRlZiBtYWluKCk6 CiAgICAgICAgIHRlc3Rlci5hZGRfdHJlZShvcy5wYXRoLmpvaW4oX3dlYmtpdF9yb290LCAnU291 cmNlJywgJ1dlYktpdCcsICdTY3JpcHRzJyksICd3ZWJraXQnKQogCiAgICAgbGxkYl9weXRob25f ZGlyZWN0b3J5ID0gX2hvc3QucGF0aF90b19sbGRiX3B5dGhvbl9kaXJlY3RvcnkoKQotICAgIGlm IG9zLnBhdGguaXNkaXIobGxkYl9weXRob25fZGlyZWN0b3J5KToKKyAgICBpZiBub3QgX3N1cHBv cnRzX2J1aWxkaW5nX2FuZF9ydW5uaW5nX2xsZGJfdGVzdHMoKToKKyAgICAgICAgX2xvZy5pbmZv KCJTa2lwcGluZyBsbGRiX3dlYmtpdCB0ZXN0czsgbm90IHlldCBzdXBwb3J0ZWQgb24gbWFjT1Mg Q2F0YWxpbmEuIikKKyAgICAgICAgd2lsbF9ydW5fbGxkYl93ZWJraXRfdGVzdHMgPSBGYWxzZQor ICAgIGVsaWYgbm90IG9zLnBhdGguaXNkaXIobGxkYl9weXRob25fZGlyZWN0b3J5KToKKyAgICAg ICAgX2xvZy5pbmZvKCJTa2lwcGluZyBsbGRiX3dlYmtpdCB0ZXN0czsgY291bGQgbm90IGZpbmQg cGF0aCB0byBsbGRiLnB5ICd7fScuIi5mb3JtYXQobGxkYl9weXRob25fZGlyZWN0b3J5KSkKKyAg ICAgICAgd2lsbF9ydW5fbGxkYl93ZWJraXRfdGVzdHMgPSBGYWxzZQorICAgIGVsc2U6CiAgICAg ICAgIGlmIGxsZGJfcHl0aG9uX2RpcmVjdG9yeSBub3QgaW4gc3lzLnBhdGg6CiAgICAgICAgICAg ICBzeXMucGF0aC5hcHBlbmQobGxkYl9weXRob25fZGlyZWN0b3J5KQogICAgICAgICB0ZXN0ZXIu YWRkX3RyZWUob3MucGF0aC5qb2luKF93ZWJraXRfcm9vdCwgJ1Rvb2xzJywgJ2xsZGInKSkKICAg ICAgICAgd2lsbF9ydW5fbGxkYl93ZWJraXRfdGVzdHMgPSBUcnVlCi0gICAgZWxzZToKLSAgICAg ICAgX2xvZy5pbmZvKCJTa2lwcGluZyBsbGRiX3dlYmtpdCB0ZXN0czsgY291bGQgbm90IGZpbmQg cGF0aCB0byBsbGRiLnB5ICd7fScuIi5mb3JtYXQobGxkYl9weXRob25fZGlyZWN0b3J5KSkKLSAg ICAgICAgd2lsbF9ydW5fbGxkYl93ZWJraXRfdGVzdHMgPSBGYWxzZQogCiAgICAgdGVzdGVyLnNr aXAoKCd3ZWJraXRweS5jb21tb24uY2hlY2tvdXQuc2NtLnNjbV91bml0dGVzdCcsKSwgJ2FyZSBy ZWFsbHksIHJlYWxseSwgc2xvdycsIDMxODE4KQogICAgIGlmIHN5cy5wbGF0Zm9ybS5zdGFydHN3 aXRoKCd3aW4nKToKQEAgLTk4LDYgKzEwMSwxMiBAQCBkZWYgbWFpbigpOgogICAgIHJldHVybiBu b3QgdGVzdGVyLnJ1bih3aWxsX3J1bl9sbGRiX3dlYmtpdF90ZXN0cz13aWxsX3J1bl9sbGRiX3dl YmtpdF90ZXN0cykKIAogCitkZWYgX3N1cHBvcnRzX2J1aWxkaW5nX2FuZF9ydW5uaW5nX2xsZGJf dGVzdHMoKToKKyAgICAjIEZJWE1FOiBSZW1vdmUgd2hlbiB0ZXN0LWxsZGIgaXMgaW4gaXRzIG93 biBzY3JpcHQKKyAgICAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODc5MTYKKyAgICByZXR1cm4gbm90IF9ob3N0LnBsYXRmb3JtLmJ1aWxkX3ZlcnNpb24oKS5zdGFy dHN3aXRoKCcxOUEnKQorCisKIGRlZiBfcHJpbnRfcmVzdWx0c19hc19qc29uKHN0cmVhbSwgYWxs X3Rlc3RfbmFtZXMsIGZhaWx1cmVzLCBlcnJvcnMpOgogICAgIGRlZiByZXN1bHRfZGljdF9mcm9t X3R1cGxlKHJlc3VsdF90dXBsZSk6CiAgICAgICAgIHJldHVybiB7J25hbWUnOiByZXN1bHRfdHVw bGVbMF0sICdyZXN1bHQnOiByZXN1bHRfdHVwbGVbMV19Cg==