199072 2019-06-20 11:16:15 -0700 Resolve frequent crashes in String::isolatedCopy inside topPrivatelyControlledDomain call 2019-06-20 13:52:51 -0700 1 1 1 Unclassified WebKit WebKit Misc. Safari 10 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham andersca beidson bfulgham cdumez commit-queue ggaren jfbastien rniwa youennf oldest_to_newest 1546583 0 bfulgham 2019-06-20 11:16:15 -0700 Crash data indicates that we are frequently crashing while performing 'String::isolatedCopy' inside topPrivatelyControlledDomain calls. This seem to be primarily related to multiple threads attempting to initialize RegistrableDomain members at the same time. Code review showed the potential for a thread contention issue. This patch resolves the problem in two ways: (1) A thread safety issue in the implementation of WebCore::topPrivatelyControlledDomain is corrected. (Note: This is an issue because we build WebKit with --fno-threadsafe-statics). (2) I added a call during NetworkProcess initialization (before spawning multiple threads) to initialize the domain cache. This change is probably not needed, but adds another layer of defense. 1546584 1 bfulgham 2019-06-20 11:16:31 -0700 <rdar://problem/51428162> 1546593 2 372575 bfulgham 2019-06-20 11:42:14 -0700 Created attachment 372575 Patch 1546624 3 372575 youennf 2019-06-20 13:08:29 -0700 Comment on attachment 372575 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372575&action=review > Source/WebKit/ChangeLog:17 > + (2) Call WebCore::topPrivatelyControlledDomain during NetworkProcess initialization (before We probably do not need 2 given we have 1. 1546630 4 372575 commit-queue 2019-06-20 13:12:52 -0700 Comment on attachment 372575 Patch Rejecting attachment 372575 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 372575, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12534056 1546642 5 bfulgham 2019-06-20 13:39:33 -0700 Committed r246652: <https://trac.webkit.org/changeset/246652> 1546644 6 372575 ap 2019-06-20 13:42:29 -0700 Comment on attachment 372575 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372575&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:293 > + UNUSED_PARAM(initialized); This is not a parameter, so using the UNUSED_PARAM macro is incorrect. 1546648 7 bfulgham 2019-06-20 13:52:51 -0700 (In reply to Alexey Proskuryakov from comment #6) > Comment on attachment 372575 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372575&action=review > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:293 > > + UNUSED_PARAM(initialized); > > This is not a parameter, so using the UNUSED_PARAM macro is incorrect. I removed that code. 372575 2019-06-20 11:42:14 -0700 2019-06-20 13:12:52 -0700 Patch bug-199072-20190620114213.patch text/plain 4530 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjU3YTE3ZDA0ZDRiZmMy ZGQ5ODA4NTE2OWRhNjk3NzBiZjgyMDQ5Yi4uMWM3ZGRhYjVmZjdlNThkZGMzODlmOTk2Nzc3MDNl Y2I3NzVkZjE0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTA2LTIwICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJlc29sdmUgZnJlcXVl bnQgY3Jhc2hlcyBpbiB0b3BQcml2YXRlbHlDb250cm9sbGVkRG9tYWluCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkwNzIKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzUxNDI4MTYyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENyYXNoIGRhdGEgaW5kaWNhdGVzIHRoYXQgd2UgYXJlIGZyZXF1ZW50bHkg Y3Jhc2hpbmcgd2hlbiBtdWx0aXBsZSB0aHJlYWRzIGNhbGwKKyAgICAgICAgV2ViQ29yZTo6dG9w UHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbi4gCisKKyAgICAgICAgQ29kZSByZXZpZXcgc2hvd2Vk IHRoZSBwb3RlbnRpYWwgZm9yIGEgdGhyZWFkIGNvbnRlbnRpb24gaXNzdWUsIHNpbmNlIFdlYktp dCBidWlsZHMKKyAgICAgICAgd2l0aCAnLS1mbm8tdGhyZWFkc2FmZS1zdGF0aWNzJy4KKworICAg ICAgICBUaGlzIHBhdGNoIHJlc29sdmVzIHRoZSBwcm9ibGVtIGluIHR3byB3YXlzOgorICAgICAg ICAoMSkgQ29ycmVjdCB0aGUgdGhyZWFkIHNhZmV0eSBpc3N1ZSBpbiBXZWJDb3JlOjp0b3BQcml2 YXRlbHlDb250cm9sbGVkRG9tYWluLgorICAgICAgICAoMikgQ2FsbCBXZWJDb3JlOjp0b3BQcml2 YXRlbHlDb250cm9sbGVkRG9tYWluIGR1cmluZyBOZXR3b3JrUHJvY2VzcyBpbml0aWFsaXphdGlv biAoYmVmb3JlCisgICAgICAgIG90aGVyIHRocmVhZHMgYXJlIHNwYXduZWQgaW4gdGhlIHByb2Nl c3MpIHRvIGluaXRpYWxpemUgdGhlIGRvbWFpbiBjYWNoZS4KKworICAgICAgICAqIHBsYXRmb3Jt L21hYy9QdWJsaWNTdWZmaXhNYWMubW06CisgICAgICAgIChXZWJDb3JlOjp0b3BQcml2YXRlbHlD b250cm9sbGVkRG9tYWluKTogT25seSBpbnN0YW50aWF0ZSB0aGUgc3RhdGljIGNhY2hlIGFmdGVy IHRoZQorICAgICAgICBjdXJyZW50IHRocmVhZCBoYXMgYWNoaWV2ZWQgaXRzIGxvY2suCisKIDIw MTktMDYtMjAgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZC4gU3BlY3VsYXRpdmUgYnVpbGQgZml4IGZvciB3YXRjaE9TIGFmdGVyIHIyNDY2MzEu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nCmluZGV4IDRkODUzYTE0NmI3ZGExYWZmZmUyM2M0ZjQ5ZmQ4MjM1MjE1YWY3YjEuLjYz OGVmYjUxNzEwZjVjMjUwNTRlMDkwYWI4YTVmMTY4ZTNjNDE1NDYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjcgQEAKKzIwMTktMDYtMjAgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+ CisKKyAgICAgICAgUmVzb2x2ZSBmcmVxdWVudCBjcmFzaGVzIGluIHRvcFByaXZhdGVseUNvbnRy b2xsZWREb21haW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5OTA3MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE0MjgxNjI+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3Jhc2ggZGF0YSBpbmRpY2F0 ZXMgdGhhdCB3ZSBhcmUgZnJlcXVlbnRseSBjcmFzaGluZyB3aGVuIG11bHRpcGxlIHRocmVhZHMg Y2FsbAorICAgICAgICBXZWJDb3JlOjp0b3BQcml2YXRlbHlDb250cm9sbGVkRG9tYWluLiAKKwor ICAgICAgICBDb2RlIHJldmlldyBzaG93ZWQgdGhlIHBvdGVudGlhbCBmb3IgYSB0aHJlYWQgY29u dGVudGlvbiBpc3N1ZSwgc2luY2UgV2ViS2l0IGJ1aWxkcworICAgICAgICB3aXRoICctLWZuby10 aHJlYWRzYWZlLXN0YXRpY3MnLgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVzb2x2ZXMgdGhlIHBy b2JsZW0gaW4gdHdvIHdheXM6CisgICAgICAgICgxKSBDb3JyZWN0IHRoZSB0aHJlYWQgc2FmZXR5 IGlzc3VlIGluIFdlYkNvcmU6OnRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4uCisgICAgICAg ICgyKSBDYWxsIFdlYkNvcmU6OnRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4gZHVyaW5nIE5l dHdvcmtQcm9jZXNzIGluaXRpYWxpemF0aW9uIChiZWZvcmUKKyAgICAgICAgb3RoZXIgdGhyZWFk cyBhcmUgc3Bhd25lZCBpbiB0aGUgcHJvY2VzcykgdG8gaW5pdGlhbGl6ZSB0aGUgZG9tYWluIGNh Y2hlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3 b3JrUHJvY2Vzczo6aW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKTogSW5pdGlhbGl6ZSB0aGUgZG9t YWluIGNhY2hlIGR1cmluZyBsYXVuY2guCisKIDIwMTktMDYtMjAgIEFsZXhhbmRlciBNaWtoYXls ZW5rbyAgPGV4YWxtNzY1OUBnbWFpbC5jb20+CiAKICAgICAgICAgW0dUS10gRW5hYmxlIG5hdmln YXRpb24gc3dpcGUgbGF5b3V0IHRlc3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvUHVibGljU3VmZml4TWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1B1YmxpY1N1ZmZpeE1hYy5tbQppbmRleCA2NjhkY2UwOWZhY2U1NTg4NzNiYmViODVkZDA0OTdi YTVkMzQ0ZGNmLi5iODUwNmFiNzZlMzI0OGM1NTlkZTU5YmViZDhhYmMxYWJmNjY1ZGE1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUHVibGljU3VmZml4TWFjLm1tCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QdWJsaWNTdWZmaXhNYWMubW0KQEAgLTUw LDEzICs1MCwxMyBAQCBTdHJpbmcgdG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbihjb25zdCBT dHJpbmcmIGRvbWFpbikKICAgICBpZiAoIWRvbWFpbi5pc0FsbEFTQ0lJKCkpCiAgICAgICAgIHJl dHVybiBkb21haW47CiAKLSAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8SGFzaE1hcDxTdHJpbmcs IFN0cmluZywgQVNDSUlDYXNlSW5zZW5zaXRpdmVIYXNoPj4gY2FjaGU7CiAgICAgc3RhdGljIExv Y2sgY2FjaGVMb2NrOwotCi0gICAgYXV0byBpc29sYXRlZERvbWFpbiA9IGRvbWFpbi5pc29sYXRl ZENvcHkoKTsKLQogICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2soY2FjaGVMb2NrKTsKIAorICAg IHN0YXRpYyBOZXZlckRlc3Ryb3llZDxIYXNoTWFwPFN0cmluZywgU3RyaW5nLCBBU0NJSUNhc2VJ bnNlbnNpdGl2ZUhhc2g+PiBjYWNoZTsKKworICAgIGF1dG8gaXNvbGF0ZWREb21haW4gPSBkb21h aW4uaXNvbGF0ZWRDb3B5KCk7CisgICAgCiAgICAgY29uc3RleHByIGF1dG8gbWF4aW11bVNpemVU b1ByZXZlbnRVbmxpbWl0ZWRHcm93dGggPSAxMjg7CiAgICAgaWYgKGNhY2hlLmdldCgpLnNpemUo KSA9PSBtYXhpbXVtU2l6ZVRvUHJldmVudFVubGltaXRlZEdyb3d0aCkKICAgICAgICAgY2FjaGUu Z2V0KCkucmVtb3ZlKGNhY2hlLmdldCgpLnJhbmRvbSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKaW5kZXggZTJlZDE1ZTI1ZWY2ZTQyZGQ0 ODI4OTA2MTg4YWVlMGFkNzc1OTRmYi4uOTU0NjczNjAzMDkzM2ZlNTRkMmM4ZjUxYjExMTU3NGE1 OTkxOTQzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3Jr UHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJv Y2Vzcy5jcHAKQEAgLTI4OSw2ICsyODksOCBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjppbml0aWFs aXplTmV0d29ya1Byb2Nlc3MoTmV0d29ya1Byb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmJgogCiAg ICAgV1RGOjpUaHJlYWQ6OnNldEN1cnJlbnRUaHJlYWRJc1VzZXJJbml0aWF0ZWQoKTsKICAgICBB dG9tU3RyaW5nOjppbml0KCk7CisgICAgYXV0byBpbml0aWFsaXplZCA9IHRvcFByaXZhdGVseUNv bnRyb2xsZWREb21haW4oIm51bGxPcmlnaW4iX3MpOworICAgIFVOVVNFRF9QQVJBTShpbml0aWFs aXplZCk7CiAKICAgICBtX3N1cHByZXNzTWVtb3J5UHJlc3N1cmVIYW5kbGVyID0gcGFyYW1ldGVy cy5zaG91bGRTdXBwcmVzc01lbW9yeVByZXNzdXJlSGFuZGxlcjsKICAgICBpZiAoIW1fc3VwcHJl c3NNZW1vcnlQcmVzc3VyZUhhbmRsZXIpIHsK