199062 2019-06-20 00:19:53 -0700 Fix a bug that 'test_metrics' and 'tests' tables are not joined correctly in CommitLogFetcher.fetch_latest_for_platform 2019-06-20 16:53:56 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dewei_zhu dewei_zhu dewei_zhu rniwa oldest_to_newest 1546457 0 dewei_zhu 2019-06-20 00:19:53 -0700 Fix a bug that 'test_metrics' and 'tests' tables are not joined correctly in CommitLogFetcher.fetch_latest_for_platform 1546458 1 372544 dewei_zhu 2019-06-20 00:21:37 -0700 Created attachment 372544 Patch 1546459 2 dewei_zhu 2019-06-20 00:24:05 -0700 rdar://51932287 1546748 3 dewei_zhu 2019-06-20 16:53:56 -0700 Landed in r246663. 372544 2019-06-20 00:21:37 -0700 2019-06-20 14:31:34 -0700 Patch bug-199062-20190620002136.patch text/plain 5404 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NjMwCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA4NWVmNDExNDJlZWY2NjY3OWJlZmUyMzZiODVmZGFkNDU1OTg3MTEzLi5kZTBjMDQ3MGU2 MTRlNTRmZmQ2OWJmMTA4NWUyNDRlMDQzM2QxNzY5IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wNi0yMCAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggYSBidWcgdGhhdCAndGVzdF9tZXRyaWNzJyBhbmQg J3Rlc3RzJyB0YWJsZXMgYXJlIG5vdCBqb2luZWQgY29ycmVjdGx5IGluIENvbW1pdExvZ0ZldGNo ZXIuZmV0Y2hfbGF0ZXN0X2Zvcl9wbGF0Zm9ybQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MDYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgJ3Rlc3RfbWV0cmljcycgYW5kICd0ZXN0cycgc2hvdWxkIGJl IGpvaW5lZCBiYXNlZCBvbiAnbWV0cmljX3Rlc3QnIGFuZCAndGVzdF9pZCcuCisKKyAgICAgICAg KiBwdWJsaWMvaW5jbHVkZS9jb21taXQtbG9nLWZldGNoZXIucGhwOiBGaXggdGhlIHR5cG8gaW4g dGhlIHF1ZXJ5LgorICAgICAgICAqIHNlcnZlci10ZXN0cy9hcGktY29tbWl0cy10ZXN0cy5qczog QWRkZWQgYSB1bml0IHRlc3QgZm9yIHRoaXMgY2hhbmdlLgorCiAyMDE5LTA2LTE3ICBEZXdlaSBa aHUgIDxkZXdlaV96aHVAYXBwbGUuY29tPgogCiAgICAgICAgIEN1c3RvbWl6YWJsZSB0ZXN0IGdy b3VwIGZvcm0gc2hvdWxkIGFsbG93IHVzZXIgdG8gc3VwcGx5IGEgcmV2aXNpb24gcHJlZml4IG9m IGEgY29tbWl0IGFuZCByZXZpc2lvbiBzdGFydHMgd2l0aCAncicuCmRpZmYgLS1naXQgYS9XZWJz aXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luY2x1ZGUvY29tbWl0LWxvZy1mZXRjaGVyLnBo cCBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9jb21taXQtbG9nLWZl dGNoZXIucGhwCmluZGV4IDU0MGYxZGVjMTVjNzNjMjA2YjZjZGZhYzI5NGFhY2U4NjJjNGUwNDQu LjBmZDZkZjgyZDQxYTM1OWM1ZTcyNDU1OTU4ZTFlMDdjZTgyODgxYmUgMTAwNjQ0Ci0tLSBhL1dl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9jb21taXQtbG9nLWZldGNoZXIu cGhwCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9jb21taXQt bG9nLWZldGNoZXIucGhwCkBAIC0xNTUsMTAgKzE1NSwxMCBAQCBjbGFzcyBDb21taXRMb2dGZXRj aGVyIHsKICAgICBmdW5jdGlvbiBmZXRjaF9sYXRlc3RfZm9yX3BsYXRmb3JtKCRyZXBvc2l0b3J5 X2lkLCAkcGxhdGZvcm1faWQpCiAgICAgewogICAgICAgICAkcXVlcnlfcmVzdWx0ID0gJHRoaXMt PmRiLT5xdWVyeV9hbmRfZmV0Y2hfYWxsKCJTRUxFQ1QgY29tbWl0cy4qIEZST00gdGVzdF9ydW5z LCBidWlsZHMsIGJ1aWxkX2NvbW1pdHMsIGNvbW1pdHMKLSAgICAgICAgICAgIFdIRVJFIHJ1bl9i dWlsZCA9IGJ1aWxkX2lkIEFORCBOT1QgRVhJU1RTIChTRUxFQ1QgKiBGUk9NIGJ1aWxkX3JlcXVl c3RzIFdIRVJFIHJlcXVlc3RfYnVpbGQgPSBidWlsZF9pZCkKKyAgICAgICAgICAgIFdIRVJFIHJ1 bl9idWlsZCA9IGJ1aWxkX2lkIEFORCBOT1QgRVhJU1RTIChTRUxFQ1QgKiBGUk9NIGJ1aWxkX3Jl cXVlc3RzIFdIRVJFIHJlcXVlc3RfYnVpbGQgPSBidWlsZF9pZCBMSU1JVCAxKQogICAgICAgICAg ICAgICAgIEFORCBydW5fY29uZmlnIElOIChTRUxFQ1QgY29uZmlnX2lkIEZST00gdGVzdF9jb25m aWd1cmF0aW9ucwogICAgICAgICAgICAgICAgICAgICBXSEVSRSBjb25maWdfdHlwZSA9ICdjdXJy ZW50JyBBTkQgY29uZmlnX3BsYXRmb3JtID0gJDIgQU5EIGNvbmZpZ19tZXRyaWMKLSAgICAgICAg ICAgICAgICAgICAgICAgIElOIChTRUxFQ1QgbWV0cmljX2lkIEZST00gdGVzdF9tZXRyaWNzLCB0 ZXN0cyBXSEVSRSBtZXRyaWNfaWQgPSB0ZXN0X2lkIGFuZCB0ZXN0X3BhcmVudCBJUyBOVUxMKSkK KyAgICAgICAgICAgICAgICAgICAgICAgIElOIChTRUxFQ1QgbWV0cmljX2lkIEZST00gdGVzdF9t ZXRyaWNzLCB0ZXN0cyBXSEVSRSBtZXRyaWNfdGVzdCA9IHRlc3RfaWQgYW5kIHRlc3RfcGFyZW50 IElTIE5VTEwpKQogICAgICAgICAgICAgICAgIEFORCBydW5fYnVpbGQgPSBidWlsZF9pZCBBTkQg Y29tbWl0X2J1aWxkID0gYnVpbGRfaWQgQU5EIGJ1aWxkX2NvbW1pdCA9IGNvbW1pdF9pZCBBTkQg Y29tbWl0X3JlcG9zaXRvcnkgPSAkMQogICAgICAgICAgICAgT1JERVIgQlkgYnVpbGRfdGltZSBE RVNDIExJTUlUIDE7IiwgYXJyYXkoJHJlcG9zaXRvcnlfaWQsICRwbGF0Zm9ybV9pZCkpOwogICAg ICAgICAvKiBUaGlzIHF1ZXJ5IGlzIGFwcHJveGltYXRpb24uIEl0IGZpbmRzIHRoZSBjb21taXQg b2YgdGhlIGxhc3QgYnVpbGQgaW5zdGVhZCBvZiB0aGUgbGFzdCBjb21taXQuCmRpZmYgLS1naXQg YS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvc2VydmVyLXRlc3RzL2FwaS1jb21taXRzLXRlc3Rz LmpzIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3NlcnZlci10ZXN0cy9hcGktY29tbWl0cy10 ZXN0cy5qcwppbmRleCA5OGIwMmVmZWE2NzFkMWRlNjNiNTg2MzVkMDQ0NjYyNzBmYzJkMzFhLi4x ZWQxYWRmOTBiMDUxNjc1OTk5ZDUwMDM3MDY1MTNmMjZjNjRiZmM3IDEwMDY0NAotLS0gYS9XZWJz aXRlcy9wZXJmLndlYmtpdC5vcmcvc2VydmVyLXRlc3RzL2FwaS1jb21taXRzLXRlc3RzLmpzCisr KyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9zZXJ2ZXItdGVzdHMvYXBpLWNvbW1pdHMtdGVz dHMuanMKQEAgLTUsNiArNSw3IEBAIGNvbnN0IGFzc2VydCA9IHJlcXVpcmUoJ2Fzc2VydCcpOwog Y29uc3QgVGVzdFNlcnZlciA9IHJlcXVpcmUoJy4vcmVzb3VyY2VzL3Rlc3Qtc2VydmVyLmpzJyk7 CiBjb25zdCBhZGRTbGF2ZUZvclJlcG9ydCA9IHJlcXVpcmUoJy4vcmVzb3VyY2VzL2NvbW1vbi1v cGVyYXRpb25zLmpzJykuYWRkU2xhdmVGb3JSZXBvcnQ7CiBjb25zdCBwcmVwYXJlU2VydmVyVGVz dCA9IHJlcXVpcmUoJy4vcmVzb3VyY2VzL2NvbW1vbi1vcGVyYXRpb25zLmpzJykucHJlcGFyZVNl cnZlclRlc3Q7Citjb25zdCBzdWJtaXRSZXBvcnQgPSByZXF1aXJlKCcuL3Jlc291cmNlcy9jb21t b24tb3BlcmF0aW9ucy5qcycpLnN1Ym1pdFJlcG9ydDsKIAogZGVzY3JpYmUoIi9hcGkvY29tbWl0 cy8iLCBmdW5jdGlvbiAoKSB7CiAgICAgcHJlcGFyZVNlcnZlclRlc3QodGhpcyk7CkBAIC04MCw2 ICs4MSwyMSBAQCBkZXNjcmliZSgiL2FwaS9jb21taXRzLyIsIGZ1bmN0aW9uICgpIHsKICAgICAg ICAgdGltZTogJzIwMTctMDEtMjBUMDM6NTY6MjAuMDQ1WicKICAgICB9CiAKKyAgICBjb25zdCBy ZXBvcnQgPSBbeworICAgICAgICAiYnVpbGROdW1iZXIiOiAiMTI0IiwKKyAgICAgICAgImJ1aWxk VGltZSI6ICIyMDE1LTEwLTI3VDE1OjM0OjUxIiwKKyAgICAgICAgImJ1aWxkZXJOYW1lIjogInNv bWVCdWlsZGVyIiwKKyAgICAgICAgImJ1aWxkZXJQYXNzd29yZCI6ICJzb21lUGFzc3dvcmQiLAor ICAgICAgICAicGxhdGZvcm0iOiAic29tZSBwbGF0Zm9ybSIsCisgICAgICAgICJ0ZXN0cyI6IHsi U3BlZWRvbWV0ZXItMiI6IHsibWV0cmljcyI6IHsiU2NvcmUiOiB7ImN1cnJlbnQiOiBbWzEwMF1d fX19fSwKKyAgICAgICAgInJldmlzaW9ucyI6IHsKKyAgICAgICAgICAgICJXZWJLaXQiOiB7Cisg ICAgICAgICAgICAgICAgInRpbWVzdGFtcCI6ICIyMDE3LTAxLTIwVDAyOjUyOjM0LjU3N1oiLAor ICAgICAgICAgICAgICAgICJyZXZpc2lvbiI6ICIyMTA5NDgiCisgICAgICAgICAgICB9CisgICAg ICAgIH0KKyAgICB9XTsKKwogICAgIGZ1bmN0aW9uIGFzc2VydENvbW1pdElzU2FtZUFzT25lU3Vi bWl0dGVkKGNvbW1pdCwgc3VibWl0dGVkKQogICAgIHsKICAgICAgICAgYXNzZXJ0LmVxdWFsKGNv bW1pdFsncmV2aXNpb24nXSwgc3VibWl0dGVkWydyZXZpc2lvbiddKTsKQEAgLTIzOCw2ICsyNTQs MjggQEAgZGVzY3JpYmUoIi9hcGkvY29tbWl0cy8iLCBmdW5jdGlvbiAoKSB7CiAgICAgICAgICAg ICAgICAgYXNzZXJ0LmVxdWFsKHJlc3VsdFsnY29tbWl0cyddWzBdWydyZXZpc2lvbiddLCBzeXN0 ZW1WZXJzaW9uQ29tbWl0c1snY29tbWl0cyddWzBdWydyZXZpc2lvbiddKTsKICAgICAgICAgICAg IH0pOwogICAgICAgICB9KTsKKworICAgICAgICBpdCgic2hvdWxkIGFsd2F5cyByZXR1cm4gYSBj b21taXQgYXMgbG9uZyBhcyB0aGVyZSBpcyBhbiBleGlzdGluZyAnY3VycmVudCcgdHlwZSB0ZXN0 IHJ1biBmb3IgZ2l2ZW4gcGxhdGZvcm0iLCBhc3luYyAoKSA9PiB7CisgICAgICAgICAgICBjb25z dCByZW1vdGUgPSBUZXN0U2VydmVyLnJlbW90ZUFQSSgpOworICAgICAgICAgICAgY29uc3QgZGIg PSBUZXN0U2VydmVyLmRhdGFiYXNlKCk7CisgICAgICAgICAgICBhd2FpdCBkYi5pbnNlcnQoJ3Rl c3RzJywge25hbWU6ICdBLVRlc3QnfSk7CisgICAgICAgICAgICBhd2FpdCBzdWJtaXRSZXBvcnQo cmVwb3J0KTsKKyAgICAgICAgICAgIGF3YWl0IGRiLnF1ZXJ5KGBERUxFVEUgRlJPTSB0ZXN0cyBX SEVSRSB0ZXN0X25hbWUgPSAnQS1UZXN0J2ApOworCisgICAgICAgICAgICBjb25zdCBwbGF0Zm9y bXMgPSBhd2FpdCBkYi5zZWxlY3RBbGwoJ3BsYXRmb3JtcycpOworICAgICAgICAgICAgYXNzZXJ0 LmVxdWFsKHBsYXRmb3Jtcy5sZW5ndGgsIDEpOworCisgICAgICAgICAgICBjb25zdCB0ZXN0X21l dHJpY3MgPSBhd2FpdCBkYi5zZWxlY3RBbGwoJ3Rlc3RfbWV0cmljcycpOworICAgICAgICAgICAg YXNzZXJ0LmVxdWFsKHRlc3RfbWV0cmljcy5sZW5ndGgsIDEpOworCisgICAgICAgICAgICBjb25z dCB0ZXN0cyA9IGF3YWl0IGRiLnNlbGVjdEFsbCgndGVzdHMnKTsKKyAgICAgICAgICAgIGFzc2Vy dC5lcXVhbCh0ZXN0cy5sZW5ndGgsIDEpOworCisgICAgICAgICAgICBhc3NlcnQodGVzdF9tZXRy aWNzWzBdLmlkICE9IHRlc3RzWzBdLmlkKTsKKworICAgICAgICAgICAgY29uc3QgcmVzcG9uc2Ug PSBhd2FpdCByZW1vdGUuZ2V0SlNPTihgL2FwaS9jb21taXRzL1dlYktpdC9sYXRlc3Q/cGxhdGZv cm09JHtwbGF0Zm9ybXNbMF0uaWR9YCk7CisgICAgICAgICAgICBhc3NlcnQocmVzcG9uc2UuY29t bWl0cy5sZW5ndGgpOworICAgICAgICB9KTsKICAgICB9KTsKIAogICAgIGRlc2NyaWJlKCcvYXBp L2NvbW1pdHMvPHJlcG9zaXRvcnk+L2xhc3QtcmVwb3J0ZWQnLCAoKSA9PiB7Cg==