199031 2019-06-19 13:46:56 -0700 [ews-build] Patch link should open the pretty patch 2019-06-19 15:48:44 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain commit-queue jbedard webkit-bug-importer oldest_to_newest 1546227 0 aakash_jain 2019-06-19 13:46:56 -0700 EWS builds have a link to patch, however it opens the plain text version of the patch which isn't much readable. It would be better to link to prettypatch which is more readable (and shows the diff in color). 1546228 1 372491 aakash_jain 2019-06-19 13:48:09 -0700 Created attachment 372491 Patch 1546232 2 aakash_jain 2019-06-19 13:49:25 -0700 The difference is: https://bugs.webkit.org/attachment.cgi?id=372491 vs https://bugs.webkit.org/attachment.cgi?id=372491&action=prettypatch 1546257 3 372491 commit-queue 2019-06-19 15:45:58 -0700 Comment on attachment 372491 Patch Clearing flags on attachment: 372491 Committed r246613: <https://trac.webkit.org/changeset/246613> 1546258 4 commit-queue 2019-06-19 15:45:59 -0700 All reviewed patches have been landed. Closing bug. 1546259 5 webkit-bug-importer 2019-06-19 15:48:44 -0700 <rdar://problem/51917356> 372491 2019-06-19 13:48:09 -0700 2019-06-19 15:45:58 -0700 Patch bug-199031-20190619164808.patch text/plain 1223 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NjYwOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA2LTE5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBQYXRjaCBsaW5rIHNob3VsZCBvcGVuIHRoZSBwcmV0 dHkgcGF0Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5OTAzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoQ29uZmln dXJlQnVpbGQuZ2V0UGF0Y2hVUkwpOiBVc2UgdGhlIHByZXR0eXBhdGNoIHVybCBmb3IgcGF0Y2gu CisKIDIwMTktMDYtMTkgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFtld3MtYnVpbGRdIFNlbmQgZW1haWwgbm90aWZpY2F0aW9ucyBmb3IgZmFpbHVyZXMK SW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlz aW9uIDI0NjYwOCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5w eQkod29ya2luZyBjb3B5KQpAQCAtODMsNyArODMsNyBAQCBjbGFzcyBDb25maWd1cmVCdWlsZChi dWlsZHN0ZXAuQnVpbGRTdGVwCiAgICAgZGVmIGdldFBhdGNoVVJMKHNlbGYsIHBhdGNoX2lkKToK ICAgICAgICAgaWYgbm90IHBhdGNoX2lkOgogICAgICAgICAgICAgcmV0dXJuIE5vbmUKLSAgICAg ICAgcmV0dXJuICd7fWF0dGFjaG1lbnQuY2dpP2lkPXt9Jy5mb3JtYXQoQlVHX1NFUlZFUl9VUkws IHBhdGNoX2lkKQorICAgICAgICByZXR1cm4gJ3t9YXR0YWNobWVudC5jZ2k/aWQ9e30mYWN0aW9u PXByZXR0eXBhdGNoJy5mb3JtYXQoQlVHX1NFUlZFUl9VUkwsIHBhdGNoX2lkKQogCiAKIGNsYXNz IENoZWNrT3V0U291cmNlKGdpdC5HaXQpOgo=