199030 2019-06-19 13:33:04 -0700 Some of the ASSERTs in CachedTypes.cpp should be RELEASE_ASSERTs 2019-06-19 14:30:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1546221 0 tzagallo 2019-06-19 13:33:04 -0700 ... 1546224 1 372490 tzagallo 2019-06-19 13:34:56 -0700 Created attachment 372490 Patch 1546226 2 372490 mark.lam 2019-06-19 13:42:38 -0700 Comment on attachment 372490 Patch r=me 1546242 3 372490 commit-queue 2019-06-19 14:29:55 -0700 Comment on attachment 372490 Patch Clearing flags on attachment: 372490 Committed r246610: <https://trac.webkit.org/changeset/246610> 1546243 4 commit-queue 2019-06-19 14:29:56 -0700 All reviewed patches have been landed. Closing bug. 1546244 5 webkit-bug-importer 2019-06-19 14:30:17 -0700 <rdar://problem/51913463> 372490 2019-06-19 13:34:56 -0700 2019-06-19 14:29:55 -0700 Patch bug-199030-20190619223454.patch text/plain 3758 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx YzA4ZjYwMzljMTEwODRkMTE4N2ExNWM2MGYwZTEzNTI2ODk5YmRkLi44YWY1Y2M3ZjgyNzNiZmNh NTRhOWI0NjRkZjNhZTVjZDU4ZDQyNGQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxOS0wNi0xOSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBTb21lIG9mIHRoZSBBU1NFUlRzIGluIENhY2hlZFR5cGVzLmNwcCBzaG91 bGQgYmUgUkVMRUFTRV9BU1NFUlRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTkwMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGVzZSBhc3NlcnRpb25zIHJlcHJlc2VudCBzdHJvbmcgYXNzdW1wdGlv bnMgdGhhdCB0aGUgY2FjaGUgbWFrZXMgc28KKyAgICAgICAgaXQncyBub3Qgc2FmZSB0byBrZWVw IGV4ZWN1dGluZyBpZiB0aGV5IGZhaWwuCisKKyAgICAgICAgKiBydW50aW1lL0NhY2hlZFR5cGVz LmNwcDoKKyAgICAgICAgKEpTQzo6RW5jb2Rlcjo6bWFsbG9jKToKKyAgICAgICAgKEpTQzo6RW5j b2Rlcjo6UGFnZTo6YWxpZ25FbmQpOgorICAgICAgICAoSlNDOjpEZWNvZGVyOjpwdHJGb3JPZmZz ZXRGcm9tQmFzZSk6CisgICAgICAgIChKU0M6OkRlY29kZXI6OmhhbmRsZUZvckVudmlyb25tZW50 IGNvbnN0KToKKyAgICAgICAgKEpTQzo6RGVjb2Rlcjo6c2V0SGFuZGxlRm9yRW52aXJvbm1lbnQp OgorICAgICAgICAoSlNDOjpDYWNoZWRQdHI6OmdldCBjb25zdCk6CisgICAgICAgIChKU0M6OkNh Y2hlZE9wdGlvbmFsOjplbmNvZGUpOgorICAgICAgICAoSlNDOjpDYWNoZWRPcHRpb25hbDo6ZGVj b2RlQXNQdHIgY29uc3QpOiBEZWxldGVkLgorCiAyMDE5LTA2LTExICBBbGV4ZXkgU2h2YXlrYSAg PHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBKU0Mgc2hvdWxkIHRocm93IGlmIHBy b3h5IHNldCByZXR1cm5zIGZhbHNpc2ggaW4gc3RyaWN0IG1vZGUgY29udGV4dApkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwCmluZGV4IGIxNjIzNjk1Y2I2 M2U0ZTlkOTYzNzZmMWMyNDFmNzM2ZjlmOWJlNzUuLmZlY2E0ZWMxNDU4NGQxOTc0YTAyNzVhMGY1 ZGRiMmZiMzgwNTFiN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0NhY2hlZFR5cGVzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9DYWNo ZWRUeXBlcy5jcHAKQEAgLTEwMSw3ICsxMDEsNyBAQCBwdWJsaWM6CiAKICAgICBBbGxvY2F0aW9u IG1hbGxvYyh1bnNpZ25lZCBzaXplKQogICAgIHsKLSAgICAgICAgQVNTRVJUKHNpemUpOworICAg ICAgICBSRUxFQVNFX0FTU0VSVChzaXplKTsKICAgICAgICAgcHRyZGlmZl90IG9mZnNldDsKICAg ICAgICAgaWYgKG1fY3VycmVudFBhZ2UtPm1hbGxvYyhzaXplLCBvZmZzZXQpKQogICAgICAgICAg ICAgcmV0dXJuIEFsbG9jYXRpb24geyBtX2N1cnJlbnRQYWdlLT5idWZmZXIoKSArIG9mZnNldCwg bV9iYXNlT2Zmc2V0ICsgb2Zmc2V0IH07CkBAIC0yNDQsNyArMjQ0LDcgQEAgcHJpdmF0ZToKICAg ICAgICAgICAgIHB0cmRpZmZfdCBzaXplID0gcm91bmRVcFRvTXVsdGlwbGVPZihhbGlnbm9mKHN0 ZDo6bWF4X2FsaWduX3QpLCBtX29mZnNldCk7CiAgICAgICAgICAgICBpZiAoc2l6ZSA9PSBtX29m ZnNldCkKICAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICBBU1NFUlQoc3RhdGlj X2Nhc3Q8c2l6ZV90PihzaXplKSA8PSBtX2NhcGFjaXR5KTsKKyAgICAgICAgICAgIFJFTEVBU0Vf QVNTRVJUKHN0YXRpY19jYXN0PHNpemVfdD4oc2l6ZSkgPD0gbV9jYXBhY2l0eSk7CiAgICAgICAg ICAgICBtX29mZnNldCA9IHNpemU7CiAgICAgICAgIH0KIApAQCAtMzIzLDIzICszMjMsMjEgQEAg V1RGOjpPcHRpb25hbDx2b2lkKj4gRGVjb2Rlcjo6Y2FjaGVkUHRyRm9yT2Zmc2V0KHB0cmRpZmZf dCBvZmZzZXQpCiAKIGNvbnN0IHZvaWQqIERlY29kZXI6OnB0ckZvck9mZnNldEZyb21CYXNlKHB0 cmRpZmZfdCBvZmZzZXQpCiB7Ci0jaWZuZGVmIE5ERUJVRwogICAgIEFTU0VSVChvZmZzZXQgPiAw ICYmIHN0YXRpY19jYXN0PHNpemVfdD4ob2Zmc2V0KSA8IG1fY2FjaGVkQnl0ZWNvZGUtPnNpemUo KSk7Ci0jZW5kaWYKICAgICByZXR1cm4gbV9jYWNoZWRCeXRlY29kZS0+ZGF0YSgpICsgb2Zmc2V0 OwogfQogCiBDb21wYWN0VmFyaWFibGVNYXA6OkhhbmRsZSBEZWNvZGVyOjpoYW5kbGVGb3JFbnZp cm9ubWVudChDb21wYWN0VmFyaWFibGVFbnZpcm9ubWVudCogZW52aXJvbm1lbnQpIGNvbnN0CiB7 CiAgICAgYXV0byBpdCA9IG1fZW52aXJvbm1lbnRUb0hhbmRsZU1hcC5maW5kKGVudmlyb25tZW50 KTsKLSAgICBBU1NFUlQoaXQgIT0gbV9lbnZpcm9ubWVudFRvSGFuZGxlTWFwLmVuZCgpKTsKKyAg ICBSRUxFQVNFX0FTU0VSVChpdCAhPSBtX2Vudmlyb25tZW50VG9IYW5kbGVNYXAuZW5kKCkpOwog ICAgIHJldHVybiBpdC0+dmFsdWU7CiB9CiAKIHZvaWQgRGVjb2Rlcjo6c2V0SGFuZGxlRm9yRW52 aXJvbm1lbnQoQ29tcGFjdFZhcmlhYmxlRW52aXJvbm1lbnQqIGVudmlyb25tZW50LCBjb25zdCBD b21wYWN0VmFyaWFibGVNYXA6OkhhbmRsZSYgaGFuZGxlKQogewogICAgIGF1dG8gYWRkUmVzdWx0 ID0gbV9lbnZpcm9ubWVudFRvSGFuZGxlTWFwLmFkZChlbnZpcm9ubWVudCwgaGFuZGxlKTsKLSAg ICBBU1NFUlRfVU5VU0VEKGFkZFJlc3VsdCwgYWRkUmVzdWx0LmlzTmV3RW50cnkpOworICAgIFJF TEVBU0VfQVNTRVJUKGFkZFJlc3VsdC5pc05ld0VudHJ5KTsKIH0KIAogdm9pZCBEZWNvZGVyOjph ZGRMZWFmRXhlY3V0YWJsZShjb25zdCBVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZSogZXhlY3V0 YWJsZSwgcHRyZGlmZl90IG9mZnNldCkKQEAgLTUyNSw4ICs1MjMsNyBAQCBwdWJsaWM6CiBwcml2 YXRlOgogICAgIGNvbnN0IFQqIGdldCgpIGNvbnN0CiAgICAgewotICAgICAgICBpZiAodGhpcy0+ aXNFbXB0eSgpKQotICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgICAgIFJFTEVBU0Vf QVNTRVJUKCF0aGlzLT5pc0VtcHR5KCkpOwogICAgICAgICByZXR1cm4gdGhpcy0+dGVtcGxhdGUg YnVmZmVyPFQ+KCk7CiAgICAgfQogfTsKQEAgLTgyNCwxNCArODIxLDYgQEAgcHVibGljOgogICAg ICAgICBlbHNlCiAgICAgICAgICAgICBlbmNvZGUoZW5jb2RlciwgeyAqc291cmNlIH0pOwogICAg IH0KLQotICAgIFNvdXJjZVR5cGU8VD4qIGRlY29kZUFzUHRyKERlY29kZXImIGRlY29kZXIpIGNv bnN0Ci0gICAgewotICAgICAgICBpZiAodGhpcy0+aXNFbXB0eSgpKQotICAgICAgICAgICAgcmV0 dXJuIG51bGxwdHI7Ci0KLSAgICAgICAgcmV0dXJuIHRoaXMtPnRlbXBsYXRlIGJ1ZmZlcjxUPigp LT5kZWNvZGUoZGVjb2Rlcik7Ci0gICAgfQogfTsKIAogY2xhc3MgQ2FjaGVkU2ltcGxlSnVtcFRh YmxlIDogcHVibGljIENhY2hlZE9iamVjdDxVbmxpbmtlZFNpbXBsZUp1bXBUYWJsZT4gewo=