199025 2019-06-19 12:25:37 -0700 [ews-build] Add step to analyze Compile WebKit failures 2019-06-19 13:50:20 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197850 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1546183 0 aakash_jain 2019-06-19 12:25:37 -0700 Currently when a patch fails to build, we un-apply the patch, and build without patch. However, we do not analyze the results. We should add a step to analyze these results. Also when ToT fails to build, instead of marking the patch as failed, we should keep trying indefinitely (like old EWS) until ToT is green again. 1546187 1 372485 aakash_jain 2019-06-19 12:35:54 -0700 Created attachment 372485 Proposed patch Sample run: Without failure on ToT: https://ews-build.webkit-uat.org/#/builders/33/builds/4178 With failure on ToT: https://ews-build.webkit-uat.org/#/builders/33/builds/4182 1546191 2 aakash_jain 2019-06-19 12:40:25 -0700 Example of similar behavior on old EWS: https://webkit-queues.webkit.org/patch/369760/mac-wk2-ews 1546230 3 372485 commit-queue 2019-06-19 13:49:13 -0700 Comment on attachment 372485 Proposed patch Clearing flags on attachment: 372485 Committed r246609: <https://trac.webkit.org/changeset/246609> 1546231 4 commit-queue 2019-06-19 13:49:15 -0700 All reviewed patches have been landed. Closing bug. 1546234 5 webkit-bug-importer 2019-06-19 13:50:20 -0700 <rdar://problem/51911524> 372485 2019-06-19 12:35:54 -0700 2019-06-19 13:49:13 -0700 Proposed patch AnalyzeCompileWebKitResults.patch text/plain 3396 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NjYwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTA2LTE5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgc3RlcCB0byBhbmFseXplIENvbXBpbGUgV2Vi S2l0IGZhaWx1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTkwMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKENv bXBpbGVXZWJLaXQuZXZhbHVhdGVDb21tYW5kKTogQWRkIEFuYWx5emVDb21waWxlV2ViS2l0UmVz dWx0cyBzdGVwLgorICAgICAgICAoQ29tcGlsZVdlYktpdFRvVCk6IHNldCBoYWx0T25GYWlsdXJl IHRvIEZhbHNlIHNpbmNlIHdlIG5lZWQgdG8gcnVuIEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0 cyBzdGVwLgorICAgICAgICAoQW5hbHl6ZUNvbXBpbGVXZWJLaXRSZXN1bHRzKTogQ2xhc3MgdG8g YW5hbHl6ZSBjb21waWxlIHdlYmtpdCBzdGVwcyByZXN1bHRzLgorICAgICAgICAoQW5hbHl6ZUNv bXBpbGVXZWJLaXRSZXN1bHRzLnN0YXJ0KTogSWYgVG9UIGZhaWxzIHRvIGJ1aWxkLCByZXRyeSB0 aGUgYnVpbGQsIGVsc2UgbWFya2VkIHRoZSBidWlsZCBhcyBmYWlsZWQuIE5vdGUgdGhhdAorICAg ICAgICB0aGlzIHN0ZXAgaXMgcnVuIG9ubHkgd2hlbiBjb21waWxlLXdlYmtpdCBmYWlsZWQuCisK IDIwMTktMDYtMTkgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCBidWlsZCB3YXJuaW5ncyBpbiBUZXN0V2ViS2l0QVBJ SW5qZWN0ZWRCdW5kbGUKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHMucHkJKHJldmlzaW9uIDI0NjYwNCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtNjE3LDcgKzYxNyw3IEBAIGNsYXNz IENvbXBpbGVXZWJLaXQoc2hlbGwuQ29tcGlsZSk6CiAgICAgZGVmIGV2YWx1YXRlQ29tbWFuZChz ZWxmLCBjbWQpOgogICAgICAgICBpZiBjbWQuZGlkRmFpbCgpOgogICAgICAgICAgICAgc2VsZi5z ZXRQcm9wZXJ0eSgncGF0Y2hGYWlsZWRUb0J1aWxkJywgVHJ1ZSkKLSAgICAgICAgICAgIHNlbGYu YnVpbGQuYWRkU3RlcHNBZnRlckN1cnJlbnRTdGVwKFtVbkFwcGx5UGF0Y2hJZlJlcXVpcmVkKCks IENvbXBpbGVXZWJLaXRUb1QoKV0pCisgICAgICAgICAgICBzZWxmLmJ1aWxkLmFkZFN0ZXBzQWZ0 ZXJDdXJyZW50U3RlcChbVW5BcHBseVBhdGNoSWZSZXF1aXJlZCgpLCBDb21waWxlV2ViS2l0VG9U KCksIEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0cygpXSkKICAgICAgICAgZWxzZToKICAgICAg ICAgICAgIHNlbGYuYnVpbGQuYWRkU3RlcHNBZnRlckN1cnJlbnRTdGVwKFtBcmNoaXZlQnVpbHRQ cm9kdWN0KCksIFVwbG9hZEJ1aWx0UHJvZHVjdCgpLCBUcmFuc2ZlclRvUzMoKV0pCiAKQEAgLTYy Niw3ICs2MjYsNyBAQCBjbGFzcyBDb21waWxlV2ViS2l0KHNoZWxsLkNvbXBpbGUpOgogCiBjbGFz cyBDb21waWxlV2ViS2l0VG9UKENvbXBpbGVXZWJLaXQpOgogICAgIG5hbWUgPSAnY29tcGlsZS13 ZWJraXQtdG90JwotICAgIGhhbHRPbkZhaWx1cmUgPSBUcnVlCisgICAgaGFsdE9uRmFpbHVyZSA9 IEZhbHNlCiAKICAgICBkZWYgZG9TdGVwSWYoc2VsZiwgc3RlcCk6CiAgICAgICAgIHJldHVybiBz ZWxmLmdldFByb3BlcnR5KCdwYXRjaEZhaWxlZFRvQnVpbGQnKSBvciBzZWxmLmdldFByb3BlcnR5 KCdwYXRjaEZhaWxlZEFQSVRlc3RzJykKQEAgLTYzOCw2ICs2MzgsMzUgQEAgY2xhc3MgQ29tcGls ZVdlYktpdFRvVChDb21waWxlV2ViS2l0KToKICAgICAgICAgcmV0dXJuIHNoZWxsLkNvbXBpbGUu ZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNtZCkKIAogCitjbGFzcyBBbmFseXplQ29tcGlsZVdlYktp dFJlc3VsdHMoYnVpbGRzdGVwLkJ1aWxkU3RlcCk6CisgICAgbmFtZSA9ICdhbmFseXplLWNvbXBp bGUtd2Via2l0LXJlc3VsdHMnCisgICAgZGVzY3JpcHRpb24gPSBbJ2FuYWx5emUtY29tcGlsZS13 ZWJraXQtcmVzdWx0cyddCisgICAgZGVzY3JpcHRpb25Eb25lID0gWydhbmFseXplLWNvbXBpbGUt d2Via2l0LXJlc3VsdHMnXQorCisgICAgZGVmIHN0YXJ0KHNlbGYpOgorICAgICAgICBjb21waWxl X3dlYmtpdF90b3RfcmVzdWx0ID0gc2VsZi5nZXRTdGVwUmVzdWx0KENvbXBpbGVXZWJLaXRUb1Qu bmFtZSkKKworICAgICAgICBpZiBjb21waWxlX3dlYmtpdF90b3RfcmVzdWx0ID09IEZBSUxVUkU6 CisgICAgICAgICAgICBzZWxmLmZpbmlzaGVkKEZBSUxVUkUpCisgICAgICAgICAgICBtZXNzYWdl ID0gJ1VuYWJsZSB0byBidWlsZCBXZWJLaXQgd2l0aG91dCBwYXRjaCwgcmV0cnlpbmcgYnVpbGQn CisgICAgICAgICAgICBzZWxmLmRlc2NyaXB0aW9uRG9uZSA9IG1lc3NhZ2UKKyAgICAgICAgICAg IHNlbGYuYnVpbGQuYnVpbGRGaW5pc2hlZChbbWVzc2FnZV0sIFJFVFJZKQorICAgICAgICAgICAg cmV0dXJuIGRlZmVyLnN1Y2NlZWQoTm9uZSkKKworICAgICAgICBzZWxmLmZpbmlzaGVkKEZBSUxV UkUpCisgICAgICAgIHNlbGYuYnVpbGQucmVzdWx0cyA9IEZBSUxVUkUKKyAgICAgICAgbWVzc2Fn ZSA9ICdQYXRjaCBkb2VzIG5vdCBidWlsZCcKKyAgICAgICAgc2VsZi5kZXNjcmlwdGlvbkRvbmUg PSBtZXNzYWdlCisgICAgICAgIHNlbGYuYnVpbGQuYnVpbGRGaW5pc2hlZChbbWVzc2FnZV0sIEZB SUxVUkUpCisKKyAgICAgICAgcmV0dXJuIGRlZmVyLnN1Y2NlZWQoTm9uZSkKKworICAgIGRlZiBn ZXRTdGVwUmVzdWx0KHNlbGYsIHN0ZXBfbmFtZSk6CisgICAgICAgIGZvciBzdGVwIGluIHNlbGYu YnVpbGQuZXhlY3V0ZWRTdGVwczoKKyAgICAgICAgICAgIGlmIHN0ZXAubmFtZSA9PSBzdGVwX25h bWU6CisgICAgICAgICAgICAgICAgcmV0dXJuIHN0ZXAucmVzdWx0cworCisKIGNsYXNzIENvbXBp bGVKU0NPbmx5KENvbXBpbGVXZWJLaXQpOgogICAgIG5hbWUgPSAnYnVpbGQtanNjJwogICAgIGRl c2NyaXB0aW9uRG9uZSA9IFsnQ29tcGlsZWQgSlNDJ10K