199018 2019-06-19 11:03:12 -0700 [GTK] fast/mediastream/RTCPeerConnection-add-removeTrack.html is crashing 2019-08-09 14:57:34 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya tsaunier bugs-noreply clopez commit-queue pnormand tsaunier oldest_to_newest 1546139 0 aboya 2019-06-19 11:03:12 -0700 fast/mediastream/RTCPeerConnection-add-removeTrack.html Crashing since r246053:r246056 It seems the string is too long: String String::fromUTF8(const LChar* stringStart, size_t length) { if (length > MaxLength) CRASH(); Thread 1 (Thread 0x7f27550be9c0 (LWP 36070)): #0 WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:305 #1 0x00007f275ec97969 in WTF::String::fromUTF8(unsigned char const*, unsigned long) (stringStart="", length=139807294951298) at ../../Source/WTF/wtf/text/WTFString.cpp:846 #2 0x00007f276b014acb in WTF::String::fromUTF8(char const*, unsigned long) (characters=0x7fff1b898c00 "", length=139807294951298) at DerivedSources/ForwardingHeaders/wtf/text/WTFString.h:349 #3 0x00007f276ddbccdd in WebCore::fromStdString(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (value='\000' <repeats 24 times>, "\202\017'l'\177\000\000P\214\211\033\377\177\000\000\313J\001k'\177\000\000P\214\211\033\377\177\000\000\202\017'l'\177\000\000\000\214\211\033\377\177\000\000@\215\211\033\377\177\000\000\200\214\211\033\377\177\000\000\335\314\333m'\177\000\000\240\214\211\033\377\177\000\000@\215\211\033\377\177\000\000\275Ѳk'\177\000\000\275Ѳk'\177\000\000\340\214\211\033\377\177\000\000\205\310\333m'\177\000\000\240\225\022b&\177\000\000@\215\211\033\377\177\000\000\000\214\211\033\377\177\000\000\202\017'l'\177\000\000\000\000\000\000\000\000\000\000\240\063\000\354&\177\000\000\340\214\211\033\377\177\000\000"...) at ../../Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.h:57 #4 0x00007f276ddbc885 in WebCore::LibWebRTCRtpTransceiverBackend::mid() (this=0x7f26621295a0) at ../../Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.cpp:67 #5 0x00007f276c26e4aa in WebCore::RTCRtpTransceiver::mid() const (this=0x7f26ec003360) at ../../Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp:55 #6 0x00007f276bb2d190 in WebCore::jsRTCRtpTransceiverMidGetter (state=..., thisObject=..., throwScope=...) at DerivedSources/WebCore/JSRTCRtpTransceiver.cpp:217 #7 0x00007f276bb4c95a in WebCore::IDLAttribute<WebCore::JSRTCRtpTransceiver>::get<WebCore::jsRTCRtpTransceiverMidGetter, (WebCore::CastedThisErrorBehavior)3> (state=..., thisValue=139805210572384, attributeName=0x7f276f989bda "mid") at ../../Source/WebCore/bindings/js/JSDOMAttribute.h:69 #8 0x00007f276bb2d1eb in WebCore::jsRTCRtpTransceiverMid(JSC::ExecState*, long, JSC::PropertyName) (state=0x7fff1b8991f0, thisValue=139805210572384) at DerivedSources/WebCore/JSRTCRtpTransceiver.cpp:223 #9 0x00007f275e9350c9 in JSC::PropertySlot::customGetter(JSC::ExecState*, JSC::PropertyName) const (this=0x7fff1b899040, exec=0x7fff1b8991f0, propertyName=...) at ../../Source/JavaScriptCore/runtime/PropertySlot.cpp:50 #10 0x00007f276b38f1c0 in JSC::PropertySlot::getValue(JSC::ExecState*, JSC::PropertyName) const (this=0x7fff1b899040, exec=0x7fff1b8991f0, propertyName=...) at DerivedSources/ForwardingHeaders/JavaScriptCore/PropertySlot.h:414 #11 0x00007f276c5acb83 in JSC::JSValue::get(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&) const (this=0x7fff1b899088, exec=0x7fff1b8991f0, propertyName=..., slot=...) at DerivedSources/ForwardingHeaders/JavaScriptCore/JSCJSValueInlines.h:873 #12 0x00007f275e5de21a in JSC::LLInt::llint_slow_path_get_by_id (exec=0x7fff1b8991f0, pc=0x7f266211c33c) at ../../Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:762 #13 0x00007f275e5c75ce in llint_op_get_by_id () from /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18 #14 0x0000000000000000 in ?? () 1552055 1 373922 tsaunier 2019-07-11 07:42:22 -0700 Created attachment 373922 Patch 1552062 2 373922 clopez 2019-07-11 08:11:54 -0700 Comment on attachment 373922 Patch This is a gardening patch. It doesn't need review. Simply change the "Reviewed by NOBODY (OOPS!)." by something that contains the word "unreviewed" Like "Unreviewed gardening patch" and commit it directly (if you are committer) or ask any comitter to just set the cq+ flag 1559978 3 375943 tsaunier 2019-08-09 12:45:29 -0700 Created attachment 375943 Patch 1560060 4 375943 commit-queue 2019-08-09 14:57:32 -0700 Comment on attachment 375943 Patch Clearing flags on attachment: 375943 Committed r248479: <https://trac.webkit.org/changeset/248479> 1560061 5 commit-queue 2019-08-09 14:57:34 -0700 All reviewed patches have been landed. Closing bug. 373922 2019-07-11 07:42:22 -0700 2019-08-09 12:45:25 -0700 Patch bug-199018-20190711104221.patch text/plain 1644 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3MzQ3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODViMDdhM2ZiYWJhMGIzNjEyMzE3 MDM3NWU1NWJiNGYxYzM4NWQ5YS4uMzRkY2RhMmQ0MWM2NzY3MWViYzYwMDNiMDM2NDY0YzgxODll YmZmNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA3LTExICBUaGliYXVsdCBTYXVuaWVy ICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBmYXN0L21lZGlhc3RyZWFt L1JUQ1BlZXJDb25uZWN0aW9uLWFkZC1yZW1vdmVUcmFjay5odG1sIGlzIGNyYXNoaW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkwMTgKKworICAg ICAgICBUaGlzIGlzIGZpeGVkIGJ5IHRoZSBwYXRjaCBwcm92aWRlZCBpbiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MzI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u czoKKwogMjAxOS0wNy0xMCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAg ICAgICBbV0hMU0xdIEltcG9ydCBhbGwgdGVzdHMgdGhhdCBwYXNzIHdpdGhvdXQgY29tcGlsZXIg Y2hhbmdlcyBmcm9tIHRoZSBKUyByZWZlcmVuY2UgdGVzdCBzdWl0ZQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBhZTFkYjgwZTZjNTBhYmYwOWNmMWNiNzgz MTcxYzM0NWI4MWEzMTg4Li4wMWFkNzEyZWJjOWMyYTg5NTMxYzRmNTEwNWRjZGJhYjYxY2EzNTI0 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTI2OSw3 ICsxMjY5LDYgQEAgd2Via2l0Lm9yZy9iLzE5ODEyNiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0 L2FjY2Vzcy1jb250cm9sLXJlc3BvbnNlLXdpdGgtYm9keS0KIHdlYmtpdC5vcmcvYi8xMjA4Mzkg YW5pbWF0aW9ucy9jcm9zcy1mYWRlLWJhY2tncm91bmQtaW1hZ2UuaHRtbCBbIEltYWdlT25seUZh aWx1cmUgQ3Jhc2ggXQogd2Via2l0Lm9yZy9iLzE5OTAxMCBjc3MyLjEvdDEyMDQtb3JkZXItMDEt ZC5odG1sIFsgUGFzcyBDcmFzaCBdCiB3ZWJraXQub3JnL2IvMTk5MDE0IGZhc3QvY2FudmFzL3dl YmdsL3RleC1pbWFnZS1hbmQtc3ViLWltYWdlLTJkLXdpdGgtdmlkZW8tcmdiYTU1NTEuaHRtbCBb IFBhc3MgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzE5OTAxOCBmYXN0L21lZGlhc3RyZWFtL1JUQ1Bl ZXJDb25uZWN0aW9uLWFkZC1yZW1vdmVUcmFjay5odG1sIFsgQ3Jhc2ggXQogCiAjLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIyBFbmQgb2YgQ3Jhc2hpbmcgdGVzdHMK 375943 2019-08-09 12:45:29 -0700 2019-08-09 14:57:32 -0700 Patch bug-199018-20190809154528.patch text/plain 1594 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NDY1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmNkMDAwZjVkMDUxMmU1NGVkN2My ZmY4MTY4YWJiZWEyNTllZjAzZS4uNzk0MWRiYmM3MWQwZThmYWQ2ZmY2ZmJlNGUwOTQ2YzliNzRl MjhiNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA3LTExICBUaGliYXVsdCBTYXVuaWVy ICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBmYXN0L21lZGlhc3RyZWFt L1JUQ1BlZXJDb25uZWN0aW9uLWFkZC1yZW1vdmVUcmFjay5odG1sIGlzIGNyYXNoaW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkwMTgKKworICAg ICAgICBUaGlzIGlzIGZpeGVkIGJ5IHRoZSBwYXRjaCBwcm92aWRlZCBpbiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0MzI2CisKKyAgICAgICAgVW5yZXZpZXdlZCBn YXJkZW5pbmcgcGF0Y2gKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z OgorCiAyMDE5LTA4LTA4ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBQYWdlOiBkb24ndCBhbGxvdyB0aGUgZG9tYWluIHRvIGJlIGRp c2FibGVkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0 aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGIz MjEzODBhMWU3ODNiZThlZTdkNWIzZmUxY2NhYmZlNzgxM2E4NjcuLmYyNTdiNDA2NDFiMDU4ZjBh OWEzMzdlZmNjNDk2MmFkNDc4OTY2YTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0 RXhwZWN0YXRpb25zCkBAIC0xMjcxLDcgKzEyNzEsNiBAQCB3ZWJraXQub3JnL2IvMTk4MTI2IGh0 dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtcmVzcG9uc2Utd2l0aC1ib2R5 LQogd2Via2l0Lm9yZy9iLzEyMDgzOSBhbmltYXRpb25zL2Nyb3NzLWZhZGUtYmFja2dyb3VuZC1p bWFnZS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBDcmFzaCBdCiB3ZWJraXQub3JnL2IvMTk5MDEw IGNzczIuMS90MTIwNC1vcmRlci0wMS1kLmh0bWwgWyBQYXNzIENyYXNoIF0KIHdlYmtpdC5vcmcv Yi8xOTkwMTQgZmFzdC9jYW52YXMvd2ViZ2wvdGV4LWltYWdlLWFuZC1zdWItaW1hZ2UtMmQtd2l0 aC12aWRlby1yZ2JhNTU1MS5odG1sIFsgUGFzcyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMTk5MDE4 IGZhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24tYWRkLXJlbW92ZVRyYWNrLmh0bWwg WyBDcmFzaCBdCiAKIHdlYmtpdC5vcmcvYi8xOTk0NDAgZmFzdC9tZWRpYXN0cmVhbS9tZWRpYXN0 cmVhbXRyYWNrLXZpZGVvLWNsb25lLmh0bWwgWyBGYWlsdXJlIFRpbWVvdXQgQ3Jhc2ggXQogCg==