198973 2019-06-18 12:07:56 -0700 WebSocketDeflater uses an unnecessarily constrained compression memory level 2019-11-21 20:44:14 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=202401 InRadar P2 Normal --- 1 joepeck joepeck achristensen ap commit-queue joepeck webkit-bug-importer youennf oldest_to_newest 1545710 0 joepeck 2019-06-18 12:07:56 -0700 WebSocketDeflater uses an unnecessarily constrained compression memory level The default value for compression mem level is 8. WebSocketDeflater is using 1, which may be slow: > The memLevel parameter specifies how much memory should be allocated for the internal > compression state. memLevel=1 uses minimum memory but is slow and reduces compression > ratio; memLevel=9 uses maximum memory for optimal speed. The default value is 8. See > zconf.h for total memory usage as a function of windowBits and memLevel. A quick shows other browsers also appear to use the true default (8): - blink: https://chromiumcodereview.appspot.com/23623008 - net/websockets/websocket_deflater.cc - mozilla: https://hg.mozilla.org/mozilla-central/rev/724f0a71d621 - netwerk/protocol/websocket/WebSocketChannel.cpp 1545713 1 372360 joepeck 2019-06-18 12:10:06 -0700 Created attachment 372360 [PATCH] Proposed Fix 1545839 2 372360 commit-queue 2019-06-18 15:30:00 -0700 Comment on attachment 372360 [PATCH] Proposed Fix Clearing flags on attachment: 372360 Committed r246573: <https://trac.webkit.org/changeset/246573> 1545840 3 commit-queue 2019-06-18 15:30:02 -0700 All reviewed patches have been landed. Closing bug. 1545850 4 webkit-bug-importer 2019-06-18 15:36:37 -0700 <rdar://problem/51869119> 372360 2019-06-18 12:10:06 -0700 2019-06-18 15:30:00 -0700 [PATCH] Proposed Fix deflate.patch text/plain 1259 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMTZjMTgxY2UzYS4uNTk5NDI4NjVkYmQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0wNi0xOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFdlYlNvY2tldERlZmxhdGVyIHVzZXMgYW4gdW5uZWNlc3NhcmlseSBj b25zdHJhaW5lZCBjb21wcmVzc2lvbiBtZW1vcnkgbGV2ZWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODk3MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tl dERlZmxhdGVyLmNwcDoKKyAgICAgICAgU2V0IHRoZSBtZW1MZXZlbCB0byB0aGUgZGVmbGF0ZUlu aXQyIGRlZmF1bHQgdmFsdWUsIG5vdCBhIG1pbmltdW0gdmFsdWUuCisKIDIwMTktMDYtMTggIFNh YW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dITFNMXSBEbyBub3Qg Z2VuZXJhdGUgZHVwbGljYXRlIGNvbnN0cnVjdG9ycy9jb3B5IGNvbnN0cnVjdG9ycyBpbiBzeW50 aGVzaXplQ29uc3RydWN0b3JzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl YnNvY2tldHMvV2ViU29ja2V0RGVmbGF0ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJzb2NrZXRzL1dlYlNvY2tldERlZmxhdGVyLmNwcAppbmRleCA3ZDM5NzFkNTc5Ni4uMWQ2ZjE3 ODIyYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0cy9XZWJT b2NrZXREZWZsYXRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRz L1dlYlNvY2tldERlZmxhdGVyLmNwcApAQCAtNDMsNyArNDMsNyBAQAogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKLXN0YXRpYyBjb25zdCBpbnQgZGVmYXVsdE1lbUxldmVsID0gMTsKK3N0YXRpYyBj b25zdCBpbnQgZGVmYXVsdE1lbUxldmVsID0gODsKIHN0YXRpYyBjb25zdCBzaXplX3QgYnVmZmVy SW5jcmVtZW50VW5pdCA9IDQwOTY7CiAKIFdlYlNvY2tldERlZmxhdGVyOjpXZWJTb2NrZXREZWZs YXRlcihpbnQgd2luZG93Qml0cywgQ29udGV4dFRha2VPdmVyTW9kZSBjb250ZXh0VGFrZU92ZXJN b2RlKQo=