198972 2019-06-18 12:05:07 -0700 webkit-patch should allow for a bugzilla url not just bugzilla id 2019-06-18 14:12:28 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ap commit-queue dewei_zhu ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1545708 0 keith_miller 2019-06-18 12:05:07 -0700 webkit-patch should allow for a bugzilla url not just bugzilla id 1545709 1 372359 keith_miller 2019-06-18 12:06:43 -0700 Created attachment 372359 Patch 1545766 2 372359 dewei_zhu 2019-06-18 13:24:23 -0700 Comment on attachment 372359 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372359&action=review > Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py:61 > + 1 use 'pass' 1545769 3 372359 dewei_zhu 2019-06-18 13:25:36 -0700 Comment on attachment 372359 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372359&action=review > Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py:51 > + parsed_url = None You doin't need to initialize a parsed_url here. 1545771 4 372373 keith_miller 2019-06-18 13:29:05 -0700 Created attachment 372373 Patch for landing 1545773 5 keith_miller 2019-06-18 13:30:05 -0700 (In reply to dewei_zhu from comment #3) > Comment on attachment 372359 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372359&action=review > > > Tools/Scripts/webkitpy/tool/steps/promptforbugortitle.py:51 > > + parsed_url = None > > You doin't need to initialize a parsed_url here. As discussed offline. I meant to move the code out of the try catch block, which I have done for the final patch. 1545799 6 372373 commit-queue 2019-06-18 14:11:37 -0700 Comment on attachment 372373 Patch for landing Clearing flags on attachment: 372373 Committed r246566: <https://trac.webkit.org/changeset/246566> 1545800 7 commit-queue 2019-06-18 14:11:38 -0700 All reviewed patches have been landed. Closing bug. 1545802 8 webkit-bug-importer 2019-06-18 14:12:28 -0700 <rdar://problem/51865072> 372359 2019-06-18 12:06:43 -0700 2019-06-18 13:29:03 -0700 Patch bug-198972-20190618120643.patch text/plain 2865 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NTQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDljY2NjMjQ2N2VkZWI4OTJhYzRiNWIxM2E2M2YzNjM4 NzQxZjdmNS4uMThiZjBhZjMwMTYxNWUxNjZmZWFmNTg1M2YyZDliYjc4YWU1Mzg1NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE5LTA2LTE4ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIHdlYmtpdC1wYXRjaCBzaG91bGQgYWxsb3cgZm9yIGEgYnVnemlsbGEgdXJsIG5v dCBqdXN0IGJ1Z3ppbGxhIGlkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTg5NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXaGVuIHByb21wdGluZyBmb3IgYSBidWd6aWxsYSBpZCBvciBhIG5ldyB0aXRs ZSB3ZSBzaG91bGQgYWxzbworICAgICAgICBhbGxvdyBmb3IgYSBidWd6aWxsYSB1cmwuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcHJvbXB0Zm9yYnVnb3J0aXRsZS5w eToKKyAgICAgICAgKFByb21wdEZvckJ1Z09yVGl0bGUucnVuKToKKwogMjAxOS0wNi0xOCAgRGFu IEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmVydCB3b3JrYXJvdW5k IGZvciBidWcgMTk4OTA0IGZyb20gcnVuLXdlYmtpdC1hcmNoaXZlCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcHJvbXB0Zm9yYnVnb3J0aXRsZS5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9wcm9tcHRmb3JidWdvcnRpdGxlLnB5Cmlu ZGV4IDM5MTE0NGYyMDQyZTEwZmQwNjZiZjI0NDM1ODIzZDM4ZGZiMGE4NzUuLjU3NTc2NDRiYjEw MDFlYmNmMWE3NmZiY2U5ZTIwNWFjZTkzYjIwMDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9zdGVwcy9wcm9tcHRmb3JidWdvcnRpdGxlLnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9wcm9tcHRmb3JidWdvcnRpdGxlLnB5CkBAIC0yOCw3 ICsyOCw4IEBACiAKIGZyb20gd2Via2l0cHkudG9vbC5zdGVwcy5hYnN0cmFjdHN0ZXAgaW1wb3J0 IEFic3RyYWN0U3RlcAogZnJvbSB3ZWJraXRweS50b29sLnN0ZXBzLm9wdGlvbnMgaW1wb3J0IE9w dGlvbnMKLQorZnJvbSB1cmxwYXJzZSBpbXBvcnQgdXJscGFyc2UKK2ltcG9ydCByZQogCiBjbGFz cyBQcm9tcHRGb3JCdWdPclRpdGxlKEFic3RyYWN0U3RlcCk6CiAgICAgQGNsYXNzbWV0aG9kCkBA IC00MSwxMiArNDIsMjQgQEAgY2xhc3MgUHJvbXB0Rm9yQnVnT3JUaXRsZShBYnN0cmFjdFN0ZXAp OgogICAgICAgICAjIE5vIG5lZWQgdG8gcHJvbXB0IGlmIHdlIGFscmFkeSBoYXZlIHRoZSBidWdf aWQuCiAgICAgICAgIGlmIHN0YXRlLmdldCgiYnVnX2lkIik6CiAgICAgICAgICAgICByZXR1cm4K LSAgICAgICAgdXNlcl9yZXNwb25zZSA9IHNlbGYuX3Rvb2wudXNlci5wcm9tcHQoIlBsZWFzZSBl bnRlciBhIGJ1ZyBudW1iZXIgb3IgYSB0aXRsZSBmb3IgYSBuZXcgYnVnOlxuIikKLSAgICAgICAg IyBJZiB0aGUgdXNlciByZXNwb25kcyB3aXRoIGEgbnVtYmVyLCB3ZSBhc3N1bWUgaXQncyBidWcg bnVtYmVyLgorICAgICAgICB1c2VyX3Jlc3BvbnNlID0gc2VsZi5fdG9vbC51c2VyLnByb21wdCgi UGxlYXNlIGVudGVyIGEgYnVnIG51bWJlci9idWd6aWxsYSBVUkwgb3IgYSB0aXRsZSBmb3IgYSBu ZXcgYnVnOlxuIikKKyAgICAgICAgIyBJZiB0aGUgdXNlciByZXNwb25kcyB3aXRoIGEgbnVtYmVy IG9yIGEgdmFsaWQgYnVnemlsbGEgVVJMLCB3ZSBhc3N1bWUgaXQncyBidWcgbnVtYmVyLgogICAg ICAgICAjIE90aGVyd2lzZSB3ZSBhc3N1bWUgaXQncyBhIGJ1ZyBzdWJqZWN0LgogICAgICAgICB0 cnk6CiAgICAgICAgICAgICBzdGF0ZVsiYnVnX2lkIl0gPSBpbnQodXNlcl9yZXNwb25zZSkKICAg ICAgICAgZXhjZXB0IFZhbHVlRXJyb3IgYXMgVHlwZUVycm9yOgorICAgICAgICAgICAgcGFyc2Vk X3VybCA9IE5vbmUKKyAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAgICBwYXJzZWRfdXJs ID0gdXJscGFyc2UodXNlcl9yZXNwb25zZSkKKyAgICAgICAgICAgICAgICBpZiByZS5tYXRjaCgi YnVncy53ZWJraXQub3JnIiwgcGFyc2VkX3VybC5uZXRsb2MpOgorICAgICAgICAgICAgICAgICAg ICBtYXRjaCA9IHJlLm1hdGNoKCJpZD0oP1A8YnVnX2lkPlxkKykiLCBwYXJzZWRfdXJsLnF1ZXJ5 KQorICAgICAgICAgICAgICAgICAgICBpZiBtYXRjaDoKKyAgICAgICAgICAgICAgICAgICAgICAg IHN0YXRlWyJidWdfaWQiXSA9IG1hdGNoLmdyb3VwKCJidWdfaWQiKQorICAgICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuCisgICAgICAgICAgICBleGNlcHQgVmFsdWVFcnJvcjoKKyAgICAgICAg ICAgICAgICAjIHVybHBhcnNlIGNhbiB0aHJvdyBhIHZhbHVlIGVycm9yIGZvciBzb21lIHN0cmlu Z3MgYW5kIGl0J3MgYSBzeW50YXggZXJyb3IgdG8gbm90IGhhdmUgYW4gZXhwcmVzc2lvbiBoZXJl CisgICAgICAgICAgICAgICAgMQorCiAgICAgICAgICAgICBpZiBub3Qgc2VsZi5fb3B0aW9ucy5u b25faW50ZXJhY3RpdmUgYW5kIG5vdCBzZWxmLl90b29sLnVzZXIuY29uZmlybSgiQXJlIHlvdSBz dXJlIHlvdSB3YW50IHRvIGNyZWF0ZSBhIG5ldyBidWc/IiwgZGVmYXVsdD0ibiIpOgogICAgICAg ICAgICAgICAgIHNlbGYuX2V4aXQoMSkKICAgICAgICAgICAgIHN0YXRlWyJidWdfdGl0bGUiXSA9 IHVzZXJfcmVzcG9uc2UK 372373 2019-06-18 13:29:05 -0700 2019-06-18 14:11:37 -0700 Patch for landing bug-198972-20190618132905.patch text/plain 2827 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NTQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDljY2NjMjQ2N2VkZWI4OTJhYzRiNWIxM2E2M2YzNjM4 NzQxZjdmNS4uNmI1MTU1N2NhOWIwZDM3YjllNTNiNjkyZDQyM2RmZGZkMTkwMTI4NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE5LTA2LTE4ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIHdlYmtpdC1wYXRjaCBzaG91bGQgYWxsb3cgZm9yIGEgYnVnemlsbGEgdXJsIG5v dCBqdXN0IGJ1Z3ppbGxhIGlkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTg5NzIKKworICAgICAgICBSZXZpZXdlZCBieSBEZXdlaSBaaHUuCisKKyAg ICAgICAgV2hlbiBwcm9tcHRpbmcgZm9yIGEgYnVnemlsbGEgaWQgb3IgYSBuZXcgdGl0bGUgd2Ug c2hvdWxkIGFsc28KKyAgICAgICAgYWxsb3cgZm9yIGEgYnVnemlsbGEgdXJsLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3Byb21wdGZvcmJ1Z29ydGl0bGUucHk6Cisg ICAgICAgIChQcm9tcHRGb3JCdWdPclRpdGxlLnJ1bik6CisKIDIwMTktMDYtMTggIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZlcnQgd29ya2Fyb3VuZCBmb3Ig YnVnIDE5ODkwNCBmcm9tIHJ1bi13ZWJraXQtYXJjaGl2ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3Byb21wdGZvcmJ1Z29ydGl0bGUucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcHJvbXB0Zm9yYnVnb3J0aXRsZS5weQppbmRleCAz OTExNDRmMjA0MmUxMGZkMDY2YmYyNDQzNTgyM2QzOGRmYjBhODc1Li5hMzIzNTc1NDY2NDAxYzBl ZmQ0OWIwNjAzNDczMjYyNjhmM2I4YmQzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvc3RlcHMvcHJvbXB0Zm9yYnVnb3J0aXRsZS5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvc3RlcHMvcHJvbXB0Zm9yYnVnb3J0aXRsZS5weQpAQCAtMjgsNyArMjgs OCBAQAogCiBmcm9tIHdlYmtpdHB5LnRvb2wuc3RlcHMuYWJzdHJhY3RzdGVwIGltcG9ydCBBYnN0 cmFjdFN0ZXAKIGZyb20gd2Via2l0cHkudG9vbC5zdGVwcy5vcHRpb25zIGltcG9ydCBPcHRpb25z Ci0KK2Zyb20gdXJscGFyc2UgaW1wb3J0IHVybHBhcnNlCitpbXBvcnQgcmUKIAogY2xhc3MgUHJv bXB0Rm9yQnVnT3JUaXRsZShBYnN0cmFjdFN0ZXApOgogICAgIEBjbGFzc21ldGhvZApAQCAtNDEs MTIgKzQyLDI1IEBAIGNsYXNzIFByb21wdEZvckJ1Z09yVGl0bGUoQWJzdHJhY3RTdGVwKToKICAg ICAgICAgIyBObyBuZWVkIHRvIHByb21wdCBpZiB3ZSBhbHJhZHkgaGF2ZSB0aGUgYnVnX2lkLgog ICAgICAgICBpZiBzdGF0ZS5nZXQoImJ1Z19pZCIpOgogICAgICAgICAgICAgcmV0dXJuCi0gICAg ICAgIHVzZXJfcmVzcG9uc2UgPSBzZWxmLl90b29sLnVzZXIucHJvbXB0KCJQbGVhc2UgZW50ZXIg YSBidWcgbnVtYmVyIG9yIGEgdGl0bGUgZm9yIGEgbmV3IGJ1ZzpcbiIpCi0gICAgICAgICMgSWYg dGhlIHVzZXIgcmVzcG9uZHMgd2l0aCBhIG51bWJlciwgd2UgYXNzdW1lIGl0J3MgYnVnIG51bWJl ci4KKyAgICAgICAgdXNlcl9yZXNwb25zZSA9IHNlbGYuX3Rvb2wudXNlci5wcm9tcHQoIlBsZWFz ZSBlbnRlciBhIGJ1ZyBudW1iZXIvYnVnemlsbGEgVVJMIG9yIGEgdGl0bGUgZm9yIGEgbmV3IGJ1 ZzpcbiIpCisgICAgICAgICMgSWYgdGhlIHVzZXIgcmVzcG9uZHMgd2l0aCBhIG51bWJlciBvciBh IHZhbGlkIGJ1Z3ppbGxhIFVSTCwgd2UgYXNzdW1lIGl0J3MgYnVnIG51bWJlci4KICAgICAgICAg IyBPdGhlcndpc2Ugd2UgYXNzdW1lIGl0J3MgYSBidWcgc3ViamVjdC4KICAgICAgICAgdHJ5Ogog ICAgICAgICAgICAgc3RhdGVbImJ1Z19pZCJdID0gaW50KHVzZXJfcmVzcG9uc2UpCiAgICAgICAg IGV4Y2VwdCBWYWx1ZUVycm9yIGFzIFR5cGVFcnJvcjoKKyAgICAgICAgICAgIHBhcnNlZF91cmwg PSBOb25lCisgICAgICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAgcGFyc2VkX3VybCA9IHVy bHBhcnNlKHVzZXJfcmVzcG9uc2UpCisgICAgICAgICAgICBleGNlcHQgVmFsdWVFcnJvcjoKKyAg ICAgICAgICAgICAgICAjIHVybHBhcnNlIGNhbiB0aHJvdyBhIHZhbHVlIGVycm9yIGZvciBzb21l IHN0cmluZ3MuCisgICAgICAgICAgICAgICAgcGFzcworCisgICAgICAgICAgICBpZiBwYXJzZWRf dXJsIGFuZCByZS5tYXRjaCgiYnVncy53ZWJraXQub3JnIiwgcGFyc2VkX3VybC5uZXRsb2MpOgor ICAgICAgICAgICAgICAgICAgICBtYXRjaCA9IHJlLm1hdGNoKCJpZD0oP1A8YnVnX2lkPlxkKyki LCBwYXJzZWRfdXJsLnF1ZXJ5KQorICAgICAgICAgICAgICAgICAgICBpZiBtYXRjaDoKKyAgICAg ICAgICAgICAgICAgICAgICAgIHN0YXRlWyJidWdfaWQiXSA9IGludChtYXRjaC5ncm91cCgiYnVn X2lkIikpCisgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4KKwogICAgICAgICAgICAgaWYg bm90IHNlbGYuX29wdGlvbnMubm9uX2ludGVyYWN0aXZlIGFuZCBub3Qgc2VsZi5fdG9vbC51c2Vy LmNvbmZpcm0oIkFyZSB5b3Ugc3VyZSB5b3Ugd2FudCB0byBjcmVhdGUgYSBuZXcgYnVnPyIsIGRl ZmF1bHQ9Im4iKToKICAgICAgICAgICAgICAgICBzZWxmLl9leGl0KDEpCiAgICAgICAgICAgICBz dGF0ZVsiYnVnX3RpdGxlIl0gPSB1c2VyX3Jlc3BvbnNlCg==