198961 2019-06-18 07:02:23 -0700 [LFC][IFC] Line::append() should take care of all the inline types. 2019-06-18 08:23:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1545595 0 zalan 2019-06-18 07:02:23 -0700 make all the ::append*() functions private. 1545596 1 webkit-bug-importer 2019-06-18 07:04:47 -0700 <rdar://problem/51847711> 1545598 2 372336 zalan 2019-06-18 07:05:32 -0700 Created attachment 372336 Patch 1545617 3 372336 commit-queue 2019-06-18 08:23:53 -0700 Comment on attachment 372336 Patch Clearing flags on attachment: 372336 Committed r246539: <https://trac.webkit.org/changeset/246539> 1545618 4 commit-queue 2019-06-18 08:23:54 -0700 All reviewed patches have been landed. Closing bug. 372336 2019-06-18 07:05:32 -0700 2019-06-18 08:23:53 -0700 Patch bug-198961-20190618070532.patch text/plain 7035 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTk5OGU1NmNhMmU2N2U1 YTliYTFhYmQ3ZjNhMDIyOGQzZDczOWU4Ny4uYWQwODIyZGQwZWFkOTNiYjIzZjNmZDZkYzk1MmY4 MzQyZDBmYjY1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA2LTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBMaW5lOjph cHBlbmQoKSBzaG91bGQgdGFrZSBjYXJlIG9mIGFsbCB0aGUgaW5saW5lIHR5cGVzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4OTYxCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS81MTg0NzcxMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBNYWtlIGFsbCB0aGUgZXhpc3RpbmcgTGluZTo6YXBwZW5kKiBm dW5jdGlvbnMgcHJpdmF0ZS4KKworICAgICAgICAqIGxheW91dC9Gb3JtYXR0aW5nQ29udGV4dEdl b21ldHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6c3RhdGljSG9yaXpvbnRhbFBv c2l0aW9uRm9yT3V0T2ZGbG93UG9zaXRpb25lZCk6IGZpeCBhIHR5cG8uCisgICAgICAgICogbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5b3V0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6SW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6Okxp bmVMYXlvdXQ6OnBsYWNlSW5saW5lSXRlbXMgY29uc3QpOgorICAgICAgICAqIGxheW91dC9pbmxp bmVmb3JtYXR0aW5nL0lubGluZUxpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpM aW5lOjphcHBlbmQpOgorICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxp bmUuaDoKKwogMjAxOS0wNi0xNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgQ29udmVydCBzb21lIHVzZXMgb2YgZml4ZWQgd2lkdGggYW5kIGZpeGVkIHByZWNpc2lv biBmbG9hdGluZyBwb2ludCBmb3JtYXR0aW5nIHRvIHVzZSBzaG9ydGVzdCBpbnN0ZWFkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHAK aW5kZXggMThlYTg2Zjk0ZDZjYzljMmEyYTdkMDY1ZDE5OTUwNTFkNTA2OTEyZC4uNDU2MDBlMDUy MWVkNTQ0ODBkMjQzZTMxMWQ0NWIwYzRkMDYyNjY1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvbGF5b3V0L0Zvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcApAQCAtMjMzLDcgKzIzMyw3 IEBAIHN0YXRpYyBMYXlvdXRVbml0IHN0YXRpY0hvcml6b250YWxQb3NpdGlvbkZvck91dE9mRmxv d1Bvc2l0aW9uZWQoY29uc3QgTGF5b3V0U3RhCiAgICAgICAgIEFTU0VSVCghY29udGFpbmVyLT5p c1Bvc2l0aW9uZWQoKSB8fCBsYXlvdXRCb3guaXNGaXhlZFBvc2l0aW9uZWQoKSk7CiAgICAgfQog ICAgIC8vIE1vdmUgdGhlIHN0YXRpYyBwb3NpdGlvbiByZWxhdGl2ZSB0byB0aGUgcGFkZGluZyBi b3guIFRoaXMgaXMgdmVyeSBzcGVjaWZpYyB0byBhYm9sdXRlbHkgcG9zaXRpb25lZCBib3hlcy4K LSAgICBhdXRvIHBhZGRpbmdCb3hMZWZ0ID0gbGF5b3V0U3RhdGUuZGlzcGxheUJveEZvckxheW91 dEJveChjb250YWluaW5nQmxvY2spLnBhZGRpbmdCb3hUb3AoKTsKKyAgICBhdXRvIHBhZGRpbmdC b3hMZWZ0ID0gbGF5b3V0U3RhdGUuZGlzcGxheUJveEZvckxheW91dEJveChjb250YWluaW5nQmxv Y2spLnBhZGRpbmdCb3hMZWZ0KCk7CiAgICAgcmV0dXJuIGxlZnQgLSBwYWRkaW5nQm94TGVmdDsK IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcv SW5saW5lRm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0TGluZUxheW91dC5j cHAKaW5kZXggYjVhMzRiM2E0ODBiMDVlNDc5YTg5Zjk2MzNjNGUyNjI4NDM0NTM2ZS4uNDk0NTEw MDA5MjlhZmM3NGE0OWMxZWVjMzQwMGVkZjQ4NTE2N2RiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRMaW5l TGF5b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9J bmxpbmVGb3JtYXR0aW5nQ29udGV4dExpbmVMYXlvdXQuY3BwCkBAIC0xNDMsMjEgKzE0Myw4IEBA IElubGluZUZvcm1hdHRpbmdDb250ZXh0OjpMaW5lTGF5b3V0OjpMaW5lQ29udGVudCBJbmxpbmVG b3JtYXR0aW5nQ29udGV4dDo6TGluZUxhCiAgICAgICAgIGlmICh1bmNvbW1pdHRlZENvbnRlbnQu aXNFbXB0eSgpKQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBjb21taXR0ZWRJbmxpbmVJ dGVtQ291bnQgKz0gdW5jb21taXR0ZWRDb250ZW50LnNpemUoKTsKLSAgICAgICAgZm9yIChhdXRv JiB1bmNvbW1pdHRlZFJ1biA6IHVuY29tbWl0dGVkQ29udGVudC5ydW5zKCkpIHsKLSAgICAgICAg ICAgIGF1dG8mIGlubGluZUl0ZW0gPSB1bmNvbW1pdHRlZFJ1bi5pbmxpbmVJdGVtOwotICAgICAg ICAgICAgaWYgKGlubGluZUl0ZW0uaXNIYXJkTGluZUJyZWFrKCkpCi0gICAgICAgICAgICAgICAg bGluZS0+YXBwZW5kSGFyZExpbmVCcmVhayhpbmxpbmVJdGVtKTsKLSAgICAgICAgICAgIGVsc2Ug aWYgKGlzPElubGluZVRleHRJdGVtPihpbmxpbmVJdGVtKSkKLSAgICAgICAgICAgICAgICBsaW5l LT5hcHBlbmRUZXh0Q29udGVudChkb3duY2FzdDxJbmxpbmVUZXh0SXRlbT4oaW5saW5lSXRlbSks IHVuY29tbWl0dGVkUnVuLmxvZ2ljYWxXaWR0aCk7Ci0gICAgICAgICAgICBlbHNlIGlmIChpbmxp bmVJdGVtLmlzQ29udGFpbmVyU3RhcnQoKSkKLSAgICAgICAgICAgICAgICBsaW5lLT5hcHBlbmRJ bmxpbmVDb250YWluZXJTdGFydChpbmxpbmVJdGVtLCB1bmNvbW1pdHRlZFJ1bi5sb2dpY2FsV2lk dGgpOwotICAgICAgICAgICAgZWxzZSBpZiAoaW5saW5lSXRlbS5pc0NvbnRhaW5lckVuZCgpKQot ICAgICAgICAgICAgICAgIGxpbmUtPmFwcGVuZElubGluZUNvbnRhaW5lckVuZChpbmxpbmVJdGVt LCB1bmNvbW1pdHRlZFJ1bi5sb2dpY2FsV2lkdGgpOwotICAgICAgICAgICAgZWxzZSBpZiAoaW5s aW5lSXRlbS5sYXlvdXRCb3goKS5pc1JlcGxhY2VkKCkpCi0gICAgICAgICAgICAgICAgbGluZS0+ YXBwZW5kUmVwbGFjZWRJbmxpbmVCb3goaW5saW5lSXRlbSwgdW5jb21taXR0ZWRSdW4ubG9naWNh bFdpZHRoKTsKLSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICBsaW5lLT5hcHBlbmRO b25SZXBsYWNlZElubGluZUJveChpbmxpbmVJdGVtLCB1bmNvbW1pdHRlZFJ1bi5sb2dpY2FsV2lk dGgpOwotICAgICAgICB9CisgICAgICAgIGZvciAoYXV0byYgdW5jb21taXR0ZWRSdW4gOiB1bmNv bW1pdHRlZENvbnRlbnQucnVucygpKQorICAgICAgICAgICAgbGluZS0+YXBwZW5kKHVuY29tbWl0 dGVkUnVuLmlubGluZUl0ZW0sIHVuY29tbWl0dGVkUnVuLmxvZ2ljYWxXaWR0aCk7CiAgICAgICAg IHVuY29tbWl0dGVkQ29udGVudC5yZXNldCgpOwogICAgIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuY3BwIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKaW5kZXggMmE2 MzU2ZDI2YjE5ZTE5YmQxYWZmZmU3OTVjNTg1ZWI5M2ZmYmY4Yi4uMGQ4MTA4Njc1MzUyMjNkZjky ZmY5YTg1MDEzNmEwZjBhMDdhMTk3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKQEAgLTE5Myw2ICsxOTMsMjEgQEAg TGF5b3V0VW5pdCBMaW5lOjp0cmFpbGluZ1RyaW1tYWJsZVdpZHRoKCkgY29uc3QKICAgICByZXR1 cm4gdHJpbW1hYmxlV2lkdGg7CiB9CiAKK3ZvaWQgTGluZTo6YXBwZW5kKGNvbnN0IElubGluZUl0 ZW0mIGlubGluZUl0ZW0sIExheW91dFVuaXQgbG9naWNhbFdpZHRoKQoreworICAgIGlmIChpbmxp bmVJdGVtLmlzSGFyZExpbmVCcmVhaygpKQorICAgICAgICByZXR1cm4gYXBwZW5kSGFyZExpbmVC cmVhayhpbmxpbmVJdGVtKTsKKyAgICBpZiAoaXM8SW5saW5lVGV4dEl0ZW0+KGlubGluZUl0ZW0p KQorICAgICAgICByZXR1cm4gYXBwZW5kVGV4dENvbnRlbnQoZG93bmNhc3Q8SW5saW5lVGV4dEl0 ZW0+KGlubGluZUl0ZW0pLCBsb2dpY2FsV2lkdGgpOworICAgIGlmIChpbmxpbmVJdGVtLmlzQ29u dGFpbmVyU3RhcnQoKSkKKyAgICAgICAgcmV0dXJuIGFwcGVuZElubGluZUNvbnRhaW5lclN0YXJ0 KGlubGluZUl0ZW0sIGxvZ2ljYWxXaWR0aCk7CisgICAgaWYgKGlubGluZUl0ZW0uaXNDb250YWlu ZXJFbmQoKSkKKyAgICAgICAgcmV0dXJuIGFwcGVuZElubGluZUNvbnRhaW5lckVuZChpbmxpbmVJ dGVtLCBsb2dpY2FsV2lkdGgpOworICAgIGlmIChpbmxpbmVJdGVtLmxheW91dEJveCgpLmlzUmVw bGFjZWQoKSkKKyAgICAgICAgcmV0dXJuIGFwcGVuZFJlcGxhY2VkSW5saW5lQm94KGlubGluZUl0 ZW0sIGxvZ2ljYWxXaWR0aCk7CisgICAgYXBwZW5kTm9uUmVwbGFjZWRJbmxpbmVCb3goaW5saW5l SXRlbSwgbG9naWNhbFdpZHRoKTsKK30KKwogdm9pZCBMaW5lOjphcHBlbmROb25CcmVha2FibGVT cGFjZShjb25zdCBJbmxpbmVJdGVtJiBpbmxpbmVJdGVtLCBjb25zdCBEaXNwbGF5OjpSZWN0JiBs b2dpY2FsUmVjdCkKIHsKICAgICBtX2NvbnRlbnQtPnJ1bnMoKS5hcHBlbmQoc3RkOjptYWtlX3Vu aXF1ZTxDb250ZW50OjpSdW4+KGlubGluZUl0ZW0sIGxvZ2ljYWxSZWN0LCBDb250ZW50OjpSdW46 OlRleHRDb250ZXh0IHsgfSwgZmFsc2UsIGZhbHNlKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmggYi9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmgKaW5kZXggYzI1YjdiNTdhMGM4 Y2JmYjI0N2JkMjEzOTY1ZmQzN2FlOTBmMGJjOC4uN2I2Y2IxMTQwZjM1N2I5Njk5ZjExZDY3OGNk MmIyZTk2OTQ5OTFjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZv cm1hdHRpbmcvSW5saW5lTGluZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVm b3JtYXR0aW5nL0lubGluZUxpbmUuaApAQCAtODUsMTMgKzg1LDcgQEAgcHVibGljOgogICAgIH07 CiAgICAgc3RkOjp1bmlxdWVfcHRyPENvbnRlbnQ+IGNsb3NlKCk7CiAKLSAgICB2b2lkIGFwcGVu ZFRleHRDb250ZW50KGNvbnN0IElubGluZVRleHRJdGVtJiwgTGF5b3V0VW5pdCBsb2dpY2FsV2lk dGgpOwotICAgIHZvaWQgYXBwZW5kTm9uUmVwbGFjZWRJbmxpbmVCb3goY29uc3QgSW5saW5lSXRl bSYsIExheW91dFVuaXQgbG9naWNhbFdpZHRoKTsKLSAgICB2b2lkIGFwcGVuZFJlcGxhY2VkSW5s aW5lQm94KGNvbnN0IElubGluZUl0ZW0mLCBMYXlvdXRVbml0IGxvZ2ljYWxXaWR0aCk7Ci0gICAg dm9pZCBhcHBlbmRJbmxpbmVDb250YWluZXJTdGFydChjb25zdCBJbmxpbmVJdGVtJiwgTGF5b3V0 VW5pdCBsb2dpY2FsV2lkdGgpOwotICAgIHZvaWQgYXBwZW5kSW5saW5lQ29udGFpbmVyRW5kKGNv bnN0IElubGluZUl0ZW0mLCBMYXlvdXRVbml0IGxvZ2ljYWxXaWR0aCk7Ci0gICAgdm9pZCBhcHBl bmRIYXJkTGluZUJyZWFrKGNvbnN0IElubGluZUl0ZW0mKTsKLQorICAgIHZvaWQgYXBwZW5kKGNv bnN0IElubGluZUl0ZW0mLCBMYXlvdXRVbml0IGxvZ2ljYWxXaWR0aCk7CiAgICAgYm9vbCBoYXND b250ZW50KCkgY29uc3QgeyByZXR1cm4gIWlzVmlzdWFsbHlFbXB0eSgpOyB9CiAKICAgICBMYXlv dXRVbml0IHRyYWlsaW5nVHJpbW1hYmxlV2lkdGgoKSBjb25zdDsKQEAgLTExOCw2ICsxMTIsMTMg QEAgcHJpdmF0ZToKICAgICBMYXlvdXRVbml0IGJhc2VsaW5lT2Zmc2V0KCkgY29uc3QgeyByZXR1 cm4gbV9iYXNlbGluZS5hc2NlbnQgKyBtX2Jhc2VsaW5lVG9wOyB9CiAKICAgICB2b2lkIGFwcGVu ZE5vbkJyZWFrYWJsZVNwYWNlKGNvbnN0IElubGluZUl0ZW0mLCBjb25zdCBEaXNwbGF5OjpSZWN0 JiBsb2dpY2FsUmVjdCk7CisgICAgdm9pZCBhcHBlbmRUZXh0Q29udGVudChjb25zdCBJbmxpbmVU ZXh0SXRlbSYsIExheW91dFVuaXQgbG9naWNhbFdpZHRoKTsKKyAgICB2b2lkIGFwcGVuZE5vblJl cGxhY2VkSW5saW5lQm94KGNvbnN0IElubGluZUl0ZW0mLCBMYXlvdXRVbml0IGxvZ2ljYWxXaWR0 aCk7CisgICAgdm9pZCBhcHBlbmRSZXBsYWNlZElubGluZUJveChjb25zdCBJbmxpbmVJdGVtJiwg TGF5b3V0VW5pdCBsb2dpY2FsV2lkdGgpOworICAgIHZvaWQgYXBwZW5kSW5saW5lQ29udGFpbmVy U3RhcnQoY29uc3QgSW5saW5lSXRlbSYsIExheW91dFVuaXQgbG9naWNhbFdpZHRoKTsKKyAgICB2 b2lkIGFwcGVuZElubGluZUNvbnRhaW5lckVuZChjb25zdCBJbmxpbmVJdGVtJiwgTGF5b3V0VW5p dCBsb2dpY2FsV2lkdGgpOworICAgIHZvaWQgYXBwZW5kSGFyZExpbmVCcmVhayhjb25zdCBJbmxp bmVJdGVtJik7CisKICAgICB2b2lkIHJlbW92ZVRyYWlsaW5nVHJpbW1hYmxlQ29udGVudCgpOwog CiAgICAgdm9pZCBhZGp1c3RCYXNlbGluZUFuZExpbmVIZWlnaHQoY29uc3QgSW5saW5lSXRlbSYs IExheW91dFVuaXQgcnVuSGVpZ2h0KTsK