198954 2019-06-17 22:20:32 -0700 REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing 2019-06-18 10:20:22 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 david_quesada webkit-unassigned achristensen ap commit-queue rniwa webkit-bug-importer oldest_to_newest 1545555 0 david_quesada 2019-06-17 22:20:32 -0700 rdar://problem/51711556 1545560 1 372328 david_quesada 2019-06-17 22:35:20 -0700 Created attachment 372328 Patch 1545561 2 david_quesada 2019-06-17 22:39:27 -0700 Before this patch, I ran 30 iterations of these tests locally and saw success rates of 21/30 and 25/30. With this patch, I've run 200 iterations (so far) and haven't seen any failures of either. 1545650 3 372328 commit-queue 2019-06-18 10:20:20 -0700 Comment on attachment 372328 Patch Clearing flags on attachment: 372328 Committed r246548: <https://trac.webkit.org/changeset/246548> 1545651 4 commit-queue 2019-06-18 10:20:22 -0700 All reviewed patches have been landed. Closing bug. 372328 2019-06-17 22:35:20 -0700 2019-06-18 10:20:20 -0700 Patch file_198954.txt text/plain 2699 david_quesada Y29tbWl0IDAzMzNiNzQ0NmI1NDhhNDE0OTQ3NjlhMzg1MjJhMzhkNDMxYjZlZDQNCkF1dGhvcjog RGF2aWQgUXVlc2FkYSA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQpEYXRlOiAgIE1vbiBKdW4g MTcgMjI6MzM6MDUgMjAxOSAtMDcwMA0KDQogICAgUkVHUkVTU0lPTjogX1dLRG93bmxvYWQuT3Jp Z2luYXRpbmdXZWJWaWV3IGFuZCBfV0tEb3dubG9hZC5DcmFzaEFmdGVyRG93bmxvYWREaWRGaW5p c2hXaGVuRG93bmxvYWRQcm94eUhvbGRzVGhlTGFzdFJlZk9uV2ViUHJvY2Vzc1Bvb2wgZmFpbGlu Zw0KICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg5NTQNCiAg ICByZGFyOi8vcHJvYmxlbS81MTcxMTU1Ng0KICAgIA0KICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLg0KICAgIA0KICAgIEZvciB0aGVzZSB0ZXN0cywga2lsbCB0aGUgd2ViIHByb2Nlc3Mg YWZ0ZXIgdGhlIGRvd25sb2FkIHN0YXJ0cy4gVGhpcyBtYWtlcyB0aGUgZGVhbGxvY2F0aW9uDQog ICAgb2YgdGhlIGRvd25sb2FkLW9yaWdpbmF0aW5nIHdlYiB2aWV3cywgd2hpY2ggdGhlc2UgdGVz dHMgZGVwZW5kIG9uLCBtb3JlIHJlbGlhYmxlLg0KICAgIA0KICAgICogVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXRDb2NvYS9Eb3dubG9hZC5tbToNCiAgICAoLVtPcmlnaW5hdGluZ1dlYlZpZXdE b3dubG9hZERlbGVnYXRlIF9kb3dubG9hZERpZFN0YXJ0Ol0pOg0KICAgICgtW1dhaXRVbnRpbERv d25sb2FkQ2FuY2VsZWREZWxlZ2F0ZSBfZG93bmxvYWREaWRTdGFydDpdKToNCg0KZGlmZiAtLWdp dCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZw0KaW5kZXggYzEzYmU2Nzk4MDIu Ljk4OGRkM2VkNDIzIDEwMDY0NA0KLS0tIGEvVG9vbHMvQ2hhbmdlTG9nDQorKysgYi9Ub29scy9D aGFuZ2VMb2cNCkBAIC0xLDMgKzEsMTggQEANCisyMDE5LTA2LTE3ICBEYXZpZCBRdWVzYWRhICA8 ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQorDQorICAgICAgICBSRUdSRVNTSU9OOiBfV0tEb3du bG9hZC5PcmlnaW5hdGluZ1dlYlZpZXcgYW5kIF9XS0Rvd25sb2FkLkNyYXNoQWZ0ZXJEb3dubG9h ZERpZEZpbmlzaFdoZW5Eb3dubG9hZFByb3h5SG9sZHNUaGVMYXN0UmVmT25XZWJQcm9jZXNzUG9v bCBmYWlsaW5nDQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk4OTU0DQorICAgICAgICByZGFyOi8vcHJvYmxlbS81MTcxMTU1Ng0KKw0KKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQorICAgICAgICBGb3IgdGhlc2UgdGVzdHMs IGtpbGwgdGhlIHdlYiBwcm9jZXNzIGFmdGVyIHRoZSBkb3dubG9hZCBzdGFydHMuIFRoaXMgbWFr ZXMgdGhlIGRlYWxsb2NhdGlvbg0KKyAgICAgICAgb2YgdGhlIGRvd25sb2FkLW9yaWdpbmF0aW5n IHdlYiB2aWV3cywgd2hpY2ggdGhlc2UgdGVzdHMgZGVwZW5kIG9uLCBtb3JlIHJlbGlhYmxlLg0K Kw0KKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0Rvd25sb2FkLm1t Og0KKyAgICAgICAgKC1bT3JpZ2luYXRpbmdXZWJWaWV3RG93bmxvYWREZWxlZ2F0ZSBfZG93bmxv YWREaWRTdGFydDpdKToNCisgICAgICAgICgtW1dhaXRVbnRpbERvd25sb2FkQ2FuY2VsZWREZWxl Z2F0ZSBfZG93bmxvYWREaWRTdGFydDpdKToNCisNCiAyMDE5LTA2LTE3ICBCcmVudCBGdWxnaGFt ICA8YmZ1bGdoYW1AYXBwbGUuY29tPg0KIA0KICAgICAgICAgRW5zdXJlIElUUCBzdGF0ZSBpcyBy ZWxheWVkIHRvIE5ldHdvcmsgUHJvY2VzcyBvbiByZXN0YXJ0DQpkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Eb3dubG9hZC5tbSBiL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvRG93bmxvYWQubW0NCmluZGV4IDU4MTc3MjdiNzNm Li44OGVkNWQ2MzY5YSAxMDA2NDQNCi0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Q29jb2EvRG93bmxvYWQubW0NCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Q29jb2EvRG93bmxvYWQubW0NCkBAIC0yNTksNiArMjU5LDcgQEAgLSAoaW5zdGFuY2V0eXBl KWluaXRXaXRoV2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldw0KIC0gKHZvaWQpX2Rvd25sb2Fk RGlkU3RhcnQ6KF9XS0Rvd25sb2FkICopZG93bmxvYWQNCiB7DQogICAgIEVYUEVDVF9FUShbZG93 bmxvYWQgb3JpZ2luYXRpbmdXZWJWaWV3XSwgX3dlYlZpZXcpOw0KKyAgICBbX3dlYlZpZXcgX2tp bGxXZWJDb250ZW50UHJvY2Vzc0FuZFJlc2V0U3RhdGVdOw0KICAgICBfd2ViVmlldyA9IG51bGxw dHI7DQogDQogICAgIFdURjo6Y2FsbE9uTWFpblRocmVhZChbZG93bmxvYWQgPSByZXRhaW5QdHIo ZG93bmxvYWQpXSB7DQpAQCAtNzUwLDYgKzc1MSw3IEBAIEBpbXBsZW1lbnRhdGlvbiBXYWl0VW50 aWxEb3dubG9hZENhbmNlbGVkRGVsZWdhdGUNCiAtICh2b2lkKV9kb3dubG9hZERpZFN0YXJ0Oihf V0tEb3dubG9hZCAqKWRvd25sb2FkDQogew0KICAgICBkaWREb3dubG9hZFN0YXJ0ID0gdHJ1ZTsN CisgICAgW2Rvd25sb2FkLm9yaWdpbmF0aW5nV2ViVmlldyBfa2lsbFdlYkNvbnRlbnRQcm9jZXNz QW5kUmVzZXRTdGF0ZV07DQogfQ0KIA0KIC0gKHZvaWQpX2Rvd25sb2FkRGlkQ2FuY2VsOihfV0tE b3dubG9hZCAqKWRvd25sb2FkDQo=