198951 2019-06-17 21:04:43 -0700 Web Inspector: Network: detail view shouldn't stay open when the related entry is removed 2019-06-18 12:51:20 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1545538 0 hi 2019-06-17 21:04:43 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. go to the Network tab 3. reload the inspected page 4. select any entry in the Network tab 5. reload the inspected page => the detail view stays open 1545540 1 372320 hi 2019-06-17 21:19:44 -0700 Created attachment 372320 Patch 1545701 2 372320 joepeck 2019-06-18 11:52:25 -0700 Comment on attachment 372320 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372320&action=review Good catch! r-me > Source/WebInspectorUI/UserInterface/Views/Table.js:285 > - for (let rowIndex = this._visibleRowIndexStart; rowIndex < this._visibleRowIndexEnd; ++rowIndex) { > + let numberOfRows = this.numberOfRows; > + for (let rowIndex = this._visibleRowIndexStart; rowIndex < Math.min(this._visibleRowIndexEnd, numberOfRows); ++rowIndex) { You should be able to move the `Math.min` calculation out of the loop so it is only performed once: let endIndex = Math.min(this._visibleRowIndexEnd, this.numberOfRows); 1545706 3 372358 hi 2019-06-18 12:01:10 -0700 Created attachment 372358 Patch 1545732 4 372358 commit-queue 2019-06-18 12:50:12 -0700 Comment on attachment 372358 Patch Clearing flags on attachment: 372358 Committed r246560: <https://trac.webkit.org/changeset/246560> 1545733 5 commit-queue 2019-06-18 12:50:14 -0700 All reviewed patches have been landed. Closing bug. 1545735 6 webkit-bug-importer 2019-06-18 12:51:20 -0700 <rdar://problem/51861653> 372320 2019-06-17 21:19:44 -0700 2019-06-18 12:01:08 -0700 Patch bug-198951-20190617211943.patch text/plain 3112 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDA3OWNmMDFhNzc2NmZlZTM0NWMzNTdiOTQ4OTY0 MmViNWYwMWNjYmEuLjk0NzgwNWM4MWZjOTAzOTdhNjMzOGM5MGY2MmQ5Y2RkNDY4YzY2ZjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA2LTE3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBO ZXR3b3JrOiBkZXRhaWwgdmlldyBzaG91bGRuJ3Qgc3RheSBvcGVuIHdoZW4gdGhlIHJlbGF0ZWQg ZW50cnkgaXMgcmVtb3ZlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk4OTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3Lmpz OgorICAgICAgICAoV0kuTmV0d29ya1RhYmxlQ29udGVudFZpZXcucHJvdG90eXBlLl9tYWluUmVz b3VyY2VEaWRDaGFuZ2UpOgorICAgICAgICBIaWRlIHRoZSBkZXRhaWwgdmlldyBpZiB0aGUgbWFp biByZXNvdXJjZSBjaGFuZ2VzIGFuZCB3ZSBhcmVuJ3QgcHJlc2VydmluZyB0aGUgbG9nLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qczoKKyAgICAgICAgKFdJLlRhYmxl LnByb3RvdHlwZS5yZWxvYWRWaXNpYmxlQ29sdW1uQ2VsbHMpOgorICAgICAgICBPbmx5IGF0dGVt cHQgdG8gcG9wdWxhdGUgY2VsbHMgZm9yIHJvd3MgdGhhdCB0aGUgYF9kYXRhU291cmNlYCBhY3R1 YWxseSBoYXMuIFdpdGhvdXQgdGhpcywKKyAgICAgICAgdGhlIGBfZGVsZWdhdGVgIG1heSBiZSBh c2tlZCB0byBwb3B1bGF0ZSBhIGNlbGwgZm9yIGEgcm93IGl0IGRvZXNuJ3QgaGF2ZSwgd2hpY2gg d291bGQgZXJyb3IuCisKIDIwMTktMDYtMTcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNldHRpbmdzOiBzcGxpdCB0aGUgR2VuZXJh bCBwYW5lbCBpbnRvIHN1YiBwYW5lbHMgc28gaXQncyBsZXNzIGNyb3dkZWQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNv bnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKaW5kZXggY2ZmZDFjZjI4NGM1OWExZmNkNzAzMTA4 MzZkNWVkYTg2ZmIzNTMyYS4uZjU4Mzg1YmEyMjlkYThlMGE4N2U2MjljMzcyZGQ2N2MzYTU1NDlj MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKQEAgLTE1ODcsOSAr MTU4NywxMyBAQCBXSS5OZXR3b3JrVGFibGVDb250ZW50VmlldyA9IGNsYXNzIE5ldHdvcmtUYWJs ZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZQogICAgIHsKICAgICAgICAgdGhpcy5f cnVuRm9yTWFpbkNvbGxlY3Rpb24oKGNvbGxlY3Rpb24pID0+IHsKICAgICAgICAgICAgIGxldCBm cmFtZSA9IGV2ZW50LnRhcmdldDsKLSAgICAgICAgICAgIGlmIChmcmFtZS5pc01haW5GcmFtZSgp ICYmIFdJLnNldHRpbmdzLmNsZWFyTmV0d29ya09uTmF2aWdhdGUudmFsdWUpCisgICAgICAgICAg ICBpZiAoZnJhbWUuaXNNYWluRnJhbWUoKSAmJiBXSS5zZXR0aW5ncy5jbGVhck5ldHdvcmtPbk5h dmlnYXRlLnZhbHVlKSB7CiAgICAgICAgICAgICAgICAgdGhpcy5fcmVzZXRDb2xsZWN0aW9uKGNv bGxlY3Rpb24pOwogCisgICAgICAgICAgICAgICAgaWYgKCF0aGlzLl9uZWVkc0luaXRpYWxQb3B1 bGF0ZSkKKyAgICAgICAgICAgICAgICAgICAgdGhpcy5faGlkZURldGFpbFZpZXcoKTsKKyAgICAg ICAgICAgIH0KKwogICAgICAgICAgICAgaWYgKHRoaXMuX3RyYW5zaXRpb25pbmdQYWdlVGFyZ2V0 KSB7CiAgICAgICAgICAgICAgICAgdGhpcy5fdHJhbnNpdGlvbmluZ1BhZ2VUYXJnZXQgPSBmYWxz ZTsKICAgICAgICAgICAgICAgICB0aGlzLl9uZWVkc0luaXRpYWxQb3B1bGF0ZSA9IHRydWU7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJs ZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpz CmluZGV4IDgyMTViMmMwOWQ0YTJjNjE2YTMyMTI4ODg5ZDI3YmI3NDIwOGE3ZjUuLmNlOWYwZWE0 Nzg1MmNhNDZkZGIyMmZmNzcwNThmZjEzNTJlMjFlNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzCkBAIC0yODEsNyArMjgxLDgg QEAgV0kuVGFibGUgPSBjbGFzcyBUYWJsZSBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgaWYgKGNv bHVtbkluZGV4ID09PSAtMSkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBmb3IgKGxl dCByb3dJbmRleCA9IHRoaXMuX3Zpc2libGVSb3dJbmRleFN0YXJ0OyByb3dJbmRleCA8IHRoaXMu X3Zpc2libGVSb3dJbmRleEVuZDsgKytyb3dJbmRleCkgeworICAgICAgICBsZXQgbnVtYmVyT2ZS b3dzID0gdGhpcy5udW1iZXJPZlJvd3M7CisgICAgICAgIGZvciAobGV0IHJvd0luZGV4ID0gdGhp cy5fdmlzaWJsZVJvd0luZGV4U3RhcnQ7IHJvd0luZGV4IDwgTWF0aC5taW4odGhpcy5fdmlzaWJs ZVJvd0luZGV4RW5kLCBudW1iZXJPZlJvd3MpOyArK3Jvd0luZGV4KSB7CiAgICAgICAgICAgICBs ZXQgcm93ID0gdGhpcy5fY2FjaGVkUm93cy5nZXQocm93SW5kZXgpOwogICAgICAgICAgICAgaWYg KCFyb3cpCiAgICAgICAgICAgICAgICAgY29udGludWU7Cg== 372358 2019-06-18 12:01:10 -0700 2019-06-18 12:50:12 -0700 Patch bug-198951-20190618120110.patch text/plain 3220 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ4YTAwODdiMDkwYjg0YzI3M2MyMTVhNmVkMDE4 ZTM2MGJhMDk5YTcuLjExYmNkODFmZjVjZTE5NzlkZTkyNzRlZDY2YThjZWNhNGYyNzI2YTEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA2LTE4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBO ZXR3b3JrOiBkZXRhaWwgdmlldyBzaG91bGRuJ3Qgc3RheSBvcGVuIHdoZW4gdGhlIHJlbGF0ZWQg ZW50cnkgaXMgcmVtb3ZlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk4OTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9zZXBoIFBlY29yYXJvLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5q czoKKyAgICAgICAgKFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5fbWFpblJl c291cmNlRGlkQ2hhbmdlKToKKyAgICAgICAgSGlkZSB0aGUgZGV0YWlsIHZpZXcgaWYgdGhlIG1h aW4gcmVzb3VyY2UgY2hhbmdlcyBhbmQgd2UgYXJlbid0IHByZXNlcnZpbmcgdGhlIGxvZy4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanM6CisgICAgICAgIChXSS5UYWJs ZS5wcm90b3R5cGUucmVsb2FkVmlzaWJsZUNvbHVtbkNlbGxzKToKKyAgICAgICAgT25seSBhdHRl bXB0IHRvIHBvcHVsYXRlIGNlbGxzIGZvciByb3dzIHRoYXQgdGhlIGBfZGF0YVNvdXJjZWAgYWN0 dWFsbHkgaGFzLiBXaXRob3V0IHRoaXMsCisgICAgICAgIHRoZSBgX2RlbGVnYXRlYCBtYXkgYmUg YXNrZWQgdG8gcG9wdWxhdGUgYSBjZWxsIGZvciBhIHJvdyBpdCBkb2Vzbid0IGhhdmUsIHdoaWNo IHdvdWxkIGVycm9yLgorCiAyMDE5LTA2LTE3ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBFbGVtZW50czogcmVtb3ZlIGVsbGlwc2Vz IGZyb20gIkJyZWFrIG9uIiBjb250ZXh0IG1lbnUgaXRlbSB0aXRsZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVu dFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3 b3JrVGFibGVDb250ZW50Vmlldy5qcwppbmRleCBjZmZkMWNmMjg0YzU5YTFmY2Q3MDMxMDgzNmQ1 ZWRhODZmYjM1MzJhLi44NzJlYWI4NDQxZTQyZDU0NmI0YjFiYWQ1YWY4ODUzZjg4MWVlNjIwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3 b3JrVGFibGVDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcwpAQCAtMTU4NSwxMSArMTU4 NSwxNSBAQCBXSS5OZXR3b3JrVGFibGVDb250ZW50VmlldyA9IGNsYXNzIE5ldHdvcmtUYWJsZUNv bnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZQogCiAgICAgX21haW5SZXNvdXJjZURpZENo YW5nZShldmVudCkKICAgICB7Ci0gICAgICAgIHRoaXMuX3J1bkZvck1haW5Db2xsZWN0aW9uKChj b2xsZWN0aW9uKSA9PiB7CisgICAgICAgIHRoaXMuX3J1bkZvck1haW5Db2xsZWN0aW9uKChjb2xs ZWN0aW9uLCB3YXNNYWluKSA9PiB7CiAgICAgICAgICAgICBsZXQgZnJhbWUgPSBldmVudC50YXJn ZXQ7Ci0gICAgICAgICAgICBpZiAoZnJhbWUuaXNNYWluRnJhbWUoKSAmJiBXSS5zZXR0aW5ncy5j bGVhck5ldHdvcmtPbk5hdmlnYXRlLnZhbHVlKQorICAgICAgICAgICAgaWYgKGZyYW1lLmlzTWFp bkZyYW1lKCkgJiYgV0kuc2V0dGluZ3MuY2xlYXJOZXR3b3JrT25OYXZpZ2F0ZS52YWx1ZSkgewog ICAgICAgICAgICAgICAgIHRoaXMuX3Jlc2V0Q29sbGVjdGlvbihjb2xsZWN0aW9uKTsKIAorICAg ICAgICAgICAgICAgIGlmICh3YXNNYWluICYmICF0aGlzLl9uZWVkc0luaXRpYWxQb3B1bGF0ZSkK KyAgICAgICAgICAgICAgICAgICAgdGhpcy5faGlkZURldGFpbFZpZXcoKTsKKyAgICAgICAgICAg IH0KKwogICAgICAgICAgICAgaWYgKHRoaXMuX3RyYW5zaXRpb25pbmdQYWdlVGFyZ2V0KSB7CiAg ICAgICAgICAgICAgICAgdGhpcy5fdHJhbnNpdGlvbmluZ1BhZ2VUYXJnZXQgPSBmYWxzZTsKICAg ICAgICAgICAgICAgICB0aGlzLl9uZWVkc0luaXRpYWxQb3B1bGF0ZSA9IHRydWU7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzCmluZGV4 IDgyMTViMmMwOWQ0YTJjNjE2YTMyMTI4ODg5ZDI3YmI3NDIwOGE3ZjUuLmU0NGE3YzI2MTgyZWM2 YzM2ZjZhZjQ5MTlhYTMxNWNjMDQ4MTRkNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzCkBAIC0yODEsNyArMjgxLDggQEAgV0ku VGFibGUgPSBjbGFzcyBUYWJsZSBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgaWYgKGNvbHVtbklu ZGV4ID09PSAtMSkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBmb3IgKGxldCByb3dJ bmRleCA9IHRoaXMuX3Zpc2libGVSb3dJbmRleFN0YXJ0OyByb3dJbmRleCA8IHRoaXMuX3Zpc2li bGVSb3dJbmRleEVuZDsgKytyb3dJbmRleCkgeworICAgICAgICBsZXQgbnVtYmVyT2ZSb3dzID0g TWF0aC5taW4odGhpcy5fdmlzaWJsZVJvd0luZGV4RW5kLCB0aGlzLm51bWJlck9mUm93cyk7Cisg ICAgICAgIGZvciAobGV0IHJvd0luZGV4ID0gdGhpcy5fdmlzaWJsZVJvd0luZGV4U3RhcnQ7IHJv d0luZGV4IDwgbnVtYmVyT2ZSb3dzOyArK3Jvd0luZGV4KSB7CiAgICAgICAgICAgICBsZXQgcm93 ID0gdGhpcy5fY2FjaGVkUm93cy5nZXQocm93SW5kZXgpOwogICAgICAgICAgICAgaWYgKCFyb3cp CiAgICAgICAgICAgICAgICAgY29udGludWU7Cg==