198944 2019-06-17 17:15:44 -0700 Web Inspector: Elements: remove ellipses from "Break on" context menu item title 2019-06-17 21:32:49 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198937 InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes nvasilyev webkit-bug-importer oldest_to_newest 1545483 0 mattbaker 2019-06-17 17:15:44 -0700 Per Apple's HI guidelines: Menu Item Titles A menu item title describes an action or attribute. Use an ellipsis whenever choosing a menu item requires additional input from the user. The ellipsis character (…) means a dialog or separate window will open and prompt the user for additional information or to make a choice. See: https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-anatomy/ Notes: I don't believe that the above description of "additional input" or a "separate window" applies to submenus. 1545485 1 372298 mattbaker 2019-06-17 17:17:56 -0700 Created attachment 372298 Patch 1545488 2 mattbaker 2019-06-17 17:21:21 -0700 (In reply to Matt Baker from comment #0) > Per Apple's HI guidelines: > > Menu Item Titles > A menu item title describes an action or attribute. > > Use an ellipsis whenever choosing a menu item requires additional input from > the user. The ellipsis character (…) means a dialog or separate window will > open and prompt the user for additional information or to make a choice. > > See: > https://developer.apple.com/design/human-interface-guidelines/macos/menus/ > menu-anatomy/ > > Notes: > I don't believe that the above description of "additional input" or a > "separate window" applies to submenus. It just occurred to me that the arrow (">") glyph displayed in macOS menu item titles implies this, making the ellipses redundant. 1545497 3 webkit-bug-importer 2019-06-17 17:41:05 -0700 <rdar://problem/51829232> 1545511 4 nvasilyev 2019-06-17 18:06:55 -0700 Good find! I was wondering about these ellipses. 1545537 5 372298 hi 2019-06-17 21:01:37 -0700 Comment on attachment 372298 Patch r=me 1545544 6 372298 commit-queue 2019-06-17 21:32:47 -0700 Comment on attachment 372298 Patch Clearing flags on attachment: 372298 Committed r246532: <https://trac.webkit.org/changeset/246532> 1545545 7 commit-queue 2019-06-17 21:32:49 -0700 All reviewed patches have been landed. Closing bug. 372298 2019-06-17 17:17:56 -0700 2019-06-17 21:32:47 -0700 Patch bug-198944-20190617171755.patch text/plain 2905 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 MjZiOTBjYzY3Nzc2YjIwZTVmYzVmOTU0MWMzZDE0MDI0MDkzMjYzLi4yMTMxYWIzZjEzYmY1Njg4 Yjk3N2U2MmViNThkMTExZDk3Y2FmZjVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wNi0xNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRWxlbWVudHM6IHJlbW92ZSBlbGxpcHNlcyBmcm9t ICJCcmVhayBvbiIgY29udGV4dCBtZW51IGl0ZW0gdGl0bGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODk0NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBjb250ZXh0IG1lbnUgdGl0bGUgdG8g Y29tcGx5IHdpdGggQXBwbGUgSEkgZ3VpZGVsaW5lcy4KKworICAgICAgICAqIExvY2FsaXphdGlv bnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL0NvbnRleHRNZW51VXRpbGl0aWVzLmpzOgorCiAyMDE5LTA2LTEzICBEZXZpbiBSb3Vz c28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNT SU9OKHIyNDYxNzgpOiBleHRyYSBzcGFjZXMgYWRkZWQgaW4gYXQtcnVsZXMgd2hlbiBmb3JtYXR0 aW5nIENTUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMv ZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2Nh bGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggOWEzYzllYTRjNGEz NWU5OGMwYWE2NDQwYWVlM2ZjOTFhYWUxNjI5Ni4uMzE1YmQ1ZjE5OGJkYjRhNDhmMGJlYTdiNDA5 ZWQ0ZWY1OTE1MzAxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXph dGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCkBAIC0xNjYs OSArMTY2LDkgQEAgbG9jYWxpemVkU3RyaW5nc1siQmxvY2sgVmFyaWFibGVzIl0gPSAiQmxvY2sg VmFyaWFibGVzIjsKIGxvY2FsaXplZFN0cmluZ3NbIkJvZHk6Il0gPSAiQm9keToiOwogbG9jYWxp emVkU3RyaW5nc1siQm91bmRhcnkiXSA9ICJCb3VuZGFyeSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJC b3ggTW9kZWwiXSA9ICJCb3ggTW9kZWwiOworbG9jYWxpemVkU3RyaW5nc1siQnJlYWsgb24iXSA9 ICJCcmVhayBvbiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJCcmVhayBvbiBldmVudHMgd2l0aCBuYW1l OiJdID0gIkJyZWFrIG9uIGV2ZW50cyB3aXRoIG5hbWU6IjsKIGxvY2FsaXplZFN0cmluZ3NbIkJy ZWFrIG9uIHJlcXVlc3Qgd2l0aCBVUkw6Il0gPSAiQnJlYWsgb24gcmVxdWVzdCB3aXRoIFVSTDoi OwotbG9jYWxpemVkU3RyaW5nc1siQnJlYWsgb25cdTIwMjYiXSA9ICJCcmVhayBvblx1MjAyNiI7 CiBsb2NhbGl6ZWRTdHJpbmdzWyJCcmVha2Rvd24iXSA9ICJCcmVha2Rvd24iOwogbG9jYWxpemVk U3RyaW5nc1siQnJlYWtkb3duIG9mIGVhY2ggbWVtb3J5IGNhdGVnb3J5IGF0IHRoZSBlbmQgb2Yg dGhlIHNlbGVjdGVkIHRpbWUgcmFuZ2UiXSA9ICJCcmVha2Rvd24gb2YgZWFjaCBtZW1vcnkgY2F0 ZWdvcnkgYXQgdGhlIGVuZCBvZiB0aGUgc2VsZWN0ZWQgdGltZSByYW5nZSI7CiBsb2NhbGl6ZWRT dHJpbmdzWyJCcmVha2Rvd24gb2YgdGltZSBzcGVudCBvbiB0aGUgbWFpbiB0aHJlYWQiXSA9ICJC cmVha2Rvd24gb2YgdGltZSBzcGVudCBvbiB0aGUgbWFpbiB0aHJlYWQiOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGV4dE1lbnVVdGls aXRpZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250 ZXh0TWVudVV0aWxpdGllcy5qcwppbmRleCBkYTNkYzYzM2NkZmNhYzZjMGRjYzcwM2E4NjdkNDAz NzE1NmQ2Nzg4Li4zZTM5NWM1MTVhMzY0YjNmYTEwNTQ0MjlhMzBlNjk5MTRlMjQwMjFhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZXh0 TWVudVV0aWxpdGllcy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9Db250ZXh0TWVudVV0aWxpdGllcy5qcwpAQCAtMjkxLDcgKzI5MSw3IEBAIFdJLmFw cGVuZENvbnRleHRNZW51SXRlbXNGb3JET01Ob2RlQnJlYWtwb2ludHMgPSBmdW5jdGlvbihjb250 ZXh0TWVudSwgZG9tTm9kZSwKIAogICAgIGNvbnRleHRNZW51Ll9fZG9tQnJlYWtwb2ludEl0ZW1z QWRkZWQgPSB0cnVlOwogCi0gICAgbGV0IHN1Yk1lbnUgPSBjb250ZXh0TWVudS5hcHBlbmRTdWJN ZW51SXRlbShXSS5VSVN0cmluZygiQnJlYWsgb25cdTIwMjYiKSk7CisgICAgbGV0IHN1Yk1lbnUg PSBjb250ZXh0TWVudS5hcHBlbmRTdWJNZW51SXRlbShXSS5VSVN0cmluZygiQnJlYWsgb24iKSk7 CiAKICAgICBsZXQgYnJlYWtwb2ludHMgPSBXSS5kb21EZWJ1Z2dlck1hbmFnZXIuZG9tQnJlYWtw b2ludHNGb3JOb2RlKGRvbU5vZGUpOwogICAgIGxldCBrZXlWYWx1ZVBhaXJzID0gYnJlYWtwb2lu dHMubWFwKChicmVha3BvaW50KSA9PiBbYnJlYWtwb2ludC50eXBlLCBicmVha3BvaW50XSk7Cg==