198943 2019-06-17 17:09:44 -0700 m_disconnectedFrame can be null in DOMWindowExtension::willDestroyGlobalObjectInCachedFrame() 2019-06-17 18:41:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa beidson cdumez ggaren oldest_to_newest 1545476 0 rniwa 2019-06-17 17:09:44 -0700 m_disconnectedFrame should never be null inside DOMWindowExtension::willDestroyGlobalObjectInCachedFrame(). This is happening in wild :( <rdar://problem/49613448> 1545482 1 372297 rniwa 2019-06-17 17:15:38 -0700 Created attachment 372297 Adds a null check 1545519 2 rniwa 2019-06-17 18:41:03 -0700 Committed r246529: <https://trac.webkit.org/changeset/246529> 372297 2019-06-17 17:15:38 -0700 2019-06-17 17:18:13 -0700 Adds a null check bug-198943-20190617171538.patch text/plain 2220 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NjUyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA2LTE3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIG1fZGlzY29ubmVjdGVkRnJhbWUg Y2FuIGJlIG51bGwgaW4gRE9NV2luZG93RXh0ZW5zaW9uOjp3aWxsRGVzdHJveUdsb2JhbE9iamVj dEluQ2FjaGVkRnJhbWUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk4OTQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQXBwYXJlbnRseSBpdCdzIHBvc3NpYmxlIGZvciBtX2Rpc2Nvbm5lY3RlZEZyYW1l IHRvIGJlIG51bGwgaW4gdGhpcyBmdW5jdGlvbiBldmVuIHRob3VnaCB0aGlzIHNob3VsZCBuZXZl ciBoYXBwZW4uCisKKyAgICAgICAgV2UndmUgYmVlbiB0cnlpbmcgdG8gZGlhZ25vc2UgYSBjbGFz cyBvZiBpc3N1ZXMgaW4gdGhpcyBhcmVhIChlLmcuIHIyNDYxODcsIHIyNDQ5NzEsIHIyNDI3OTcs IHIyNDI2NzcsIHIyNDI2NzYsIHIyNDE4NDgpCisgICAgICAgIGJ1dCBhdCBzb21lIHBvaW50LCB3 ZSBuZWVkIHRvIHN0b3AgY3Jhc2hpbmcgZm9yIHRoZSBzYWtlIG9mIHVzZXIuCisKKyAgICAgICAg V29ya2VkIGFyb3VuZCB0aGUgYnVnIGJ5IGFkZGluZyBhIG51bGwgcG9pbnRlciBjaGVjayBoZXJl LgorCisgICAgICAgICogcGFnZS9ET01XaW5kb3dFeHRlbnNpb24uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RE9NV2luZG93RXh0ZW5zaW9uOjp3aWxsRGVzdHJveUdsb2JhbE9iamVjdEluQ2FjaGVk RnJhbWUpOgorCiAyMDE5LTA2LTE3ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5j b20+CiAKICAgICAgICAgW1dITFNMXSBUaGUgbmFtZSByZXNvbHZlciBkb2VzIG5vdCBkZWFsIHdp dGggbmF0aXZlRnVuY3Rpb25EZWNsYXJhdGlvbgpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9E T01XaW5kb3dFeHRlbnNpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv RE9NV2luZG93RXh0ZW5zaW9uLmNwcAkocmV2aXNpb24gMjQ2NTIzKQorKysgU291cmNlL1dlYkNv cmUvcGFnZS9ET01XaW5kb3dFeHRlbnNpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MSwxMyAr ODEsMTQgQEAgdm9pZCBET01XaW5kb3dFeHRlbnNpb246OnJlc3VtZUZyb21QYWdlQwogCiB2b2lk IERPTVdpbmRvd0V4dGVuc2lvbjo6d2lsbERlc3Ryb3lHbG9iYWxPYmplY3RJbkNhY2hlZEZyYW1l KCkKIHsKLSAgICBBU1NFUlQobV9kaXNjb25uZWN0ZWRGcmFtZSk7CisgICAgQVNTRVJUKG1fZGlz Y29ubmVjdGVkRnJhbWUpOyAvLyBTb21laG93IG1fZGlzY29ubmVjdGVkRnJhbWUgY2FuIGJlIG51 bGwgaGVyZS4gU2VlIDxyZGFyOi8vcHJvYmxlbS80OTYxMzQ0OD4uCiAKICAgICAvLyBDYWxsaW5n IG91dCB0byB0aGUgY2xpZW50IG1pZ2h0IHJlc3VsdCBpbiB0aGlzIERPTVdpbmRvd0V4dGVuc2lv biBiZWluZyBkZXN0cm95ZWQKICAgICAvLyB3aGlsZSB0aGVyZSBpcyBzdGlsbCB3b3JrIHRvIGRv LgogICAgIFJlZjxET01XaW5kb3dFeHRlbnNpb24+IHByb3RlY3RlZFRoaXMoKnRoaXMpOwogCi0g ICAgbV9kaXNjb25uZWN0ZWRGcmFtZS0+bG9hZGVyKCkuY2xpZW50KCkuZGlzcGF0Y2hXaWxsRGVz dHJveUdsb2JhbE9iamVjdEZvckRPTVdpbmRvd0V4dGVuc2lvbih0aGlzKTsKKyAgICBpZiAobV9k aXNjb25uZWN0ZWRGcmFtZSkKKyAgICAgICAgbV9kaXNjb25uZWN0ZWRGcmFtZS0+bG9hZGVyKCku Y2xpZW50KCkuZGlzcGF0Y2hXaWxsRGVzdHJveUdsb2JhbE9iamVjdEZvckRPTVdpbmRvd0V4dGVu c2lvbih0aGlzKTsKICAgICBtX2Rpc2Nvbm5lY3RlZEZyYW1lID0gbnVsbHB0cjsKIAogICAgIC8v IERPTVdpbmRvd0V4dGVuc2lvbiBsaWZldGltZSBpc24ndCB0aWVkIGRpcmVjdGx5IHRvIHRoZSBE T01XaW5kb3cgaXRzZWxmIHNvIGl0IGlzIGltcG9ydGFudCB0aGF0IGl0IHVucmVnaXN0ZXIK